Re: [PATCH] wifi: mt76: mt7603: add debugfs attr for disabling frames buffering

2024-05-25 Thread Rafał Miłecki
On 26.03.2024 00:11, Rafał Miłecki wrote: I'll provide some iperf logs from my ThinkPad with 8086:3166 Intel Wireless-AC 3165 working as 2 GHz client of MT7603EN on Netgear R6220. I run seven 1-hour iperf sessions overnight using ThinkPad + Xiaomi Mi Router 4C (MT7628AN Wi-Fi SoC) with bufferin

[PATCH] wifi: mt76: mt7603: add debugfs attr for disabling frames buffering

2024-05-25 Thread Rafał Miłecki
From: Rafał Miłecki MT7603EN and MT7628AN were reported by multiple users to be unstable under high traffic. Transmission of packets could stop for seconds often leading to disconnections. Long research & debugging revelaed a close relation between MCU interrupts of type PKT_TYPE_TXS and slowdow

[PATCH] dt-bindings: leds: add FUNCTION defines for per-band WLANs

2024-05-25 Thread Rafał Miłecki
From: Rafał Miłecki Most wireless routers and access points can operate in multiple bands simultaneously. Vendors often equip their devices with per-band LEDs. Add defines for those very common functions to allow cleaner & clearer bindings. Signed-off-by: Rafał Miłecki --- include/dt-bindings

Re: [PATCH] wifi: mt76: mt7603: add debugfs attr for disabling frames buffering

2024-05-25 Thread Rafał Miłecki
On 2.04.2024 18:54, Shengyu Qu wrote: > Maybe we could disable frames buffering by default until it is fixed? Please check commit description: "If this solution yields a success we can make this feature disabled by default." > Also, maybe we could do more tests on newer models such as mt7986

Re: [PATCH dt-schema] schemas: chosen: Add OpenWrt LEDs properties for system states

2024-05-25 Thread Rafał Miłecki
On 9.01.2024 20:10, Krzysztof Kozlowski wrote: On 09/01/2024 17:38, Rafał Miłecki wrote: On 9.01.2024 10:02, Krzysztof Kozlowski wrote: On 09/01/2024 09:23, Rafał Miłecki wrote: From: Rafał Miłecki OpenWrt project provides downstream support for thousands of embedded home network devices. It

Re: [PATCH dt-schema] schemas: chosen: Add OpenWrt LEDs properties for system states

2024-05-25 Thread Rafał Miłecki
On 9.01.2024 10:02, Krzysztof Kozlowski wrote: On 09/01/2024 09:23, Rafał Miłecki wrote: From: Rafał Miłecki OpenWrt project provides downstream support for thousands of embedded home network devices. Its custom requirement for DT is to provide info about LEDs roles. Currently it does it by us

ARM BCM53573 SoC hangs/lockups caused by locks/clock/random changes

2024-05-25 Thread Rafał Miłecki
I made a second attempt on debugging some longstanding stability issues affecting BCM53753 SoCs. Those are single CPU core ARM Cortex-A7 boards with a pretty slow arch timer running at 36,8 kHz. After 0 to 20 minutes of close to zero activity I experience hangs and I need to wait a minute for wat

Re: ARM board lockups/hangs triggered by locks and mutexes

2024-05-25 Thread Rafał Miłecki
On 18.08.2023 22:23, Rafał Miłecki wrote: On 14.08.2023 11:04, Geert Uytterhoeven wrote: Hi Rafal, On Mon, Aug 7, 2023 at 1:11 PM Rafał Miłecki wrote: On 4.08.2023 13:07, Rafał Miłecki wrote: I triple checked that. Dropping a single unused function breaks kernel / device stability on BCM5357

Re: ARM board lockups/hangs triggered by locks and mutexes

2024-05-25 Thread Rafał Miłecki
On 14.08.2023 11:04, Geert Uytterhoeven wrote: Hi Rafal, On Mon, Aug 7, 2023 at 1:11 PM Rafał Miłecki wrote: On 4.08.2023 13:07, Rafał Miłecki wrote: I triple checked that. Dropping a single unused function breaks kernel / device stability on BCM53573! AFAIK the only thing below diff actuall

Re: ARM board lockups/hangs triggered by locks and mutexes

2024-05-25 Thread Rafał Miłecki
On 7.08.2023 20:34, Florian Fainelli wrote: On 8/7/23 04:10, Rafał Miłecki wrote: On 4.08.2023 13:07, Rafał Miłecki wrote: I triple checked that. Dropping a single unused function breaks kernel / device stability on BCM53573! AFAIK the only thing below diff actually affects is location of symb

Re: ARM board lockups/hangs triggered by locks and mutexes

2024-05-25 Thread Rafał Miłecki
On 4.08.2023 13:07, Rafał Miłecki wrote: I triple checked that. Dropping a single unused function breaks kernel / device stability on BCM53573! AFAIK the only thing below diff actually affects is location of symbols (I actually verified that by comparing System.map before and after - over 22'000

Re: ARM board lockups/hangs triggered by locks and mutexes

2024-05-25 Thread Rafał Miłecki
On 2.08.2023 00:10, Rafał Miłecki wrote: Unfortunately enabling *any* of following options: CONFIG_DEBUG_RT_MUTEXES=y CONFIG_DEBUG_SPINLOCK=y CONFIG_DEBUG_MUTEXES=y seems to make locksup/hangs go away. I tried for few hours. I decided to find out why enabling CONFIG_DEBUG_MUTEXES "fixes" kernel

Re: ARM board lockups/hangs triggered by locks and mutexes

2024-05-25 Thread Rafał Miłecki
On 2.08.2023 00:10, Rafał Miłecki wrote: Reverting that extra commit from v5.4.238 allows me to run Linux for hours again (currently 3 devices x 6 hours and counting). So I need in total 10+1 reverts from 5.4 branch to get a stable kernel. I switched back to OpenWrt's kernel 5.4 and applied all

ARM board lockups/hangs triggered by locks and mutexes

2024-05-25 Thread Rafał Miłecki
Hi, Years ago I added support for Broadcom's BCM53573 SoCs. We released firmwares based on Linux 4.4 (and later on 4.14) that worked almost fine. There was one little issue we couldn't debug or fix: random hangs and reboots. They were too rare to deal with (most devices worked fine for weeks or mo

Re: ARM board lockups/hangs triggered by locks and mutexes

2024-05-25 Thread Rafał Miłecki
On 2.08.2023 00:21, Russell King (Oracle) wrote: On Wed, Aug 02, 2023 at 12:10:24AM +0200, Rafał Miłecki wrote: Years ago I added support for Broadcom's BCM53573 SoCs. We released firmwares based on Linux 4.4 (and later on 4.14) that worked almost fine. There was one little issue we couldn't deb

Re: ARM board lockups/hangs triggered by locks and mutexes

2024-05-25 Thread Rafał Miłecki
On 2.08.2023 00:25, Florian Fainelli wrote: Hi Rafal, On 8/1/23 15:10, Rafał Miłecki wrote: Hi, Years ago I added support for Broadcom's BCM53573 SoCs. We released firmwares based on Linux 4.4 (and later on 4.14) that worked almost fine. There was one little issue we couldn't debug or fix: ran

Re: ARM board lockups/hangs triggered by locks and mutexes

2024-05-25 Thread Rafał Miłecki
On 2.08.2023 09:00, Rafał Miłecki wrote: With your comment I decided to try CONFIG_PROVE_LOCKING anyway / again and this time on 1 of my BCM53573 devices I got something very interesting on the first boot. FWIW following error: Broadcom B53 (2) bcma_mdio-0-0:1e: failed to register switch: -517 i

[PATCH] ath79: replace "mac-address-ascii" with "mac-base"

2024-05-25 Thread Rafał Miłecki
From: Rafał Miłecki With upstream accepted "mac-base" binding there is no need for a downstream "mac-address-ascii" workaround anymore. Signed-off-by: Rafał Miłecki --- .../ath79/dts/ar7161_dlink_dir-825-b1.dts | 57 +++ .../linux/ath79/dts/ar9331_hiwifi_hc6361.dts | 37 ++

Re: ARM BCM53573 SoC hangs/lockups caused by locks/clock/random changes

2024-05-25 Thread Rafał Miłecki
Hi, it's a late reply but I didn't find enough determination earlier. On 8.09.2023 10:10, Linus Walleij wrote: On Mon, Sep 4, 2023 at 10:34 AM Rafał Miłecki wrote: I'm clueless at this point. Maybe someone can come up with an idea of actual issue & ideally a solution. Damn this is frustrat

Re: [PATCH] brcm: add CLM BLOB files for Luxul devices

2024-05-25 Thread Rafał Miłecki
Hi Josh, I'm OpenWrt developer and those CLM BLOBs have significant meaning for this project. They allow OpenWrt users to use their devices with full WiFi support (not limited to some generic fallback setup level). For that let me speak up regarding this PATCH case. On 12.06.2023 18:57, Josh Bo

[PATCH] net: gro: respect nf_conntrack_checksum for skipping csum verification

2024-05-25 Thread Rafał Miłecki
From: Rafał Miłecki Netfilter allows disabling checksum verification of incoming packets by setting nf_conntrack_checksum variable. That feature is very useful for home routers which: 1. Most of the time just /forward/ network traffic 2. Have slow CPU(s) and csum calculation is a challenge Some

Re: [PATCH] wifi: mt76: mt7603: add debugfs attr for disabling frames buffering

2024-05-25 Thread Shengyu Qu
Hi Rafal, Maybe we could disable frames buffering by default until it is fixed? Also, maybe we could do more tests on newer models such as mt7986/81 to make this patch benefit more models? Best regards, Shengyu 在 2024/3/26 6:33, Rafał Miłecki 写道: From: Rafał Miłecki MT7603EN and MT7628AN we

[PATCH v2] imx: add imx8m support

2024-05-25 Thread Tim Harvey
Add imx8m support: - add a cortexa53 subtarget to imx - move ARCH and KERNELNAME to subtargets No device-specific targets or firmware images are created yet but all imx8m* dtbs will be built. enabling CONFIG_TARGET_ROOTFS_INITRAMFS results in openwrt-imx-cortexa53-imx8m-initramfs-kernel.bin whi

Re: [PATCH] dt-bindings: leds: add FUNCTION defines for per-band WLANs

2024-05-25 Thread Rob Herring
On Wed, 17 Jan 2024 16:17:36 +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > Most wireless routers and access points can operate in multiple bands > simultaneously. Vendors often equip their devices with per-band LEDs. > > Add defines for those very common functions to allow cleaner & cle

Re: (subset) [PATCH] dt-bindings: leds: add FUNCTION defines for per-band WLANs

2024-05-25 Thread Lee Jones
On Wed, 17 Jan 2024 16:17:36 +0100, Rafał Miłecki wrote: > Most wireless routers and access points can operate in multiple bands > simultaneously. Vendors often equip their devices with per-band LEDs. > > Add defines for those very common functions to allow cleaner & clearer > bindings. > > > [.

Re: [PATCH dt-schema] schemas: chosen: Add OpenWrt LEDs properties for system states

2024-05-25 Thread Krzysztof Kozlowski
On 09/01/2024 17:38, Rafał Miłecki wrote: > On 9.01.2024 10:02, Krzysztof Kozlowski wrote: >> On 09/01/2024 09:23, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> OpenWrt project provides downstream support for thousands of embedded >>> home network devices. Its custom requirement for DT is t

Re: [PATCH dt-schema] schemas: chosen: Add OpenWrt LEDs properties for system states

2024-05-25 Thread Krzysztof Kozlowski
On 09/01/2024 22:08, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Tue, Jan 9, 2024 at 8:10 PM Krzysztof Kozlowski > wrote: >> On 09/01/2024 17:38, Rafał Miłecki wrote: >>> On 9.01.2024 10:02, Krzysztof Kozlowski wrote: On 09/01/2024 09:23, Rafał Miłecki wrote: > From: Rafał Miłecki

Re: [PATCH dt-schema] schemas: chosen: Add OpenWrt LEDs properties for system states

2024-05-25 Thread Krzysztof Kozlowski
On 09/01/2024 22:48, Rafał Miłecki wrote: >> >> You can also define how pieces of hardware are wired together and create >> entire system, e.g. connect one LED to disk activity. >> >> However what you are proposing here is to dynamically configure one, >> given OS. I don't think it is suitable. >>

Re: [PATCH dt-schema] schemas: chosen: Add OpenWrt LEDs properties for system states

2024-05-25 Thread Geert Uytterhoeven
Hi Krzysztof, On Tue, Jan 9, 2024 at 8:10 PM Krzysztof Kozlowski wrote: > On 09/01/2024 17:38, Rafał Miłecki wrote: > > On 9.01.2024 10:02, Krzysztof Kozlowski wrote: > >> On 09/01/2024 09:23, Rafał Miłecki wrote: > >>> From: Rafał Miłecki > >>> > >>> OpenWrt project provides downstream support

Re: ARM board lockups/hangs triggered by locks and mutexes

2024-05-25 Thread Geert Uytterhoeven
Hi Rafal, On Mon, Aug 7, 2023 at 1:11 PM Rafał Miłecki wrote: > On 4.08.2023 13:07, Rafał Miłecki wrote: > > I triple checked that. Dropping a single unused function breaks kernel / > > device stability on BCM53573! > > > > AFAIK the only thing below diff actually affects is location of symbols >

Re: ARM BCM53573 SoC hangs/lockups caused by locks/clock/random changes

2024-05-25 Thread Geert Uytterhoeven
Hi Rafał, On Mon, Sep 4, 2023 at 10:35 AM Rafał Miłecki wrote: > 2. Clock (arm,armv7-timer) > > While comparing main clock in Broadcom's SDK with upstream one I noticed > a tiny difference: mask value. I don't know it it makes any sense but > switching from CLOCKSOURCE_MASK(56) to CLOCKSOURCE_MAS