[OpenWrt-Devel] [PATCH] make sure strings will always be 0-terminated.

2012-12-05 Thread Frank Meerkötter
From the man page: [...] The strncpy() function is similar, except that at most n bytes of src are copied. Warning: If there is no null byte among the first n bytes of src, the string placed in dest will not be null-terminated. [...] Signed-off-by: Frank Meerkötter fr

Re: [OpenWrt-Devel] [PATCH][netifd] fix error checking of asprintf

2012-12-03 Thread Frank Meerkötter
On 03/12/12 10:43, Felix Fietkau wrote: On 2012-11-22 3:03 PM, Frank Meerkötter wrote: Hi, while building with -D_FORTIFY_SOURCE i noticed a small problem in how netifd is using asprintf(). To check if an allocation by asprintf() worked or not the return value must be checked. Checking

[OpenWrt-Devel] [PATCH][netifd] corner case: make sure strings are always 0-terminated

2012-12-03 Thread Frank Meerkötter
placed in dest will not be null-terminated. [...] Signed-off-by: Frank Meerkötter fr...@meerkoetter.org --- system-linux.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/system-linux.c b/system-linux.c index eb73e95..17143cb 100644 --- a/system-linux.c

Re: [OpenWrt-Devel] [PATCH][netifd] corner case: make sure strings are always 0-terminated

2012-12-03 Thread Frank Meerkötter
On 03/12/12 13:56, Felix Fietkau wrote: On 2012-12-03 1:42 PM, Frank Meerkötter wrote: Hi, i noticed that strncpy wasn't used correctly here. Please review/apply. Patch follows: From the man page: [...] The strncpy() function is similar, except that at most n bytes of src

[OpenWrt-Devel] [PATCH] fix error checking of asprintf

2012-12-03 Thread Frank Meerkötter
-by: Frank Meerkötter fr...@meerkoetter.org --- ubus.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ubus.c b/ubus.c index 7b85930..d6d4188 100644 --- a/ubus.c +++ b/ubus.c @@ -727,8 +727,7 @@ netifd_ubus_add_interface(struct interface *iface) struct ubus_object *obj

[OpenWrt-Devel] DSL support and luci integration

2012-11-27 Thread Frank Meerkötter
Hi, back in January there was a discussion on how to integrate DSL into Luci. https://lists.openwrt.org/pipermail/openwrt-devel/2012-January/013587.html A patch was presented which only got partially merged. The dsl_control.sh is there, the integration into the web-ui seems to be missing (AA

Re: [OpenWrt-Devel] DSL support and luci integration

2012-11-27 Thread Frank Meerkötter
On 27/11/12 12:28, John Crispin wrote: On 27/11/12 12:23, Frank Meerkötter wrote: Hi, back in January there was a discussion on how to integrate DSL into Luci. https://lists.openwrt.org/pipermail/openwrt-devel/2012-January/013587.html A patch was presented which only got partially merged

[OpenWrt-Devel] [PATCH] dsl support for the luci webinterface

2012-11-27 Thread Frank Meerkötter
Hi, this patch is the work of* *Lee Essen which he posted here in January. https://lists.openwrt.org/pipermail/openwrt-devel/2012-January/013602.html Unfortunately not everything was merged back then. The integration into the web-ui was lost. I have rebased the patch against the current trunk

Re: [OpenWrt-Devel] musl patches are breaking the eglibc build

2012-11-25 Thread Frank Meerkötter
On 25/11/12 12:41, Florian Fainelli wrote: [...] Whoops, sorry about that. Reverting 4cf1359d5dc38debc89834d895f9a3951044bf90 [package] iptables: add some musl portability fixes fixes the building of iptables. Reverting acd937382fefda95988b6dc279cf8989be4d6747 [buildroot] add preliminary

Re: [OpenWrt-Devel] [iptables] iptables broken ?

2012-11-24 Thread Frank Meerkötter
On 24/11/12 20:49, shazz wrote: Hi, my 2 builds failed yesterday : mips-openwrt-linux-gnu-gcc -Wp,-MMD,./.libxt_hashlimit.oo.d,-MT,libxt_hashlimit.oo [...] error: nested redefinition of 'enum tcp_ca_state'

[OpenWrt-Devel] [PATCH][package] make ltq-dsl-app compile with an eglibc-based toolchain

2012-11-22 Thread Frank Meerkötter
Hi, i had problems building the ltq-dsl-app when switching from uclibc to eglibc. This patch is adding a needed include, adds a configure test to figure out where clock_gettime() is located and runs autoreconfigurer afterwards. Please review/apply. Signed-Off-By: Frank Meerkötter fr

[OpenWrt-Devel] [PATCH][netifd] fix error checking of asprintf

2012-11-22 Thread Frank Meerkötter
against the package, fixing it upstream might be the way to go). Regards, Frank --- commit 626874984862ccb31dd5ccea378113d26acdb218 Author: Frank Meerkötter fr...@meerkoetter.org Date: Thu Nov 22 14:51:22 2012 +0100 fix error checking of asprintf $ man asprintf [...] RETURN

[OpenWrt-Devel] [PATCH] actually deploy atmarp and atmarpd and not just their libtool wrapper

2012-11-01 Thread Frank Meerkötter
Hi all, i noticed that due to a small error in the atm-tools package we are not deploying atmarp/atmarpd but instead the (useless) libtool-wrappers. Please review/apply. Signed-Off-By: Frank Meerkötter fr...@meerkoetter.org Patch follows: Index: package/linux-atm/Makefile