Re: [PATCH buildbot] phase1: add JSON merge step

2020-07-19 Thread Paul Spooren
On 30.06.20 13:28, Paul Spooren wrote: The refactored JSON info files require a final merge step which sums up all created JSON info files of a target into a single `profiles.json` files. This patch adds the extra step to run `make json_overview_image_info` just before calculating the checksums

[PATCH usign] usign: add VERIFYONLY option

2020-07-18 Thread Paul Spooren
conditions to reduce the code size. If VERIFYONLY is set, the usign binary size is reduced by 4kB. Only the functions `-V` for verification and `-F` for fingerprint printing are enabled. [0]: https://github.com/openwrt/openwrt/pull/2911 Signed-off-by: Paul Spooren --- main.c | 118

Re: [PATCH 3/3] scripts: mkhash fail on hashing a folder

2020-07-17 Thread Paul Spooren
Hi, On 16.07.20 21:20, Bjørn Mork wrote: Paul Spooren writes: To avoid hashing of folders `fopen()` is called in `r+` mode which fails on folders, as their are not writeable. Regular files work as before. This prevents mkhash from working with read-only files. That's unexpected, and IMHO

[PATCH v2 2/2] scripts: mkhash fail on hashing a folder

2020-07-17 Thread Paul Spooren
: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 Signed-off-by: Paul Spooren --- scripts/mkhash.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/scripts/mkhash.c b/scripts/mkhash.c index ea3bd60ce1..13d50176c8 100644 --- a/scripts/mkhash.c +++ b/scripts/mkhash.c @@ -85,6 +85,7 @@ #include #include

[PATCH v2 1/2] scripts: mkhash fix return code handling

2020-07-17 Thread Paul Spooren
If hashing a file fails mkhash shouldn't just silently fail. Now check after each call of `hash_file()` the return and exit early in case of errors. The return value which was previously ignored and would always return 0. Signed-off-by: Paul Spooren --- scripts/mkhash.c | 7 +-- 1 file

[PATCH 2/3] scripts: mkhash fix return code handling

2020-07-16 Thread Paul Spooren
If hashing a file fails mkhash shouldn't just silently fail. Now check after each call of `hash_file()` the return and exit early in case of errors. The return value which was previously ignored and would always return 0. Signed-off-by: Paul Spooren --- scripts/mkhash.c | 5 +++-- 1 file

[PATCH 3/3] scripts: mkhash fail on hashing a folder

2020-07-16 Thread Paul Spooren
: d41d8cd98f00b204e9800998ecf8427e sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 Signed-off-by: Paul Spooren --- scripts/mkhash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/mkhash.c b/scripts/mkhash.c index 96f92e42b5..4d1ff1c166 100644

[PATCH 1/3] scripts: mkhash show -n option in usage

2020-07-16 Thread Paul Spooren
The -n option prints the filename of hashed files next to the calculated checksum. Reflect that in the usage message. user@dawn:~/src/openwrt/openwrt$ ./a.out md5 -n .config eb06db36e7b6751cb18801945e46bf5d .config Signed-off-by: Paul Spooren --- scripts/mkhash.c | 5 - 1 file changed, 4

[PATCH] build: use mkhash for IPK metadata checksums

2020-07-16 Thread Paul Spooren
ment, this replaces it with `mkhash sha256` and adapts the `sed` pipe command to fit spacing. CC: Xu Wang CC: Michal Hrusecky Signed-off-by: Paul Spooren --- include/package-ipkg.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/package-ipkg.mk b/include/package-ipk

Re: [RFC] usage of mkhash, sha256sum and md5sum

2020-07-16 Thread Paul Spooren
On 16.07.20 09:36, Felix Fietkau wrote: On 2020-07-16 21:18, Paul Spooren wrote: Hi, On 15.07.20 22:54, Felix Fietkau wrote: On 2020-07-16 04:06, Paul Spooren wrote: Hi, the OpenWrt system requires the calculation of both md5 and sha256 sums at various places, this is partly done via

Re: [RFC] usage of mkhash, sha256sum and md5sum

2020-07-16 Thread Paul Spooren
Hi, On 15.07.20 22:54, Felix Fietkau wrote: On 2020-07-16 04:06, Paul Spooren wrote: Hi, the OpenWrt system requires the calculation of both md5 and sha256 sums at various places, this is partly done via a small C file in ./scripts/mkhash.c and partly by using a sha256sum binary. A ancient

Re: [PATCH v2 5/6] mvebu: implement compatibility version for DSA migration

2020-07-15 Thread Paul Spooren
On 14.07.20 04:28, Adrian Schmutzler wrote: This implements the newly introduced compat-version to prevent upgrade between swconfig and DSA for mvebu. Just define a compat version with minor increment and an appropriate message for both image (in Makefile) and device (in base-files). Having

Re: [PATCH v2 4/6] base-files: fwtool: make compat_version backward compatible

2020-07-15 Thread Paul Spooren
On 14.07.20 04:28, Adrian Schmutzler wrote: So far, the compatibility mechanism only works if both device and image are already updated to the new routines. This patch extends the sysupgrade metadata and fwtool_check_image() to account for "older" images as well: The basic mechanism for older

Re: [PATCH v2 3/6] base-files: fwtool: implement compatibility check for images

2020-07-15 Thread Paul Spooren
On 14.07.20 04:28, Adrian Schmutzler wrote: We regularly encounter the situation that devices are subject to changes that will make them incompatible to previous versions. Removing SUPPORTED_DEVICES will not really be helpful in most of these cases, as this only helps after a rename. To solve

[RFC] usage of mkhash, sha256sum and md5sum

2020-07-15 Thread Paul Spooren
Hi, the OpenWrt system requires the calculation of both md5 and sha256 sums at various places, this is partly done via a small C file in ./scripts/mkhash.c and partly by using a sha256sum binary. A ancient wrapper ./scripts/md5sum is added for Mac OS X compatibility. * Should we create our

[PATCH] build: store buildsystem revision in packages

2020-07-15 Thread Paul Spooren
on ath79/generic. Signed-off-by: Paul Spooren --- include/package-ipkg.mk | 1 + package/Makefile| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/package-ipkg.mk b/include/package-ipkg.mk index 622cbf3223..1dc8dc8f56 100644 --- a/include/package-ipkg.mk +++ b

[PATCH] dropbear: Enable Ed25519 for normal devices

2020-07-15 Thread Paul Spooren
splitting `dropbear` into two packages like `dropbear` and `dropbear-ed25519`. Signed-off-by: Paul Spooren --- package/network/services/dropbear/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/services/dropbear/Config.in b/package/network/services

[RFC] CI testing of device-tree .dts files

2020-07-15 Thread Paul Spooren
Hi all, I played today a bit with dt-schema[0] which allows to validate device-tree schema files via something called json-schema[1], a schema description written in, *drums*, yaml. Ideally vendors specify their hardware in the Kernel[2] and dt-schema validates each .dts file added to

Re: [PATCH] build: put DT "compatible" value as "board_name" in profiles.json

2020-07-13 Thread Paul Spooren
Štetiar ; Moritz Warning ; Paul Spooren Subject: [PATCH] build: put DT "compatible" value as "board_name" in profiles.json From: Rafał Miłecki The purpose of "board_name" in JSON is matchine OpenWrt running device with JSON profile entry. Right now it gets filled for d

Re: [PATCH] scripts: Add Buildbot dumpinfo.pl script

2020-07-13 Thread Paul Spooren
On 12.07.20 17:16, Paul Spooren wrote: The dumpinfo.pl script comes from buildbot.git[0] and is used to print available targets and architectures, which are then build. As the buildbot clones openwrt.git anyway, the script might as well live here as it can be used for other cases as well, e.g

[PATCH] scripts: Add Buildbot dumpinfo.pl script

2020-07-12 Thread Paul Spooren
could be removed from the buildbot repository and maintained only here. [0]: https://git.openwrt.org/?p=buildbot.git;a=blob;f=scripts/dumpinfo.pl;h=aa97f8d60379076a41b968402e9337cea824ece5;hb=HEAD Signed-off-by: Paul Spooren --- scripts/dumpinfo.pl | 91

Re: [PATCHv2 3/4] scripts/clean-package.sh: remove useless cat

2020-07-11 Thread Paul Spooren
Hi, On 11.07.20 08:45, Rosen Penev wrote: Found with shellcheck. Signed-off-by: Rosen Penev --- v2: rebased scripts/clean-package.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh index 4b536c8a48..03e49df3e7

Re: [PATCH] build: put DT "compatible" value as "board_name" in profiles.json

2020-07-08 Thread Paul Spooren
TL;DR: I think the issue is solved for devices using DT, the problem are the other targets with custom solutions. I think there is a policy for new DT devices to use the compatible string as profile. Multiple targets contain the following line in the target Makefile, which automatically

Re: [PATCH] busybox: disable SUSv2 compatibility by default

2020-07-08 Thread Paul Spooren
What is the storage gain archived by changing this? On 08.07.20 01:27, Rui Salvaterra wrote: The Single UNIX Specification, Version 3, came out on the 30th January 2002 [1]. There's nothing in the OpenWrt userspace which needs support for legacy SUSv2 compatibility. [1]

[PATCH] build,json: store arch_packages in profiles.json

2020-06-30 Thread Paul Spooren
The `arch_packages` contains the supported package architecture. Previously it was necessary to parse the `Packages` index for the line `Architecture:`, requiring both an additional parser and file download. Signed-off-by: Paul Spooren --- scripts/json_overview_image_info.py | 7 +-- 1

[PATCH buildbot] phase1: add JSON merge step

2020-06-30 Thread Paul Spooren
as well. Signed-off-by: Paul Spooren --- phase1/master.cfg | 8 1 file changed, 8 insertions(+) diff --git a/phase1/master.cfg b/phase1/master.cfg index 792f9b3..1a96982 100644 --- a/phase1/master.cfg +++ b/phase1/master.cfg @@ -925,6 +925,14 @@ for target in targets

Re: [OpenWrt-Devel] [PATCH][RFC] build: disable target name in image filename

2020-06-15 Thread Paul Spooren
On 6/15/20 7:32 AM, Matthias Schiffer wrote: I just think of ar71xx and ath79, where we have the same device but different targets. Of course, the name won't be exactly equal, as ath79 will have e.g. tplink_ prefix and ar71xx won't. Isn't ar71xx removed from master builds? It's neither at

Re: [OpenWrt-Devel] [PATCH][RFC] build: disable target name in image filename

2020-06-14 Thread Paul Spooren
Hi, On 6/14/20 10:00 AM, m...@adrianschmutzler.de wrote: -Original Message- From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On Behalf Of Paul Spooren Sent: Sonntag, 14. Juni 2020 11:34 To: openwrt-devel@lists.openwrt.org Subject: [OpenWrt-Devel] [PATCH][RFC] build

[OpenWrt-Devel] [PATCH][RFC] build: disable target name in image filename

2020-06-14 Thread Paul Spooren
openwrt-linksys_wrt3200acm.manifest * openwrt-linksys_wrt3200acm-squashfs-factory.img * openwrt-linksys_wrt3200acm-squashfs-sysupgrade.bin Signed-off-by: Paul Spooren --- It's been a while since I made a controversial patch[0] so it feels about time. [0]: https://github.com/openwrt/openwrt/pull/2107

Re: [OpenWrt-Devel] [PATCH] build, imagebuilder: Do not require libncurses-dev

2020-06-10 Thread Paul Spooren
Hi, Hi Paul, I gave this today a test on my spare computer, but it still complained about the missing libncurses. I tested with snapshot imagebuilder (r13519-8a858363b0) with just calling "make image" Any ideas? It's just a PR and not yet merged. Once merged give it another 24 hours. Best,

Re: [OpenWrt-Devel] [PATCH] build, imagebuilder: Do not require libncurses-dev

2020-06-09 Thread Paul Spooren
, Sven Roederer wrote: Am Dienstag, 14. April 2020, 23:14:47 CEST schrieb Paul Spooren: The buildroot and SDK both require `libncurses-dev` to be installed on the system, however the ImageBuilder uses precompiled binaries. This patch changes the prerequirements checks to skip the `libncurses-dev

Re: [OpenWrt-Devel] [PATCH 2/2] build: compress kernel debuginfo using zstd

2020-05-15 Thread Paul Spooren
Could we use that for the SDK/ImageBuilder as well? Best, Paul -- May 13, 2020 9:20:39 AM Matthias Schiffer : zstd with its default settings (compression level -3) compresses better than bzip2 -9 (which is the default setting), and is an order of magnitude faster. I made the following

Re: [OpenWrt-Devel] Applying to Season of Docs

2020-05-03 Thread Paul Spooren
On Sun, 2020-05-03 at 17:37 +0200, Hauke Mehrtens wrote: > On 5/1/20 11:07 PM, Paul Spooren wrote: > > Hi all, > > > > Google offers a program[0] to stipend people writing technical documentation > > for > > open source projects. The stipend is possi

[OpenWrt-Devel] Applying to Season of Docs

2020-05-01 Thread Paul Spooren
Hi all, Google offers a program[0] to stipend people writing technical documentation for open source projects. The stipend is possible for anyone 18+ and not living in a US embargoed country, so unlike the Google Summer of Code project not only for students. Successful writers get a stipend of

Re: [OpenWrt-Devel] Uncompress image: trailing garbage ignored

2020-04-26 Thread Paul Spooren
Hi, On Thu, 2020-04-23 at 23:29 +0300, Hannu Nyman wrote: > W. Michael Petullo kirjoitti 23.4.2020 klo 19.50: > > I have started to notice a gunzip warning when decompressing the > > OpenWrt images I build. This is with master df27e949: > > > > gunzip

Re: [OpenWrt-Devel] [PATCH] x86: fix unusable squashfs images by adding missing padding

2020-04-25 Thread Paul Spooren
nt root, tried: > ext3 > ext2 > ext4 > squashfs > iso9660 > f2fs > > Kernel panic - not syncing: VFS: Unable to mount root fs on > unknown-block(202,0) > > So lets fix this by adding back padding which was introduced in commit > a17d9482f5e2 ("x86: image: fi

Re: [OpenWrt-Devel] [PATCH] x86: fix unusable squashfs images by adding missing padding

2020-04-25 Thread Paul Spooren
nt root, tried: > ext3 > ext2 > ext4 > squashfs > iso9660 > f2fs > > Kernel panic - not syncing: VFS: Unable to mount root fs on > unknown-block(202,0) > > So lets fix this by adding back padding which was introduced in commit > a17d9482f5e2 ("x86: image: fi

[OpenWrt-Devel] [RFC] x86: use multiple profiles

2020-04-14 Thread Paul Spooren
Hi all, the x86 been recently reworked (cb007a7bf6) and now it is easily possible to define multiple profiles. Currently only a `generic` profile is offered which builds mbr and efi grub images with a standard selection of packages (common device drivers). I'd suggest to have multiple profiles

Re: [OpenWrt-Devel] [PATCH v2] scripts: add docker-run-rootfs.sh

2020-04-14 Thread Paul Spooren
Forgot to annotate, the v2 adds a description of the NETWORK_PREFIX to the usage message. On Tue, 2020-04-14 at 14:39 -1000, Paul Spooren wrote: > The script allows to run a OpenWrt x86/64 rootfs in no time. It is > possible to access the web interface and SSH via 192.168.1.1. > &

[OpenWrt-Devel] [PATCH v2 1/3] scripts: target-metadata don't add PROFILES twice

2020-04-14 Thread Paul Spooren
`. This patch uses Perls `uniq` function to add the profiles only once to `.profiles.mk`. Signed-off-by: Paul Spooren --- v2: * Instead of importing the entire MoreUtils library only copy the `uniq` function. scripts/target-metadata.pl | 11 ++- 1 file changed, 10 insertions(+), 1

[OpenWrt-Devel] [PATCH v2] scripts: add docker-run-rootfs.sh

2020-04-14 Thread Paul Spooren
--network or -n. Using --prebuild or -p will download the OpenWrt image from docker hub. [0]: https://forums.docker.com/t/modify-a-file-which-mount-as-a-data-volume-but-it-didnt-change-in-container/2813/14 Signed-off-by: Paul Spooren --- scripts/docker-run-rootfs.sh | 103 +++

[OpenWrt-Devel] [PATCH] build, imagebuilder: Do not require libncurses-dev

2020-04-14 Thread Paul Spooren
The buildroot and SDK both require `libncurses-dev` to be installed on the system, however the ImageBuilder uses precompiled binaries. This patch changes the prerequirements checks to skip the `libncurses-dev` part if running as ImageBuilder. Signed-off-by: Paul Spooren --- include/prereq

Re: [OpenWrt-Devel] [PATCH] scripts/download: add sources CDN as first mirror

2020-04-13 Thread Paul Spooren
options or at least disable-able via a option? On Mon, 2020-04-06 at 01:53 -1000, Paul Spooren wrote: > OpenWrt now has a CDN for sources at sources.cdn.openwrt.org which > mirrors sources.openwrt.org. > > Downloading sources outside Europe or US (mainland) could > result in

Re: [OpenWrt-Devel] [PATCH] mvebu: add support for GL.iNet GL-MV1000

2020-04-10 Thread Paul Spooren
Hi Li Zhang, thank you very much for the contribution! Please stick to the device tree naming schema of `manufacture,model` when adding devices to OpenWrt. In this case the device should be called `glinet,gl-vm1000` instead of just `gl-mv1000`. For the device profile (inline commented below),

[OpenWrt-Devel] [PATCH] mvebu, cortexa9: rename linksys, rango to wrt3200acm

2020-04-10 Thread Paul Spooren
to keep track of two different names for the same device. Additionally running devices now know which profile was used to create the running firmware, instead of requiring an additional mapping. Signed-off-by: Paul Spooren --- This is just meant as a RFC, in case the idea is good I'll send

[OpenWrt-Devel] [PATCH] x86: append metadata to combined images

2020-04-10 Thread Paul Spooren
. Signed-off-by: Paul Spooren --- target/linux/x86/image/Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/linux/x86/image/Makefile b/target/linux/x86/image/Makefile index 7a474e7a6e..77516a4a9d 100644 --- a/target/linux/x86/image/Makefile +++ b/target/linux

[OpenWrt-Devel] Configuration management for OpenWrt

2020-04-08 Thread Paul Spooren
Hi all, I was wondering if there are some best practices for configuration management of OpenWrt devices. I understand that it is fairly easy to get/restore a backup of the etc/config folder, but though maybe there are some smarter ways. Ideally a local state (e.g. git repository) would deploy

Re: [OpenWrt-Devel] [PATCH v2] phase1: Add JSON merging step

2020-04-08 Thread Paul Spooren
On Wed, 2020-04-08 at 21:09 +0200, Petr Štetiar wrote: > Paul Spooren [2020-04-08 08:57:13]: > > > v2: > > * Removed the `haltOnFailure` options as this may break the > > current > > builds if the merge script show any unexpected errors in the > > build

[OpenWrt-Devel] [PATCH] scripts: JSON merge don't crash if no JSON found

2020-04-08 Thread Paul Spooren
, therefore the for loop won't run. Signed-off-by: Paul Spooren CC: Petr Štetiar --- scripts/json_overview_image_info.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/json_overview_image_info.py b/scripts/json_overview_image_info.py index 5ed829249b..a1418e366d 100755

[OpenWrt-Devel] [PATCH v2] phase1: Add JSON merging step

2020-04-08 Thread Paul Spooren
as well. Signed-off-by: Paul Spooren CC: Jo-Philipp Wich --- v2: * Removed the `haltOnFailure` options as this may break the current builds if the merge script show any unexpected errors in the buildbot environment. This option should be added again once the script proofs working

[OpenWrt-Devel] [PATCH] scripts: add docker-run-rootfs.sh

2020-04-07 Thread Paul Spooren
--network or -n. Using --prebuild or -p will download the OpenWrt image from docker hub. [0]: https://forums.docker.com/t/modify-a-file-which-mount-as-a-data-volume-but-it-didnt-change-in-container/2813/14 Signed-off-by: Paul Spooren --- scripts/docker-run-rootfs.sh | 96 +++

[OpenWrt-Devel] [PATCH] scripts/download: add sources CDN as first mirror

2020-04-06 Thread Paul Spooren
as the first mirror to offer worldwide fast download speeds by default. If the CDN goes down for whatever reason, the script jumps to the next available mirror and downloads requested files as before (in regional varying speed). Signed-off-by: Paul Spooren --- scripts/download.pl | 1 + 1 file changed, 1

[OpenWrt-Devel] [PATCH] phase1: Add JSON merging step

2020-04-04 Thread Paul Spooren
as well. Signed-off-by: Paul Spooren --- phase1/master.cfg | 8 1 file changed, 8 insertions(+) diff --git a/phase1/master.cfg b/phase1/master.cfg index 792f9b3..6ff827d 100644 --- a/phase1/master.cfg +++ b/phase1/master.cfg @@ -925,6 +925,14 @@ for target in targets

Re: [OpenWrt-Devel] [PATCH] mvebu/cortexa9: use Linksys codename as PROFILE

2020-04-02 Thread Paul Spooren
On Wed Apr 1, 2020 at 5:02 AM PST, wrote: > Hi, > > > > How about patching device's DTSes and include 'manufacturer,model' > > there instead (in front of the existing ones)? Scripts in 'basic-files' > > would also > > need to be fixed but this way we save this (in my opinion) misuse of > >

[OpenWrt-Devel] [PATCH 3/3] ImageBuilder: Show alternative device names

2020-04-01 Thread Paul Spooren
With the introduction of `Target-Profile-AltNames` the ImageBuilder should show these names to allow users to find their devices without knowing the name used in the OpenWrt build system. Signed-off-by: Paul Spooren --- target/imagebuilder/files/Makefile | 1 + 1 file changed, 1 insertion

[OpenWrt-Devel] [PATCH 2/3] build: Introduce Target-Profile-AltNames

2020-04-01 Thread Paul Spooren
Currently the alternative consumer names for devices are stored in the description only or as a joint string in `Target-Profile-Name`. This adds a new variable called `Target-Profile-AltNames` to store the alternateive names as a quoted list: "" "" "" Signed-off-

[OpenWrt-Devel] [PATCH 0/3] ImageBuilder: Show alternative names

2020-04-01 Thread Paul Spooren
The ImageBuilder was never really updated to work with alternative names of 4ee3cf2b5a, this patch makes the alternative names visible when running `make info`. Also I can now cross of "Do something with Perl" from my bucket list. Paul Spooren (3): scripts: target-metadata don't ad

[OpenWrt-Devel] [PATCH 1/3] scripts: target-metadata don't add PROFILES twice

2020-04-01 Thread Paul Spooren
`. This patch uses Perls `uniq` function to add the profiles only once to `.profiles.mk`. Signed-off-by: Paul Spooren --- scripts/target-metadata.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/target-metadata.pl b/scripts/target-metadata.pl index ee0ab5a718

[OpenWrt-Devel] [PATCH] mvebu/cortexa9: use Linksys codename as PROFILE

2020-03-31 Thread Paul Spooren
identical except for a `,` replacement with `_`, which is due to Makefile naming limitations. Signed-off-by: Paul Spooren --- This is just a first step, we should follow the device tree identifier for all other PROFILE as well. target/linux/mvebu/image/cortexa9.mk | 56

Re: [OpenWrt-Devel] [PATCH] mvebu, tegra: make CPU subtype default to vfp3-d16

2020-03-31 Thread Paul Spooren
Tested on mvebu and fixes opkg issue the issue for me, thanks! Best, Paul ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] OpenWrt developer meeting at Battlemesh and COVID-19

2020-03-26 Thread Paul Spooren
Hi team, I hope everyone is fine & healthy and can use the time in quarantine to finally review those important patches I sent! Based on recent events regarding COVID-19 the Battlemesh and the OpenWrt developer meeting will not take place in May this year. it's really nice and necessary to

Re: [OpenWrt-Devel] [PATCH] x86: fix virutalbox squashfs images

2020-03-25 Thread Paul Spooren
> >> typo in title and missing "R" in name directly above. Ack > > This script is for only your typical block devices, no MTD involved. > > > Looks like you should rather fix the logic setting > > CONFIG_TARGET_IMAGE_PAD. > > This has been removed with >

[OpenWrt-Devel] [PATCH v2] x86: fix offer f2fs/ext4 based overlays

2020-03-25 Thread Paul Spooren
With the recent rework of the x86 image creation the f2fs/ext4 based overlays dissappeared as their are not copied by default. This patch enables the creation of rootfs files for ext4 and squashfs and stores it next to the combined images. Signed-off-by: Paul Spooren --- v2: * Use generic

[OpenWrt-Devel] [PATCH] x86: fix virutalbox squashfs images

2020-03-25 Thread Paul Spooren
The previous rework of x86 image creation broke the `vdi` images. ussell Senior came up with this patch to fix the padding. Tested with x86/64 with Docker (squashfs), qemustart (ext4/squashfs) and virtualbox (ext4/squashfs). Signed-off-by: Paul Spooren --- target/linux/x86/image/Makefile | 10

[OpenWrt-Devel] [PATCH] x86: fix offer f2fs/ext4 based overlays

2020-03-24 Thread Paul Spooren
With the recent rework of the x86 image creation the f2fs/ext4 based overlays dissappeared as their are not copied by default. This commit follows the implementation of malta and armvirt to copy the overlays as well. Signed-off-by: Paul Spooren --- target/linux/x86/image/Makefile | 10

[OpenWrt-Devel] [PATCH] x86/geode: fixup FEATURE inheritance

2020-03-23 Thread Paul Spooren
In the geode subtarget all default x86 features were overwritten via := instead of extending them via +=. This patch fixes the inheritance and thereby the compilation of x86/geode target. Compile tested x86/geode. Signed-off-by: Paul Spooren --- target/linux/x86/geode/target.mk | 2 +- 1 file

[OpenWrt-Devel] [PATCH] x86/geode: add missing include after rebase

2020-03-23 Thread Paul Spooren
The x86 image generation was refacted via cb007a7bf6 and accidently not included `geode.mk` when selected as subtarget. Now the file is included and image compilation for x86/geode works again. Thanks to Russell Senior for reporting the problem and suggesting a patch! Signed-off-by: Paul

Re: [OpenWrt-Devel] [PATCH] tools: squashfskit4: fix build with GCC10

2020-03-22 Thread Paul Spooren
On Sat Mar 21, 2020 at 5:41 AM PST, Alexander 'lynxis' Couzens wrote: > Hi Paul, > Hi Robert, > > > Sorry, I did not know about that situation but after a look it seems > > that squashfs-tools is more up to date that the fork. > > There has been a 4.4 release and couple of patches each month to

Re: [OpenWrt-Devel] [PATCH] tools: squashfskit4: fix build with GCC10

2020-03-20 Thread Paul Spooren
Hi, wan't squashfskit4 created as a workaround for an inactive upstream maintainer? Wouldn't it make sense to move back to upstream now that it is more up to date than our fork? Best, Paul On Thu Mar 19, 2020 at 2:22 AM PST, Robert Marko wrote: > From: Robert Marko > > In order to build

[OpenWrt-Devel] [PATCH 6/6] scripts: fixup qemustart for new x86 image names

2020-03-20 Thread Paul Spooren
it still finds the file. Signed-off-by: Paul Spooren --- scripts/qemustart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qemustart b/scripts/qemustart index dbb8deddaf..9ce03901aa 100755 --- a/scripts/qemustart +++ b/scripts/qemustart @@ -255,7 +255,7

[OpenWrt-Devel] [PATCH 3/6] x86: remove obsolete legacy profiles

2020-03-20 Thread Paul Spooren
Rely on device profiles instead for packages selection. Signed-off-by: Tomasz Maciej Nowak [rebase, adjusted commit title] Signed-off-by: Paul Spooren --- target/linux/x86/64/profiles/000-Generic.mk | 15 -- .../linux/x86/generic/profiles/000-Generic.mk | 19

[OpenWrt-Devel] [PATCH 4/6] x86: use qemu-image command from image-commands.mk

2020-03-20 Thread Paul Spooren
=416cccf398e9589e3de386e05b61b1c46cace20d#l51 Signed-off-by: Paul Spooren --- include/image-commands.mk | 7 +++ target/linux/x86/image/Makefile | 14 ++ 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/include/image-commands.mk b/include/image-commands.mk index 37cb083bbf

[OpenWrt-Devel] [PATCH 5/6] x86: allow non gzipped images

2020-03-20 Thread Paul Spooren
The previous image generation code would always gzipped images. This patch changes the behaviour and only compresses images when selected in menuconfig. Signed-off-by: Paul Spooren --- target/linux/x86/image/Makefile | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[OpenWrt-Devel] [PATCH 2/6] x86: switch image generation to new code

2020-03-20 Thread Paul Spooren
of redefining them. * For subtargets create device definitions with basic packages set. Signed-off-by: Tomasz Maciej Nowak [rebased] Signed-off-by: Paul Spooren --- config/Config-images.in | 18 +- include/image.mk | 1 - target/linux/x86/Makefile

[OpenWrt-Devel] [PATCH 0/6] x86: switch to generic image generation code

2020-03-20 Thread Paul Spooren
patches are added to keep consistency with current behaviour. [0]: https://patchwork.ozlabs.org/cover/1024165/ Paul Spooren (6): x86/grub2: move grub2 image creation to package x86: switch image generation to new code x86: remove obsolete legacy profiles x86: use qemu-image command from

[OpenWrt-Devel] [PATCH 1/6] x86/grub2: move grub2 image creation to package

2020-03-20 Thread Paul Spooren
Nowak [rebase, adjusted commit title] Signed-off-by: Paul Spooren --- package/boot/grub2/Makefile | 31 +++ .../boot/grub2/files}/grub-early.cfg | 0 target/linux/x86/image/Makefile | 30 +- 3 files changed, 39 insertions

Re: [OpenWrt-Devel] [PATCH v6] build: refactor JSON info files to `profiles.json`

2020-03-12 Thread Paul Spooren
On Thu Mar 12, 2020 at 2:55 AM PST, Paul Spooren wrote: > JSON info files contain machine readable information of built profiles > and resulting images. These files where added via 881ed09ee6e2. They are > useful for firmware wizards and script checking for reproducibility. > > Cur

[OpenWrt-Devel] [PATCH v6] build: refactor JSON info files to `profiles.json`

2020-03-12 Thread Paul Spooren
. If no JSON info files were created, no `profiles.json` files is created as it would be empty anyway. As before, this creation is enabled by default only if `BUILDBOT` is set. Tested via buildroot & ImageBuilder on ath79/generic, imx6 and x86/64. Signed-off-by: Paul Spooren --- v2: * One ins

Re: [OpenWrt-Devel] [PATCH v5] build: refactor JSON info files to `profiles.json`

2020-03-11 Thread Paul Spooren
On Wed Mar 11, 2020 at 2:12 AM PST, Petr Štetiar wrote: > Paul Spooren [2020-03-10 18:11:21]: > > > + $$(_TARGET): $(BUILD_DIR)/json_info_files/$(call > > IMAGE_NAME,$(1),$(2)).json > > + $(BUILD_DIR)/json_info_files/$(call IMAGE_NAME,$(1),$(2)).json: > > $(BIN_D

[OpenWrt-Devel] [PATCH v5] build: refactor JSON info files to `profiles.json`

2020-03-10 Thread Paul Spooren
. If no JSON info files were created, no `profiles.json` files is created as it would be empty anyway. As before, this creation is enabled by default only if `BUILDBOT` is set. Tested via buildroot & ImageBuilder on ath79/generic, imx6 and x86/64. Signed-off-by: Paul Spooren --- v2: * One ins

Re: [OpenWrt-Devel] [PATCH v4] build: refactor JSON info files to `profiles.json`

2020-03-08 Thread Paul Spooren
On Sat Mar 7, 2020 at 1:34 AM PST, Petr Štetiar wrote: > Paul Spooren [2020-03-05 12:26:03]: > > Hi, > > > +json_overview_image_info: FORCE > > + WORK_DIR=$(BUILD_DIR)/json_info_files \ > > + TARGET_DIR=$(BIN_DIR) \ > > + $(SCR

[OpenWrt-Devel] [RFT]x86: rework image builder code

2020-03-07 Thread Paul Spooren
Hi team, based on @tmn505 and @lynxis great work[0][1] I created a rebased hybird version upgrading the x86 image creation code to use `image.mk`! I created the patch on Github.com[3], but as it is such a core component I can also send the patch to the list... It works and boots via qemu and

[OpenWrt-Devel] [PATCH v4] build: refactor JSON info files to `profiles.json`

2020-03-05 Thread Paul Spooren
son` files is created as it would be empty anyway. As before, this creation is enabled by default only if `BUILDBOT` is set. Tested via buildroot & ImageBuilder on ath79/generic, imx6 and x86/64. Signed-off-by: Paul Spooren --- v2: * One instead of three CONFIG options * Only created `profiles

Re: [OpenWrt-Devel] [PATCH v2] build: refactor JSON info files to `profiles.json`

2020-03-03 Thread Paul Spooren
Hi Petr, On 02.03.20 23:12, Petr Štetiar wrote: Paul Spooren [2020-03-02 16:19:05]: -  .IGNORE: $(BIN_DIR)/$(call IMAGE_NAME,$(1),$(2)) [...]    $(BIN_DIR)/$(call IMAGE_NAME,$(1),$(2)): $(KDIR)/tmp/$(call IMAGE_NAME,$(1),$(2)) -   cp $$^ $$@ +   -cp $$^ $$@ The prefixed dash

Re: [OpenWrt-Devel] RFC: versions.json

2020-03-02 Thread Paul Spooren
Hi, Thinking on which info the client side would need, I would remove the minors info if we can just skip to latest. Yes, if we always skip to the latest anyway the "latest" key could contain that version and the rest is simply interpolated. When wanting to cover release candidates we could

Re: [OpenWrt-Devel] [PATCH v2] build: refactor JSON info files to `profiles.json`

2020-03-02 Thread Paul Spooren
This problem occurs also fox x86, the problem is that the image function is not properly called. Maybe because IMX6 only offer a default target but no profiles, resulting in an empty profiles.json file - I think. I started (based on Lynxis draft) reworking the x86 so it creates also JSON

[OpenWrt-Devel] [PATCH v3] build: refactor JSON info files to `profiles.json`

2020-03-02 Thread Paul Spooren
implementation used the functions `json.dumps()` which seem to have caused broken files. Now the `pathlib` library is used to deal with files and the `json` library only reads/writes into variables. Tested via buildroot & ImageBuilder on ath79/generic. Signed-off-by: Paul Spooren --- v2: * One ins

Re: [OpenWrt-Devel] RFC: versions.json

2020-03-02 Thread Paul Spooren
Hi, A first step could be to establish a *versions.json* file at the root of downloads.openwrt.org! The file would allow to check if a device still runs the latest release. JSON seems common enough and is well supported by LuCIs JavaScript implementation and also via jshn.sh on a CLI/script

Re: [OpenWrt-Devel] [PATCH v2] build: refactor JSON info files to `profiles.json`

2020-03-01 Thread Paul Spooren
On 01.03.20 02:34, Petr Štetiar wrote: Paul Spooren [2020-02-29 16:48:50]: FYI: $ grep JSON .config CONFIG_JSON_OVERVIEW_IMAGE_INFO=y $ cat bin/targets/imx6/generic/profiles.json {} This problem occurs also fox x86, the problem is that the image function is not properly called

Re: [OpenWrt-Devel] [PATCH v2] build: refactor JSON info files to `profiles.json`

2020-03-01 Thread Paul Spooren
. Thanks, included in v3 On 3/1/20 3:48 AM, Paul Spooren wrote: JSON info files contain machine readable information of built profiles and resulting images. These files where added via 881ed09ee6e2. They are useful for firmware wizards and script checking for reproducibility. Currently all JSON

[OpenWrt-Devel] [PATCH v2] build: refactor JSON info files to `profiles.json`

2020-02-29 Thread Paul Spooren
implementation used the functions `json.dumps()` which seem to have caused broken files. Now the `pathlib` library is used to deal with files and the `json` library only reads/writes into variables. Tested via buildroot & ImageBuilder on ath79/generic. Signed-off-by: Paul Spooren --- v2: * One ins

[OpenWrt-Devel] ImageBuilder: satisfy_dependencies_for [...] iw

2020-02-29 Thread Paul Spooren
Hi, for the last few days I get the following error for multiple targets, would it be possible to rerun the snapshot servers to rebuild the package `iw`? $ make manifest PROFILE="devolo_dvl1750e" [...] Collected errors:  * satisfy_dependencies_for: Cannot satisfy the following dependencies

Re: [OpenWrt-Devel] [PATCH] build: refactor JSON info files

2020-02-28 Thread Paul Spooren
Hi, This PR refactors the JSON creation to store individual files in $(KDIR)/tmp and create an single overview file called `profiles.json` in the target dir. As before, this creation is enabled by default only for the BUILDBOT. To archive the previous behaviour the option

[OpenWrt-Devel] [PATCH] build: refactor JSON info files

2020-02-15 Thread Paul Spooren
behaviour the option JSON_INDIVIDUAL_JSON_INFO can be set. Signed-off-by: Paul Spooren --- Makefile| 6 ++ config/Config-build.in | 24 + include/image.mk| 9 +--- scripts/json_overview_image_info.py | 33

[OpenWrt-Devel] [PATCH] build: fix empty SUBTARGET in json files

2020-02-11 Thread Paul Spooren
dition to use `generic` if the subtarget is empty. Tested for the kirkwood target. Signed-off-by: Paul Spooren --- include/image.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/image.mk b/include/image.mk index 46d592e8dc..fd04d4020b 100644 --- a/include/image.mk

Re: [OpenWrt-Devel] [RFC] commit message in YAML format for new devices

2020-01-24 Thread Paul Spooren
Hi, I created a very basic script which should be extended to show all hardware information needed. Once that works I'd package it. https://forum.openwrt.org/t/script-convert-device-information-to-yaml/53516 Best, Paul On 1/12/20 11:47 AM, Paul Spooren wrote: Hi all, some time ago I

Re: [OpenWrt-Devel] GSoC 2020 - reminder for ideas

2020-01-21 Thread Paul Spooren
Hi, I added a device pages project idea. That could come in handy with the page refresh and all. Also I'm trying to setup a devices.git repository storing all relevant metadata. That could be an additional project or I just do it on my own and leave the rendering to a student. Best, Paul

Re: [OpenWrt-Devel] [RFC] commit message in YAML format for new devices

2020-01-20 Thread Paul Spooren
On 1/13/20 3:03 AM, Thomas Endt wrote: -Ursprüngliche Nachricht- Von: openwrt-devel Im Auftrag von Paul Spooren Gesendet: Sonntag, 12. Januar 2020 22:47 An: 'OpenWrt Development List' Betreff: [OpenWrt-Devel] [RFC] commit message in YAML format for new devices An illustrative commit there

Re: [OpenWrt-Devel] [RFC] commit message in YAML format for new devices

2020-01-13 Thread Paul Spooren
Hi, On 1/12/20 1:05 PM, Martin Blumenstingl wrote: Hi Paul, On Sun, Jan 12, 2020 at 10:47 PM Paul Spooren wrote: Hi all, some time ago I created a (now outdated) device overview[0] based on YAML meta data. This approach could simplify maintaining an device overview and device specific pages

[OpenWrt-Devel] [RFC] commit message in YAML format for new devices

2020-01-12 Thread Paul Spooren
Hi all, some time ago I created a (now outdated) device overview[0] based on YAML meta data. This approach could simplify maintaining an device overview and device specific pages[1]. All commits adding new devices already include most relevant information for creating the overview. However

<    1   2   3   4   5   6   >