Re: [PATCH V2] tplink-safeloader: Patch to handle partitions with alternate names.

2022-05-05 Thread Rafał Miłecki
On 5.05.2022 16:33, Ole Kristian Lona wrote: I removed those "const" qualifiers to get rid of the error message about "assignments discards 'const' qualifiers"... If I in addition make flash_partition_entry a const, the file won't compile any more, since we are adjusting the value of flash_part

Re: [PATCH V2] tplink-safeloader: Patch to handle partitions with alternate names.

2022-05-05 Thread Rafał Miłecki
On 5.05.2022 10:31, Ole Kristian Lona via openwrt-devel wrote: > +/** Flash partition names table entry */ > +struct factory_partition_names { > + char *partition_table; > + char *soft_ver; > + char *os_image; > + char *file_system; > + char *extra_para; > +}; Use "const char *" for each. Y

Re: [PATCH] tplink-safeloader: Patch to handle partitions with alternate names.

2022-05-05 Thread Rafał Miłecki
On 5.05.2022 09:14, Ole Kristian Lona via openwrt-devel wrote: The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list

Re: [PATCH v2] bcm53xx: complete Asus RT-AC88U support

2022-05-03 Thread Rafał Miłecki
On 31.03.2022 08:35, Arınç ÜNAL wrote: Add white:lan LED configuration. Remove the BROKEN flag. Signed-off-by: Arınç ÜNAL --- v2: remove adding rtl8365mb patch as it's already done. --- target/linux/bcm53xx/base-files/etc/board.d/01_leds | 3 +++ target/linux/bcm53xx/image/Makefile

Re: [PATCH] packages: nvram: add NVRAM quirks for bcm53xx target

2022-05-03 Thread Rafał Miłecki
On 31.03.2022 21:19, Arınç ÜNAL wrote: Add NVRAM quirks script for the bcm53xx target. Split NVRAM quirks for the bcm47xx and bcm53xx targets. Move clear partialboot NVRAM quirk for Linksys EA9500 here. Add set wireless LED behaviour quirk for Asus RT-AC88U. Signed-off-by: Arınç ÜNAL --- pack

Re: [PATCH] tplink-safeloader: Patch to handle partitions with alternate names.

2022-05-03 Thread Rafał Miłecki
On 2.05.2022 18:24, Ole Kristian Lona via openwrt-devel wrote: The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list

Re: Optimizing kernel compilation / alignments for network performance

2022-04-29 Thread Rafał Miłecki
On 27.04.2022 19:31, Rafał Miłecki wrote: On 27.04.2022 14:56, Alexander Lobakin wrote: From: Rafał Miłecki Date: Wed, 27 Apr 2022 14:04:54 +0200 I noticed years ago that kernel changes touching code - that I don't use at all - can affect network performance for me. I work with home ro

Re: Optimizing kernel compilation / alignments for network performance

2022-04-27 Thread Rafał Miłecki
On 27.04.2022 14:56, Alexander Lobakin wrote: From: Rafał Miłecki Date: Wed, 27 Apr 2022 14:04:54 +0200 I noticed years ago that kernel changes touching code - that I don't use at all - can affect network performance for me. I work with home routers based on Broadcom Northstar pla

Optimizing kernel compilation / alignments for network performance

2022-04-27 Thread Rafał Miłecki
Hi, I noticed years ago that kernel changes touching code - that I don't use at all - can affect network performance for me. I work with home routers based on Broadcom Northstar platform. Those are SoCs with not-so-powerful 2 x ARM Cortex-A9 CPU cores. Main task of those devices is NAT masquerad

Re: [PATCH] Revert "ipq40xx: document pcie wifi chip on the GL.Inet GL-B2200"

2022-04-27 Thread Rafał Miłecki
On 17.04.2022 02:42, Enrico Mioso wrote: This reverts commit 80d34d9d593865248bf5a23794e9163895140de7. This brings back the PCI Wi-Fi interface on the GL-B2200. CC: Christian Lamparter Signed-off-by: Enrico Mioso This description doesn't tell anything really. Please explain what happens and

[PATCH] swconfig: parse "switch_vlan" before "switch_port"

2022-04-04 Thread Rafał Miłecki
From: Rafał Miłecki Before this change UCI sections of both types were parsed in order as specified in UCI. That didn't work well with all drivers (e.g. b53). It seems that VLAN setup can reset / overwrite previously set ports parameters. It resulted in "switch_port" option

Re: [PATCH v2] bcm53xx: add support for Asus RT-AC88U

2022-03-29 Thread Rafał Miłecki
On 12.11.2021 11:56, Arınç ÜNAL wrote: Asus RT-AC88U is an AC3100 router featuring 9 Ethernet ports over the integrated Broadcom and the external Realtek switch. Hardware info: * Processor: Broadcom BCM4709C0KFEBG dual-core @ 1.4 GHz * Switch: BCM53012 in BCM4709C0KFEBG & external RTL8365MB * DD

Re: [PATCH] bcm4908: fix sysupgrade with backup

2022-03-04 Thread Rafał Miłecki
On 11.02.2022 19:21, Rafał Miłecki wrote: From: Rafał Miłecki 1. Clean "rootfs_data" manually as bcm4908 doesn't use nand.sh helpers 2. Update image sequence in rootfs_data to make overlay_verify accept it 3. Set CI_UBIPART to make nand_do_upgrade_success() (re)store backup

Re: [PATCH] bcm4908: support "rootfs_data" on U-Boot devices

2022-03-04 Thread Rafał Miłecki
On 5.01.2022 23:16, Rafał Miłecki wrote: From: Rafał Miłecki 1. Create "rootfs_data" dynamicaly U-Boot firmware images can contain only kernel and rootfs volume (squashfs in case of OpenWrt). There is no way to include "rootfs_data" UBI volume or make firmware file tell

Re: [PATCH fstools] libfstools: support custom executable validating overlay

2022-03-04 Thread Rafał Miłecki
On 4.01.2022 23:46, Rafał Miłecki wrote: From: Rafał Miłecki This results in calling /usr/libexec/overlay_verify which may either modify overlay (e.g. wipe it) or refuse it. It's needed by targets that need to validate that "rootfs_data" doesn't come from a previous firmwa

[PATCH 2/2] bcm4908: include U-Boot in images

2022-03-04 Thread Rafał Miłecki
From: Rafał Miłecki This is a step forward in adding support for devices with U-Boot. Signed-off-by: Rafał Miłecki --- target/linux/bcm4908/image/bootfs-generic.its | 35 +-- 1 file changed, 32 insertions(+), 3 deletions(-) diff --git a/target/linux/bcm4908/image/bootfs

[PATCH 1/2] uboot-bcm4908: add package with BCM4908 U-Boot

2022-03-04 Thread Rafał Miłecki
From: Rafał Miłecki New BCM4908 devices come with U-Boot instead of CFE. Firmwares for such devices has to include U-Boot. Signed-off-by: Rafał Miłecki --- package/boot/uboot-bcm4908/Makefile | 48 ...ow-to-complete-build-even-with-ad-ho.patch | 40

[PATCH] kernel: force atomic renames in ubifs

2022-03-01 Thread Rafał Miłecki
From: Rafał Miłecki This deals with user-spaces apps that don't handle all syncing correctly. It prevents user ending up with an empty file. Signed-off-by: Rafał Miłecki --- .../510-ubifs-force-atomic-renames.patch | 46 +++ .../510-ubifs-force-atomic-renames.

[PATCH] base-files: call "sync" after initial setup

2022-03-01 Thread Rafał Miłecki
From: Rafał Miłecki OpenWrt uses a lot of (b)ash scripts for initial setup. This isn't the best solution as they almost never consider syncing files / data. Still this is what we have and we need to try living with it. Without proper syncing OpenWrt can easily get into an inconsistent sta

Re: ubifs: handling dirty data (writing back) + power cuts

2022-02-28 Thread Rafał Miłecki
On 25.02.2022 15:17, Rafał Miłecki wrote: My actual problem is related to ubifs behaviour for power cuts happening between 5 and 35 seconds after saving a file: date > /mount/ubifs/test.txt && sleep 15 && echo CUT POWER *NOW* On the next boot test.txt exists but it's E

Re: ubifs: handling dirty data (writing back) + power cuts

2022-02-25 Thread Rafał Miłecki
On 25.02.2022 15:17, Rafał Miłecki wrote: My actual problem is related to ubifs behaviour for power cuts happening between 5 and 35 seconds after saving a file: date > /mount/ubifs/test.txt && sleep 15 && echo CUT POWER *NOW* On the next boot test.txt exists but it's EMP

ubifs: handling dirty data (writing back) + power cuts

2022-02-25 Thread Rafał Miłecki
Hi, my system is setup as follows: # mount | grep ubifs /dev/ubi0_1 on /mount/ubifs type ubifs (rw,noatime,assert=read-only,ubi=0,vol=1) # cat /proc/sys/vm/dirty_writeback_centisecs 500 # cat /proc/sys/vm/dirty_expire_centisecs 3000 (5 s and 30 s respectively) and I'm currently debugging some

[PATCH] bcm4908: fix sysupgrade with backup

2022-02-11 Thread Rafał Miłecki
From: Rafał Miłecki 1. Clean "rootfs_data" manually as bcm4908 doesn't use nand.sh helpers 2. Update image sequence in rootfs_data to make overlay_verify accept it 3. Set CI_UBIPART to make nand_do_upgrade_success() (re)store backup Signed-off-by: Rafał Miłecki --- .../base-fi

Re: [PATCH v2 1/2] uhttpd: Reload config after uhttpd-mod-ubus was added

2022-01-06 Thread Rafał Miłecki
On 6.01.2022 22:50, Rafał Miłecki wrote: Hi Hauke, On 20.03.2021 20:57, Hauke Mehrtens wrote: Without this change the config is only committed, but the uhttpd daemon is not reloaded. This reload is needed to apply the config. Without the reload of uhttpd, the ubus server is not available over

[PATCH 21.02 2/2] procd: update to git HEAD

2022-01-06 Thread Rafał Miłecki
From: Daniel Golle 945d0d7 utils: fix C style in header file 2cfc26f inittab: detect active console from kernel if no console= specified Signed-off-by: Daniel Golle (cherry picked from commit ffeb37047e85a5efd96890db12710e9d60b4b76a) --- package/system/procd/Makefile | 6 +++--- 1 file chang

[PATCH 21.02 0/2] procd: fix console support

2022-01-06 Thread Rafał Miłecki
From: Rafał Miłecki There is one procd patch that is critical for few devices: 2cfc26f inittab: detect active console from kernel if no console= specified It allows using serial console on devices that have it but don't specify it e.g. using console= cmdline argument. In a long term w

[PATCH 21.02 1/2] procd: update to git HEAD

2022-01-06 Thread Rafał Miłecki
From: Daniel Golle 64e9f3a procd: fix compilation with newer musl Signed-off-by: Daniel Golle (cherry picked from commit 1cd4a02c8e3f8574f1ba8c40b1bd4decbfb49e62) --- package/system/procd/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/system/procd/M

Re: [PATCH v2 1/2] uhttpd: Reload config after uhttpd-mod-ubus was added

2022-01-06 Thread Rafał Miłecki
On 6.01.2022 22:50, Rafał Miłecki wrote: On 20.03.2021 20:57, Hauke Mehrtens wrote: Without this change the config is only committed, but the uhttpd daemon is not reloaded. This reload is needed to apply the config. Without the reload of uhttpd, the ubus server is not available over http and

Re: [PATCH v2 1/2] uhttpd: Reload config after uhttpd-mod-ubus was added

2022-01-06 Thread Rafał Miłecki
Hi Hauke, On 20.03.2021 20:57, Hauke Mehrtens wrote: Without this change the config is only committed, but the uhttpd daemon is not reloaded. This reload is needed to apply the config. Without the reload of uhttpd, the ubus server is not available over http and returns a Error 404. This caused

[PATCH] bcm4908: support "rootfs_data" on U-Boot devices

2022-01-05 Thread Rafał Miłecki
From: Rafał Miłecki 1. Create "rootfs_data" dynamicaly U-Boot firmware images can contain only kernel and rootfs volume (squashfs in case of OpenWrt). There is no way to include "rootfs_data" UBI volume or make firmware file tell U-Boot to create one. For that reason "

[PATCH fstools] libfstools: support custom executable validating overlay

2022-01-04 Thread Rafał Miłecki
From: Rafał Miłecki This results in calling /usr/libexec/overlay_verify which may either modify overlay (e.g. wipe it) or refuse it. It's needed by targets that need to validate that "rootfs_data" doesn't come from a previous firmware. They may provide a script that will

[PATCH fstools 2/2] libfstools: use variable for overlay mount-point

2022-01-04 Thread Rafał Miłecki
From: Rafał Miłecki This avoids duplicating path over and over. Signed-off-by: Rafał Miłecki --- libfstools/overlay.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/libfstools/overlay.c b/libfstools/overlay.c index 26f0d6e..6790337 100644 --- a

[PATCH fstools 1/2] libfstools: get rid of "extroot_prefix" global variable

2022-01-04 Thread Rafał Miłecki
From: Rafał Miłecki Replace it with mount_extroot() argument. It's cleaner than a global var. Signed-off-by: Rafał Miłecki --- libfstools/extroot.c| 7 +-- libfstools/libfstools.h | 3 +-- libfstools/overlay.c| 3 +-- mount_root.c| 3 +-- 4 files changed, 4 inser

[PATCH fstools 2/2] Update / fix extroot comments

2022-01-04 Thread Rafał Miłecki
From: Rafał Miłecki Comment in start() was invalid as mount_extroot() doesn't handle any mounting internally. It was a misunderstanding coming from block.s function called just the same. Signed-off-by: Rafał Miłecki --- libfstools/overlay.c | 4 mount_root.c | 6 +- 2

[PATCH fstools 1/2] libfstools: check for overlay mounting errors

2022-01-04 Thread Rafał Miłecki
From: Rafał Miłecki Signed-off-by: Rafał Miłecki --- libfstools/overlay.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libfstools/overlay.c b/libfstools/overlay.c index 5de12c5..87fad11 100644 --- a/libfstools/overlay.c +++ b/libfstools/overlay.c @@ -416,6 +416,7

New OpenWrt rootfs format: ubifs volume with squashfs & overlay dir

2022-01-03 Thread Rafał Miłecki
On some UBI-aware devices, firmware file can contain only kernel & 1 UBI volume. It means we can't use: 1. rootfs UBI volume with squashfs 2. rootfs_data UBI volume with ubifs (for overlay) Note: creating rootfs_data dynamically is not an option as that wouldn't be wiped out properly while flashin

Re: [PATCH v2] ruckus_fw_header: Add Ruckus Firmware builder for Ruckus R500 and others

2022-01-03 Thread Rafał Miłecki
On 3.12.2021 01:18, tus...@tusker.org wrote: From: Damien Mascord This image builder builds a tftp updatable binary for Ruckus hardware Hey, I missed this patch, my suggestion would be to use something like [PATCH firmware-utils V2] Let me look at it now. First git complains about some whit

Re: [PATCH V2] firmware-utils: replace GPL 2.0 boilerplate/reference with SPDX

2021-12-17 Thread Rafał Miłecki
Cc people from copyrights On 04.08.2021 16:12, Rafał Miłecki wrote: From: Rafał Miłecki This uses "GPL-2.0-only" header for files identified using scancode license scanner with 100% score as GPL 2.0. Signed-off-by: Rafał Miłecki --- V2: Include .h files Send without 22 peopl

Re: [PATCH] firmware-utils: replace GPL 2.0+ boilerplate/reference with SPDX

2021-12-17 Thread Rafał Miłecki
Cc people from copyrights On 04.08.2021 13:12, Rafał Miłecki wrote: From: Rafał Miłecki This uses "GPL-2.0-or-later" header for files identified using scancode license scanner with 100% score as GPL 2.0 or later. Signed-off-by: Rafał Miłecki --- tools/firmware-utils/src/ad

[PATCH 21.02] busybox: backport dd support for iflag=count_bytes

2021-12-16 Thread Rafał Miłecki
From: Rafał Miłecki It's very useful flag for handling various formats in sysupgrade. This commits comes from 1.34.0 release. Signed-off-by: Rafał Miłecki --- .../001-dd-support-iflag-count_bytes.patch| 140 ++ 1 file changed, 140 insertions(+) create mode 100644 pa

Re: Identifying UBI volume instance / storing UBI volume metadata

2021-12-09 Thread Rafał Miłecki
On 9.12.2021 21:11, Olivier Valentin wrote: How about storing the squashfs into the rootfs ubi volume (as a bare file), start with an initramfs appended to the kernel and mount the root file with loopback block dev. The RW overlay part would be stored directly in the ubifs. (All modifications

Identifying UBI volume instance / storing UBI volume metadata

2021-12-09 Thread Rafał Miłecki
Hi, I'm Linux developer involved in OpenWrt & buildroot projects. I work on building firmware images for home routers but I need to work with existing designs. I don't work for Broadcom (or any other manufacturer) and so I can't change how firmware images are handled by original software. I'm dea

rootfs_data on UBI-aware devices

2021-12-09 Thread Rafał Miłecki
Hi, I have BCM4908 router with U-Boot that uses UBI. There are basically two relevant UBI volumes: 1. bootfs (contains U-Boot, kernel & DTBs) 2. rootfs Broadcom's U-Boot takes "pkgtb" firmware format with "bootfs" and "rootfs" images. It writes them to UBI volumes. What's missing in this design

[PATCH] bcm4908: sysupgrade: add pkgtb format support

2021-12-08 Thread Rafał Miłecki
From: Rafał Miłecki BCM4908 devices with U-Boot use pkgtb firmware format. It's based on U-Boot's FIT: DTB with configurations, images & embedded data. This format contains bootfs, rootfs and optionally a first stage U-Boot loader. Contained images need to be extracted & flash

[PATCH 2/2] dtc: support printing binary data with fdtget

2021-12-07 Thread Rafał Miłecki
From: Rafał Miłecki It's needed for extracting binary images. Cc: Yousong Zhou Signed-off-by: Rafał Miłecki --- ...t-for-printing-raw-bytes-with-fdtget.patch | 78 +++ 1 file changed, 78 insertions(+) create mode 100644 package/utils/dtc/patches/0001-Support-b-forma

[PATCH 1/2] dtc: import package for dtc & fdt from packages feed

2021-12-07 Thread Rafał Miłecki
From: Rafał Miłecki fdt* utils are needed by targets that use U-Boot FIT images for sysupgrade. It includes all recent BCM4908 SoC routers as Broadcom switched from CFE to U-Boot. fdtget is required for extracting images (bootfs & rootfs) from Broadcom's ITB. Extracted images ca

[PATCH] u-boot-tools: add new package for mkimage & dumpimage

2021-11-30 Thread Rafał Miłecki
From: Rafał Miłecki Those tools can be useful for targets that use ITB firmware format. They may need them to extract firmware images to flash them. Signed-off-by: Rafał Miłecki --- package/boot/u-boot-tools/Makefile| 50 +++ .../patches/0001-tools-disable

[PATCH] bcm4908: sysupgrade: refactor handling different firmware formats

2021-11-29 Thread Rafał Miłecki
From: Rafał Miłecki This results in setting format specific data (format info, extract commands) in a single function. It should help maintaining sysupgrade code. This change has been tested on Asus GT-AC5300 and Netgear R8000P. Signed-off-by: Rafał Miłecki --- .../base-files/lib/upgrade

[PATCH] bcm53xx: sysupgrade: refactor handling different firmware formats

2021-11-28 Thread Rafał Miłecki
From: Rafał Miłecki List of supported formats grew over time and implementation got a bit messy. There are multiple functions with format-specific parameters and commands. Refactor it by making platform_identify() setup all required info right after detecting firmware format. This simplifies

[PATCH firmware-utils 3/3] otrx: support TRX from stdin when extracting

2021-11-27 Thread Rafał Miłecki
From: Rafał Miłecki It allows e.g. dd if=firmware.chk skip=1 bs=58 | otrx extract - -1 kernel.bin Signed-off-by: Rafał Miłecki --- src/otrx.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/otrx.c b/src/otrx.c index 5ee310c..4ea19aa 100644 --- a/src/otrx.c

[PATCH firmware-utils 2/3] otrx: support unsorted partitions offsets

2021-11-27 Thread Rafał Miłecki
From: Rafał Miłecki TRX format doesn't guarantee that it contains partitions offsets in a sorted order. Store partitions info in context struct and make sure it's sorted. Signed-off-by: Rafał Miłecki --- src/otrx.c | 54 ++ 1 fi

[PATCH firmware-utils 1/3] otrx: extract shared code opening & parsing TRX format

2021-11-27 Thread Rafał Miłecki
From: Rafał Miłecki This avoids some code duplication. Signed-off-by: Rafał Miłecki --- src/otrx.c | 145 - 1 file changed, 77 insertions(+), 68 deletions(-) diff --git a/src/otrx.c b/src/otrx.c index af6e905..7f661ca 100644 --- a/src

[PATCH] bcm53xx: sysupgrade: simplify extracting image from Seama seal

2021-11-26 Thread Rafał Miłecki
From: Rafał Miłecki Use "oseama extract" which supports now writing to stdout. Signed-off-by: Rafał Miłecki --- .../bcm53xx/base-files/lib/upgrade/platform.sh | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/target/linux/bcm53xx/base-files/l

[PATCH firmware-utils 1/2] oseama: allow reading from stdin

2021-11-26 Thread Rafał Miłecki
From: Rafał Miłecki This adds support for reading Seama seal from stdin when using "info" or "extract" command. It allows e.g. cat firmware.bin | oseama info - Signed-off-by: Rafał Miłecki --- src/oseama.c | 77 +++-

[PATCH firmware-utils 2/2] oseama: support extracting entity to stdout

2021-11-26 Thread Rafał Miłecki
From: Rafał Miłecki This allows using oseama in a pipe. It's very useful for writing data to flash using e.g. oseama extract firmware.bin -e 0 | mtd write - firmware Signed-off-by: Rafał Miłecki --- src/oseama.c | 21 +++-- 1 file changed, 11 insertions(+), 10 dele

[PATCH firmware-utils 2/2] otrx: allow validating TRX from stdin

2021-11-25 Thread Rafał Miłecki
From: Rafał Miłecki This makes "otrx check" work with stdin to allow e.g. dd if=firmware.chk skip=1 bs=58 | otrx check - Signed-off-by: Rafał Miłecki --- src/otrx.c | 50 +++--- 1 file changed, 47 insertions(+), 3 deletions(-) diff -

[PATCH firmware-utils 1/2] otrx: avoid unneeded fseek() when calculating CRC32

2021-11-25 Thread Rafał Miłecki
From: Rafał Miłecki Just use already read data. Signed-off-by: Rafał Miłecki --- src/otrx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/otrx.c b/src/otrx.c index b5cd70d..aa81c96 100644 --- a/src/otrx.c +++ b/src/otrx.c @@ -193,8 +193,8 @@ static int otrx_check

Re: [PATCH 2/5] mac80211: add patch for BCM43436 firmware

2021-11-20 Thread Rafał Miłecki
On 20.11.2021 04:41, Stijn Tintel wrote: This chip is used in the Raspberry Pi Zero 2. Signed-off-by: Stijn Tintel This trivial patch could easily be upstreamed, please send it to linux-wireless@. ___ openwrt-devel mailing list openwrt-devel@lists.

[PATCH V2] bcm47xx: relocate LZMA loader

2021-11-07 Thread Rafał Miłecki
From: Rafał Miłecki Kernel 5.10 grew bigger than 5.4 so we need to bump BZ_TEXT_START to allow lzma loader hanel its size. At the same time BZ_STACK_START needs to be increased to avoid overwriting the stack. For a reference see: d5cf4a5aa4a3 ("brcm47xx: relocate loader to higher ad

[PATCH] bcm47xx: relocate LZMA loader

2021-11-07 Thread Rafał Miłecki
From: Rafał Miłecki This allows loader to handle kernel 5.10 that grew bigger than 5.4. Variations tested on BCM4706: BAD: BZ_TEXT_START := 0x8060 BZ_STACK_START := 0x8070 GOOD: BZ_TEXT_START := 0x8070 BZ_STACK_START := 0x8070 BAD: BZ_TEXT_START := 0x8060

Re: [PATCH] bcm53xx: add support for Asus RT-AC88U

2021-11-04 Thread Rafał Miłecki
On 04.11.2021 07:52, Rafał Miłecki wrote: On 25.10.2021 23:37, Arınç ÜNAL wrote: @@ -8,6 +8,12 @@ netgear,r8000)   ucidef_set_led_usbport "usb2" "USB 2.0" "bcm53xx:white:usb2" "usb1-port2" "usb2-port2"   ucidef_set_led_usbport "u

Re: [PATCH] bcm53xx: add support for Asus RT-AC88U

2021-11-04 Thread Rafał Miłecki
On 25.10.2021 23:37, Arınç ÜNAL wrote: @@ -8,6 +8,12 @@ netgear,r8000) ucidef_set_led_usbport "usb2" "USB 2.0" "bcm53xx:white:usb2" "usb1-port2" "usb2-port2" ucidef_set_led_usbport "usb3" "USB 3.0" "bcm53xx:white:usb3" "usb1-port1" "usb2-port1" "usb4-port1" ;; +asus,rt-a

[PATCH] bcm4908: start work on images for devices using U-Boot

2021-11-03 Thread Rafał Miłecki
From: Rafał Miłecki New BCM4908 family based routers will use U-Boot bootloader. That will require using a totally different firmware format. Kernel has to be put in a FIT image. OpenWrt has some helpers for generating .its files but they don't fit BCM4908 requirements and there is no s

[PATCH fstools RFC] mount_root: use RAM overlay if "rootfs_data" is missing

2021-10-28 Thread Rafał Miłecki
From: Rafał Miłecki This results in at least bootable system if something goes wrong and "rootfs_data" isn't available. Signed-off-by: Rafał Miłecki --- I noticed this problem on my UBI based system without "rootfs_data". This allows me to at least access my device.

[PATCH] layerscape: mkits-multiple-config: fail on invalid arguments

2021-10-25 Thread Rafał Miłecki
From: Rafał Miłecki Fail if arguments couldn't be parsed and print unrecognized part. It's important when running it from script with dynamic values. Missing value could result in skipping argument and silent failures (unexpected its). Signed-off-by: Rafał Miłecki --- target/linux/

Re: [PATCH v2 1/2] bcm53xx: remove extsw interface on Linksys EA9500

2021-10-23 Thread Rafał Miłecki
On 2021-10-23 23:09, Arınç ÜNAL wrote: On 23/10/2021 23:35, Rafał Miłecki wrote: On 2021-10-23 21:56, Arınç ÜNAL wrote: Remove extsw interface from the bridge as it's used as a master interface by the DSA driver. According to Vivek it's required, I explicitly asked about

Re: [PATCH v2 1/2] bcm53xx: remove extsw interface on Linksys EA9500

2021-10-23 Thread Rafał Miłecki
On 2021-10-23 21:56, Arınç ÜNAL wrote: Remove extsw interface from the bridge as it's used as a master interface by the DSA driver. According to Vivek it's required, I explicitly asked about it: https://forum.openwrt.org/t/build-for-linksys-ea9500/1817/984 _

[PATCH] bcm53xx: switch to the upstream DSA-based b53 driver

2021-10-18 Thread Rafał Miłecki
From: Rafał Miłecki 1. Drop swconfig 2. Simplify network setup 3. Verify network config 4. Disable Buffalo WZR-900DHP for now - it misses ports definition Signed-off-by: Rafał Miłecki --- target/linux/bcm53xx/Makefile | 2 +- .../bcm53xx/base-files/etc/board.d/02_network | 80

Re: nvmem: Defining cells on mtd created by mtdparts

2021-10-15 Thread Rafał Miłecki
On 11.10.2021 09:06, Sven Eckelmann wrote: On Sunday, 10 October 2021 14:53:13 CEST Sven Eckelmann wrote: [...] Since there are most likely more devices out there which use mtdparts, I would guess that there might already be a strategy out there which can be used to define the nvmem-provider for

Re: Missing -lpthread for libssl / libcrypto (LibreSSL) when compiling U-Boot

2021-10-13 Thread Rafał Miłecki
On 13.10.2021 10:23, Andre Heider wrote: On 13/10/2021 10:10, Rafał Miłecki wrote: *** Manual pkg-config test *** I'm not sure if I test it correctly but output looks OK: $ PATH=/home/rmilecki/openwrt/openwrt-master-bcm4908/staging_dir/host/bin:$PATH ./staging_dir/host/bin/pkg-config -

Missing -lpthread for libssl / libcrypto (LibreSSL) when compiling U-Boot

2021-10-13 Thread Rafał Miłecki
*** Introduction *** OpenWrt compiles U-Boot with some host tools like mkimage. *** Problem *** HOSTLD tools/mkimage /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: /home/rmilecki/openwrt/openwrt-master-bcm4908/staging_dir/host/lib/libssl.a(ssl_init.o): in functio

Re: [PATCH] bcm53xx: disable CONFIG_SWCONFIG_B53_PHY_DRIVER

2021-10-07 Thread Rafał Miłecki
Deprecated by the Revert "swconfig: fix Broadcom b53 support" ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: Release goals for 22.XX

2021-10-05 Thread Rafał Miłecki
On 30.09.2021 03:34, Rich Brown wrote: My desire would be to name our next release "22.03", with a target release date in March 2022. And we should name the following release "22.09" with a release date in September. And so on - every six months (or whatever interval we believe we can susta

[PATCH] Revert "swconfig: fix Broadcom b53 support"

2021-10-03 Thread Rafał Miłecki
From: Rafał Miłecki This reverts commit 8f9cd1af0f9c325a902dbd0e79e12015372e6bb0. That commit was meant to add a single EXPORT_SYMBOL_GPL() but it actually also added few .of_match_table-s. One commit should handle one thing and should not introduce unrelated changes. Regarding actual changes

Re: Removing 5.4 support for bcm27xx and bcm53xx

2021-10-02 Thread Rafał Miłecki
On 2021-10-02 18:43, Adrian Schmutzler wrote: both bcm27xx and bcm53xx have kernel 5.10 by default for more than one month. I'd like to remove 5.4 patches etc. there, so we don't have to bother with 5.4 for new patches (like stintel had to when adding config symbols recently). bcm53xx + 5.10

Re: [PATCH] bcm53xx: disable CONFIG_SWCONFIG_B53_PHY_DRIVER

2021-09-30 Thread Rafał Miłecki
Cc Tobias, author of the 8f9cd1af0f9c ("swconfig: fix Broadcom b53 support"). Another option would be to revert above commit (.of_match_table part anyway). On 30.09.2021 16:40, Rafał Miłecki wrote: From: Rafał Miłecki OpenWrt downstream b53 MDIO driver is bugged as it: 1. Regist

[PATCH] bcm53xx: disable CONFIG_SWCONFIG_B53_PHY_DRIVER

2021-09-30 Thread Rafał Miłecki
From: Rafał Miłecki OpenWrt downstream b53 MDIO driver is bugged as it: 1. Registers as PHY device driver (while switch is an MDIO device) 2. Provides of_match_table That results in bypassing kernel bus matching checks and probing b53 for MDIO device treated as PHY device. It doesn't wo

[PATCH] bcm53xx: drop downstream patch for Buffalo WZR-1750DHP button

2021-09-15 Thread Rafał Miłecki
From: Rafał Miłecki This patch never received a proper description and was never sent upstream as supposed. It was meant to be handled in 2015-2018 so it should be safe to assume noone really understands it or care. Cc: Felix Fietkau Signed-off-by: Rafał Miłecki --- ...power-button-for

[PATCH 1/2] bcm4908img: store offset of tail data

2021-09-10 Thread Rafał Miłecki
From: Rafał Miłecki This simplifies some operations as it doesn't have to be caculated over and over. It will also allow adding support for more vendor formats. Signed-off-by: Rafał Miłecki --- package/utils/bcm4908img/Makefile | 2 +- package/utils/bcm4908img/src/bcm4908img.c

[PATCH 2/2] bcm4908img: detect Linksys images

2021-09-10 Thread Rafał Miłecki
From: Rafał Miłecki Linksys uses an extra 0x100 bytes long tail for BCM4908 images. Signed-off-by: Rafał Miłecki --- package/utils/bcm4908img/Makefile | 2 +- package/utils/bcm4908img/src/bcm4908img.c | 22 ++ 2 files changed, 23 insertions(+), 1 deletion(-) diff

Re: Question about qca8k dsa driver and path to follow

2021-09-09 Thread Rafał Miłecki
wt., 7 wrz 2021 o 18:53 Ansuel Smith napisał(a): > I currently have a pr open [1] to migrate ipq806x to > dsa driver Can you paste a missing link, please? -- Rafał ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.o

Re: [PATCH ubus] ubusd: log ACL init errors

2021-08-20 Thread Rafał Miłecki
On 20.08.2021 18:39, Rafał Miłecki wrote: From: Rafał Miłecki This makes it easier to notice ubusd (and so often a system) failing to start properly. Some users reported procd failing to initialize fully without a clear error with faulty /etc/passwd. Signed-off-by: Rafał Miłecki Search for

[PATCH ubus] ubusd: log ACL init errors

2021-08-20 Thread Rafał Miłecki
From: Rafał Miłecki This makes it easier to notice ubusd (and so often a system) failing to start properly. Some users reported procd failing to initialize fully without a clear error with faulty /etc/passwd. Signed-off-by: Rafał Miłecki --- ubusd_acl.c | 13 ++--- ubusd_main.c | 3

Re: [PATCH 1/5] firmware-utils: mkmerakifw-old: replace GPL-2.0-only boilerplate with SPDX

2021-08-08 Thread Rafał Miłecki
On 2021-08-08 14:37, Christian Lamparter wrote: On 06/08/2021 12:59, Rafał Miłecki wrote: From: Rafał Miłecki This was missed because scancode license scanner was confused by a comment about Cisco's GPL code github repository. Cc: Christian Lamparter Signed-off-by: Rafał Miłecki Ack

[PATCH firmware-utils] xiaomifw: new tool for managing Xiaomi firmwares

2021-08-06 Thread Rafał Miłecki
From: Rafał Miłecki This has been tested with Xiaomi routers images (r1cl, r1cm, r2100, r3, r3d, r3g, r4cm, ra70) but it should also be compatible with other devices as Xiaomi seems to share the same format across most of their products. The biggest & probably unresolvable problem is RSA 2

[PATCH] firmware-utils: seama.h replace LGPL-2.1-or-later boilerplate with SPDX

2021-08-06 Thread Rafał Miłecki
From: Rafał Miłecki This was missed because scancode license scanner was confused by a slightly different than expected license text (96,75% license score). License text included "file" instead of "library" in the main part of the licensing info. It also used "The GNU

[PATCH 5/5] firmware-utils: nand_ecc: replace GPL boilerplate with SPDX

2021-08-06 Thread Rafał Miłecki
From: Rafał Miłecki Cc: yajin Cc: Felix Fietkau Signed-off-by: Rafał Miłecki --- tools/firmware-utils/src/nand_ecc.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/tools/firmware-utils/src/nand_ecc.c b/tools/firmware-utils/src/nand_ecc.c index

[PATCH 4/5] firmware-utils: trx: replace GPL-2.0-or-later boilerplate with SPDX

2021-08-06 Thread Rafał Miłecki
From: Rafał Miłecki This was missed because scancode license scanner was confused by comments about crc32buf(). Signed-off-by: Rafał Miłecki --- tools/firmware-utils/src/trx.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/tools/firmware-utils/src/trx.c b

[PATCH 1/5] firmware-utils: mkmerakifw-old: replace GPL-2.0-only boilerplate with SPDX

2021-08-06 Thread Rafał Miłecki
From: Rafał Miłecki This was missed because scancode license scanner was confused by a comment about Cisco's GPL code github repository. Cc: Christian Lamparter Signed-off-by: Rafał Miłecki --- tools/firmware-utils/src/mkmerakifw-old.c | 6 +- 1 file changed, 1 insertion(+), 5 dele

[PATCH 2/5] firmware-utils: mkmylofw: replace GPL-2.0-or-later boilerplate with SPDX

2021-08-06 Thread Rafał Miłecki
From: Rafał Miłecki This was missed because scancode license scanner was confused by a comment about (no) copyrights in the init_crc_table(). Cc: Gabor Juhos Cc: Gabor Juhos Signed-off-by: Rafał Miłecki --- tools/firmware-utils/src/mkmylofw.c | 17 + 1 file changed, 1

[PATCH 3/5] firmware-utils: osbridge-crc: replace GPL-2.0-only boilerplate with SPDX

2021-08-06 Thread Rafał Miłecki
From: Rafał Miłecki This was missed because scancode license scanner was confused by comments about crc32buf(). Cc: Gabor Juhos Cc: Gabor Juhos Signed-off-by: Rafał Miłecki --- tools/firmware-utils/src/osbridge-crc.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a

[PATCH V2] firmware-utils: replace GPL 2.0 boilerplate/reference with SPDX

2021-08-04 Thread Rafał Miłecki
From: Rafał Miłecki This uses "GPL-2.0-only" header for files identified using scancode license scanner with 100% score as GPL 2.0. Signed-off-by: Rafał Miłecki --- V2: Include .h files Send without 22 people in cc to let is reach openwrt-devel@ --- tools/firmware-utils/src/ad

[PATCH] firmware-utils: add GPL 2.0 SPDX to files with no license info

2021-08-04 Thread Rafał Miłecki
From: Rafał Miłecki These files fall under the project license: GPL-2.0-only. Signed-off-by: Rafał Miłecki --- tools/firmware-utils/src/bcm_tag.h | 1 + tools/firmware-utils/src/bcmalgo.c | 1 + tools/firmware-utils/src/bcmalgo.h | 1 + tools/firmware-utils/src/dgfirmware.c

[PATCH] firmware-utils: tplink-safeloader: replace BSD-2-Clause boilerplate with SPDX

2021-08-04 Thread Rafał Miłecki
From: Rafał Miłecki Signed-off-by: Rafał Miłecki --- tools/firmware-utils/src/tplink-safeloader.c | 21 +--- 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/tools/firmware-utils/src/tplink-safeloader.c b/tools/firmware-utils/src/tplink-safeloader.c index

[PATCH] firmware-utils: seama: replace BSD-3-Clause boilerplate with SPDX

2021-08-04 Thread Rafał Miłecki
From: Rafał Miłecki Signed-off-by: Rafał Miłecki --- tools/firmware-utils/src/seama.c | 32 +--- 1 file changed, 1 insertion(+), 31 deletions(-) diff --git a/tools/firmware-utils/src/seama.c b/tools/firmware-utils/src/seama.c index 05aee8e76a..89eeac90c4 100644

[PATCH] firmware-utils: replace GPL 2.0+ boilerplate/reference with SPDX

2021-08-04 Thread Rafał Miłecki
From: Rafał Miłecki This uses "GPL-2.0-or-later" header for files identified using scancode license scanner with 100% score as GPL 2.0 or later. Signed-off-by: Rafał Miłecki --- tools/firmware-utils/src/addpattern.c | 15 +-- tools/firmware-utils/src/asustrx.c

[PATCH] kernel: rename some b53 symbols to avoid conflict with upstream driver

2021-07-29 Thread Rafał Miłecki
From: Rafał Miłecki This fixes following error when trying to comppile both b53: swconfig one and upstream one. LD vmlinux.o arm-openwrt-linux-muslgnueabi-ld: drivers/net/dsa/b53/b53_common.o: in function `b53_switch_alloc': drivers/net/dsa/b53/b53_common.c:2598: multiple definiti

Re: [PATCH] uqmi: Move to community packages repo

2021-07-01 Thread Rafał Miłecki
On 01.07.2021 21:50, Arjun AK wrote: Signed-off-by: Arjun AK Nacked-by: Rafał Miłecki No proper explanation. Package is included by default in few device images. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https

Re: [PATCH v2 2/5] base-files: failsafe: Fix IP configuration

2021-06-22 Thread Rafał Miłecki
quot;ports" array in board.json network for bridges") Signed-off-by: Hauke Mehrtens Looks great, it fixes failsafe on bcm53xx (swconfig) and bcm4908 (DSA). Reviewed-by: Rafał Miłecki ___ openwrt-devel mailing list openwrt-devel@lis

Re: [PATCH v2 1/5] kernel: Backport patch to automatically bring up DSA master when opening user port

2021-06-22 Thread Rafał Miłecki
: Network is down Tested-by: Rafał Miłecki ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

<    1   2   3   4   5   6   7   8   9   10   >