Re: [OpenWrt-Devel] RE:RE: [PATCH v4 1/3] ramips: add support for JS7628 development board

2019-10-09 Thread Adrian Schmutzler
x27;且听风吟' > Cc: 'openwrt-devel' > Subject: Re: [OpenWrt-Devel] RE:RE: [PATCH v4 1/3] ramips: add support for > JS7628 development board > > Hi, > > before you resend you patches, two other comments: > > 1. When we introduced DEVICE_VARIANT, we

Re: [OpenWrt-Devel] RE:RE: [PATCH v4 1/3] ramips: add support for JS7628 development board

2019-10-09 Thread Adrian Schmutzler
Hi, before you resend you patches, two other comments: 1. When we introduced DEVICE_VARIANT, we typically removed the "flash" reference formerly present in the DEVICE_TITLE. So you might update your DEVICE_VARIANT entries for consistency, e.g. DEVICE_VARIANT := 32M flash to DEVICE_VARIANT :=