Abhijit, I'm not sure OpenWrt has formally listed rules but here's the normal etiquette on these topics from other projects:
* Squashing commits is preferred. It reduces the work on reviewers and it's more useful to other users in case they need to pull out a single feature or change for their use-case. * Sign-offs are usually only required when they leave an organization to the upstream project. In your case, if you're the submitter you should do the signoff which provides an assurance that you either wrote the code or know that other people wrote the code or included code which can be legally included. As an alternative, you could put a signoff line for each person who contributed (since they did already sign off on their work) but that's usually not done because of how long it could make the commits. If it's two sign-off lines, I doubt anyone is going to be annoyed but if it's 20, people may ask you to resubmit. I hope that helps. If not, just let me know and I can try to help you out. Thanks, Eric On Wed, Sep 14, 2016 at 1:17 PM, Abhijit Mahajani < abhijit.mahaj...@imgtec.com> wrote: > Copying in prpl mailing list. > > Any advice much appreciated. > > > Thanks and Regards, > > Abhijit A. Mahajani > > > ------ Original message------ > > *From: *Abhijit Mahajani > > *Date: *Wed, 14 Sep 2016 20:22 > > *To: *openwrt-devel@lists.openwrt.org; > > *Subject:*Re: [OpenWrt] Upstreaming related doubt > > > Hello, > > Another doubt related to upstreaming. > > When we submit a Pull request for Creator Ci40 i.e. pistachio soc support, > do I need to maintain the commit history of all the changes done in our > working repo or I can squash all the commits into 3-4 logical commits and > send a Pull Request? > > Only problem is by squashing the commits I am losing original > author/committer information., though I am adding Signed-Off-By fields to > give the credit to those (and at the same time, people might not be > interested in all the 100s of commits in the working repo, rather they > would need only the "final" changes need to run Ci40) , so I am inclined > towards squashing the commits, but if there is any policy on no. of commits > or need to maintain the commit history in a Pull request then I am > interested to know that. > > Kindly advice. > > > Thanks and Regards, > Abhijit A. Mahajani > > -----Original Message----- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org > <openwrt-devel-boun...@lists.openwrt.org>] On Behalf Of > openwrt-devel-requ...@lists.openwrt.org > Sent: Saturday, August 6, 2016 2:56 AM > To: openwrt-devel@lists.openwrt.org > Subject: openwrt-devel Digest, Vol 128, Issue 5 > > Send openwrt-devel mailing list submissions to > openwrt-devel@lists.openwrt.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel > or, via email, send a message with subject or body 'help' to > openwrt-devel-requ...@lists.openwrt.org > > You can reach the person managing the list at > openwrt-devel-ow...@lists.openwrt.org > > When replying, please edit your Subject line so it is more specific than > "Re: Contents of openwrt-devel digest..." > > > Today's Topics: > > 1. Re: [OpenWrt] Upstreaming related doubt (Felix Fietkau) > 2. Re: [LEDE-DEV] latency on PPPoA ADSL Annex A on using Lantiq > (Kevin Darbyshire-Bryant) > 3. [PATCH] regmap: Fix debugfs for write-only devices (Cody Harris) > 4. $5 OpenWRT Device on Kickstarter (Boken Lin) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Fri, 5 Aug 2016 12:01:55 +0200 > From: Felix Fietkau <n...@nbd.name> > To: Abhijit Mahajani <abhijit.mahaj...@imgtec.com>, > "openwrt-devel@lists.openwrt.org" <openwrt-devel@lists.openwrt.org > >, > "open...@lists.prplfoundation.org" <openwrt@lists.prplfoundation. > org> > Subject: Re: [OpenWrt-Devel] [OpenWrt] Upstreaming related doubt > Message-ID: <2a8dc348-407f-6297-1602-945293731...@nbd.name> > Content-Type: text/plain; charset=utf-8 > > On 2016-08-05 11:41, Abhijit Mahajani wrote: > > Hello All, > > > > > > > > We have added Creator Ci40 into OpenWrt and its available at > > https://github.com/CreatorDev/openwrt. We want to upstream our port to > > the openwrt community. However currently we have based on 4.1 kernel.. > > > > I understand OpenWrt is with 4.4.14 right now, so If I want to create > > a pull request for upstreaming Ci40 port, then do I need to first move > > to > > 4.4 or pull request with 4.1 is also fine? > Please move to 4.4 first. > > - Felix > > > ------------------------------ > > > _______________________________________________ > OpenWrt mailing list > open...@lists.prplfoundation.org > http://lists.prplfoundation.org/cgi-bin/mailman/listinfo/openwrt > > -- Eric Schultz, Community Manager, prpl Foundation http://www.prplfoundation.org eschu...@prplfoundation.org cell: 920-539-0404
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
