Re: [OpenWrt-Devel] [PATCH] Give WiFi modules more time to settle

2015-05-16 Thread Arend van Spriel
On 05/15/15 21:28, Felix Fietkau wrote: On 2015-05-15 09:02, Arend van Spriel wrote: On 05/12/15 12:25, Hante Meuleman wrote: It is a bit more than just changing request_firmware_nowait into request_firmware. The worker in core.c needs to be removed. The function brcmf_pcie_setup needs to be up

Re: [OpenWrt-Devel] [PATCH] Give WiFi modules more time to settle

2015-05-15 Thread Felix Fietkau
On 2015-05-15 09:02, Arend van Spriel wrote: > On 05/12/15 12:25, Hante Meuleman wrote: >> It is a bit more than just changing request_firmware_nowait into >> request_firmware. The worker in core.c needs to be removed. The >> function brcmf_pcie_setup needs to be updated as it cannot call >> device

Re: [OpenWrt-Devel] [PATCH] Give WiFi modules more time to settle

2015-05-15 Thread Rafał Miłecki
On 15 May 2015 at 09:02, Arend van Spriel wrote: > On 05/12/15 12:25, Hante Meuleman wrote: >> >> It is a bit more than just changing request_firmware_nowait into >> request_firmware. The worker in core.c needs to be removed. The >> function brcmf_pcie_setup needs to be updated as it cannot call >

Re: [OpenWrt-Devel] [PATCH] Give WiFi modules more time to settle

2015-05-15 Thread Arend van Spriel
On 05/12/15 12:25, Hante Meuleman wrote: It is a bit more than just changing request_firmware_nowait into request_firmware. The worker in core.c needs to be removed. The function brcmf_pcie_setup needs to be updated as it cannot call device_release_driver during probe. As a result brcmf_fw_get_fi

Re: [OpenWrt-Devel] [PATCH] Give WiFi modules more time to settle

2015-05-12 Thread Hante Meuleman
It is a bit more than just changing request_firmware_nowait into request_firmware. The worker in core.c needs to be removed. The function brcmf_pcie_setup needs to be updated as it cannot call device_release_driver during probe. As a result brcmf_fw_get_firmwares_pcie has to return the error, w

Re: [OpenWrt-Devel] [PATCH] Give WiFi modules more time to settle

2015-05-12 Thread Hante Meuleman
Ok, thanks, that requires the wifi device to be completely up and initialized. There is way more involved in getting that synchronous. So what about the idea of adding a delay of two seconds to brcmfmac_module_init? Would that patch be accepted? -Original Message- From: Rafał Miłecki [m

Re: [OpenWrt-Devel] [PATCH] Give WiFi modules more time to settle

2015-05-12 Thread Felix Fietkau
On 2015-05-12 11:33, Hante Meuleman wrote: > Understood, what is wifi detect using as input? Do the netdevs have to > be up? Where is the information that wifi app is reading coming from? It looks for registered cfg80211 wiphys. It does not care about netdevs. > brcmfmac uses different method for

Re: [OpenWrt-Devel] [PATCH] Give WiFi modules more time to settle

2015-05-12 Thread Rafał Miłecki
On 12 May 2015 at 11:33, Hante Meuleman wrote: > Understood, what is wifi detect using as input? Do the netdevs have to > be up? Where is the information that wifi app is reading coming from? What about just checking it by yourself? vim package/base-files/files/sbin/wifi vim package/kernel/mac802

Re: [OpenWrt-Devel] [PATCH] Give WiFi modules more time to settle

2015-05-12 Thread Hante Meuleman
Understood, what is wifi detect using as input? Do the netdevs have to be up? Where is the information that wifi app is reading coming from? brcmfmac uses different method for firmware loading. It is not as easily patched as the ath10k driver. But I would like to know exactly what wifi detect u

Re: [OpenWrt-Devel] [PATCH] Give WiFi modules more time to settle

2015-05-12 Thread Felix Fietkau
On 2015-05-12 10:35, Hante Meuleman wrote: > The boot script gives 1 second for wifi modules to settle. For newer > routers > > like R8000 which has three wifi devices which all need to be firmware > > downloaded, nvram downloaded and initialized this delay is getting very > > tight. On some boo

Re: [OpenWrt-Devel] [PATCH] Give WiFi modules more time to settle

2015-05-12 Thread Rafał Miłecki
On 12 May 2015 at 10:35, Hante Meuleman wrote: > The boot script gives 1 second for wifi modules to settle. For newer routers > > like R8000 which has three wifi devices which all need to be firmware > > downloaded, nvram downloaded and initialized this delay is getting very > > tight. On some boo

[OpenWrt-Devel] [PATCH] Give WiFi modules more time to settle

2015-05-12 Thread Hante Meuleman
The boot script gives 1 second for wifi modules to settle. For newer routers like R8000 which has three wifi devices which all need to be firmware downloaded, nvram downloaded and initialized this delay is getting very tight. On some bootups it was seen that not all wifi modules were initialized by