Re: [OpenWrt-Devel] [PATCH] Honour NO_COLOR in include/scan.mk

2019-02-17 Thread Hauke Mehrtens
On 1/30/19 3:01 PM, R. Diez wrote: > >> Could you please send a V2 with the requested change >> to print $(1) without ANSII escape sequences? > > Here it goes: > > Honour NO_COLOR in Makefile function 'progress' in include/scan.mk, in > the same way that include/verbose.mk does. > > >

[OpenWrt-Devel] [PATCH] Honour NO_COLOR in include/scan.mk

2019-01-30 Thread R. Diez via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- > Could you please send a V2

Re: [OpenWrt-Devel] [PATCH] Honour NO_COLOR in include/scan.mk

2019-01-30 Thread Jo-Philipp Wich
Hi, > That is true. But, on the other hand, the same routine was not printing > anything if IS_TTY is not 1. I would say that this is unexpected > behaviour too. If the log file shows some error, it would be nice to see > what part was being processed. this might be, but the scope of this patch

[OpenWrt-Devel] [PATCH] Honour NO_COLOR in include/scan.mk

2019-01-30 Thread R. Diez via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- > your patch would disable the

Re: [OpenWrt-Devel] [PATCH] Honour NO_COLOR in include/scan.mk

2019-01-29 Thread Jo-Philipp Wich
Hi, your patch would disable the complete output if NO_COLOR is set. That does not seem to meet the expected behavior. Looks like the fallback path should still print $(1) to stderr, just without ANSI escape sequences. ~ Jo signature.asc Description: OpenPGP digital signature

[OpenWrt-Devel] [PATCH] Honour NO_COLOR in include/scan.mk

2019-01-21 Thread R. Diez via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- Hi all: This is my first