Re: [OpenWrt-Devel] [PATCH] base-files: make wifi report unknown command

2018-08-07 Thread Karl Palsson
Jo-Philipp Wich wrote: > Hi, > > > respectfully, the behaviour of the "wifi" command is one of the most > > obtuse parts of openwrt's tooling. It does "something" with no > > command output, and responds ~instantly.This is expected > > behaviour for very few people. even "wifi asdfasdfa"

Re: [OpenWrt-Devel] [PATCH] base-files: make wifi report unknown command

2018-08-07 Thread Jo-Philipp Wich
Hi, > respectfully, the behaviour of the "wifi" command is one of the most > obtuse parts of openwrt's tooling. It does "something" with no > command output, and responds ~instantly.This is expected > behaviour for very few people. even "wifi asdfasdfa" returns > ~instantly, with no warning

Re: [OpenWrt-Devel] [PATCH] base-files: make wifi report unknown command

2018-08-07 Thread Kevin Darbyshire-Bryant
> On 6 Aug 2018, at 15:49, Karl Palsson wrote: > > Signed PGP part > > John Crispin wrote: >> >> >> On 03/08/18 18:18, Thibaut VARÈNE wrote: >>> Avoid having /sbin/wifi silently ignore unknown keywords and execute >>> "enable"; instead display the help message and exit with an error. >>>

Re: [OpenWrt-Devel] [PATCH] base-files: make wifi report unknown command

2018-08-06 Thread Karl Palsson
John Crispin wrote: > > > On 03/08/18 18:18, Thibaut VARÈNE wrote: > > Avoid having /sbin/wifi silently ignore unknown keywords and execute > > "enable"; instead display the help message and exit with an error. > > > > Signed-off-by: Thibaut VARÈNE > > --- > >

Re: [OpenWrt-Devel] [PATCH] base-files: make wifi report unknown command

2018-08-06 Thread Alberto Bursi
On 06/08/2018 07:20, John Crispin wrote: On 03/08/18 18:18, Thibaut VARÈNE wrote: Avoid having /sbin/wifi silently ignore unknown keywords and execute "enable"; instead display the help message and exit with an error. Signed-off-by: Thibaut VARÈNE ---   package/base-files/files/sbin/wifi

[OpenWrt-Devel] [PATCH] base-files: make wifi report unknown command

2018-08-06 Thread Thibaut VARÈNE
Avoid having /sbin/wifi silently ignore unknown keywords and execute "enable"; instead display the help message and exit with an error. Also preserve the implicit assumption that runing /sbin/wifi without argument performs network reload and "enable". Signed-off-by: Thibaut VARÈNE ---

Re: [OpenWrt-Devel] [PATCH] base-files: make wifi report unknown command

2018-08-05 Thread John Crispin
On 03/08/18 18:18, Thibaut VARÈNE wrote: Avoid having /sbin/wifi silently ignore unknown keywords and execute "enable"; instead display the help message and exit with an error. Signed-off-by: Thibaut VARÈNE --- package/base-files/files/sbin/wifi | 2 +- 1 file changed, 1 insertion(+), 1

[OpenWrt-Devel] [PATCH] base-files: make wifi report unknown command

2018-08-03 Thread Thibaut VARÈNE
Avoid having /sbin/wifi silently ignore unknown keywords and execute "enable"; instead display the help message and exit with an error. Signed-off-by: Thibaut VARÈNE --- package/base-files/files/sbin/wifi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git