Re: [OpenWrt-Devel] [PATCH] build: add mkrasimage

2018-08-18 Thread Stefan Lippers-Hollmann
Hi On 2018-08-17, Christian Lamparter wrote: > On Thursday, August 16, 2018 12:31:38 PM CEST David Bauer wrote: > > On 8/16/18 3:12 AM, Karl Palsson wrote: [...] > [...] (And there is at least > one more device that can make use of ras: the NBG6817). Adding support for a factory image for the

Re: [OpenWrt-Devel] [PATCH] build: add mkrasimage

2018-08-18 Thread David Bauer
Hi Christian, I wrote the bash version because of issues in the past with C implementations of firmware packers for the Meraki routers (mkmerakifw.c and mkmerakifw-old.c). The issue there was that the main dev was coming from a sysadmin background and as with many OpenWrt users he had problems

Re: [OpenWrt-Devel] [PATCH] build: add mkrasimage

2018-08-17 Thread Christian Lamparter
On Thursday, August 16, 2018 12:31:38 PM CEST David Bauer wrote: > On 8/16/18 3:12 AM, Karl Palsson wrote: > > 1) how bad are the portability issues that you felt > > reimplementing in _C_ was the best path? 2) if it's that bad, why > > keep it? How will future people knwo what to use. Either get

Re: [OpenWrt-Devel] [PATCH] build: add mkrasimage

2018-08-16 Thread David Bauer
Hello Karl, On 8/16/18 3:12 AM, Karl Palsson wrote: > 1) how bad are the portability issues that you felt > reimplementing in _C_ was the best path? 2) if it's that bad, why > keep it? How will future people knwo what to use. Either get rid > of it, or fix it. Regarding 1) The portability issue

Re: [OpenWrt-Devel] [PATCH] build: add mkrasimage

2018-08-15 Thread Karl Palsson
David Bauer wrote: > The current make-ras.sh image generation script for the ZyXEL > NBG6617 has portability issues with bash. Because of this, > factory images are currently not built correctly by the OpenWRT > buildbots. > > This commit replaces the make-ras.sh by C-written mkrasimage. > The

Re: [OpenWrt-Devel] [PATCH] build: add mkrasimage

2018-08-15 Thread Michael Heimpold
Hi David, a few code-styling nitpicks, see comments below: Am Mittwoch, 15. August 2018, 16:44:03 CEST schrieb David Bauer: > The current make-ras.sh image generation script for the ZyXEL NBG6617 > has portability issues with bash. Because of this, factory images are > currently not built

[OpenWrt-Devel] [PATCH] build: add mkrasimage

2018-08-15 Thread David Bauer
The current make-ras.sh image generation script for the ZyXEL NBG6617 has portability issues with bash. Because of this, factory images are currently not built correctly by the OpenWRT buildbots. This commit replaces the make-ras.sh by C-written mkrasimage. The old script is still kept but can be