Re: [OpenWrt-Devel] [PATCH] build: improve ccache support

2020-06-12 Thread Roman Yeryomin
On 2020-06-04 22:29, Michael Jones wrote: I agree with Felix. Having one ccache directory for multiple repos doesn't make much sense to me as most probably they are for different platforms. And even if they are for same platform there are more chances for ccache corruption and deleting it will

Re: [OpenWrt-Devel] [PATCH] build: improve ccache support

2020-06-04 Thread Michael Jones
> I agree with Felix. Having one ccache directory for multiple repos > doesn't make much sense to me as most probably they are for different > platforms. And even if they are for same platform there are more chances > for ccache corruption and deleting it will affect all those repos. So it > still

Re: [OpenWrt-Devel] [PATCH] build: improve ccache support

2020-06-02 Thread Roman Yeryomin
On 2020-06-01 23:51, Petr Štetiar wrote: Roman Yeryomin [2020-06-01 18:32:26]: Hi, Set CCACHE_DIR to $(TOPDIR)/.ccache and CCACHE_BASEDIR to $(TOPDIR). this changes location of ccache directory (people would need to move it, symlink back or override it) and with CCACHE_BASEDIR it

Re: [OpenWrt-Devel] [PATCH] build: improve ccache support

2020-06-02 Thread Roman Yeryomin
On 2020-06-01 21:34, Michael Jones wrote: On Mon, Jun 1, 2020 at 1:22 PM Felix Fietkau wrote: On 2020-06-01 19:11, Michael Jones wrote: > > > On Mon, Jun 1, 2020 at 10:33 AM Roman Yeryomin > wrote: > > Set CCACHE_DIR to $(TOPDIR)/.ccache and CCACHE_BASEDIR to

Re: [OpenWrt-Devel] [PATCH] build: improve ccache support

2020-06-01 Thread Petr Štetiar
Roman Yeryomin [2020-06-01 18:32:26]: Hi, > Set CCACHE_DIR to $(TOPDIR)/.ccache and CCACHE_BASEDIR to $(TOPDIR). this changes location of ccache directory (people would need to move it, symlink back or override it) and with CCACHE_BASEDIR it probably also invalidates the current cache/hashes,

Re: [OpenWrt-Devel] [PATCH] build: improve ccache support

2020-06-01 Thread Michael Jones
On Mon, Jun 1, 2020 at 1:22 PM Felix Fietkau wrote: > On 2020-06-01 19:11, Michael Jones wrote: > > > > > > On Mon, Jun 1, 2020 at 10:33 AM Roman Yeryomin > > wrote: > > > > Set CCACHE_DIR to $(TOPDIR)/.ccache and CCACHE_BASEDIR to $(TOPDIR). > > This allows to do

Re: [OpenWrt-Devel] [PATCH] build: improve ccache support

2020-06-01 Thread Felix Fietkau
On 2020-06-01 19:11, Michael Jones wrote: > > > On Mon, Jun 1, 2020 at 10:33 AM Roman Yeryomin > wrote: > > Set CCACHE_DIR to $(TOPDIR)/.ccache and CCACHE_BASEDIR to $(TOPDIR). > This allows to do clean and dirclean. Cache hit rate for test build > after

Re: [OpenWrt-Devel] [PATCH] build: improve ccache support

2020-06-01 Thread Michael Jones
On Mon, Jun 1, 2020 at 10:33 AM Roman Yeryomin wrote: > Set CCACHE_DIR to $(TOPDIR)/.ccache and CCACHE_BASEDIR to $(TOPDIR). > This allows to do clean and dirclean. Cache hit rate for test build > after dirclean is ~65%. > If CCACHE is enabled stats are printed out at the end of building

[OpenWrt-Devel] [PATCH] build: improve ccache support

2020-06-01 Thread Roman Yeryomin
Set CCACHE_DIR to $(TOPDIR)/.ccache and CCACHE_BASEDIR to $(TOPDIR). This allows to do clean and dirclean. Cache hit rate for test build after dirclean is ~65%. If CCACHE is enabled stats are printed out at the end of building process. Signed-off-by: Roman Yeryomin --- .gitignore| 1