Re: [OpenWrt-Devel] [PATCH] busybox: Include hdparm by default on nas type device

2020-01-15 Thread John Crispin
On 01/01/2020 16:55, Jo-Philipp Wich wrote: Hi Linus, can you move the condition before the sed program populating the initial config? That should restore the ability for users to deselect busybox hdparm (e.g. to replace it with something different). ~ Jo folded Jo's comment into the patch

Re: [OpenWrt-Devel] [PATCH] busybox: Include hdparm by default on nas type device

2020-01-01 Thread Jo-Philipp Wich
Hi Linus, can you move the condition before the sed program populating the initial config? That should restore the ability for users to deselect busybox hdparm (e.g. to replace it with something different). ~ Jo signature.asc Description: OpenPGP digital signature

[OpenWrt-Devel] [PATCH] busybox: Include hdparm by default on nas type device

2020-01-01 Thread Linus Walleij
NAS devices certainly need to have hdparm to configure things like spin-down time or their disks will be constantly spinning. Just catenate CONFIG_HDPARM=y on these configs. Signed-off-by: Linus Walleij --- package/utils/busybox/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git