[OpenWrt-Devel] [PATCH] ramips: add support for the Asus RP-N53 in the "02_network" boot script

This patch adds a case for the Asus RP-N53 in the "02_network" boot script. Without this, the lan interface does not get configured on startup, effectively bricking the device. Signed-off-by: Alberto Mattea --- diff -uN

Re: [OpenWrt-Devel] [PATCH] ramips: add support for the Asus RP-N53 in the "02_network" boot script

Hello Alberto, Two comments: 1. Your patch breaks alphabetical order. 2. If you look more deeply into the file, you will easily find there other boards with exactly the same configuration: asl26555 and re6500. Please, don't add unnecessary code and use what's already there. Cheers, Piotr

Re: [OpenWrt-Devel] [PATCH] ramips: add support for the Asus RP-N53 in the "02_network" boot script

Hey, thanks for the quick review. To be honest I hadn't noticed they were in alphabetical order :) I'll fix and resubmit Cheers Alberto In data mer 28 ottobre 2015 19:46:50, Piotr Dymacz ha scritto: > Hello Alberto, > > Two comments: > 1. Your patch breaks alphabetical order. > 2. If you look

Re: [OpenWrt-Devel] [PATCH] ramips: add support for the Asus RP-N53 in the "02_network" boot script

Hey, Thanks for fast fix! Cheers, Piotr 2015-10-28 19:56 GMT+01:00 Alberto Mattea : > Hey, > > thanks for the quick review. To be honest I hadn't noticed they were in > alphabetical order :) I'll fix and resubmit > > Cheers > Alberto > > In data mer 28 ottobre 2015