Re: [OpenWrt-Devel] [PATCH] ramips:Allow funcs in multiple groups in pinctrl-rt2880.c for UARTF pin sharing

Hi, thanks for looking at this. I actually tried this approach before deciding groups that are not a fixed set of pins would require modifying pinctrl/pinmux.c and possibly pinctrl/core.c thus would affect a lot more than just the ralink drivers. The problem arises when pinmux_enable_setting()

Re: [OpenWrt-Devel] [PATCH] ramips:Allow funcs in multiple groups in pinctrl-rt2880.c for UARTF pin sharing

On 22/11/2015 20:26, Noble Pepper wrote: > Hi, thanks for looking at this. > > I actually tried this approach before deciding groups that are not a > fixed set of pins would require modifying pinctrl/pinmux.c and possibly > pinctrl/core.c thus would affect a lot more than just the ralink >

Re: [OpenWrt-Devel] [PATCH] ramips:Allow funcs in multiple groups in pinctrl-rt2880.c for UARTF pin sharing

Hi, i had a closer look at the code. what you want to do instead of adding 2 dummy muxes is to modify static int rt2880_pmx_group_enable(struct pinctrl_dev *pctrldev, and change this part /* mark the pins as gpio */ for (i = 0; i < p->groups[group].func[0].pin_count; i++)

[OpenWrt-Devel] [PATCH] ramips:Allow funcs in multiple groups in pinctrl-rt2880.c for UARTF pin sharing

Signed-off-by: Noble Pepper --- Existing pinctrl-rt2880.c code only kept track of one pin group that functions other than gpio may use. Functions in rt305x.c had differing numbers of pins which caused rt2880_get_group_pins() to sometimes return incorrect pins.

Re: [OpenWrt-Devel] [PATCH] ramips:Allow funcs in multiple groups in pinctrl-rt2880.c for UARTF pin sharing

Hi, the patch is white space broken and for some reason this seems to be a forwarding. could you fix and resend please John On 03/11/2015 13:26, Noble Pepper wrote: > > Signed-off-by: Noble Pepper > --- > Existing pinctrl-rt2880.c code only kept track of