Re: [OpenWrt-Devel] [PATCH 1/1] firewall3: add --contiguous to time-based rules where needed

2020-05-12 Thread Yousong Zhou
On Wed, 13 May 2020 at 00:39, Philip Prindeville wrote: > > > > > On May 12, 2020, at 7:08 AM, Yousong Zhou wrote: > > > > On Sat, 2 May 2020 at 03:21, Philip Prindeville > > wrote: > >> > >> From: Philip Prindeville > >> > >> If the start_time > stop_time on a rule, then the --contiguous arg

Re: [OpenWrt-Devel] [PATCH 1/1] firewall3: add --contiguous to time-based rules where needed

2020-05-12 Thread Philip Prindeville
> On May 12, 2020, at 7:08 AM, Yousong Zhou wrote: > > On Sat, 2 May 2020 at 03:21, Philip Prindeville > wrote: >> >> From: Philip Prindeville >> >> If the start_time > stop_time on a rule, then the --contiguous arg >> should be included in the rule. > > It seems that start_time >=

Re: [OpenWrt-Devel] [PATCH 1/1] firewall3: add --contiguous to time-based rules where needed

2020-05-12 Thread Yousong Zhou
On Sat, 2 May 2020 at 03:21, Philip Prindeville wrote: > > From: Philip Prindeville > > If the start_time > stop_time on a rule, then the --contiguous arg > should be included in the rule. It seems that start_time >= stop_time has its defined meaning in xt_time module. Better add another uci

Re: [OpenWrt-Devel] [PATCH 1/1] firewall3: add --contiguous to time-based rules where needed

2020-05-07 Thread Philip Prindeville
Should I open a PR or is this the correct way to get a review for firewall3? Thanks > On May 1, 2020, at 1:21 PM, Philip Prindeville > wrote: > > From: Philip Prindeville > > If the start_time > stop_time on a rule, then the --contiguous arg > should be included in the rule. > >

[OpenWrt-Devel] [PATCH 1/1] firewall3: add --contiguous to time-based rules where needed

2020-05-01 Thread Philip Prindeville
From: Philip Prindeville If the start_time > stop_time on a rule, then the --contiguous arg should be included in the rule. Signed-off-by: Philip Prindeville --- iptables.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/iptables.c b/iptables.c index