Re: [OpenWrt-Devel] [PATCH 1/2] __packed can leak from the kernel headers into iptables so define

2012-04-25 Thread David Woodhouse
On Tue, 2012-04-24 at 07:53 -0700, Dave Taht wrote: Hmm. OK. Well, it happened, so perhaps something in openwrt is doing it wrong, or some pattern of mine while doing a build broke it. /me looks... yes, openwrt is doing it wrong. It's pointing iptables at the actual kernel source, rather than

Re: [OpenWrt-Devel] [PATCH 1/2] __packed can leak from the kernel headers into iptables so define

2012-04-24 Thread David Woodhouse
On Mon, 2012-04-23 at 07:24 +0200, Felix Fietkau wrote: Maybe it would make sense to just use the long form __attribute__((packed)) instead of __packed in parts that are visible to userspace. Hm, 'make headers_install' should be performing that substitution anyway, shouldn't it? I don't

Re: [OpenWrt-Devel] [PATCH 1/2] __packed can leak from the kernel headers into iptables so define

2012-04-24 Thread Dave Taht
On Tue, Apr 24, 2012 at 7:21 AM, David Woodhouse dw...@infradead.org wrote: On Mon, 2012-04-23 at 07:24 +0200, Felix Fietkau wrote: Maybe it would make sense to just use the long form __attribute__((packed)) instead of __packed in parts that are visible to userspace. Hm, 'make

Re: [OpenWrt-Devel] [PATCH 1/2] __packed can leak from the kernel headers into iptables so define

2012-04-24 Thread David Woodhouse
On Tue, 2012-04-24 at 07:47 -0700, Dave Taht wrote: b) However __packed leaks out of the main network header file, and was not defined by iptables to be the define it is in the kernel code. How? When you run 'make headers_install' to export kernel headers for use by userspace, it *sanitizes*

Re: [OpenWrt-Devel] [PATCH 1/2] __packed can leak from the kernel headers into iptables so define

2012-04-24 Thread Dave Taht
On Tue, Apr 24, 2012 at 7:50 AM, David Woodhouse dw...@infradead.org wrote: On Tue, 2012-04-24 at 07:47 -0700, Dave Taht wrote: b) However __packed leaks out of the main network header file, and was not defined by iptables to be the define it is in the kernel code. How? When you run 'make

Re: [OpenWrt-Devel] [PATCH 1/2] __packed can leak from the kernel headers into iptables so define

2012-04-24 Thread Dave Taht
Also I'd like for there to be some way to not apply this patch on successor architectures such as the - on ar724x, rx buffers can be aligned with an offset of 2, which keeps the ip header aligned - alignment offset is only added if the ar8216 workaround is not active and the phy driver does not

[OpenWrt-Devel] [PATCH 1/2] __packed can leak from the kernel headers into iptables so define

2012-04-22 Thread Dave Täht
With the upcoming ag71xx patch the __packed attribute can leak into the rest of the build, and iptables does not have it defined. This defines it. --- package/iptables/patches/900-packed.patch | 28 1 files changed, 28 insertions(+), 0 deletions(-) create mode

Re: [OpenWrt-Devel] [PATCH 1/2] __packed can leak from the kernel headers into iptables so define

2012-04-22 Thread Felix Fietkau
On 2012-04-22 11:48 PM, Dave Täht wrote: With the upcoming ag71xx patch the __packed attribute can leak into the rest of the build, and iptables does not have it defined. This defines it. I think a better solution would be to make sure that userspace does not need such changes. iptables might