Re: [OpenWrt-Devel] [PATCH 1/2] oxnas: drop some unused sysupgrade code

2015-09-21 Thread Rafał Miłecki
On 21 September 2015 at 11:37, Daniel Golle wrote: > First of all sorry for the delay. Both patches look correct to me, > thanks for the good work! I new tested them on Shuttle KD-20 and > sysupgrade works great with both patches applied. > > > On Tue, Sep 15, 2015 at 06:28:16PM +0200, Rafał Miłec

Re: [OpenWrt-Devel] [PATCH 1/2] oxnas: drop some unused sysupgrade code

2015-09-21 Thread Daniel Golle
Hi! First of all sorry for the delay. Both patches look correct to me, thanks for the good work! I new tested them on Shuttle KD-20 and sysupgrade works great with both patches applied. On Tue, Sep 15, 2015 at 06:28:16PM +0200, Rafał Miłecki wrote: > First of all platform_do_upgrade_phase2 doesn

[OpenWrt-Devel] [PATCH 1/2] oxnas: drop some unused sysupgrade code

2015-09-15 Thread Rafał Miłecki
First of all platform_do_upgrade_phase2 doesn't seem to be defined anywhere. Other than that platform_do_upgrade is not likely to be ever called. There is a call to nand_do_platform_check which triggers nand_upgrade_stage1 call with "exit 0" in it. Signed-off-by: Rafał Miłecki --- target/linux/o