Re: [OpenWrt-Devel] [PATCH 1/3] gemini: Make a per-board case for ethernet MAC

2019-06-14 Thread Linus Walleij
On Fri, Jun 14, 2019 at 7:24 PM Christian Lamparter wrote: > I put together a patchset in my staging tree starting from > > https://git.openwrt.org/?p=openwrt/staging/chunkeey.git;a=commit;h=620462e09afc40602110b82caeb2858903709567 >

Re: [OpenWrt-Devel] [PATCH 1/3] gemini: Make a per-board case for ethernet MAC

2019-06-14 Thread Christian Lamparter
Hello Linus, On Tuesday, June 11, 2019 4:40:12 PM CEST Linus Walleij wrote: > Hi Christian, > > I worked in all the changes you requested until I got to this: > > On Thu, May 30, 2019 at 12:46 AM Christian Lamparter > wrote: > > > > + ifconfig eth0 hw ether $MAC1

Re: [OpenWrt-Devel] [PATCH 1/3] gemini: Make a per-board case for ethernet MAC

2019-06-11 Thread Linus Walleij
Hi Christian, I worked in all the changes you requested until I got to this: On Thu, May 30, 2019 at 12:46 AM Christian Lamparter wrote: > > + ifconfig eth0 hw ether $MAC1 2>/dev/null > > I guess while we are at it, why not change it to > "ip link set dev eth0

Re: [OpenWrt-Devel] [PATCH 1/3] gemini: Make a per-board case for ethernet MAC

2019-05-29 Thread Christian Lamparter
Hello, I have a few suggestions inline below. On Friday, May 24, 2019 11:27:17 PM CEST Linus Walleij wrote: > The DNS-313 isn't the only special board so let's bite the > bullet and create a case ladder in preparation for DIR-685. > > Signed-off-by: Linus Walleij > --- >

[OpenWrt-Devel] [PATCH 1/3] gemini: Make a per-board case for ethernet MAC

2019-05-24 Thread Linus Walleij
The DNS-313 isn't the only special board so let's bite the bullet and create a case ladder in preparation for DIR-685. Signed-off-by: Linus Walleij --- .../lib/preinit/05_set_ether_mac_gemini | 30 --- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git