Re: [OpenWrt-Devel] [PATCH 2/4] PCI: add driver for Cortina Gemini Host Bridge

2017-02-26 Thread Linus Walleij
On Tue, Jan 31, 2017 at 1:37 AM, Bjorn Helgaas wrote: > Looks nice; a couple unused definitions below. Just so I do things right: what is your policy on unused defines? I'm asking because the defines in this case is pretty much the documentation... there is no datasheet for

Re: [OpenWrt-Devel] [PATCH 2/4] PCI: add driver for Cortina Gemini Host Bridge

2017-02-18 Thread Linus Walleij
On Thu, Feb 16, 2017 at 3:08 PM, Arnd Bergmann wrote: > On Saturday, February 4, 2017 7:43:15 PM CET Linus Walleij wrote: > Did you notice my other comment below (quoting from my own > message)? > >> > + >> > + bus = pci_scan_root_bus(>dev, 0, _pci_ops, p, ); >> >> Can you try

Re: [OpenWrt-Devel] [PATCH 2/4] PCI: add driver for Cortina Gemini Host Bridge

2017-02-05 Thread Linus Walleij
On Sun, Feb 5, 2017 at 11:00 AM, Hans Ulli Kroll wrote: > irq: type mismatch, failed to map hwirq-26 for > /soc/interrupt-controller@4800! > > We need to use the use the use the PCI IRQ from gemini as root for the irq > domain, not the next one in DT. Hm I wonder

Re: [OpenWrt-Devel] [PATCH 2/4] PCI: add driver for Cortina Gemini Host Bridge

2017-02-05 Thread Hans Ulli Kroll
Hi Linus while debugging my boot issues on my NAS 4220, I saw this warning irq: type mismatch, failed to map hwirq-26 for /soc/interrupt-controller@4800! We need to use the use the use the PCI IRQ from gemini as root for the irq domain, not the next one in DT. diff --git

Re: [OpenWrt-Devel] [PATCH 2/4] PCI: add driver for Cortina Gemini Host Bridge

2017-02-04 Thread Linus Walleij
On Wed, Feb 1, 2017 at 12:11 PM, Arnd Bergmann wrote: > On Saturday, January 28, 2017 9:48:37 PM CET Linus Walleij wrote: >> + /* No clue what these do */ >> + pcibios_min_io = 0x100; >> + pcibios_min_mem = 0; > > Don't touch these OK I have a clue why this is there

[OpenWrt-Devel] [PATCH 2/4] PCI: add driver for Cortina Gemini Host Bridge

2017-01-28 Thread Linus Walleij
This adds a host bridge driver for the Cortina Systems Gemini SoC (SL3516) PCI Host Bridge. This code is inspired by the out-of-tree OpenWRT patch and then extensively rewritten for device tree and using the modern helpers to cut down and modernize the code to all new PCI frameworks. Tested on