Re: [OpenWrt-Devel] [PATCH RFC] cfg80211: add new command for reporting wiphy crashes

2019-09-26 Thread Johannes Berg
On Thu, 2019-09-26 at 14:00 +0200, Rafał Miłecki wrote: > > You can't seriously be suggesting that the driver doesn't *have* enough > > information - everything passed through it :) > > Precisely: it doesn't store (cache) enough info. But nothing stops it (the driver) from doing so! > In brcmfm

Re: [OpenWrt-Devel] [PATCH RFC] cfg80211: add new command for reporting wiphy crashes

2019-09-26 Thread Rafał Miłecki
On 26.09.2019 13:55, Johannes Berg wrote: On Thu, 2019-09-26 at 13:52 +0200, Rafał Miłecki wrote: Indeed my main concert is AP mode. I'm afraid that cfg80211 doesn't cache all settings, consider e.g. nl80211_start_ap(). It builds struct cfg80211_ap_settings using info from nl80211 message and p

Re: [OpenWrt-Devel] [PATCH RFC] cfg80211: add new command for reporting wiphy crashes

2019-09-26 Thread Rafał Miłecki
Resending from my subscribed e-mail On 20.09.2019 16:01, Jouni Malinen wrote: > On Fri, Sep 20, 2019 at 03:37:08PM +0200, Rafał Miłecki wrote: >> Hardware or firmware instability may result in unusable wiphy. In such >> cases usually a hardware reset is needed. To allow a full recovery >> kernel h

Re: [OpenWrt-Devel] [PATCH RFC] cfg80211: add new command for reporting wiphy crashes

2019-09-26 Thread Johannes Berg
On Thu, 2019-09-26 at 13:52 +0200, Rafał Miłecki wrote: > > Indeed my main concert is AP mode. I'm afraid that cfg80211 doesn't > cache all settings, consider e.g. nl80211_start_ap(). It builds > struct cfg80211_ap_settings using info from nl80211 message and > passes it to the driver (rdev_start_

Re: [OpenWrt-Devel] [PATCH RFC] cfg80211: add new command for reporting wiphy crashes

2019-09-26 Thread Rafał Miłecki
On 20.09.2019 16:01, Jouni Malinen wrote: On Fri, Sep 20, 2019 at 03:37:08PM +0200, Rafał Miłecki wrote: Hardware or firmware instability may result in unusable wiphy. In such cases usually a hardware reset is needed. To allow a full recovery kernel has to indicate problem to the user space. W

Re: [OpenWrt-Devel] [PATCH RFC] cfg80211: add new command for reporting wiphy crashes

2019-09-20 Thread Jakub Kicinski
On Fri, 20 Sep 2019 15:37:08 +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > Hardware or firmware instability may result in unusable wiphy. In such > cases usually a hardware reset is needed. To allow a full recovery > kernel has to indicate problem to the user space. > > This new nl80211

Re: [OpenWrt-Devel] [PATCH RFC] cfg80211: add new command for reporting wiphy crashes

2019-09-20 Thread Jouni Malinen
On Fri, Sep 20, 2019 at 03:37:08PM +0200, Rafał Miłecki wrote: > Hardware or firmware instability may result in unusable wiphy. In such > cases usually a hardware reset is needed. To allow a full recovery > kernel has to indicate problem to the user space. Why? Shouldn't the driver be able to hand

[OpenWrt-Devel] [PATCH RFC] cfg80211: add new command for reporting wiphy crashes

2019-09-20 Thread Rafał Miłecki
From: Rafał Miłecki Hardware or firmware instability may result in unusable wiphy. In such cases usually a hardware reset is needed. To allow a full recovery kernel has to indicate problem to the user space. This new nl80211 command lets user space known wiphy has crashed and has been just recov