Re: [OpenWrt-Devel] [PATCH procd 2/4] ujail: remove useless arg in clone call

2015-11-24 Thread John Crispin
On 23/11/2015 13:12, Etienne Champetier wrote: > Hey, > > 2015-11-23 12:52 GMT+01:00 Paul Fertser >: > > Hey Etienne, > > Etienne Champetier > writes: > > i

Re: [OpenWrt-Devel] [PATCH procd 2/4] ujail: remove useless arg in clone call

2015-11-23 Thread John Crispin
On 23/11/2015 09:09, Etienne Champetier wrote: > Hi, > > Le 23 nov. 2015 08:18, "John Crispin" > a écrit : >> >> >> >> On 23/11/2015 01:39, Etienne CHAMPETIER wrote: >> > spawn_jail(void) produce a compilation error, >> > so we use spawn_jail()

Re: [OpenWrt-Devel] [PATCH procd 2/4] ujail: remove useless arg in clone call

2015-11-23 Thread Etienne Champetier
Hi, Le 23 nov. 2015 08:18, "John Crispin" a écrit : > > > > On 23/11/2015 01:39, Etienne CHAMPETIER wrote: > > spawn_jail(void) produce a compilation error, > > so we use spawn_jail() > > > > Signed-off-by: Etienne CHAMPETIER > > --- > >

Re: [OpenWrt-Devel] [PATCH procd 2/4] ujail: remove useless arg in clone call

2015-11-23 Thread Paul Fertser
Hey Etienne, Etienne Champetier writes: > i know that spawn_jail(void) is valid code, but then the clone call > refuses to compile That's type-safety for you. spawn_jail() is valid code too but it's not type-safe, so AFAICT you're avoiding the errors by letting the

Re: [OpenWrt-Devel] [PATCH procd 2/4] ujail: remove useless arg in clone call

2015-11-23 Thread Etienne Champetier
Hey, 2015-11-23 12:52 GMT+01:00 Paul Fertser : > Hey Etienne, > > Etienne Champetier writes: > > i know that spawn_jail(void) is valid code, but then the clone call > > refuses to compile > > That's type-safety for you. spawn_jail() is valid

Re: [OpenWrt-Devel] [PATCH procd 2/4] ujail: remove useless arg in clone call

2015-11-23 Thread Etienne Champetier
2015-11-23 9:11 GMT+01:00 John Crispin : > > > On 23/11/2015 09:09, Etienne Champetier wrote: > > Hi, > > > > Le 23 nov. 2015 08:18, "John Crispin" > > a écrit : > >> > >> > >> > >> On 23/11/2015 01:39, Etienne CHAMPETIER wrote:

Re: [OpenWrt-Devel] [PATCH procd 2/4] ujail: remove useless arg in clone call

2015-11-22 Thread John Crispin
On 23/11/2015 01:39, Etienne CHAMPETIER wrote: > spawn_jail(void) produce a compilation error, > so we use spawn_jail() > > Signed-off-by: Etienne CHAMPETIER > --- > jail/jail.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

[OpenWrt-Devel] [PATCH procd 2/4] ujail: remove useless arg in clone call

2015-11-22 Thread Etienne CHAMPETIER
spawn_jail(void) produce a compilation error, so we use spawn_jail() Signed-off-by: Etienne CHAMPETIER --- jail/jail.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jail/jail.c b/jail/jail.c index 56dc9ca..08babde 100644 --- a/jail/jail.c