Re: [OpenWrt-Devel] [PATCH v2] wireguard: fix interface remove for lonely peers

2020-03-03 Thread Jo-Philipp Wich
Hi Florian, > Deleting an interface section in LuCI is generic. So I don't know if we should > do this and make an exception for wireguard. proper removal of wg peer sections is in LuCI master and openwrt-19.07 now. ~ Jo signature.asc Description: OpenPGP digital signature

Re: [OpenWrt-Devel] [PATCH v2] wireguard: fix interface remove for lonely peers

2020-01-16 Thread Florian Eckert
Thanks for feedback I think this behavior is not really acceptable. Programs, init scripts, hotplug events etc. should not automatically modify (and commit) uci configurations, especially not such vital ones like the network config. The new wireguard init script is only executed if the

Re: [OpenWrt-Devel] [PATCH v2] wireguard: fix interface remove for lonely peers

2020-01-16 Thread Jo-Philipp Wich
Hi, I think this behavior is not really acceptable. Programs, init scripts, hotplug events etc. should not automatically modify (and commit) uci configurations, especially not such vital ones like the network config. The main problem I see is that you do not know what state the config is in at

Re: [OpenWrt-Devel] [PATCH v2] wireguard: fix interface remove for lonely peers

2020-01-15 Thread John Crispin
On 05/12/2019 11:58, Florian Eckert wrote: +++ b/package/network/services/wireguard/Makefile @@ -93,6 +93,8 @@ define Package/wireguard-tools/install $(INSTALL_BIN) ./files/wireguard_watchdog $(1)/usr/bin/ $(INSTALL_DIR) $(1)/lib/netifd/proto/ $(INSTALL_BIN)

[OpenWrt-Devel] [PATCH v2] wireguard: fix interface remove for lonely peers

2019-12-05 Thread Florian Eckert
When we delete a Wireguard interface, the associated peer sections are not deleted. They remain in the network configuration. This commit adds an init script, that triggers when the network configuration file is changed. For each change event, each Wireguard peer section is checked to see if the