Re: [OpenWrt-Devel] [PATCH v2 1/2] base-files: improve lib/upgrade/common.sh

2019-05-05 Thread Christian Lamparter
On Sunday, May 5, 2019 10:11:40 AM CEST Klaus Kudielka wrote: > On 04.05.19 16:51, Christian Lamparter wrote: > > On Friday, May 3, 2019 9:38:46 PM CEST Petr Štetiar wrote: > >> Klaus Kudielka [2019-05-03 20:16:39]: > >> > >>> Let me remind you that the common one *alone* breaks sysupgrade for

Re: [OpenWrt-Devel] [PATCH v2 1/2] base-files: improve lib/upgrade/common.sh

2019-05-05 Thread Klaus Kudielka
On 04.05.19 16:51, Christian Lamparter wrote: On Friday, May 3, 2019 9:38:46 PM CEST Petr Štetiar wrote: Klaus Kudielka [2019-05-03 20:16:39]: Let me remind you that the common one *alone* breaks sysupgrade for those four targets, as Tomasz already pointed out earlier. Well, how could I

Re: [OpenWrt-Devel] [PATCH v2 1/2] base-files: improve lib/upgrade/common.sh

2019-05-04 Thread Christian Lamparter
On Friday, May 3, 2019 9:38:46 PM CEST Petr Štetiar wrote: > Klaus Kudielka [2019-05-03 20:16:39]: > > > Let me remind you that the common one *alone* breaks sysupgrade for those > > four targets, as Tomasz already pointed out earlier. > > Well, how could I know what was wrong with v1 if you

Re: [OpenWrt-Devel] [PATCH v2 1/2] base-files: improve lib/upgrade/common.sh

2019-05-03 Thread Petr Štetiar
Klaus Kudielka [2019-05-03 20:16:39]: > Let me remind you that the common one *alone* breaks sysupgrade for those > four targets, as Tomasz already pointed out earlier. Well, how could I know what was wrong with v1 if you didn't included the changes between v1 -> v2 in your v2 patch :-)

Re: [OpenWrt-Devel] [PATCH v2 1/2] base-files: improve lib/upgrade/common.sh

2019-05-03 Thread Klaus Kudielka
On 03.05.19 19:05, Petr Štetiar wrote: Klaus Kudielka [2019-04-24 21:14:38]: Hi Klaus, Remove workarounds for the old, inconsistent behaviour from the following targets: apm821xx, brcm2708, omap, sunxi. I'm willing to push the fix for mvebu (which the patch series is about), so please don't

Re: [OpenWrt-Devel] [PATCH v2 1/2] base-files: improve lib/upgrade/common.sh

2019-05-03 Thread Petr Štetiar
Klaus Kudielka [2019-04-24 21:14:38]: Hi Klaus, > Remove workarounds for the old, inconsistent behaviour from the following > targets: apm821xx, brcm2708, omap, sunxi. I'm willing to push the fix for mvebu (which the patch series is about), so please don't touch other targets. This should go

Re: [OpenWrt-Devel] [PATCH v2 1/2] base-files: improve lib/upgrade/common.sh

2019-04-25 Thread Tomasz Maciej Nowak
W dniu 24.04.2019 o 21:14, Klaus Kudielka pisze: > Recently, upgrade device autodetection has been added to the mvebu target. > This exposes some shortcomings of the generic export_bootdevice function, > e.g. on the Turris Omnia: export_bootdevice silently reports the root > partition to be the

[OpenWrt-Devel] [PATCH v2 1/2] base-files: improve lib/upgrade/common.sh

2019-04-24 Thread Klaus Kudielka
Recently, upgrade device autodetection has been added to the mvebu target. This exposes some shortcomings of the generic export_bootdevice function, e.g. on the Turris Omnia: export_bootdevice silently reports the root partition to be the boot device. This makes the sysupgrade process fail at