Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-11-01 Thread Russell Senior
On Sat, Oct 27, 2018 at 12:33 PM Richard Weinberger wrote: > Rafał, > > Am Montag, 22. Oktober 2018, 17:34:44 CEST schrieb Rafał Miłecki: > > Then I took a close look at ovl_copy_up_locked() and it seems above > > info isn't accurate. It seems to me that setxattr() happens between > > fsync and

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-27 Thread Richard Weinberger
Rafał, Am Montag, 22. Oktober 2018, 17:34:44 CEST schrieb Rafał Miłecki: > Then I took a close look at ovl_copy_up_locked() and it seems above > info isn't accurate. It seems to me that setxattr() happens between > fsync and link. I modified my C app to follow that order (open, write, > fsync,

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-22 Thread Rafał Miłecki
[resending without HTML attachment] [see http://files.zajec.net/openwrt/ubifs-dbg.html instead] On Mon, 22 Oct 2018 at 10:26, Richard Weinberger wrote: > Am Montag, 22. Oktober 2018, 09:14:08 CEST schrieb Rafał Miłecki: > > On Fri, 19 Oct 2018 at 14:31, Rafał Miłecki wrote: > > > Since OpenWrt

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-22 Thread Rafał Miłecki
On Mon, 22 Oct 2018 at 10:26, Richard Weinberger wrote: > Am Montag, 22. Oktober 2018, 09:14:08 CEST schrieb Rafał Miłecki: > > On Fri, 19 Oct 2018 at 14:31, Rafał Miłecki wrote: > > > Since OpenWrt switch from kernel 4.9 to 4.14 users started randomly > > > reporting file system corruptions.

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-22 Thread Amir Goldstein
On Mon, Oct 22, 2018 at 6:34 PM Rafał Miłecki wrote: > > On Mon, 22 Oct 2018 at 10:57, Amir Goldstein wrote: > > On Mon, Oct 22, 2018 at 11:26 AM Richard Weinberger wrote: > > > > > > Am Montag, 22. Oktober 2018, 09:14:08 CEST schrieb Rafał Miłecki: > > > > On Fri, 19 Oct 2018 at 14:31, Rafał

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-22 Thread Rafał Miłecki
On Mon, 22 Oct 2018 at 10:57, Amir Goldstein wrote: > On Mon, Oct 22, 2018 at 11:26 AM Richard Weinberger wrote: > > > > Am Montag, 22. Oktober 2018, 09:14:08 CEST schrieb Rafał Miłecki: > > > On Fri, 19 Oct 2018 at 14:31, Rafał Miłecki wrote: > > > > Since OpenWrt switch from kernel 4.9 to

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-22 Thread Amir Goldstein
On Mon, Oct 22, 2018 at 11:26 AM Richard Weinberger wrote: > > Am Montag, 22. Oktober 2018, 09:14:08 CEST schrieb Rafał Miłecki: > > On Fri, 19 Oct 2018 at 14:31, Rafał Miłecki wrote: > > > Since OpenWrt switch from kernel 4.9 to 4.14 users started randomly > > > reporting file system

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-22 Thread Richard Weinberger
Am Montag, 22. Oktober 2018, 09:14:08 CEST schrieb Rafał Miłecki: > On Fri, 19 Oct 2018 at 14:31, Rafał Miłecki wrote: > > Since OpenWrt switch from kernel 4.9 to 4.14 users started randomly > > reporting file system corruptions. OpenWrt uses overlay(fs) with > > squashfs as lowerdir and ubifs as

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-22 Thread Rafał Miłecki
On Fri, 19 Oct 2018 at 14:31, Rafał Miłecki wrote: > Since OpenWrt switch from kernel 4.9 to 4.14 users started randomly > reporting file system corruptions. OpenWrt uses overlay(fs) with > squashfs as lowerdir and ubifs as upperdir. Russell managed to isolate > & describe test case for

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-22 Thread Rafał Miłecki
On Sat, 20 Oct 2018 at 08:58, Richard Weinberger wrote: > Am Freitag, 19. Oktober 2018, 23:28:33 CEST schrieb Rafał Miłecki: > > On Fri, 19 Oct 2018 at 16:59, Richard Weinberger wrote: > > > Am Freitag, 19. Oktober 2018, 16:45:53 CEST schrieb Richard Weinberger: > > > > Well, I fear it uncovers

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-20 Thread Richard Weinberger
Am Freitag, 19. Oktober 2018, 23:28:33 CEST schrieb Rafał Miłecki: > On Fri, 19 Oct 2018 at 16:59, Richard Weinberger wrote: > > Am Freitag, 19. Oktober 2018, 16:45:53 CEST schrieb Richard Weinberger: > > > Well, I fear it uncovers a problem in UBIFS. We had already problems with > > >

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-19 Thread Rafał Miłecki
On Fri, 19 Oct 2018 at 19:18, Richard Weinberger wrote: > Am Freitag, 19. Oktober 2018, 18:18:05 CEST schrieb Rafał Miłecki: > > > Do you have something also I can test? > > > A C reproducer? An xfstest case? > > > > I don't. I may try writing one with info provided my Amir, but I'm not > >

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-19 Thread Rafał Miłecki
On Fri, 19 Oct 2018 at 16:59, Richard Weinberger wrote: > Am Freitag, 19. Oktober 2018, 16:45:53 CEST schrieb Richard Weinberger: > > Well, I fear it uncovers a problem in UBIFS. We had already problems with > > overlayfs. > > Did you bisect the problem and you are sure that the said commit is

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-19 Thread Richard Weinberger
Am Freitag, 19. Oktober 2018, 18:18:05 CEST schrieb Rafał Miłecki: > > Do you have something also I can test? > > A C reproducer? An xfstest case? > > I don't. I may try writing one with info provided my Amir, but I'm not > experienced with such things, won't be trivial for me. Next week I'm in

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-19 Thread Rafał Miłecki
On Fri, 19 Oct 2018 at 16:45, Richard Weinberger wrote: > - Ursprüngliche Mail - > > Von: "Rafał Miłecki" > > An: "Amir Goldstein" , "Miklos Szeredi" > > , linux-unio...@vger.kernel.org, > > linux-fsde...@vger.kernel.org, "richard" , "Artem > > Bityutskiy" , "Adrian Hunter" > > ,

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-19 Thread Amir Goldstein
On Fri, Oct 19, 2018 at 5:59 PM Richard Weinberger wrote: > > Am Freitag, 19. Oktober 2018, 16:45:53 CEST schrieb Richard Weinberger: > > Well, I fear it uncovers a problem in UBIFS. We had already problems with > > overlayfs. > > Did you bisect the problem and you are sure that the said commit

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-19 Thread Richard Weinberger
Am Freitag, 19. Oktober 2018, 16:45:53 CEST schrieb Richard Weinberger: > Well, I fear it uncovers a problem in UBIFS. We had already problems with > overlayfs. > Did you bisect the problem and you are sure that the said commit is the first > bad commit? Another thing, UBIFS has no export

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-19 Thread Amir Goldstein
On Fri, Oct 19, 2018 at 3:31 PM Rafał Miłecki wrote: > > Hi, > > Since OpenWrt switch from kernel 4.9 to 4.14 users started randomly > reporting file system corruptions. OpenWrt uses overlay(fs) with > squashfs as lowerdir and ubifs as upperdir. Russell managed to isolate > & describe test case

Re: [OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-19 Thread Richard Weinberger
Rafał, - Ursprüngliche Mail - > Von: "Rafał Miłecki" > An: "Amir Goldstein" , "Miklos Szeredi" > , linux-unio...@vger.kernel.org, > linux-fsde...@vger.kernel.org, "richard" , "Artem Bityutskiy" > , "Adrian Hunter" > , linux-...@lists.infradead.org, "Russell Senior" > , "OpenWrt >

[OpenWrt-Devel] Regression in handling power cuts since 3a1e819b4e80 ("ovl: store file handle of lower inode on copy up")

2018-10-19 Thread Rafał Miłecki
Hi, Since OpenWrt switch from kernel 4.9 to 4.14 users started randomly reporting file system corruptions. OpenWrt uses overlay(fs) with squashfs as lowerdir and ubifs as upperdir. Russell managed to isolate & describe test case for reproducing corruption when doing a power cut after first boot.