Re: [OpenWrt-Devel] Warning: ABI breakage - rebuild your ATM trees

2015-09-17 Thread John Crispin
On 17/09/2015 10:54, David Woodhouse wrote: > On Wed, 2015-09-16 at 15:23 +0200, John Crispin wrote: >> how i hate this shitty dsl driver ... adding new sockopt is nort an >> option. that would involve editing the dsl driver and userland and even >> looking at the code causes permanent brain

Re: [OpenWrt-Devel] Warning: ABI breakage - rebuild your ATM trees

2015-09-17 Thread David Woodhouse
On Wed, 2015-09-16 at 15:23 +0200, John Crispin wrote: > how i hate this shitty dsl driver ... adding new sockopt is nort an > option. that would involve editing the dsl driver and userland and even > looking at the code causes permanent brain damage as can be seen by the > patches and fixes ... i

Re: [OpenWrt-Devel] Warning: ABI breakage - rebuild your ATM trees

2015-09-17 Thread Kevin Darbyshire-Bryant
On 16/09/15 12:20, John Crispin wrote: > Hi, > > i pushed a patch today that removes some serious ABI brain damage of the > ATM layer that i introduced 1/2 a decade ago > > http://git.openwrt.org/?p=openwrt.git;a=commit;h=c5d4911448898f7fabdd2c4737ed0820ced4fc4d > >

Re: [OpenWrt-Devel] Warning: ABI breakage - rebuild your ATM trees

2015-09-17 Thread John Crispin
On 17/09/2015 11:11, John Crispin wrote: > > > On 17/09/2015 10:54, David Woodhouse wrote: >> On Wed, 2015-09-16 at 15:23 +0200, John Crispin wrote: >>> how i hate this shitty dsl driver ... adding new sockopt is nort an >>> option. that would involve editing the dsl driver and userland and

[OpenWrt-Devel] Warning: ABI breakage - rebuild your ATM trees

2015-09-16 Thread John Crispin
Hi, i pushed a patch today that removes some serious ABI brain damage of the ATM layer that i introduced 1/2 a decade ago http://git.openwrt.org/?p=openwrt.git;a=commit;h=c5d4911448898f7fabdd2c4737ed0820ced4fc4d https://dev.openwrt.org/ticket/20523 as a side effect you will need to rebuild

Re: [OpenWrt-Devel] Warning: ABI breakage - rebuild your ATM trees

2015-09-16 Thread John Crispin
On 16/09/2015 13:20, John Crispin wrote: > Hi, > > i pushed a patch today that removes some serious ABI brain damage of the > ATM layer that i introduced 1/2 a decade ago > > http://git.openwrt.org/?p=openwrt.git;a=commit;h=c5d4911448898f7fabdd2c4737ed0820ced4fc4d > >

Re: [OpenWrt-Devel] Warning: ABI breakage - rebuild your ATM trees

2015-09-16 Thread John Crispin
On 16/09/2015 15:17, David Woodhouse wrote: > On Wed, 2015-09-16 at 13:23 +0200, John Crispin wrote: >> thinking about this, the new elements should also be guarded by a #ifdef >> CONFIG_lantiq will add that now > > You can't do that in user-visible headers. CONFIG_LANTIQ isn't defined > in t

Re: [OpenWrt-Devel] Warning: ABI breakage - rebuild your ATM trees

2015-09-16 Thread David Woodhouse
On Wed, 2015-09-16 at 13:23 +0200, John Crispin wrote: > thinking about this, the new elements should also be guarded by a #ifdef > CONFIG_lantiq will add that now You can't do that in user-visible headers. CONFIG_LANTIQ isn't defined in t he userspace builds, so userspace will get a version