Re: [PATCH][netifd] system-linux: initialize ifreq struct before using it

2020-10-09 Thread Alin Năstac
Hi Hans, I have the confirmation, this change fixed my problem. Given the fact that my commit fixes an obvious programming error, I don't think I need to put a detailed explanation in the commit description. BR, Alin On Thu, Oct 8, 2020 at 2:35 PM Alin Năstac wrote: > > Hi Hans, > > The issue

Re: [PATCH][netifd] system-linux: initialize ifreq struct before using it

2020-10-08 Thread Alin Năstac
Hi Hans, The issue I have involved adding an external device to the lan bridge through add_device ubus call. Sometimes this operation fails to add the new bridge port with the following device debug traces: Wed Oct 7 04:22:57 2020 daemon.err netifd[2843]: device_create_default(525): Create

Re: [PATCH][netifd] system-linux: initialize ifreq struct before using it

2020-10-08 Thread Hans Dedecker
Hi Alin, On Thu, Oct 8, 2020 at 1:31 PM Alin Nastac wrote: Could you add which issue this fixes ? Thx Hans > > Signed-off-by: Alin Nastac > --- > system-linux.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/system-linux.c b/system-linux.c > index 6778b1d..9188899 100644 > ---

[PATCH][netifd] system-linux: initialize ifreq struct before using it

2020-10-08 Thread Alin Nastac
Signed-off-by: Alin Nastac --- system-linux.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/system-linux.c b/system-linux.c index 6778b1d..9188899 100644 --- a/system-linux.c +++ b/system-linux.c @@ -904,6 +904,8 @@ failure: int system_if_resolve(struct device *dev) { struct