Re: [PATCH] base-files: simplify setting device MAC

2021-06-01 Thread Jo-Philipp Wich
Hi, > Ideally you should be able to use jsonfilter too but I don't know how to > deal with "-" in a property name. Use bracket notation. > Following doesn't work for me: > > ubus call network.device status '{ "name": "br-lan" }' | jsonfilter -e > "$.bridge-members" ubus call network.device

Re: [PATCH] base-files: simplify setting device MAC

2021-05-31 Thread Rafał Miłecki
On 28.05.2021 20:18, Evgeny K wrote: 3. Drop section name It's not required by netifd or LuCI & it's not needed by this script as $device contains a single device name now. It could be convenient to have it, though. In the former scheme of things, if one would like to know the

Re: [PATCH] base-files: simplify setting device MAC

2021-05-28 Thread Evgeny K
> 3. Drop section name >It's not required by netifd or LuCI & it's not needed by this script >as $device contains a single device name now. It could be convenient to have it, though. In the former scheme of things, if one would like to know the interface behind, say, lan it was possible

[PATCH] base-files: simplify setting device MAC

2021-05-28 Thread Rafał Miłecki
From: Rafał Miłecki 1. Move code above interface generation It results in more logical order. Device gets its config section above interface section. 2. Drop the loop We have separated code handling bridges now so $device should be guaranteed to contain a single device name. 3. Drop