Hi Sander,
Thank you for review, it made me think about consistency.
On Mon, Sep 20, 2021 at 05:45:06PM +0200, Sander Vanheule wrote:
> On Fri, 2021-09-17 at 16:11 +0300, Paul Fertser wrote:
> > rtl8231_write(gpios, RTL8231_GPIO_PIN_SEL(0), 0x);
> > rtl8231_write(gpios,
Hi Paul,
Thanks for the patch. One comment below.
On Fri, 2021-09-17 at 16:11 +0300, Paul Fertser wrote:
> GPIOs > 31 require special handling. This patch fixes both the
> initialisation (defaulting to input) and direction get/set operations.
>
> Runtime-tested on D-Link DGS-1210-10P-R1 which
GPIOs > 31 require special handling. This patch fixes both the
initialisation (defaulting to input) and direction get/set operations.
Runtime-tested on D-Link DGS-1210-10P-R1 which has "reset" button on
GPIO[33].
Signed-off-by: Paul Fertser
---
.../realtek/files-5.4/drivers/gpio/gpio-rtl8231.c
