RE: [PATCH] treewide: replace `which` with `command -v`

2020-08-12 Thread Adrian Schmutzler
> -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Paul Spooren > Sent: Samstag, 8. August 2020 00:55 > To: openwrt-devel@lists.openwrt.org > Cc: Paul Spooren > Subject: [PATCH] treewide: replace `which` wi

Re: [PATCH] treewide: replace `which` with `command -v`

2020-08-09 Thread Rosen Penev
On Sun, Aug 9, 2020 at 4:33 PM Stijn Tintel wrote: > > On 8/08/2020 01:54, Paul Spooren wrote: > > Fix shellcheck SC2230 > >> which is non-standard. Use builtin 'command -v' instead. > > Once applied to everything concerning OpenWrt we can disable the busybox > > feature `which` and save 3.8kB. >

Re: [PATCH] treewide: replace `which` with `command -v`

2020-08-09 Thread Stijn Tintel
On 8/08/2020 01:54, Paul Spooren wrote: > Fix shellcheck SC2230 >> which is non-standard. Use builtin 'command -v' instead. > Once applied to everything concerning OpenWrt we can disable the busybox > feature `which` and save 3.8kB. Maybe mention `command -v` is POSIX compliant, and `which` is

Re: [PATCH] treewide: replace `which` with `command -v`

2020-08-07 Thread Rosen Penev
On Fri, Aug 7, 2020 at 8:24 PM Paul Spooren wrote: > > > On 07.08.20 16:48, Rosen Penev wrote: > > On Fri, Aug 7, 2020 at 5:42 PM Paul Spooren wrote: > >> > >> On 07.08.20 14:18, Rosen Penev wrote: > >>> On Fri, Aug 7, 2020 at 3:57 PM Paul Spooren wrote: > Fix shellcheck SC2230 > >

Re: [PATCH] treewide: replace `which` with `command -v`

2020-08-07 Thread Paul Spooren
On 07.08.20 16:48, Rosen Penev wrote: On Fri, Aug 7, 2020 at 5:42 PM Paul Spooren wrote: On 07.08.20 14:18, Rosen Penev wrote: On Fri, Aug 7, 2020 at 3:57 PM Paul Spooren wrote: Fix shellcheck SC2230 which is non-standard. Use builtin 'command -v' instead. Once applied to everything

Re: [PATCH] treewide: replace `which` with `command -v`

2020-08-07 Thread Rosen Penev
On Fri, Aug 7, 2020 at 5:42 PM Paul Spooren wrote: > > > On 07.08.20 14:18, Rosen Penev wrote: > > On Fri, Aug 7, 2020 at 3:57 PM Paul Spooren wrote: > >> Fix shellcheck SC2230 > >>> which is non-standard. Use builtin 'command -v' instead. > >> Once applied to everything concerning OpenWrt we

Re: [PATCH] treewide: replace `which` with `command -v`

2020-08-07 Thread Paul Spooren
On 07.08.20 14:18, Rosen Penev wrote: On Fri, Aug 7, 2020 at 3:57 PM Paul Spooren wrote: Fix shellcheck SC2230 which is non-standard. Use builtin 'command -v' instead. Once applied to everything concerning OpenWrt we can disable the busybox feature `which` and save 3.8kB. which and

Re: [PATCH] treewide: replace `which` with `command -v`

2020-08-07 Thread Rosen Penev
On Fri, Aug 7, 2020 at 3:57 PM Paul Spooren wrote: > > Fix shellcheck SC2230 > > which is non-standard. Use builtin 'command -v' instead. > > Once applied to everything concerning OpenWrt we can disable the busybox > feature `which` and save 3.8kB. which and command -v seem to not be the same.

[PATCH] treewide: replace `which` with `command -v`

2020-08-07 Thread Paul Spooren
Fix shellcheck SC2230 > which is non-standard. Use builtin 'command -v' instead. Once applied to everything concerning OpenWrt we can disable the busybox feature `which` and save 3.8kB. Signed-off-by: Paul Spooren --- include/rootfs.mk| 6 +++---