Re: [PATCH] uqmi: Move to community packages repo

2021-07-02 Thread John Crispin
On 02.07.21 13:35, Koen Vandeputte wrote: +1 for keeping it in the core I agree, moving packages into the feed makes sense, but stuff needed for connectivity should stay in trunk     John ___ openwrt-devel mailing list openwrt-devel@lists.ope

Re: [PATCH] uqmi: Move to community packages repo

2021-07-02 Thread Koen Vandeputte
On 01.07.21 22:12, Arjun wrote: On 02/07/21 1:36 am, David Bauer wrote: [resend, as I've missed to keep the list CC'ed] Hi Arjun On 7/1/21 9:50 PM, Arjun AK wrote: Signed-off-by: Arjun AK And just my personal opinion: While I think it makes sense to move optional packages to the packa

Re: [PATCH] uqmi: Move to community packages repo

2021-07-02 Thread Petr Štetiar
Paul Spooren [2021-07-01 09:53:27]: Hi, > I'm all for moving it maybe we should get back[1] to the drawing board and finally formaly define what is core/base package, so it's clear? BTW in that email I've proposed initial list of potential packages for cleanup/move, but comgt/uqmi and probably

Re: [PATCH] uqmi: Move to community packages repo

2021-07-01 Thread Rafał Miłecki
On 01.07.2021 21:50, Arjun AK wrote: Signed-off-by: Arjun AK Nacked-by: Rafał Miłecki No proper explanation. Package is included by default in few device images. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.

Re: [PATCH] uqmi: Move to community packages repo

2021-07-01 Thread Arjun AK
On 02/07/21 1:42 am, Arjun wrote: On 02/07/21 1:36 am, David Bauer wrote: [resend, as I've missed to keep the list CC'ed] Hi Arjun On 7/1/21 9:50 PM, Arjun AK wrote: Signed-off-by: Arjun AK And just my personal opinion: While I think it makes sense to move optional packages to the packa

Re: [PATCH] uqmi: Move to community packages repo

2021-07-01 Thread Arjun
On 02/07/21 1:36 am, David Bauer wrote: [resend, as I've missed to keep the list CC'ed] Hi Arjun On 7/1/21 9:50 PM, Arjun AK wrote: Signed-off-by: Arjun AK And just my personal opinion: While I think it makes sense to move optional packages to the packages feed, this is clearly a core f

Re: [PATCH] uqmi: Move to community packages repo

2021-07-01 Thread Piotr Dymacz
Hi Arjun, On 01.07.2021 21:50, Arjun AK wrote: Signed-off-by: Arjun AK There are many devices with uqmi dependency (more than 10?). Personally, I would prefer to keep this one in the core packages set. -- Cheers, Piotr --- package/network/utils/uqmi/Makefile | 48 -- .../util

Re: [PATCH] uqmi: Move to community packages repo

2021-07-01 Thread David Bauer
[resend, as I've missed to keep the list CC'ed] Hi Arjun On 7/1/21 9:50 PM, Arjun AK wrote: Signed-off-by: Arjun AK Describing the rationale of this change would've been nice. This package is used on most boards with a cellular modem to provide ootb internet capability, so please explain h

Re: [PATCH] uqmi: Move to community packages repo

2021-07-01 Thread Paul Spooren
On 7/1/21 9:50 AM, Arjun AK wrote: Signed-off-by: Arjun AK --- Could you please add a brief commit message describing why this package isn't needed in core? I'm all for moving it, don't get me wrong, we just try to have commit messages everywhere to keep context over time. package/n

[PATCH] uqmi: Move to community packages repo

2021-07-01 Thread Arjun AK
Signed-off-by: Arjun AK --- package/network/utils/uqmi/Makefile | 48 -- .../utils/uqmi/files/lib/netifd/proto/qmi.sh | 471 -- 2 files changed, 519 deletions(-) delete mode 100644 package/network/utils/uqmi/Makefile delete mode 100755 package/network/utils/uqmi/file