Re: [PATCH 4/7] lldpd: note about capabilities

2024-04-03 Thread Paul D
On 2024-04-03 01:15, Jo-Philipp Wich wrote: > Hi, > > What's the purpose of this isolated comment? Either we're shipping version >= > v1.0.15 so this code is guaranteed to work or we don't, in which case the > code should not be there. We're not putting such comments next to all other > option

Re: [PATCH 4/7] lldpd: note about capabilities

2024-04-02 Thread Jo-Philipp Wich
Hi, What's the purpose of this isolated comment? Either we're shipping version >= v1.0.15 so this code is guaranteed to work or we don't, in which case the code should not be there. We're not putting such comments next to all other option handling code either. ~ Jo

[PATCH 4/7] lldpd: note about capabilities

2024-04-02 Thread Paul Donald
only available from >= 1.0.15 Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 1 + 1 file changed, 1 insertion(+) diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init index 0334156fee..284c37c2ef 100644