Re: [PATCH luci] luci-mod-network: split config migration into 2 steps

2021-05-30 Thread Sven Roederer
Am Samstag, 29. Mai 2021, 18:10:59 CEST schrieb Hauke Mehrtens: > On 5/29/21 5:25 PM, Rafał Miłecki wrote: > > > > For the sake of simplicity and reliability use 2 steps migration. The > > downside is that users may get prompted twice to migrate. > > > > I tested it in OpenWrt 21.02 doing the

Re: [PATCH luci] luci-mod-network: split config migration into 2 steps

2021-05-29 Thread Hauke Mehrtens
On 5/29/21 5:25 PM, Rafał Miłecki wrote: From: Rafał Miłecki Problem with handling all migrations in 1 step is that uci.sections() doesn't include changes queued using uci.callAdd() and uci.callSet(). That could result in unexpected behaviour and generating invalid configs. For the sake of

[PATCH luci] luci-mod-network: split config migration into 2 steps

2021-05-29 Thread Rafał Miłecki
From: Rafał Miłecki Problem with handling all migrations in 1 step is that uci.sections() doesn't include changes queued using uci.callAdd() and uci.callSet(). That could result in unexpected behaviour and generating invalid configs. For the sake of simplicity and reliability use 2 steps