Re: [RFC] procd: Use /dev/console for serial console if exists

2021-04-25 Thread Paul Spooren
Apr 25, 2021 8:34:06 AM Gaurav Pathak : inittab.c: Use "/dev/console" character device (5,1) if it is present, before trying "/sys/class/tty/console/active" in case if console kernel command line is not provided during boot and to allow container environment to use it as login PTY console.

[RFC] procd: Use /dev/console for serial console if exists

2021-04-25 Thread Gaurav Pathak
inittab.c: Use "/dev/console" character device (5,1) if it is present, before trying "/sys/class/tty/console/active" in case if console kernel command line is not provided during boot and to allow container environment to use it as login PTY console. Signed-off-by: Gaurav Pathak --- inittab.c |

Re: [RFC] procd: Use /dev/console for serial console if exists

2021-04-24 Thread Daniel Golle
On Sat, Apr 24, 2021 at 09:05:58PM +0530, Gaurav Pathak wrote: > As Daniel mentioned, this change is for providing the capability to container > environment to be able to login using PTY. > Also, there can be a case when console option is not passed to kernel command > line, > in that case we

Re: [RFC] procd: Use /dev/console for serial console if exists

2021-04-24 Thread Gaurav Pathak
As Daniel mentioned, this change is for providing the capability to container environment to be able to login using PTY. Also, there can be a case when console option is not passed to kernel command line, in that case we should try and check for the presence of /dev/console character device

Re: [RFC] procd: Use /dev/console for serial console if exists

2021-04-24 Thread Daniel Golle
On Sat, Apr 24, 2021 at 03:39:51AM -1000, Paul Spooren wrote: > > On 4/24/21 1:01 AM, Gaurav Pathak wrote: > > Modified inittab.c to use "/dev/console" as preferred console if exists. > > > > Signed-off-by: Gaurav Pathak > > --- > > Could you please elaborate why this is useful? Container

Re: [RFC] procd: Use /dev/console for serial console if exists

2021-04-24 Thread Paul Spooren
On 4/24/21 1:01 AM, Gaurav Pathak wrote: Modified inittab.c to use "/dev/console" as preferred console if exists. Signed-off-by: Gaurav Pathak --- Could you please elaborate why this is useful? Edited inittab.c to check and use "/dev/console" as the first console device before parsing

[RFC] procd: Use /dev/console for serial console if exists

2021-04-24 Thread Gaurav Pathak
Modified inittab.c to use "/dev/console" as preferred console if exists. Signed-off-by: Gaurav Pathak --- Edited inittab.c to check and use "/dev/console" as the first console device before parsing "/sys/class/tty/console/active". inittab.c | 8 +++- 1 file changed, 7 insertions(+), 1