[OpenWrt-Devel] [PATCH] [rpcd] iwinfo: zero out ccode buffer since library doesn't

[Denis Osvald]

Making an ubus call iwinfo countrylist '{"device":"radio0"}' will result
in some entries having garbage uninitialized stack bytes in the "code"
fields.

With this patch we zero-initialize the buffer that libiwinfo writes to,
making it NUL-terminated so that behavior doesn't happen anymore.

Signed-off-by: Denis Osvald 
---
 iwinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/iwinfo.c b/iwinfo.c
index 325c07a..b24d0f5 100644
--- a/iwinfo.c
+++ b/iwinfo.c
@@ -588,7 +588,7 @@ rpc_iwinfo_countrylist(struct ubus_context *ctx, struct 
ubus_object *obj,
int rv, len;
char cur[3];
char iso3166[3];
-   char res[IWINFO_BUFSIZE];
+   char res[IWINFO_BUFSIZE] = {0};
const char *ccode;
const struct iwinfo_iso3166_label *l;
void *c, *d;
-- 
2.8.2
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] international keyboard layout support

[edgar . soldin]

hey All,

while tinkering with Gluon the Openwrt based Freifunk firmware (currently on 
CC) on a x86 based thin client box i needed support for a german keyboard 
layout. i managed to realize that manually as i didn't find any prepared 
packages for this purpose.

is there any interest in a keyboardmaps package, holding busybox compatible 
binary kmaps and activating the needed busybox utilities? i imagine some 
devs/users especially on platforms with proper keyboard interfaces (usb/ps2) 
would appreciate that.

thanks ..ede
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] git.openwrt.org site half broken

[Etienne Champetier]

Hi,

someone messed with git.openwrt.org nginx config, i can't get the js and css.

see https://git.openwrt.org/project/static/gitweb.css (doesn't look
like a css :) )

Cheers
Etienne
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] _GNU_SOURCE should be defined for building vs uClibc

[John Crispin]

On 02/06/2016 13:03, Karl Palsson wrote:
> 
> Waldemar Brodkorb  wrote:
>>>
>>> This still doesn't work on the uclibc in openwrt-CC branch. The
>>> O_PATH definitions are in asm-generic/fcntl.h, which can be
>>> included via linux/fcntl.h, _GNU_SOURCE doesn't get this pulled
>>> in though.
>>>
>>> I attempted to add includes for linux/fcntl, but it just gives me
>>> redeclaration errors for struct flock.
>>
>> The definition where added to uClibc-ng after 1.0.9 release.
>> LEDE included 1.0.14 recently. You need to update.
>>
> 
> I'm well aware that it would work if I was on living on the
> bleeding edge of latest LEDE. [1] I'm just reporting that, up
> until this O_PATH landed, procd fixes were still backportable to
> the last _released_ version of openwrt/lede. (uclibc 0.9.33.2)
> That is no longer the case.
> 
> Sincerely,
> Karl P
> 
> 
> [1] Everything always works, you just haven't pulled the latest!
> 

send a patch for procd ala

#ifndef O_PATH
#define O_PATH
#endif

drama solved

John
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] _GNU_SOURCE should be defined for building vs uClibc

[Karl Palsson]

Waldemar Brodkorb  wrote:
> > 
> > This still doesn't work on the uclibc in openwrt-CC branch. The
> > O_PATH definitions are in asm-generic/fcntl.h, which can be
> > included via linux/fcntl.h, _GNU_SOURCE doesn't get this pulled
> > in though.
> > 
> > I attempted to add includes for linux/fcntl, but it just gives me
> > redeclaration errors for struct flock.
> 
> The definition where added to uClibc-ng after 1.0.9 release.
> LEDE included 1.0.14 recently. You need to update.
> 

I'm well aware that it would work if I was on living on the
bleeding edge of latest LEDE. [1] I'm just reporting that, up
until this O_PATH landed, procd fixes were still backportable to
the last _released_ version of openwrt/lede. (uclibc 0.9.33.2)
That is no longer the case.

Sincerely,
Karl P


[1] Everything always works, you just haven't pulled the latest!

signature.asc
Description: OpenPGP Digital Signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel