[PATCH v3 3/9] router: inherit user-assigned preferred_lifetime

From: Paul Donald Inherit preferred_lifetime value irrespective of whether ra_useleasetime is set or not. User-provided values for preferred_lifetime are now assigned, instead of ignored. Before: == ICMPv6 Option (Prefix information : fd51:1c2a:8909::/64) Type: Prefix information (3)

[PATCH v3 8/9] router: disambiguate and clarify 'no route' messages

From: Paul Donald Signed-off-by: Paul Donald --- src/router.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/router.c b/src/router.c index 2a59530..365aaa8 100644 --- a/src/router.c +++ b/src/router.c @@ -656,9 +656,9 @@ static int send_router_advert(struct

[PATCH v2 0/7] lldpd: various improvements

v2: applied feedback comments Paul Donald (7): lldpd: fixed interface(s) parsing lldpd: get_config_cid_ifaces() -> get_interface_csv_pattern() lldpd: fix restart lldpd: note about capabilities lldpd: make capabilities advertisement controllable lldpd: make management address

[PATCH v2 2/7] lldpd: get_config_cid_ifaces() -> get_interface_csv_pattern()

Make the function more generic. Can use it for not only 'config'. Now it can be used to parse interfaces for additional lldpd settings Tested on: 22.03.6 Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 8 1 file changed, 4 insertions(+), 4

[PATCH v2 1/7] lldpd: fixed interface(s) parsing

For interface type parameters, the man page documents patterns: ``` *,!eth*,!!eth1 uses all interfaces, except interfaces starting with "eth", but including "eth1". ``` While we must check that interfaces exist, first strip any prefixed "!" then pass the original string (with `!` prefix) again,

[PATCH v2 3/7] lldpd: fix restart

redirection broke in 5364fe0f01ca11b47c55d78f756d3176748dd0c2 redirects to /dev/null shall be handled correctly (i.e. last). This fixes these errors on `/etc/init.d/lldpd reload`: 2024-03-16T20:39:00 [WARN/lldpctl] unknown command from argument 1: `/dev/null` 2024-03-16T20:39:00 [WARN/lldpctl]

[PATCH v2 4/7] lldpd: note about capabilities

only available from >= 1.0.15 Comments are useful. Apparently this config parameter was committed when openwrt used an older version of lldpd which did not yet support it. Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v2 5/7] lldpd: make capabilities advertisement controllable

Defaults to off. Only available from >= 1.0.15 These capabilities are sent in TLV. Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 7 +++ 1 file changed, 7 insertions(+) diff --git a/package/network/services/lldpd/files/lldpd.init

[PATCH v2 7/7] lldpd: bump version

3 -> 4 Signed-off-by: Paul Donald --- package/network/services/lldpd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/services/lldpd/Makefile b/package/network/services/lldpd/Makefile index 18cdda33ce..5a9a9732d2 100644 ---

[PATCH v2 6/7] lldpd: make management address advertisement controllable

Defaults to off. Available from >= 0.7.15 These are sent in TLV Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 6 ++ 1 file changed, 6 insertions(+) diff --git a/package/network/services/lldpd/files/lldpd.init

[PATCH v3 0/9] odhcpd patchset

From: Paul Donald applies to odhcpd master HEAD d8118f6e76e5519881f9a37137c3a06b3cb60fd2 Before: == ICMPv6 Option (Prefix information : fd51:1c2a:8909::/64) Type: Prefix information (3) Length: 4 (32 bytes) Prefix Length: 64 Flag: 0xc0, On-link flag(L), Autonomous

[PATCH v3 2/9] various: refactor valid -> valid_lt (lifetime)

From: Paul Donald Refactor "valid" (valid what?) to "valid_lt". Signed-off-by: Paul Donald Reviewed-by: Daniel Golle --- src/dhcpv6-ia.c | 62 - src/dhcpv6.c| 4 ++-- src/dhcpv6.h| 4 ++-- src/netlink.c | 24 +--

[PATCH v3 6/9] various: (formatting) convert spaces -> tabs

From: Paul Donald Signed-off-by: Paul Donald --- src/config.c | 52 ++-- src/router.c | 32 2 files changed, 42 insertions(+), 42 deletions(-) diff --git a/src/config.c b/src/config.c index 0368e74..7fe31a1

[PATCH v3 1/9] various: refactor pref(erred) to preferred_lt (lifetime)

From: Paul Donald Refactor "preferred" (preferred what?) and "pref" (obscure) to "preferred_lt". It is now more difficult to conflate prefix, preference and other "pref" related terminology with preferred_lifetime. Signed-off-by: Paul Donald Reviewed-by: Daniel Golle --- src/dhcpv6-ia.c |

[PATCH v3 7/9] router: rename minvalid -> lowest_found_lifetime

From: Paul Donald The variable is used across all prefix lifetimes, serving as a low-tide mark. It stores the lowest lifetime among all prefixes. Signed-off-by: Paul Donald --- src/router.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/router.c

[PATCH v3 5/9] various: Comment spell-fixes, new comments for extra clarification

From: Paul Donald Signed-off-by: Paul Donald Reviewed-by: Daniel Golle --- src/config.c| 1 + src/dhcpv4.c| 2 +- src/dhcpv6-ia.c | 6 +++--- src/ndp.c | 4 ++-- src/netlink.c | 2 +- src/router.c| 6 +++--- 6 files changed, 11 insertions(+), 10 deletions(-) diff --git

[PATCH v3 9/9] config: set RFC defaults for preferred lifetime

From: Paul Donald set them in accordance with RFC4861 Signed-off-by: Paul Donald --- README | 2 +- src/config.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README b/README index 243ae24..c8f2eb4 100644 --- a/README +++ b/README @@ -116,7 +116,7 @@ domain

[PATCH v3 4/9] router: Limit prefix preferred_lt to valid_lt in accordance with RFC4861

From: Paul Donald Follow-up fix for bc9d317f2921ae6b529f2c9f8de79b75992e206f https://www.rfc-editor.org/rfc/rfc4861#page-44 Signed-off-by: Paul Donald Reviewed-by: Daniel Golle --- src/router.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/router.c b/src/router.c index

Re: [PATCH v2 6/9] router: Apply updated values from RFC8319 (updates RFC4861) to RA/ND

On 2024-04-06 12:05, Jonas Gorski wrote: > Hi, You're right on all counts. I separated out the value clamping and config values to another patch-set. Thanks for your sharp eyes. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: Status of snapshot builds for omap target

Hi Raylynn, sorry for late reply. From my understanding... On 2024/04/05 4:42, Raylynn Knight via openwrt-devel wrote: If I understand the issue correctly then it does not affect two of the four currently supported devices (i.e. it only affects Beaglebone Black and AM335x EVM and not

Re: OpenWrt One / project update

Bjørn Mork wrote: > Michael Richardson writes: >> I'd really like to find a way to work with your manufacturer to get an >> IDevID certificate into each unit as it is manufacturered. > For those of us who are not going to pay USD 100 for a document we > won't be able to

libubus ubus_invoke() with an extended struct blob_attr *msg as input

Not too sure about any of this, so I just wanted to ask if this would make sense: bjorn@miraculix:/usr/local/src/git/ubus$ git diff diff --git a/libubus-req.c b/libubus-req.c index ae9d1925ecdf..cf85303e6aed 100644 --- a/libubus-req.c +++ b/libubus-req.c @@ -197,7 +197,7 @@ void