Re: [OpenWrt-Devel] [PATCH] Fix sysupgrade save configuration

2009-08-10 Thread Daniel Dickinson
On Tue, 11 Aug 2009 03:18:58 +0200 Felix Fietkau wrote: > Daniel Dickinson wrote: > > Ticket #5652 now contains a patch, attached here, to fix the > > following: The updated patch is below. > The patch looks wrong to me. sizeof on a constant string should return > its length + 1 (for the null b

Re: [OpenWrt-Devel] [PATCH] Fix sysupgrade save configuration

2009-08-10 Thread Daniel Dickinson
On Tue, 11 Aug 2009 00:47:33 -0400 Daniel Dickinson wrote: > On Tue, 11 Aug 2009 03:18:58 +0200 > Felix Fietkau wrote: > > > The patch looks wrong to me. sizeof on a constant string should > > return its length + 1 (for the null byte). In your patch however > > you use a > > I'm pretty sure th

Re: [OpenWrt-Devel] [PATCH] Fix sysupgrade save configuration

2009-08-10 Thread Daniel Dickinson
On Tue, 11 Aug 2009 03:18:58 +0200 Felix Fietkau wrote: > The patch looks wrong to me. sizeof on a constant string should return > its length + 1 (for the null byte). In your patch however you use a I'm pretty sure that's not true. sizeof is the sizeof a type, in this case char. I remember tha

Re: [OpenWrt-Devel] [PATCH] Fix sysupgrade save configuration

2009-08-10 Thread Daniel Dickinson
On Tue, 11 Aug 2009 03:18:58 +0200 Felix Fietkau wrote: > Daniel Dickinson wrote: > > Ticket #5652 now contains a patch, attached here, to fix the > > following: > > > > sysupgrade save the configuration in sysupgrade.tgz but that file > > never gets restored on reboot after flashing a new firmw

Re: [OpenWrt-Devel] [PATCH] Fix sysupgrade save configuration

2009-08-10 Thread Felix Fietkau
Daniel Dickinson wrote: > Ticket #5652 now contains a patch, attached here, to fix the following: > > sysupgrade save the configuration in sysupgrade.tgz but that file never > gets restored on reboot after flashing a new firmware image, so > configuration changes are always lost across firmware up

[OpenWrt-Devel] [RFC] CRC changing; leave DEADC0DE as is, have brcm63xx-only solution

2009-08-10 Thread Daniel Dickinson
Ok, neither Felix or Florian like not having the DEADC0DE generated in the generic case, but with Florian I've come up with a scheme that leave all the other boards alone and only deals with the ones that need fixing (certain brcm63xx ones). Please let me know what you think. What I'm thinking is

Re: [OpenWrt-Devel] KVM images for OpenWRT?

2009-08-10 Thread Mirko Vogt
On Mon, 2009-08-10 at 18:38 +0200, Benjamin Henrion wrote: > Hi, > > Are there any images ready to download I could use to boot an OpenWRT on a > KVM? Yep - the default x86-images are - for kamikaze 8.09.1: http://downloads.openwrt.org/kamikaze/8.09.1/x86/openwrt-x86-ext2.image $ kvm openwrt-x86

[OpenWrt-Devel] KVM images for OpenWRT?

2009-08-10 Thread Benjamin Henrion
Hi, Are there any images ready to download I could use to boot an OpenWRT on a KVM? Best, -- Benjamin Henrion FFII Brussels - +32-484-566109 - +32-2-4148403 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailm