date:20101212

Re: [OpenWrt-Devel] WarpComm TK71 Port

2010-12-12 Thread Jonas Gorski

On 9 December 2010 01:12, green openwrt@gadgetweb.de wrote:
 Hi,

 KanjiMonster asked me as a response to my threat on the OpenWRT forum
 (https://forum.openwrt.org/viewtopic.php?pid=122891) to send my patch as a
 mail attachment to the dev-list.

Good to see it here. I probably should have linked you to
https://dev.openwrt.org/wiki/SubmittingPatches, as I have some style
nitpicks ;-).

 As I am currently working with the WarpComm TK71 Qseven module based on the
 Marvell Kirkwood CPU and I liked to use OpenWRT as a basic environment I
 decided to port it based on the linux kernel patch provided by the board
 manufacturer ( http://www.warpcomm.org/downloads/tk71/20100805/linux-2.6.34-
 tk71.diff ).

Nice hardware. And it looks like they are actively supporting it by
providing updated patches.

 The kernel is based on the 2.6.34 kernel but works great for the 2.6.35
 version as well.

Good to know.

Now on to my nitpicks:
First some meta stuff:

Try to send inline, that makes it easier to comment on patches. But if
your email client automatically wraps too long lines or replaces tabs
with spaces, then it might be better to send inline. See the page
linked above for further info.

About the patch itself:
(...)
 ++.gpio_card_detect = 29,
 ++};
 ++
 ++static unsigned int tk71_mpp_config[] __initdata = {
 ++#if 0
 ++MPP0_SPI_SCn,   /* SPI - currently unused */
 ++MPP1_SPI_MOSI,
 ++MPP2_SPI_SCK,
 ++MPP3_SPI_MISO,
 ++#endif
 ++MPP7_PEX_RST_OUTn,  /* PCIe #reset */
 ++MPP8_TW_SDA,/* I2C */
 ++MPP9_TW_SCK,/* I2C */
(...)
 ++kirkwood_nand_init(ARRAY_AND_SIZE(tk71_nand_parts), 25);
 ++
 ++/* kirkwood_spi_init(); */ /* if you want to use SPI, uncomment this 
 and MPP setup above*/
 ++
 ++kirkwood_i2c_init();

perhaps this should be exposed by a Kconfig option instead of
requiring to edit the sources?

 +diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig
 +index 346ae14..e150045 100644
 +--- a/arch/arm/mm/Kconfig
  b/arch/arm/mm/Kconfig
 +@@ -382,6 +382,17 @@ config CPU_FEROCEON_OLD_ID
 +   for which the CPU ID is equal to the ARM926 ID.
 +   Relevant for Feroceon-1850 and early Feroceon-2850.
 +
 ++config CPU_FEROCEON_DISABLE_WAITFORIRQ
 ++bool Disable wait_for_irq (for JTAG debugging, see help)
 ++depends on CPU_FEROCEON
 ++default n
 ++help
 ++  On some Feroceon implementations it is necessary to disable
 ++  the wait_for_interrupt in cpu_feroceon_do_idle in order to
 ++  enable proper JTAG debugging (random kernel panics can happen
 ++  otherwise).
 ++  For production this can safely be left enabled.
 ++
 + # ARMv6
 + config CPU_V6
 + bool Support ARM V6 processor if ARCH_INTEGRATOR || MACH_REALVIEW_EB 
 || MACH_REALVIEW_PBX || ARCH_DOVE
 +diff --git a/arch/arm/mm/proc-feroceon.S b/arch/arm/mm/proc-feroceon.S
 +index 53e6323..9a99066 100644
 +--- a/arch/arm/mm/proc-feroceon.S
  b/arch/arm/mm/proc-feroceon.S
 +@@ -123,9 +123,11 @@ ENTRY(cpu_feroceon_reset)
 +  */
 + .align  5
 + ENTRY(cpu_feroceon_do_idle)
 ++#ifndef CONFIG_CPU_FEROCEON_DISABLE_WAITFORIRQ
 + mov r0, #0
 + mcr p15, 0, r0, c7, c10, 4  @ Drain write buffer
 + mcr p15, 0, r0, c7, c0, 4   @ Wait for interrupt
 ++#endif
 + mov pc, lr
 +
 + /*

This should be in its own kernel patch as this isn't TK71 specific (I assume).

+diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
+index e345ec8..ab16557 100644
+--- a/drivers/net/mv643xx_eth.c
 b/drivers/net/mv643xx_eth.c
 +@@ -2781,11 +2781,13 @@ static struct phy_device *phy_scan(struct 
 mv643xx_eth_private *mp,
 +
 + if (phydev == NULL) {
 + phydev = bus-phy_map[addr];
 +-if (phydev != NULL)
 ++if (phydev != NULL) {
 + phy_addr_set(mp, addr);
 ++printk(KERN_INFO mv643xx_eth: found PHY @ %d 
 ID %08x\n, phydev-addr, phydev-phy_id);
 ++} else
 ++printk(KERN_ERR mv643xx_eth: PHY @ %d not 
 found!\n, addr);
 + }
 + }
 +-

Unnecessary white space change.

 + return phydev;
 + }
 +

This should also be a separate kernel patch if not dropped since it
might produce quite a bit of output when scanning the whole address
range.


I can't comment the kernel config changes, since I don't know enough
about them to recognize which are required, and which aren't (e.g. is
the CONFIG_EXT4_FS_XATTR really needed?).

You should split this into three patches, one for the board support
and one for each of the kernel changes.
Also I saw there is an updated version of the patch available on their
site, which claims to fix some sata problems, perhaps you could
recreate the patch based on this version, assuming it has additional
changes?

Regards,
Jonas
___
openwrt-devel mailing list

[OpenWrt-Devel] use shutdown instead of stop when the system goes down

2010-12-12 Thread Peter Wagner

use shutdown instead of stop when the system goes down
use a wrapper to call stop if there is no shutdown routine
diff --git a/package/base-files/files/etc/inittab b/package/base-files/files/etc/inittab
index 58be3bc..e9de30b 100644
--- a/package/base-files/files/etc/inittab
+++ b/package/base-files/files/etc/inittab
@@ -1,5 +1,5 @@
 ::sysinit:/etc/init.d/rcS S boot
-::shutdown:/etc/init.d/rcS K stop
+::shutdown:/etc/init.d/rcS K shutdown
 tts/0::askfirst:/bin/ash --login
 ttyS0::askfirst:/bin/ash --login
 tty1::askfirst:/bin/ash --login
diff --git a/package/base-files/files/etc/rc.common b/package/base-files/files/etc/rc.common
index 072f143..6ec88ae 100755
--- a/package/base-files/files/etc/rc.common
+++ b/package/base-files/files/etc/rc.common
@@ -30,7 +30,7 @@ boot() {
 }
 
 shutdown() {
-	return 0
+	stop
 }
 
 disable() {
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] update package triggerhappy to version 0.3.0-1

2010-12-12 Thread Stefan Tomanek

Signed-off-by: Stefan Tomanek stefan.tomanek+open...@wertarbyte.de
---
 utils/triggerhappy/Makefile |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/utils/triggerhappy/Makefile b/utils/triggerhappy/Makefile
index b9569fd..c96b121 100644
--- a/utils/triggerhappy/Makefile
+++ b/utils/triggerhappy/Makefile
@@ -6,8 +6,8 @@
 include $(TOPDIR)/rules.mk
 
 PKG_NAME:=triggerhappy
-PKG_VERSION:=0.1.6
-PKG_REV:=01bedc72451f8afd0c35649dd67c428c44a0f737
+PKG_VERSION:=0.3.0
+PKG_REV:=19f8b9ad3b33ee5f4c2c992caf0c794ac73fdc35
 PKG_RELEASE:=1
 
 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
-- 
1.7.1
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] asterisk 1.8.x

2010-12-12 Thread Hans Zandbelt

Hi,

Here:

https://dev.openwrt.org/attachment/ticket/8132/openwrt-asterisk-1.8.patch

is an update that replaces asterisk 1.4/1.6 with version 1.8.1. The
patch needs more SVN commit rights than I have.

Could someone please apply this (and get me the correct rights for 1.8.x
maintenance?)

Thanks,

Hans Zandbelt
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] use shutdown instead of stop when the system goes down

2010-12-12 Thread Peter Wagner

i forgot to patch the target/linux/*/base-files/etc/inittab files too
here is the updated patch
Am Sonntag, 12. Dezember 2010, 21:37:29 schrieb Peter Wagner:
 use shutdown instead of stop when the system goes down
 use a wrapper to call stop if there is no shutdown routine

diff --git a/package/base-files/files/etc/inittab b/package/base-files/files/etc/inittab
index 58be3bc..e9de30b 100644
--- a/package/base-files/files/etc/inittab
+++ b/package/base-files/files/etc/inittab
@@ -1,5 +1,5 @@
 ::sysinit:/etc/init.d/rcS S boot
-::shutdown:/etc/init.d/rcS K stop
+::shutdown:/etc/init.d/rcS K shutdown
 tts/0::askfirst:/bin/ash --login
 ttyS0::askfirst:/bin/ash --login
 tty1::askfirst:/bin/ash --login
diff --git a/package/base-files/files/etc/rc.common b/package/base-files/files/etc/rc.common
index 072f143..6ec88ae 100755
--- a/package/base-files/files/etc/rc.common
+++ b/package/base-files/files/etc/rc.common
@@ -30,7 +30,7 @@ boot() {
 }
 
 shutdown() {
-	return 0
+	stop
 }
 
 disable() {
diff --git a/target/linux/ep93xx/base-files/etc/inittab b/target/linux/ep93xx/base-files/etc/inittab
index ea83e79..9f7c0ae 100644
--- a/target/linux/ep93xx/base-files/etc/inittab
+++ b/target/linux/ep93xx/base-files/etc/inittab
@@ -1,5 +1,5 @@
 ::sysinit:/etc/init.d/rcS S boot
-::shutdown:/etc/init.d/rcS K stop
+::shutdown:/etc/init.d/rcS K shutdown
 tts/0::askfirst:/bin/ash --login
 ttyAM0::askfirst:/bin/ash --login
 tty1::askfirst:/bin/ash --login
diff --git a/target/linux/ifxmips/base-files/etc/inittab b/target/linux/ifxmips/base-files/etc/inittab
index 7989a7f..67c36a6 100644
--- a/target/linux/ifxmips/base-files/etc/inittab
+++ b/target/linux/ifxmips/base-files/etc/inittab
@@ -1,4 +1,4 @@
 ::sysinit:/etc/init.d/rcS S boot
-::shutdown:/etc/init.d/rcS K stop
+::shutdown:/etc/init.d/rcS K shutdown
 ttyS0::askfirst:/bin/ash --login
 ttyS1::askfirst:/bin/ash --login
diff --git a/target/linux/mpc52xx/base-files/etc/inittab b/target/linux/mpc52xx/base-files/etc/inittab
index 68b4331..77dd6ca 100644
--- a/target/linux/mpc52xx/base-files/etc/inittab
+++ b/target/linux/mpc52xx/base-files/etc/inittab
@@ -1,3 +1,3 @@
 ::sysinit:/etc/init.d/rcS S boot
-::shutdown:/etc/init.d/rcS K stop
+::shutdown:/etc/init.d/rcS K shutdown
 ttyPSC0::askfirst:/bin/ash --login
diff --git a/target/linux/mpc83xx/base-files/etc/inittab b/target/linux/mpc83xx/base-files/etc/inittab
index 7989a7f..67c36a6 100644
--- a/target/linux/mpc83xx/base-files/etc/inittab
+++ b/target/linux/mpc83xx/base-files/etc/inittab
@@ -1,4 +1,4 @@
 ::sysinit:/etc/init.d/rcS S boot
-::shutdown:/etc/init.d/rcS K stop
+::shutdown:/etc/init.d/rcS K shutdown
 ttyS0::askfirst:/bin/ash --login
 ttyS1::askfirst:/bin/ash --login
diff --git a/target/linux/omap24xx/base-files/etc/inittab b/target/linux/omap24xx/base-files/etc/inittab
index e39d2f1..f55b7cd 100644
--- a/target/linux/omap24xx/base-files/etc/inittab
+++ b/target/linux/omap24xx/base-files/etc/inittab
@@ -1,5 +1,5 @@
 ::sysinit:/etc/init.d/rcS S boot
-::shutdown:/etc/init.d/rcS K stop
+::shutdown:/etc/init.d/rcS K shutdown
 tts/0::askfirst:/bin/ash --login
 ttyS2::askfirst:/bin/ash --login
 tty1::askfirst:/bin/ash --login
diff --git a/target/linux/omap35xx/base-files/etc/inittab b/target/linux/omap35xx/base-files/etc/inittab
index 89626ec..88567b2 100644
--- a/target/linux/omap35xx/base-files/etc/inittab
+++ b/target/linux/omap35xx/base-files/etc/inittab
@@ -1,5 +1,5 @@
 ::sysinit:/etc/init.d/rcS S boot
-::shutdown:/etc/init.d/rcS K stop
+::shutdown:/etc/init.d/rcS K shutdown
 tts/0::askfirst:/bin/ash --login
 ttyS0::askfirst:/bin/ash --login
 ttyS1::askfirst:/bin/ash --login
diff --git a/target/linux/ppc44x/base-files/etc/inittab b/target/linux/ppc44x/base-files/etc/inittab
index 7989a7f..67c36a6 100644
--- a/target/linux/ppc44x/base-files/etc/inittab
+++ b/target/linux/ppc44x/base-files/etc/inittab
@@ -1,4 +1,4 @@
 ::sysinit:/etc/init.d/rcS S boot
-::shutdown:/etc/init.d/rcS K stop
+::shutdown:/etc/init.d/rcS K shutdown
 ttyS0::askfirst:/bin/ash --login
 ttyS1::askfirst:/bin/ash --login
diff --git a/target/linux/ramips/base-files/etc/inittab b/target/linux/ramips/base-files/etc/inittab
index 7989a7f..67c36a6 100644
--- a/target/linux/ramips/base-files/etc/inittab
+++ b/target/linux/ramips/base-files/etc/inittab
@@ -1,4 +1,4 @@
 ::sysinit:/etc/init.d/rcS S boot
-::shutdown:/etc/init.d/rcS K stop
+::shutdown:/etc/init.d/rcS K shutdown
 ttyS0::askfirst:/bin/ash --login
 ttyS1::askfirst:/bin/ash --login
diff --git a/target/linux/realview/base-files/etc/inittab b/target/linux/realview/base-files/etc/inittab
index 3674d98..d9d571e 100644
--- a/target/linux/realview/base-files/etc/inittab
+++ b/target/linux/realview/base-files/etc/inittab
@@ -1,5 +1,5 @@
 ::sysinit:/etc/init.d/rcS S boot
-::shutdown:/etc/init.d/rcS K stop
+::shutdown:/etc/init.d/rcS K shutdown
 tts/0::askfirst:/bin/ash --login
 ttyAMA0::askfirst:/bin/ash --login
 tty1::askfirst:/bin/ash --login
___
openwrt-devel mailing

Re: [OpenWrt-Devel] WarpComm TK71 Port

[OpenWrt-Devel] use shutdown instead of stop when the system goes down

[OpenWrt-Devel] [PATCH] update package triggerhappy to version 0.3.0-1

[OpenWrt-Devel] [PATCH] asterisk 1.8.x

Re: [OpenWrt-Devel] use shutdown instead of stop when the system goes down

5 matches

Site Navigation

Mail list logo

Footer information