Re: [OpenWrt-Devel] [PATCH] wpa_supplicant: set regulatory domain the same way as hostapd

On 2015-12-23 12:12, Dmitry Ivanov wrote: > In sta-only configuration, wpa_supplicant needs correct regulatory > domain because otherwise it may skip channel of its AP during scan. > > Another alternative is to fix "iw reg set" in mac80211 netifd script. > Currently it fails if some phy has

[OpenWrt-Devel] [PATCH v1] kernel: make kmod-thermal dependency conditional to match upstream kernel module configuration dependency for hwmon-pwmfan

Signed-off-by: Sebastian Careba --- package/kernel/linux/modules/hwmon.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/kernel/linux/modules/hwmon.mk b/package/kernel/linux/modules/hwmon.mk index ca0ff66..26bfc00 100644 ---

[OpenWrt-Devel] [PATCH v1] kernel: make kmod-thermal dependency conditional to match upstream kernel module configuration dependency for hwmon-pwmfan

Signed-off-by: Sebastian Careba --- package/kernel/linux/modules/hwmon.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/kernel/linux/modules/hwmon.mk b/package/kernel/linux/modules/hwmon.mk index ca0ff66..26bfc00 100644 ---

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

On 12/23/2015 08:54 AM, Daniel Dickinson wrote: > On 23/12/15 02:44 AM, Heinrich Schuchardt wrote: >> Hello Daniel, >> >> my TP-LINK MR3020 (AR71XX, OpenWrt 15.05) uses /dev/ttyATH0 as serial >> console . >> >> I could not find this device in the getty commands of the inittab that >> you create in

[OpenWrt-Devel] [PATCH v2] wpa_supplicant: set regulatory domain the same way as hostapd

In sta-only configuration, wpa_supplicant needs correct regulatory domain because otherwise it may skip channel of its AP during scan. Another alternative is to fix "iw reg set" in mac80211 netifd script. Currently it fails if some phy has private regulatory domain which matches configured one.

[OpenWrt-Devel] [PATCH] package/lldpd: Remove extraneous select

From: Daniel Dickinson Only the conditional dependency ought to be required; if build fails with JSON there is some other problem at work. Signed-off-by: Daniel Dickinson --- package/network/services/lldpd/Config.in | 1 - 1 file

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

Hi Daniel, On Wed, 23 Dec 2015 07:58:59 +0100, Daniel Dickinson wrote: I am reworking this (requiring console login) as couple of packages for the packages feed, although it may require an image.mk or packages Makefile hook in order to embed an appropriate

Re: [OpenWrt-Devel] [PATCH 2/3] initial support for TP-Link Archer C2600

Hi, could you please resend the patches with the following changes * prefix each one with "ipq806x: " * dont copy paste the same subject for all 3 patches but describe what is in the patch please. John On 17/12/2015 13:35, Josh Bendavid wrote: > The device tree file is similar to the

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

On 2015-12-23 16:27, Bastian Bittorf wrote: > * Imre Kaloz [23.12.2015 16:22]: >> >I'd hate to have some corner case result in bricked routers for >> >people who have no means of recovering from a bad flash. >> >> You can reflash from the bootloader all the time, we are

Re: [OpenWrt-Devel] [Patch] ipq806x: add support for Netgear D7800

Hi John, Please check the content of the patch below. -- Index: trunk/target/linux/ipq806x/image/Makefile === --- trunk/target/linux/ipq806x/image/Makefile (revision 47890) +++

Re: [OpenWrt-Devel] [Patch] ipq806x: add support for Netgear D7800

nope that did not work properly. please consider using git to send the patch --> https://patchwork.ozlabs.org/patch/560543/ On 23/12/2015 14:12, Tathagata Das wrote: > Hi John, > > Please check the content of the patch below. > > > -- > Index:

Re: [OpenWrt-Devel] [Patch] ipq806x: add support for Netgear D7800

On Wed, 23 Dec 2015 14:12:00 +0100, Tathagata Das wrote: - r7500) + r7500 |\ + d7800) nand_do_platform_check $board $1 return $?; ;; @@ -21,7 +22,8 @@ case "$board" in AP148 |\ -

Re: [OpenWrt-Devel] [Patch] ipq806x: add support for Netgear D7800

Hi, you sent the patch as an attachment. because of this patchwork did not pick it up. could you please resend with the patch inline rather than attached. John On 14/12/2015 10:37, Tathagata Das wrote: > Add support for the Netgear D7800 and build appropariate sysupgrade and > factory

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

On 2015-12-16 15:59, open...@daniel.thecshore.com wrote: > From: Daniel Dickinson > > Some devices like generic PC's and Raspberry Pi/Pi2 are much more trivial to > get hardware console access than a typical router scenario and therefore > really > ought to require

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

* Imre Kaloz [23.12.2015 16:22]: > >I'd hate to have some corner case result in bricked routers for > >people who have no means of recovering from a bad flash. > > You can reflash from the bootloader all the time, we are talking > about userland here. IMHO this should be just

[OpenWrt-Devel] [PATCH 07/12] lantiq: define default leds in dts files

- ARV7525PW: use the power led as dsl led as done by the stock firmware - FRITZ3370: use the info led as internet led - FRITZ7320: use the power led as dsl led as done by the stock firmware Signed-off-by: Mathias Kresin --- target/linux/lantiq/dts/ARV4510PW.dts | 24

[OpenWrt-Devel] [PATCH 08/12] lantiq: use default leds defined in DTS

Remove all now double defined leds from the led board file. Use pppoe as default for all broadband connections, since it's the default in OpenWrt now. Rename the the wifi leds to make sure, the not applicable default values get overwritten. Signed-off-by: Mathias Kresin ---

[OpenWrt-Devel] [PATCH 11/12] lantiq: add support for indicating the boot state using three leds

The BTHOMEHUBV5A has a RGB power led, where every colour is perfect to indicate the current boot state. This patch adds support for such cases. The existing led sequences should be the same as before. Boards which are using a led different from power (like TDW89x0) are changed to switch of the

[OpenWrt-Devel] [PATCH 01/12] lantiq: P2812HNUFX - move leds to dtsi

Beside the used labels, they are the same on both boards. Signed-off-by: Mathias Kresin --- target/linux/lantiq/dts/P2812HNUF1.dts | 61 - target/linux/lantiq/dts/P2812HNUF3.dts | 53

[OpenWrt-Devel] [PATCH 05/12] lantiq: ARV752DPW22 - fix dts file

No need to switch (and keep) on all leds at boot. Use the same led logic and labels as the OEM firmware (red = okay, blue = failure). Add the red internet led. Signed-off-by: Mathias Kresin --- target/linux/lantiq/dts/ARV752DPW22.dts | 34 - 1

[OpenWrt-Devel] [PATCH 04/12] lantiq: DGN1000B - fix typo in dts file

Signed-off-by: Mathias Kresin --- target/linux/lantiq/dts/DGN1000B.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/lantiq/dts/DGN1000B.dts b/target/linux/lantiq/dts/DGN1000B.dts index 4ccab93..199d3a9 100644 ---

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

* Daniel Curran-Dickinson [23.12.2015 17:27]: > I'm implementing without mount_root - that means passwordless > failsafe unless user has preconfigured passwords in their image. > OTOH if they have configured passwords in their image then they will > be required. ok,

[OpenWrt-Devel] [PATCH] lantiq: fix Image Builder

Signed-off-by: Mathias Kresin --- target/linux/lantiq/image/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/linux/lantiq/image/Makefile b/target/linux/lantiq/image/Makefile index 686cb6d..553bdc1 100644 ---

[OpenWrt-Devel] [PATCH 00/12] lantiq: switch to devicename:colour:function naming scheme

I chose to use Device Tree Source files to define some common used leds. This way it's possible to prevent the bloating (as it can be seen on other tragets) of the led board.d file as well as the diag.sh file. No need to carry dozen of - unrelated - board specific led definitions with each board.

[OpenWrt-Devel] [PATCH 12/12] lantiq: use soc:colour:function led naming scheme

The leds of the following boards are not renamed due to lack of manuals/informations: - ARV7519PW - ARV7510PW22 - ARV4510PW The leds of the ARV4518PWR01* boards are unchanged, since the leds doesn't match the leds from the manual or pictures (e.g. there shouldn't be a wps led). Signed-off-by:

[OpenWrt-Devel] [PATCH] lantiq: ltq-adsl-mei: fix typo

Signed-off-by: Mathias Kresin --- package/kernel/lantiq/ltq-adsl-mei/patches/100_no-date-time.patch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/kernel/lantiq/ltq-adsl-mei/patches/100_no-date-time.patch

[OpenWrt-Devel] [PATCH 09/12] lantiq: use power leds defined in DTS

Use the power leds defined in the dts file instead of hardcoded led names. Signed-off-by: Mathias Kresin --- target/linux/lantiq/base-files/etc/diag.sh | 34 +- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git

[OpenWrt-Devel] [PATCH 06/12] lantiq: ARV752DPW - fix dts file

Use the same led logic and labels as the OEM firmware (red = okay, blue = failure). Add the red internet led. Remove missing usb led workaround. The workaround shouldn't be in the default configuration. Signed-off-by: Mathias Kresin --- target/linux/lantiq/dts/ARV752DPW.dts

[OpenWrt-Devel] [PATCH 10/12] lantiq: use dsl led defined in DTS

dsl_control (dsl_notify.sh) is the only process which is aware of the state of the atm/ptm interface. Use the dsl led exclusive for the dsl line state. On boards which don't have a distinct internet and a dsl led, let the netdev status of the atm interface trigger the shared led. Triggering the

[OpenWrt-Devel] [PATCH] lantiq: TDW89x0 - increase spi frequency

Use the same max spi frequency as set in u-boot. According to the datasheets, the Q64-104HIP as well as the Winbond 25Q64FVSIG support spi frequencies up to 50 MHz. During my tests, the Q64-104HIP couldn't be recognized/initialized if the frequency was > 40MHz. Both chips do support fast read as

[OpenWrt-Devel] [PATCH 03/12] lantiq: ARV4518PWR01* move redundant parts to dtsi

Signed-off-by: Mathias Kresin --- target/linux/lantiq/dts/ARV4518PWR01.dts | 179 + target/linux/lantiq/dts/ARV4518PWR01.dtsi | 184 ++ target/linux/lantiq/dts/ARV4518PWR01A.dts | 179 + 3

[OpenWrt-Devel] [PATCH 02/12] lantiq: BTHOMEHUBV2B - remove missing usb led workaround

The workaround shouldn't be in the default configuration. Signed-off-by: Mathias Kresin --- target/linux/lantiq/base-files/etc/board.d/01_leds | 1 - 1 file changed, 1 deletion(-) diff --git a/target/linux/lantiq/base-files/etc/board.d/01_leds

[OpenWrt-Devel] [PATCH] lantiq: fix PCI_DEVICE_ID_LANTIQ_PCIE

It's not necessary to define PCI_* if pci_ids.h is included a few lines above. The change to pci_ids.h doesn't look intentional to me, especially since the former value is added to the top of ifxmips_fixup_pcie.c. Both changes were introduced with the kernel 4.1 support patches and were not

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

On 2015-12-24 00:38, Imre Kaloz wrote: > On Wed, 23 Dec 2015 17:27:37 +0100, Felix Fietkau wrote: > >> On 2015-12-23 16:27, Bastian Bittorf wrote: >>> * Imre Kaloz [23.12.2015 16:22]: >I'd hate to have some corner case result in bricked routers for

[OpenWrt-Devel] [PATCH] Update iproute2 to 4.3.0

iproute2-4.0 had connmark support added by nbd. This does not work with 4.x kernels. iproute2-4.3 is the latest version and has his changes mainlined. This patch updates the package to iproute2-4.3 and fixes the patches so that it compiles. This should resolve ticket #21374. Signed-off-by:

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

On 23/12/15 06:49 PM, Felix Fietkau wrote: On 2015-12-24 00:38, Imre Kaloz wrote: On Wed, 23 Dec 2015 17:27:37 +0100, Felix Fietkau wrote: On 2015-12-23 16:27, Bastian Bittorf wrote: * Imre Kaloz [23.12.2015 16:22]: I'd hate to have some corner case

[OpenWrt-Devel] [PATCH] ar71xx : Add Support for the Bitmain Antrouter R1

This patch adds support for the Bitmain Antrouter R! http://wiki.openwrt.org/toh/bitmain/r1 Signed-off-by: L. D. Pinney --- target/linux/ar71xx/base-files/etc/board.d/01_leds| 5 + target/linux/ar71xx/base-files/etc/board.d/02_network | 1 +

[OpenWrt-Devel] [PATCH] V2 ar71xx : Add Support for the Bitmain Antrouter R1

This patch adds support for the Bitmain Antrouter R1 http://wiki.openwrt.org/toh/bitmain/r1 Signed-off-by: L. D. Pinney --- V2 Corrects naming errors in Profile in V1 target/linux/ar71xx/base-files/etc/board.d/01_leds| 5 +

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

On Wed, 23 Dec 2015 17:27:37 +0100, Felix Fietkau wrote: On 2015-12-23 16:27, Bastian Bittorf wrote: * Imre Kaloz [23.12.2015 16:22]: >I'd hate to have some corner case result in bricked routers for >people who have no means of recovering from a bad

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

On Wed, 23 Dec 2015 17:32:06 +0100, Bastian Bittorf wrote: * Daniel Curran-Dickinson [23.12.2015 17:27]: I'm implementing without mount_root - that means passwordless failsafe unless user has preconfigured passwords in their image. OTOH

Re: [OpenWrt-Devel] [PATCH v2] lantiq: fall back to a more appropriate default dsl firmware

Hi, does not apply any more. please rebase ! John On 19/12/2015 08:50, Andre Heider wrote: > Hi, > > On Fri, Dec 11, 2015 at 10:36 AM, John Crispin wrote: >>> @@ -69,11 +72,12 @@ start_service() { >>> eval "xtse_adsl=\"\${xtse_adsl_$annex}\"" >>> if [

Re: [OpenWrt-Devel] [PATCH] base-files image: Require login even on console (including failsafe)

I just noticed why failsafe was mounting root - I accidentally deleted the failsafe lock which blocks until login session is complete. Fixing now. On 24/12/15 01:31 AM, open...@daniel.thecshore.com wrote: From: Daniel Dickinson Passwordless root login is

[OpenWrt-Devel] [PATCH] add support for WRTnode2P and WRTnode2R

Hi blogic this is a patch is add WRTnode2P and WRTnode2R support by OpenWrt commit d0f7a56ed622a488926bb1705686b950dea34cce Author: xzmu Date: Thu Dec 24 15:30:07 2015 +0800 add support for WRTnode2P and WRTnode2R add led indicator support for WRTnode platform diff

[OpenWrt-Devel] [PATCH] base-files image: Require login even on console (including failsafe)

From: Daniel Dickinson Passwordless root login is undesirable by default on any platform, therefore make requiring a login to gain root (or any other user) even on hardware console the default. This is an opt-out option that can by disabled at image generation time

[OpenWrt-Devel] pre-Xmas bonus security patch

Hi all, The following patch is a much better implementation of the previous patch for requiring login even on hardware console. As per discussion on list, this patch would become the default behaviour for all images, but does have an opt-out which can be set at image generation time or in the

[OpenWrt-Devel] Failsafe is not mounting root

Hi all, I just thought I'd try to head of some confusion I may have caused because I thought failsafe was mounting root. The actual issue is that when I modified failsafe I accidentally delete the line that creates a lockfile that causes boot process to block when failsafe is entered (so

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

On 23/12/2015 13:05, Imre Kaloz wrote: > Hi Daniel, > > On Wed, 23 Dec 2015 07:58:59 +0100, Daniel Dickinson > wrote: > >> I am reworking this (requiring console login) as couple of packages >> for the packages feed, although it may require an image.mk or

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

Actually once root password is set is unncessary. Busybox login with no password set allows passwordless login, so there is no issue. Regards, Daniel On 23/12/15 07:24 AM, John Crispin wrote: On 23/12/2015 13:05, Imre Kaloz wrote: Hi Daniel, On Wed, 23 Dec 2015 07:58:59 +0100, Daniel

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

Hi Imre, Thanks for this! This indeed would be my preference, I just thought there wouldn't be any appetite for it on the grounds I mentioned. Before I work up a version of the patch that isn't as desirable from a security perspective, I have another concept that ought to solve the ar71xx

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

I'm inclined to make the opt-out an image generation time decision rather than configurable on the overlayfs for what I think are obvious reasons. Regards, Daniel On 23/12/15 07:24 AM, John Crispin wrote: On 23/12/2015 13:05, Imre Kaloz wrote: Hi Daniel, On Wed, 23 Dec 2015 07:58:59

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

On 23/12/2015 13:32, Daniel Dickinson wrote: > I'm inclined to make the opt-out an image generation time decision > rather than configurable on the overlayfs for what I think are obvious > reasons. yep, that would be the best choice. > > Regards, > > Daniel > > On 23/12/15 07:24 AM, John

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

Oh, and I think that initially this should be default off configuration option that people who are able to flash firmware via bootloader in case of getting locked out encourage to test before pushing this as default. I'd hate to have some corner case result in bricked routers for people who

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

On Wed, 23 Dec 2015 13:43:14 +0100, Daniel Dickinson wrote: Oh, and I think that initially this should be default off configuration option that people who are able to flash firmware via bootloader in case of getting locked out encourage to test before pushing

[OpenWrt-Devel] [PATCH 1/2] ledtrig-netdev: switch rwlock to spinlock

Read/write lock was adding useless complexity, there wasn't any real gain in case of this driver. Also switch to _bh variants to avoid deadlocks. Signed-off-by: Rafał Miłecki --- .../generic/files/drivers/leds/ledtrig-netdev.c| 40 +++--- 1 file changed, 20

[OpenWrt-Devel] [PATCH 2/2] ledtrig-netdev: drop locking from timer callback function

We may just delete timer on every trigger update and then start it again if needed. This will let us avoid both: races and locking in frequently called timer callback. Signed-off-by: Rafał Miłecki --- .../generic/files/drivers/leds/ledtrig-netdev.c| 24

[OpenWrt-Devel] [PATCH] wpa_supplicant: set regulatory domain the same way as hostapd

In sta-only configuration, wpa_supplicant needs correct regulatory domain because otherwise it may skip channel of its AP during scan. Another alternative is to fix "iw reg set" in mac80211 netifd script. Currently it fails if some phy has private regulatory domain which matches configured one.

Re: [OpenWrt-Devel] [PATCH] config: Add option to make crypto default when there is an config option for it

Erg, reversed the texts of the commit and the comment. Will resend so the commit message actually makes sense (but not tonight likely). Regards, Daniel On 23/12/15 03:16 AM, open...@daniel.thecshore.com wrote: From: Daniel Dickinson This patch it mostly for

Re: [OpenWrt-Devel] Why default of XATTR in kernel but not userspace?

Hi Daniel, When I added attr and acl initially, I enabled xattr and acl support for filesystems, but then that part was removed, possibly because dependency logic didn't conform standards (just in case, I'm not blaming anyone, that was one of my first patches submitted), see

[OpenWrt-Devel] [PATCH] config: Add option to make crypto default when there is an config option for it

From: Daniel Dickinson This patch it mostly for SDK builds since base packages seem to all have PolarSSL support as an option and but there are packages in the feeds that have the property of offering a configuration option for building with or without crypto

[OpenWrt-Devel] [PATCH Note] Explaination of config option to make crypto default

The patch listed below which will be in a separate email (so this isn't in the commit message) was created for a similar reason to CONFIG_ALL - to create a single config option that saves doing a lot of individual configuration settings. In particular the config option this creates is intended to