12/11/20 7:44 PM, Andre Heider:
On 11/12/2020 18:59, Mathias Kresin wrote:
12/11/20 1:05 PM, Andre Heider:
Shut up these warnings:
/usr/include/vdsl/cmv_message_format.h:33:6: warning:
"MEI_SUPPORT_DEBUG_STREAMS" is not defined, evaluates to 0 [-Wundef]
#if (MEI_SUPPORT_DEBUG_STREAMS ==
On 11/12/2020 19:44, Andre Heider wrote:
On 11/12/2020 18:59, Mathias Kresin wrote:
12/11/20 1:05 PM, Andre Heider:
Shut up these warnings:
/usr/include/vdsl/cmv_message_format.h:33:6: warning:
"MEI_SUPPORT_DEBUG_STREAMS" is not defined, evaluates to 0 [-Wundef]
#if
On 11/12/2020 18:59, Mathias Kresin wrote:
12/11/20 1:05 PM, Andre Heider:
Shut up these warnings:
/usr/include/vdsl/cmv_message_format.h:33:6: warning:
"MEI_SUPPORT_DEBUG_STREAMS" is not defined, evaluates to 0 [-Wundef]
#if (MEI_SUPPORT_DEBUG_STREAMS == 1)
12/11/20 1:05 PM, Andre Heider:
Shut up these warnings:
/usr/include/vdsl/cmv_message_format.h:33:6: warning:
"MEI_SUPPORT_DEBUG_STREAMS" is not defined, evaluates to 0 [-Wundef]
#if (MEI_SUPPORT_DEBUG_STREAMS == 1)
^
On 11/12/2020 13:05, Andre Heider wrote:
The ltq-vdsl-app changes are only compile time tested.
erm, *ltq-adsl-app* is only compile time tested.
ltq-vdsl-app is what I'm using, and it works pretty well for me ;)
___
openwrt-devel mailing list
On 11/12/2020 13:11, Jo-Philipp Wich wrote:
Hi,
This is significantly faster.
great work! I like it :)
Minor nitpick below.
[...]
-var callLuciDSLStatus = rpc.declare({
- object: 'luci-rpc',
- method: 'getDSLStatus',
+var call_dsl_metrics = rpc.declare({
+ object:
On 04/12/2020 13:25, Andre Heider wrote:
Hi,
On 04/12/2020 13:03, Jo-Philipp Wich wrote:
Hi,
is there any reason not to use the flock style below? It should be more
reliable wrt. unlocking if the script is prematurely terminated.
I guess because it gets more difficult to fish out the answer
Hi,
> This is significantly faster.
great work! I like it :)
Minor nitpick below.
> [...]
> -var callLuciDSLStatus = rpc.declare({
> - object: 'luci-rpc',
> - method: 'getDSLStatus',
> +var call_dsl_metrics = rpc.declare({
> + object: 'dsl',
> + method: 'metrics',
>
Just for the record. This release fixes CVE-2020-1971
https://www.openssl.org/news/secadv/20201208.txt
J.P.
Dne 11. 12. 20 v 12:39 Eneas U de Queiroz napsal(a):
> Fixes: CVE-2020-1971, defined as high severity, summarized as:
> NULL pointer deref in GENERAL_NAME_cmp function can lead to a DOS
>
All users have been converted to ubus.
Signed-off-by: Andre Heider
---
.../files/lib/functions/lantiq_dsl.sh | 749 --
1 file changed, 749 deletions(-)
delete mode 100755
package/network/utils/ltq-dsl-base/files/lib/functions/lantiq_dsl.sh
diff --git
This is significantly faster.
Signed-off-by: Andre Heider
---
.../resources/view/status/include/50_dsl.js | 55 +--
.../usr/share/rpcd/acl.d/luci-mod-status.json | 2 +-
2 files changed, 28 insertions(+), 29 deletions(-)
diff --git
As with ltq-vdsl-app, see previous commit.
Signed-off-by: Andre Heider
---
package/network/config/ltq-adsl-app/Makefile | 2 +-
.../ltq-adsl-app/patches/300-ubus.patch | 50 +++
package/network/config/ltq-adsl-app/src | 1 +
3 files changed, 52 insertions(+), 1
Add a 'dsl' ubus object with a 'metrics' function to replace the
expensive shell parsing done by /etc/init.d/dsl_control [dsl|luci]stat.
All metrics are gathered by using syscalls. An additional thread is started
to handle ubus events.
$ time /etc/init.d/dsl_control dslstat
real0m 2.66s
user
This is significantly faster.
Signed-off-by: Andre Heider
---
.../lib/lua/prometheus-collectors/ltq-dsl.lua | 108 --
1 file changed, 47 insertions(+), 61 deletions(-)
diff --git
a/utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/ltq-dsl.lua
Signed-off-by: Andre Heider
---
package/network/config/ltq-vdsl-app/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/network/config/ltq-vdsl-app/Makefile
b/package/network/config/ltq-vdsl-app/Makefile
index 5a84ea8e7e..48aa6b70c8 100644
---
Signed-off-by: Andre Heider
---
package/network/config/ltq-adsl-app/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/network/config/ltq-adsl-app/Makefile
b/package/network/config/ltq-adsl-app/Makefile
index e03c0911a5..317f8a908a 100644
---
luci now uses ubus directly, so remove 'lucistat'.
For manual usage just print the ubus output, use luci for a pretty
version.
Signed-off-by: Andre Heider
---
package/network/config/ltq-vdsl-app/files/dsl_control | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
procd sends sigterm to stop daemons, hook it up.
This speeds up the shutdown sequence and gets rid of the following message:
daemon.info procd: Instance dsl_control::instance1 pid 15408 not stopped on
SIGTERM, sending SIGKILL instead
Signed-off-by: Andre Heider
---
Shut up these warnings:
/usr/include/vdsl/cmv_message_format.h:33:6: warning:
"MEI_SUPPORT_DEBUG_STREAMS" is not defined, evaluates to 0 [-Wundef]
#if (MEI_SUPPORT_DEBUG_STREAMS == 1)
^
/usr/include/vdsl/drv_mei_cpe_interface.h:2256:6: warning:
This is to significantly speed up the generation of the metrics.
The motivation comes from the fact that ~2.6s is just way too
ineffcient for interval based metric collectors like prometheus or
collectd.
The luci status page also loads/refreshes alot faster.
$ time /etc/init.d/dsl_control
luci now uses ubus directly, so remove 'lucistat'.
For manual usage just print the ubus output, use luci for a pretty
version.
Signed-off-by: Andre Heider
---
package/network/config/ltq-adsl-app/files/dsl_control | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
Good riddance.
Signed-off-by: Andre Heider
---
libs/rpcd-mod-luci/src/luci.c | 55 ---
1 file changed, 55 deletions(-)
diff --git a/libs/rpcd-mod-luci/src/luci.c b/libs/rpcd-mod-luci/src/luci.c
index 94ccdf271..abf4b9ba5 100644
---
Signed-off-by: Andre Heider
---
package/network/utils/ltq-dsl-base/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/network/utils/ltq-dsl-base/Makefile
b/package/network/utils/ltq-dsl-base/Makefile
index e2cfc4004c..aae07bc299 100644
---
On 11.12.20 09:30, Bjørn Mork wrote:
John Crispin writes:
iff --git a/package/network/services/lldpd/files/lldpd.init
b/package/network/services/lldpd/files/lldpd.init
index 7a5b25e016..8200556786 100644
--- a/package/network/services/lldpd/files/lldpd.init
+++
On 11.12.20 09:30, Bjørn Mork wrote:
John Crispin writes:
iff --git a/package/network/services/lldpd/files/lldpd.init
b/package/network/services/lldpd/files/lldpd.init
index 7a5b25e016..8200556786 100644
--- a/package/network/services/lldpd/files/lldpd.init
+++
Fixes: CVE-2020-1971, defined as high severity, summarized as:
NULL pointer deref in GENERAL_NAME_cmp function can lead to a DOS
attack.
Signed-off-by: Eneas U de Queiroz
---
This was run-tested in a WRT-3200ACM
diff --git a/package/libs/openssl/Makefile b/package/libs/openssl/Makefile
index
John Crispin writes:
> iff --git a/package/network/services/lldpd/files/lldpd.init
> b/package/network/services/lldpd/files/lldpd.init
> index 7a5b25e016..8200556786 100644
> --- a/package/network/services/lldpd/files/lldpd.init
> +++ b/package/network/services/lldpd/files/lldpd.init
> @@ -10,6
27 matches
Mail list logo
