[PATCH v2] libmnl: fix build when bash is not located at /bin/bash

[Mark Mentovai]

This fixes the libmnl build on macOS, which ships with an outdated bash
at /bin/bash. During the OpenWrt build, a modern host bash is built and
made available at staging_dir/host/bin/bash, which is present before
/bin/bash in the build's PATH.

This is similar to 8f7ce3aa6dda, presently appearing at
package/kernel/mac80211/patches/build/001-fix_build.patch.

Signed-off-by: Mark Mentovai 
---
 package/libs/libmnl/patches/001-fix_build.patch | 11 +++
 1 file changed, 11 insertions(+)
 create mode 100644 package/libs/libmnl/patches/001-fix_build.patch

diff --git a/package/libs/libmnl/patches/001-fix_build.patch 
b/package/libs/libmnl/patches/001-fix_build.patch
new file mode 100644
index ..030020abacbe
--- /dev/null
+++ b/package/libs/libmnl/patches/001-fix_build.patch
@@ -0,0 +1,11 @@
+--- a/doxygen/Makefile.am
 b/doxygen/Makefile.am
+@@ -21,7 +21,7 @@
+ # The command has to be a single line so the functions work
+ # and so `make` gives all lines to `bash -c`
+ # (hence ";\" at the end of every line but the last).
+-  /bin/bash -p -c 'declare -A renamed_page;\
++  bash -p -c 'declare -A renamed_page;\
+ main(){ set -e; cd man/man3; rm -f _*;\
+   count_real_pages;\
+   rename_real_pages;\
-- 
2.37.0


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] libmnl: fix build when bash is not located at /bin/bash

[Mark Mentovai]

Hauke Mehrtens wrote:

On 6/21/22 16:38, Mark Mentovai wrote:

From: Mark Mentovai 

This fixes the libmnl build on macOS, which ships with an outdated bash
at /bin/bash. During the OpenWrt build, a modern host bash is built and
made available at staging_dir/host/bin/bash, which is present before
/bin/bash in the build's PATH.

This is similar to 8f7ce3aa6dda, presently appearing at
package/kernel/mac80211/patches/build/001-fix_build.patch.

Signed-off-by: Mark Mentovai 


The author email address in the From field and the Signed-off-by line do not 
match.


The rest of the patch looks ok.


That’s git-send-email trying to make a fool of me. I’ll resend as v2.___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] libmnl: fix build when bash is not located at /bin/bash

[Hauke Mehrtens]

On 6/21/22 16:38, Mark Mentovai wrote:

From: Mark Mentovai 

This fixes the libmnl build on macOS, which ships with an outdated bash
at /bin/bash. During the OpenWrt build, a modern host bash is built and
made available at staging_dir/host/bin/bash, which is present before
/bin/bash in the build's PATH.

This is similar to 8f7ce3aa6dda, presently appearing at
package/kernel/mac80211/patches/build/001-fix_build.patch.

Signed-off-by: Mark Mentovai 


The author email address in the From field and the Signed-off-by line do 
not match.


The rest of the patch looks ok.

Hauke

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[sdwalker/sdwalker.github.io] 2bacfb: This week's update

[Stephen Walker via openwrt-devel]

The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.--- Begin Message ---
  Branch: refs/heads/master
  Home:   https://github.com/sdwalker/sdwalker.github.io
  Commit: 2bacfb27f2b63bb6f834b0f045602d89ed5add8f
  
https://github.com/sdwalker/sdwalker.github.io/commit/2bacfb27f2b63bb6f834b0f045602d89ed5add8f
  Author: Stephen Walker 
  Date:   2022-07-10 (Sun, 10 Jul 2022)

  Changed paths:
M uscan/index-19.07.html
M uscan/index-21.02.html
M uscan/index.html

  Log Message:
  ---
  This week's update



--- End Message ---
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: A point against storing firmware binaries in OpenWRT git (ipq-wifi)

[Alex G.]

On 7/10/22 13:24, Christian Lamparter wrote:

Hi,

On Sun, Jul 10, 2022 at 7:30 PM Alex G.  wrote:


Hi all,

It really bothers me that the ipq-wifi firmware is stored in git as
binary files.


Sorry, this sounds like a recent topic: "Moving ipq-wifi to a dedicated repo"


what wasn't really discussed in that topic though: "Who exactly owns
these blobs?"
Technically, storing them anywhere else is a grey area... But once they hit the
linux-firmware.git repository it becomes a different story. Mostly because
this is done by Qualcomm which adds these to their libraries there under
their license.


Yes, that is the same topic. Thank you for the pointer! I am going to 
stop writing now.


Alex


Cheers,
Christian


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: A point against storing firmware binaries in OpenWRT git (ipq-wifi)

[Christian Lamparter]

Hi,

On Sun, Jul 10, 2022 at 7:30 PM Alex G.  wrote:
>
> Hi all,
>
> It really bothers me that the ipq-wifi firmware is stored in git as
> binary files.

Sorry, this sounds like a recent topic: "Moving ipq-wifi to a dedicated repo"


what wasn't really discussed in that topic though: "Who exactly owns
these blobs?"
Technically, storing them anywhere else is a grey area... But once they hit the
linux-firmware.git repository it becomes a different story. Mostly because
this is done by Qualcomm which adds these to their libraries there under
their license.

Cheers,
Christian

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

A point against storing firmware binaries in OpenWRT git (ipq-wifi)

[Alex G.]

Hi all,

It really bothers me that the ipq-wifi firmware is stored in git as 
binary files.



Binary data is useless
--

For anyone pulling down the sources to build for any target other than 
the one the firmware is for. Most source files in OpenWRT apply to a 
family of boards, and thus have broader usage. They are also much 
smaller in size than binaries.




Only ipq-wifi does this
---

The other firmware packages are not stored in git. This sort of 
inconsistency is, well, inconsistent.



Upcoming ipq807x target
---

Let's talk about the elephant in the room -- the ipq807x target that's 
getting close to being ready for OpwnWRT upstream. This target will add 
a ton of firmware files to the ipq-wifi package. Each board needs at 
least a 128 KiB binary file. This quickly adds to megabytes of useless data.


Also, these firmware files are not immutable. They do change as 
manufacturers roll out updates.



Increase in repository size
---

Continuing to allow this sort of binary inclusion will lead to 
unnecessary bloat.



Proposal


I propose that storing binaries in the main OpenWRT git be off-limits 
going forward.

 1. Move the ipq-wifi firmware binaries out of the main OpwnWRT git
 2. Store them either as as direct downloads or
 3. Store them in a separate and new git repo

Point (3) seems to contradict all the arguments I"ve just made. First, 
I'm referring to the main OpenWRT repo. All the points still apply for 
any board or target not requiring ipq-wifi.
Second, if the "new" repo becomes too bloated, it can be fixed with git 
filter-repo, and would only requirea change of the PKG_SOURCE_VERSION in 
the change in the OpenWRT makefile .


Alex

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel