Re: [PATCH] bcm53xx: Unconditionally build U-Boot for DIR-890L
On Tue, Sep 5, 2023 at 10:27 AM Arınç ÜNAL wrote: > To make it clear, what needs fixing is making OpenWrt SDK not compile an > image for the devices that are not selected on menuconfig. You're right it does, that's really weird! The BMIPS target doesn't behave like this at all. Yours, Linus Walleij ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH] bcm53xx: Unconditionally build U-Boot for DIR-890L
On Mon, 4 Sept 2023 at 23:00, Linus Walleij wrote: > > On Mon, Sep 4, 2023 at 12:03 PM Rafał Miłecki wrote: > > > I don't see anything incorrect with Linus's original patch. Maybe we > > just have some dependency handling issue in u-boot generic .mk code? > > I have transient problem with the dependencies at times, then > I just chose another target (entirely different!) in menuconfig and > then back to the intended target. Problem fixed, dependency > selected. It feels a bit shaky though, but usually all autobuilds > work fine. You might want to set HIDDEN for the u-boot packages. Then they aren't a user selectable package (config symbol) anymore, and their selection state will follow the defaults automatically. Should avoid the u-boot packages (not) being built/selected when changing the device. Best Regards, Jonas ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH] bcm53xx: Unconditionally build U-Boot for DIR-890L
On 4.09.2023 23:58, Linus Walleij wrote: On Mon, Sep 4, 2023 at 12:03 PM Rafał Miłecki wrote: I don't see anything incorrect with Linus's original patch. Maybe we just have some dependency handling issue in u-boot generic .mk code? I have transient problem with the dependencies at times, then I just chose another target (entirely different!) in menuconfig and then back to the intended target. Problem fixed, dependency selected. It feels a bit shaky though, but usually all autobuilds work fine. Perhaps I wasn't clear enough to explain the issue. As Rafał has already said, there's nothing wrong with enabling the package when DIR-890L is selected as the device. The problem is when another device is selected. OpenWrt SDK shouldn't compile an image for the devices that are not selected on menuconfig. Yet it does anyway. This is the first time on the bcm53xx target that compiling the image for a device requires a package to be built first. This has exposed an underlying issue. When a device that is not DIR-890L is selected, the u-boot package won't be enabled. An image for DIR-890L will be attempted to be compiled which will fail because the u-boot package is not enabled. To make it clear, what needs fixing is making OpenWrt SDK not compile an image for the devices that are not selected on menuconfig. I don't know GNU Make very well to figure out why this happens on the bcm53xx target. I don't see this happening on the mt7621 subtarget of the ramips target. Arınç ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
