Re: [OpenWrt-Devel] [PATCH libubox] json_script: enable custom expr handler callback

2017-05-18 Thread Denis Osvald
On 2017-05-18 09:39, Denis Osvald wrote: > This wires in custom expression handler functionality, which was > present in json script since the original version, but never used. To add a bit of context: Experimenting with procd service triggers, it was noticed that when adding tr

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH ubus 0/3] ubusd: fix ACL checking

2016-09-21 Thread Denis Osvald
On 2016-09-05 14:00, Felix Fietkau wrote: > On 2016-09-05 10:21, Denis Osvald wrote: >> Ping? > I've applied patch 1 and 3. I need more time to properly review patch 2. > > - Felix > Any news? If there was a working case which the patch breaks, please point it out so

Re: [OpenWrt-Devel] [PATCH ubus 0/3] ubusd: fix ACL checking

2016-09-05 Thread Denis Osvald
Ping? On 2016-08-25 13:54, Denis Osvald wrote: > Denis Osvald (3): > ubusd: don't check ACL when object is NULL > ubusd: fallback to linear search on ACLs to fix wildcards > ubusd: fix inverted check in ubusd_reply_add > > ubusd_acl.c | 20 +--- &g

[OpenWrt-Devel] [PATCH ubus 3/3] ubusd: fix inverted check in ubusd_reply_add

2016-08-25 Thread Denis Osvald
Signed-off-by: Denis Osvald <denis.osv...@sartura.hr> --- ubusd_acl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ubusd_acl.c b/ubusd_acl.c index 2db515e..0028431 100644 --- a/ubusd_acl.c +++ b/ubusd_acl.c @@ -432,7 +432,7 @@ ubusd_reply_add(struct ubus_objec

[OpenWrt-Devel] [PATCH ubus 2/3] ubusd: fallback to linear search on ACLs to fix wildcards

2016-08-25 Thread Denis Osvald
yz", then object "foo.xyz" is matched by first and third rules which can't be consecutive in any sorting order. Also, this makes the ACL searching loops logically same as in rpcd, with the same quirk that "net*" won't match "net", effectively making '*' repr

[OpenWrt-Devel] [PATCH ubus 1/3] ubusd: don't check ACL when object is NULL

2016-08-25 Thread Denis Osvald
such NULL objects. Signed-off-by: Denis Osvald <denis.osv...@sartura.hr> --- ubusd_acl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ubusd_acl.c b/ubusd_acl.c index 85ada5d..2700c86 100644 --- a/ubusd_acl.c +++ b/ubusd_acl.c @@ -101,7 +101,7 @@ ubusd_acl_check(struct

[OpenWrt-Devel] [PATCH ubus 0/3] ubusd: fix ACL checking

2016-08-25 Thread Denis Osvald
Denis Osvald (3): ubusd: don't check ACL when object is NULL ubusd: fallback to linear search on ACLs to fix wildcards ubusd: fix inverted check in ubusd_reply_add ubusd_acl.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) -- 2.9.3

[OpenWrt-Devel] [PATCH] [rpcd] iwinfo: zero out ccode buffer since library doesn't

2016-06-02 Thread Denis Osvald
oesn't happen anymore. Signed-off-by: Denis Osvald <denis.osv...@sartura.hr> --- iwinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iwinfo.c b/iwinfo.c index 325c07a..b24d0f5 100644 --- a/iwinfo.c +++ b/iwinfo.c @@ -588,7 +588,7 @@ rpc_iwinfo_countrylist(struct ub