Re: WDS stopped working in 21.02, looking for bug in netifd

2021-09-20 Thread Felix Fietkau
On 2021-09-20 16:46, Daniel Haid wrote: > I have continued investigating. > > After all, it seems that the interface being down is just a symptom. > > I summarize my current findings: > > With the 21.02 netifd version, there seems to be a bug concerting WDS. > The bug has the following effect:

Re: Broken ARP broadcast on master (commit 0f688797)

2021-09-06 Thread Felix Fietkau
> On 6. Sep 2021, at 02:03, David Bauer wrote: > > Hi Felix, > > updating my Wireless APs (ath9k+ath10k / mt7603+mt7915) broke ARP broadcast > delivery to clients > connected to the radios with SW rate control. > > Bisecting this problem revealed commit 0f688797 ("mac80211: add missing >

Re: [PATCH] Revert "initd: fix off-by-one error in mkdev.c"

2021-08-31 Thread Felix Fietkau
On 2021-08-31 10:25, vinc...@systemli.org wrote: > From: Nick Hainke > > This reverts commit 8eb1d783cca6e0d501dd3a2f94262ffc36ae6482. > > This line reads a symbolic link into the string buffer "buf". > len = readlink(buf2, buf, sizeof(buf)); > The commit replaced now > buf[len] =

Re: [PATCH] uhttpd: add config option for json_script

2021-08-24 Thread Felix Fietkau
not possible as it would render all other uhttpd > instances unusable. > > Signed-off-by: Stijn Tintel Acked-by: Felix Fietkau ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH 21.02] Revert "netifd: update to the latest version"

2021-07-26 Thread Felix Fietkau
On 2021-07-26 17:09, Petr Štetiar wrote: > Petr Štetiar [2021-07-26 17:01:32]: > >> This reverts commit 089efd61e9a6cdc0ea39c184d37bc8ebbe03175c as it >> breaks LAN network on at least mvebu/turris-omnia device. >> >> Confirmed-by: Josef Schlehofer >> Signed-off-by: Petr Štetiar >> --- >> >>

Re: OpenWrt 21.02 status

2021-07-17 Thread Felix Fietkau
On 2021-07-17 17:45, Hauke Mehrtens wrote: > Hi, > > In general the 21.02-rc3 looks good, but we still have some problems. > > Currently we still have these problem: > > - IPv6 broken with flow offloading (according to reports, potentially > related to hw flow offloading) > - PPPoE allegedly

Re: [PATCH] ubus: add a private field to event handlers

2021-07-14 Thread Felix Fietkau
On 2021-07-13 13:57, louis_hamp...@sercomm.com wrote: > > This is particularly useful in multithreaded non-C FFI, where > additional context from where the event handler was registered may be > critical to ensuring the output of the event is sent to the right > location. > > Signed-off-by: Louis

Re: wrong activation of internal radius server

2021-06-04 Thread Felix Fietkau
Hi Hartmut, On 2021-06-04 15:22, e9hack wrote: > OpenWrt has been supporting hostapd's internal radius server for a few days. > For several years there has been a line in the init-script that activates the > internal radius server too. I think this is wrong (from hostapd.sh): > > [ -n

Re: [PATCH V2 netifd] interface: rename "ifname" attribute to "device"

2021-05-25 Thread Felix Fietkau
On 2021-05-24 15:35, Rafał Miłecki wrote: > From: Rafał Miłecki > > Interfaces need to be assigned to devices. For that purpose a "device" > option should be more accurate than "ifname" one. > > For backward compatibility add a temporary config translation. > > Config example: > > config

Re: [PATCH netifd] interface: rename "ifname" attribute to "device"

2021-05-22 Thread Felix Fietkau
On 2021-05-17 16:49, Rafał Miłecki wrote: > From: Rafał Miłecki > > Interfaces need to be assigned to devices. For that purpose a "device" > option should be more accurate than "ifname" one. > > For backward compatibility add a temporary config translation. > > Config example: > > config

Re: netifd: redesigning UCI config & interfaces

2021-05-13 Thread Felix Fietkau
Hi Rafał, Thanks for the proposal On 2021-05-13 15:58, Rafał Miłecki wrote: > Current /etc/config/network design and netifd implementation are quite a > bit messy: > 1. There is no clear layer 2 vs. layer 3 distinction I think aside from a few legacy compatibility hacks (e.g. the infamous

Re: FRAG Attacks (new vuln for wifi)

2021-05-13 Thread Felix Fietkau
On 2021-05-13 11:10, Mirko Parthey wrote: > On Thu, May 13, 2021 at 05:57:01AM +0200, Felix Fietkau wrote: >> >> > Regarding ath10k-ct, what kernel-versions of the ath10k-ct driver need >> >> > to be patched? >> >> > Is 4.19 the oldest that o

Re: FRAG Attacks (new vuln for wifi)

2021-05-12 Thread Felix Fietkau
On 2021-05-13 01:45, Nick Lowe wrote: >> > Regarding ath10k-ct, what kernel-versions of the ath10k-ct driver need to >> > be patched? >> > Is 4.19 the oldest that owrt will consume? >> I think so. 4.19 is used by OpenWrt 19.07 and I don't think we'll update >> anything older than that. > > So,

Re: FRAG Attacks (new vuln for wifi)

2021-05-12 Thread Felix Fietkau
On 2021-05-12 19:13, Ben Greear wrote: > On 5/12/21 9:00 AM, Felix Fietkau wrote: >> >> Hi, >> >> On 2021-05-12 01:34, Paul D wrote: >>> https://www.fragattacks.com/ >>> >>> https://lore.kernel.org/linux-wireless/20210511180259.159598-1

Re: FRAG Attacks (new vuln for wifi)

2021-05-12 Thread Felix Fietkau
Hi, On 2021-05-12 01:34, Paul D wrote: > https://www.fragattacks.com/ > > https://lore.kernel.org/linux-wireless/20210511180259.159598-1-johan...@sipsolutions.net/ I've merged those fixes in openwrt commit 025bd93f36c9. After some testing in master, we should backport them soon. ath10k-ct

Re: [PATCH] build: fix regression for kernels < 5.10

2021-04-13 Thread Felix Fietkau
On 2021-04-13 14:22, Sebastian Kemper wrote: > This fixes a regression introduced with commit > 5ed1e5140a80558ab47fd70410ae3242bed5becf ("build: build kernel image > before building modules/packages"). > > Before this commit the make target would always include "modules", > resulting in a

Re: [PATCH] kernel: disable crypto-hw-ccp on BCM4908

2021-04-13 Thread Felix Fietkau
On 2021-04-13 11:46, Rafał Miłecki wrote: > From: Rafał Miłecki > > CONFIG_CRYPTO_DEV_SP_CCP depends on DMA_ENGINE which depends on > DMADEVICES=y which bcm4908 doesn't need and doesn't use at this point. > > Trying to build this package on bcm4908 was causing: > ERROR: module >

Re: Regression in auto-mounting mtd squashfs partitions

2021-04-10 Thread Felix Fietkau
On 2021-04-10 16:33, Daniel Golle wrote: > On Sat, Apr 10, 2021 at 04:04:28PM +0200, Felix Fietkau wrote: >> Hi Daniel, >> >> it seems to me that your commit 2809d744 ("kernel: support FIT >> partition parser on mtdblock devices") is causing a regressio

Regression in auto-mounting mtd squashfs partitions

2021-04-10 Thread Felix Fietkau
Hi Daniel, it seems to me that your commit 2809d744 ("kernel: support FIT partition parser on mtdblock devices") is causing a regression in mounting squashfs rootfs when CONFIG_FIT_PARTITION is enabled. The following workaround fixes it, but maybe you can make a better fix, since you're more

Re: [PATCH] kernel: drop the conntrack rtcache patch

2021-04-09 Thread Felix Fietkau
lvaterra Acked-by: Felix Fietkau - Felix ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] openssl: don't rename a file with quilt

2021-03-26 Thread Felix Fietkau
On 2021-03-26 22:39, Eneas U de Queiroz wrote: > On Fri, Mar 26, 2021 at 4:28 PM Rosen Penev wrote: >> >> On Fri, Mar 26, 2021 at 5:55 AM Eneas U de Queiroz >> wrote: >> > >> > On Fri, Mar 26, 2021 at 6:26 AM Rosen Penev wrote: >> > > +ifeq ($(QUILT),) >> > > + mv

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2021-03-26 Thread Felix Fietkau
On 2021-03-26 09:55, Martin Schiller wrote: > On 2021-03-26 09:42, Felix Fietkau wrote: >> On 2021-03-26 09:34, Martin Schiller wrote: >>> On 2020-07-24 19:13, Felix Fietkau wrote: >>>> On 2020-07-24 18:44, Jo-Philipp Wich wrote: >>>>> Hi Felix, &g

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2021-03-26 Thread Felix Fietkau
On 2021-03-26 09:34, Martin Schiller wrote: > On 2020-07-24 19:13, Felix Fietkau wrote: >> On 2020-07-24 18:44, Jo-Philipp Wich wrote: >>> Hi Felix, >>> >>>> [...] >>>> >>>> For a simple default config, you could have this: >>

Re: [PATCH v2] ubusd: convert tx_queue to linked list

2021-03-25 Thread Felix Fietkau
On 2021-03-25 21:43, Arnout Vandecappelle wrote: > > > On 25/03/2021 10:48, Felix Fietkau wrote: >> >> On 2021-03-24 13:27, Arnout Vandecappelle (Essensium/Mind) wrote: >>> ubusd maintains a per-client tx_queue containing references to message >>> b

Re: [PATCH v2] ubusd: convert tx_queue to linked list

2021-03-25 Thread Felix Fietkau
On 2021-03-24 13:27, Arnout Vandecappelle (Essensium/Mind) wrote: > ubusd maintains a per-client tx_queue containing references to message > buffers that have not been sent yet (due to the socket blocking). This > is a fixed-size, 64-element queue. > > When more than 64 elements are queued,

Re: [PATCH] gmp: compile with -DPIC to use correct asm code

2021-03-12 Thread Felix Fietkau
On 2021-03-12 11:34, Stijn Tintel wrote: > On 11/03/2021 23:46, Eneas U de Queiroz wrote: >> The library is always compiled with $(FPIC) (-fPIC or -fpic), even for >> the static library. >> >> There are some assembly sources that decide whether or not to enable >> PIC code by checking if PIC is

Re: [PATCH] uclibc++: remove

2021-03-01 Thread Felix Fietkau
On 2021-02-27 05:17, Rosen Penev wrote: > No package here depends on it. Furthermore, uClibc++ is a fairly buggy > C++ library and seems to be relatively inactive upstream. > > It also lacks proper support for modern C++11 features. > > The main benefit of it is size: 66.6 KB vs 287.3 KB

Re: Please consider reverting autoconf-lean from toolchain

2021-03-01 Thread Felix Fietkau
> On 1. Mar 2021, at 23:47, Hauke Mehrtens wrote: > > On 3/1/21 3:54 PM, Hannu Nyman wrote: >> Apparently autoconf-lean, merged into the toolchain during last weekend, >> causes problems with various packages at buildbot. >> I am not sure if that is due to underlying problems in the specific

Re: vm.min_free_kbytes seems very big

2021-02-27 Thread Felix Fietkau
Hi Adrian, On 2021-02-27 16:40, Adrian Schmutzler wrote: > Hi Felix, > > due to some OOM issues I recently became aware that OpenWrt (or rather, you > in [1]) set the vm.min_free_kbytes to quite excessive values: > > 16M for 128M RAM > 8M for 64M RAM > > The value for 32M devices has been

Re: [PATCH v3] fakeroot: fix to work with glibc 2.33

2021-02-15 Thread Felix Fietkau
On 2021-02-14 05:41, Ilya Lipnitskiy wrote: > The following commit removed _STAT_VER definitions from glibc: > https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=8ed005daf0ab03e142500324a34087ce179ae78e > > That subsequently broke fakeroot: > https://bugs.archlinux.org/task/69572 >

Re: [PATCH 4/4] mac80211: add AX support

2021-02-15 Thread Felix Fietkau
On 2021-02-15 11:19, John Crispin wrote: > Signed-off-by: John Crispin > --- > .../files/lib/netifd/wireless/mac80211.sh | 193 +- > .../mac80211/files/lib/wifi/mac80211.sh | 19 +- > 2 files changed, 195 insertions(+), 17 deletions(-) > > diff --git

Re: ath10k-ct iw missing rx stats

2021-02-14 Thread Felix Fietkau
On 2021-02-14 18:28, Ansuel Smith wrote: > With recent mac80211 bump I notice that rx stats > are no longer displayed. > I ported the atk10-ct patches to the version 5.10 > and I noticed this. It's only me? > Also this is only to report that ath10k-ct patches can > be ported with minimal changes

[PATCH 2/5] build: add support for fixing up library soname

2021-02-12 Thread Felix Fietkau
package are also fixed up Signed-off-by: Felix Fietkau --- include/package-ipkg.mk| 5 +++ include/package.mk | 2 ++ rules.mk | 6 scripts/set-abi-version.sh | 73 ++ 4 files changed, 86 insertions(+) create mode 100755

[PATCH 4/5] build: drop ABI version from metadata

2021-02-12 Thread Felix Fietkau
Preparation for supporting dynamic ABI versions that depend on the runtime configuration. Read the suffix from the staging dir pkginfo version files. Signed-off-by: Felix Fietkau --- include/feeds.mk| 2 +- include/package-dumpinfo.mk | 3 +-- include/package-ipkg.mk | 9

[PATCH 3/5] libubox: use PKG_ABI_VERSION

2021-02-12 Thread Felix Fietkau
Signed-off-by: Felix Fietkau --- package/libs/libubox/Makefile | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/package/libs/libubox/Makefile b/package/libs/libubox/Makefile index d9c239a50d15..19d91455097e 100644 --- a/package/libs/libubox/Makefile +++ b/package/libs

[PATCH 1/5] build: fix ABI version rebuild dependency

2021-02-12 Thread Felix Fietkau
A stray comma was being appended to the last package version dependency, causing it to be missed for ABI version checks Signed-off-by: Felix Fietkau --- include/package.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/package.mk b/include/package.mk index

[PATCH 5/5] wolfssl: use dynamic ABI_VERSION depending on the configuration and package version

2021-02-12 Thread Felix Fietkau
Signed-off-by: Felix Fietkau --- package/libs/wolfssl/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/package/libs/wolfssl/Makefile b/package/libs/wolfssl/Makefile index ff01fca66310..51dc4d5a0933 100644 --- a/package/libs/wolfssl/Makefile +++ b/package/libs

Re: [PATCH] fakeroot: fix to work with glibc 2.33

2021-02-11 Thread Felix Fietkau
Hi Ilya, On 2021-02-11 04:14, Ilya Lipnitskiy wrote: > The following commit removed _STAT_VER definitions from glibc: > https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=8ed005daf0ab03e142500324a34087ce179ae78e > > That subsequently broke fakeroot: > https://bugs.archlinux.org/task/69572

Re: Revisiting ABI_VERSION handling policy

2021-02-09 Thread Felix Fietkau
On 2021-02-09 23:56, Jo-Philipp Wich wrote: > Hi, > >> The last stable update didn't change SONAME, but it included changes to >> the same data structure that triggered the bug that I ran into. It could >> very likely have introduced very similar subtle breakage. > > this is a clear upstream

Re: Revisiting ABI_VERSION handling policy

2021-02-09 Thread Felix Fietkau
On 2021-02-09 13:00, Jo-Philipp Wich wrote: > Hi, > >> The goal of reducing unnecessary build churn makes perfect sense to me, >> but I think we need to reconsider the trade-off we're making here, and >> the failure modes of each option. > > the motivation wasn't about build-churn at all but

Revisiting ABI_VERSION handling policy

2021-02-08 Thread Felix Fietkau
Hi, I just wasted a few hours of debugging on an issue that turned out to be wolfssl ABI breakage related. At first I thought it was the version bump. While the commit that updates wolfssl claims that the ABI didn't change, a quick look at

Re: Fwd: C++ libubus wrapper

2021-02-04 Thread Felix Fietkau
On 2021-02-04 18:25, Wojciech Jowsa wrote: > czw., 4 lut 2021 o 10:32 Felix Fietkau napisał(a): >> >> >> On 2021-02-03 20:02, Wojciech Jowsa wrote: >> > Hi, >> > >> > I would like to write a libubus wrapper in C++. When looking into >> &

Re: C++ libubus wrapper

2021-02-04 Thread Felix Fietkau
On 2021-02-03 20:02, Wojciech Jowsa wrote: > Hi, > > I would like to write a libubus wrapper in C++. When looking into > ubus_method and ubus_handler_t structures I don't see a place where I > could pass a this pointer. It makes the handling of ubus calls in C++ > a bit complicated. > The

Re: [PATCHv3] ccache: update to 4.1

2020-12-23 Thread Felix Fietkau
On 2020-12-23 09:14, Rosen Penev wrote: > On Tue, Dec 22, 2020 at 11:53 PM Hannu Nyman wrote: >> >> Rosen Penev kirjoitti 23.12.2020 klo 8.33: >> > Upstream switched to building with CMake. Adjust accordingly. >> > >> > Reapplied patch as upstream changed the file format. >> > >> > Added

Re: [PATCH] build/prereq: requie make 4.1 or later

2020-12-13 Thread Felix Fietkau
On 2020-12-13 12:35, Hauke Mehrtens wrote: > On 12/13/20 8:17 AM, Paul Spooren wrote: >> FS#2086 "IS_TTY in the makefile is broken" reports flawed detection of >> stdout piping to a file. The issue describes how e.g. terminal color >> codes and up in log files if running make like `make >

Re: [PATCH] ramips/mt7621: refresh the kernel config

2020-12-02 Thread Felix Fietkau
On 2020-12-02 19:45, Adrian Schmutzler wrote: >> -Original Message- >> From: Felix Fietkau [mailto:n...@nbd.name] >> Sent: Mittwoch, 2. Dezember 2020 19:25 >> To: Adrian Schmutzler ; 'Rui Salvaterra' >> ; openwrt-devel@lists.openwrt.org >> Subject

Re: [PATCH] ramips/mt7621: refresh the kernel config

2020-12-02 Thread Felix Fietkau
Hi, On 2020-12-02 18:32, Adrian Schmutzler wrote: >> -Original Message- >> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] >> On Behalf Of Rui Salvaterra >> Sent: Mittwoch, 2. Dezember 2020 16:42 >> To: openwrt-devel@lists.openwrt.org >> Cc: Rui Salvaterra >>

Re: [PATCH] libroxml: remove

2020-11-27 Thread Felix Fietkau
On 2020-11-27 10:36, Paul Spooren wrote: > I'm happy to handle this but you're the maintainer. Please give your > blessing. I hereby bless you :) Thanks for taking care of this - Felix ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [PATCH v2] build: create $(PKG_SYMVERS_DIR) if non-existent

2020-11-17 Thread Felix Fietkau
On 2020-11-18 06:54, Oldřich Jedlička wrote: > út 17. 11. 2020 v 23:00 odesílatel Sebastian Kemper > napsal: >> >> Commit 5d76065 moved the creation of the symvers directory to >> include/kernel-build.mk. This is fine when building from scratch. But >> when unpacking an SDK the directory doesn't

Re: [PATCH] Revert "netifd: update to the latest version"

2020-11-13 Thread Felix Fietkau
On 2020-11-13 11:34, Rui Salvaterra wrote: > Hi, Felix, > > On Fri, 13 Nov 2020 at 10:25, Felix Fietkau wrote: >> >> Please git-bisect this and show me the config that doesn't work anymore, >> so that I can fix it properly. > > I can't bisect this now, as

Re: [PATCH] Revert "netifd: update to the latest version"

2020-11-13 Thread Felix Fietkau
On 2020-11-13 11:19, Rui Salvaterra wrote: > This broke the switch VLAN configuration on at least Archer C6 v2 EU and > Archer > C7 (both switchdev-based one-armed routers). > > Signed-off-by: Rui Salvaterra Please git-bisect this and show me the config that doesn't work anymore, so that I

Re: Someone working on kernel 5.9?

2020-10-29 Thread Felix Fietkau
On 2020-10-29 13:11, Koen Vandeputte wrote: > > On 29.10.20 11:37, Andrey Jr. Melnikov wrote: >> Koen Vandeputte wrote: >> >>> On 03.10.20 17:11, Vincent Wiemann wrote: Hi folks, is anybody working on 5.9, already? I'd like to do some testing with io_uring on ath79 devices,

Re: [RFC PATCH] ath79: remove model name from LED labels

2020-09-30 Thread Felix Fietkau
On 2020-09-30 13:43, Adrian Schmutzler wrote: >> -Original Message- >> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] >> On Behalf Of Adrian Schmutzler >> Sent: Sonntag, 27. September 2020 23:55 >> To: openwrt-devel@lists.openwrt.org >> Subject: RE: [RFC PATCH]

Re: [PATCH v2] mac80211: fix regression in sta connection monitor

2020-09-26 Thread Felix Fietkau
Hi Georgi, thanks for testing and for your insight into this issue. On 2020-09-26 06:41, Georgi Valkov wrote: > Hi Felix! > > With your latest suggestion, it takes between 10 and 17 hours for the > connection to drop, then long five minutes to reconnect. > Notice the order of code execution

Re: [PATCH] mac80211: fix regression in sta connection monitor

2020-09-22 Thread Felix Fietkau
On 2020-09-22 09:28, Georgi Valkov wrote: > Hi Felix! > > In the original code before the regression, as well as in the fix I > proposed, probe_send_count was always reset if ack is true, while in > your fix it will not be reset when non-null frames are received. The > connection failed again

Re: [PATCH] ath79: ar8216: make switch register access atomic

2020-09-21 Thread Felix Fietkau
On 2020-09-21 18:26, Chuanhong Guo wrote: > Hi! > > On Mon, Sep 21, 2020 at 9:24 PM Felix Fietkau wrote: >> > + >> > + split_addr((u32) reg, , , ); >> > + >> > ++local_irq_save(flags); >> > + mutex_lock(>mdio_lock); >>

Re: [PATCH] ath79: ar8216: make switch register access atomic

2020-09-21 Thread Felix Fietkau
On 2020-09-21 08:57, Chuanhong Guo wrote: > reg accesses on integrated ar8229 sometimes fails. As a result, phy read > got incorrect port status and wan link goes down and up mysteriously. > After comparing ar8216 with the old driver, these local_irq_save/restore > calls are the only meaningful

Re: [PATCH 3/3] mediatek: mt7623: use bash for generating bootable images

2020-09-08 Thread Felix Fietkau
On 2020-09-08 10:39, David Woodhouse wrote: > On Tue, 2020-09-08 at 10:31 +0200, Felix Fietkau wrote: >> On 2020-09-08 10:26, David Woodhouse wrote: >> > It turns out that 'echo -e' isn't portable; it doesn't work in the dash >> > builtin echo and Ubuntu users are comp

Re: [PATCH 3/3] mediatek: mt7623: use bash for generating bootable images

2020-09-08 Thread Felix Fietkau
On 2020-09-08 10:26, David Woodhouse wrote: > It turns out that 'echo -e' isn't portable; it doesn't work in the dash > builtin echo and Ubuntu users are complaining. > > I can't even get octal (specified by POSIX) to work consistently because > those variants of 'echo' which *do* support -e

Re: [PATCH 2/2] toolchain/musl: remove several GNU headers

2020-08-28 Thread Felix Fietkau
On 2020-08-29 05:28, Rosen Penev wrote: > Remove GLOB_ONLYDIR patch. Only fstools relies on it. fstools can be fixed > separately. > > Remove woresize.h file. It seems to be for an old version of GCC. > > Remove features.h and glibc-types files. Same as above. > > Remove sys/cdefs.h. This is a

Re: [Bridge] [RFC PATCH net-next] bridge: Implement MLD Querier wake-up calls / Android bug workaround

2020-08-23 Thread Felix Fietkau
On 2020-08-23 17:42, Linus Lüssing wrote: > On Sun, Aug 16, 2020 at 03:08:13PM -0700, Stephen Hemminger wrote: >> Rather than adding yet another feature to the bridge, could this hack be >> done by >> having a BPF hook? or netfilter module? > > Hi Stephen, > > Thanks for the constructive

Re: [PATCH 3/3] toolchain: remove BROKEN from uClibc-ng

2020-08-15 Thread Felix Fietkau
On 2020-08-16 00:27, Rosen Penev wrote: > On Sat, Aug 15, 2020 at 2:02 AM Felix Fietkau wrote: >> >> On 2020-08-14 23:30, Rosen Penev wrote: >> > uClibc-ng works fine. Additionally, most packages have been fixed to >> > compile with uClibc-ng. >> > &

Re: [PATCH 3/3] toolchain: remove BROKEN from uClibc-ng

2020-08-15 Thread Felix Fietkau
On 2020-08-14 23:30, Rosen Penev wrote: > uClibc-ng works fine. Additionally, most packages have been fixed to > compile with uClibc-ng. > > Signed-off-by: Rosen Penev It does not make sense to maintain uClibc-ng for anything other than arc (the only arch that needs it). In fact, once arc is

Re: ath25 and rb532 fail after mac80211 changes

2020-08-14 Thread Felix Fietkau
On 2020-08-14 11:16, Adrian Schmutzler wrote: > Hi, > > after "mac80211: merge performance improvement patches" [1], build fails on a > few 4.14 targets, namely ath25, rb532 (and ar71xx): > > > > So, we have to decide whether > 1. we fix this > 2. we leave the buildbots broken > 3. we remove

Re: [PATCH] kernel: add ar5523 driver

2020-08-11 Thread Felix Fietkau
On 2020-08-11 14:41, mohammad rasim wrote: > The driver currently only support managed and monitor mode > > Signed-off-by: mohammad rasim Are you planning on using this, or did you just add it because it's in the source tree? - Felix ___

Re: [PATCH 1/4] tools: add fakeroot

2020-08-08 Thread Felix Fietkau
On 2020-08-07 23:12, Paul Spooren wrote: > From: Thomas Petazzoni > > SELinux support requires setting the appropriate SELinux security context > to files and directories, which needs to happen at build time in order > to support read-only root filesystem scenarios. In order to create these >

[RFC netifd 1/3] bridge: add support for defining port member vlans via hotplug ops

2020-08-07 Thread Felix Fietkau
Signed-off-by: Felix Fietkau --- bridge.c| 105 +++- config.c| 1 + device.h| 4 +- interface.c | 10 +++-- interface.h | 2 +- ubus.c | 5 ++- wireless.c | 4 +- 7 files changed, 120 insertions(+), 11 deletions

[RFC netifd 2/3] vlan: add pass-through hotplug ops that pass the VLAN info to the bridge

2020-08-07 Thread Felix Fietkau
Signed-off-by: Felix Fietkau --- vlan.c | 64 ++ 1 file changed, 64 insertions(+) diff --git a/vlan.c b/vlan.c index 6270d95d755d..7d37fef33e2f 100644 --- a/vlan.c +++ b/vlan.c @@ -18,6 +18,8 @@ #include "netifd.h" #include

[RFC netifd 3/3] vlandev: add pass-through hotplug ops that pass the VLAN info to the bridge

2020-08-07 Thread Felix Fietkau
Only used for 802.1q devices Signed-off-by: Felix Fietkau --- vlandev.c | 66 +++ 1 file changed, 66 insertions(+) diff --git a/vlandev.c b/vlandev.c index 10b78e241576..7efb5f42b5c4 100644 --- a/vlandev.c +++ b/vlandev.c @@ -45,6 +45,7

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-24 Thread Felix Fietkau
On 2020-07-24 18:44, Jo-Philipp Wich wrote: > Hi Felix, > >> [...] >> >> For a simple default config, you could have this: >> >> # network >> config device > option type bridge # I assume this is needed as well >> option name switch0 Correct. >> config bridge-vlan >> option

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-24 Thread Felix Fietkau
On 2020-07-24 10:37, Jo-Philipp Wich wrote: > Hi Luiz, > > I mostly agree with your proposal (though I'd call "device_for" simply > "bridge" instead but that's details). > > I don't think everything can be simply switched in one go but I do think your > proposal could be broken down into the

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Felix Fietkau
> On 23. Jul 2020, at 14:17, Jo-Philipp Wich wrote: > > Hi, > >> 1. Have VLAN devices on top of vlan-enabled bridges to define hotplug >> ops where applicable, so LAN could be a plain VLAN interface switch0.1 >> instead of its own bridge. >> 2. With these wrapper hotplug ops, a default VLAN

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Felix Fietkau
> On 23. Jul 2020, at 13:44, Josh Bendavid wrote: > > "1. Have VLAN devices on top of vlan-enabled bridges to define hotplug > ops where applicable, so LAN could be a plain VLAN interface switch0.1 > instead of its own bridge." > > By this you mean that the creation of the switch0.1 device

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Felix Fietkau
Hi, On 2020-07-23 12:10, Jo-Philipp Wich wrote: > yeah I forgot to elaborate that in my last mail. The problem of dynamic / not > explicitly addressable wifi interface names in the network config remains. > > The best solution I can think of is fixing the wifi ifnames using "option > ifname" in

Re: [PATCH] iftop: fix compilation with GCC 10

2020-07-17 Thread Felix Fietkau
On 2020-07-14 07:43, Rosen Penev wrote: > GCC 10 defaults to fno-common, which demains unique defenitions. > > Signed-off-by: Rosen Penev > --- > package/network/utils/iftop/Makefile | 2 +- > .../utils/iftop/patches/010-gcc10.patch | 20 +++ > 2 files changed,

Re: [RFC] usage of mkhash, sha256sum and md5sum

2020-07-16 Thread Felix Fietkau
On 2020-07-16 21:18, Paul Spooren wrote: > Hi, > > On 15.07.20 22:54, Felix Fietkau wrote: >> On 2020-07-16 04:06, Paul Spooren wrote: >>> Hi, >>> >>> the OpenWrt system requires the calculation of both md5 and sha256 sums >>> at var

Re: [RFC] usage of mkhash, sha256sum and md5sum

2020-07-16 Thread Felix Fietkau
On 2020-07-16 04:06, Paul Spooren wrote: > Hi, > > the OpenWrt system requires the calculation of both md5 and sha256 sums > at various places, this is partly done via a small C file in > ./scripts/mkhash.c and partly by using a sha256sum binary. A ancient > wrapper ./scripts/md5sum is added

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-15 Thread Felix Fietkau
On 2020-07-15 13:52, John Crispin wrote: > > On 15.07.20 13:39, Jo-Philipp Wich wrote: >> Hi, >> >>> If we can't come up with a working automatic scheme, maybe we could have >>> an option to disable the cpu port per vlan? >> Having a default-enabled "option self" or "option local" was my idea as

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-15 Thread Felix Fietkau
On 2020-07-15 09:56, Jo-Philipp Wich wrote: > Hi, > >> Changes: >> - The device is created as a netifd bridge >> - Bridge vlan sections should always refer to the bridge instead of >> automatically be applied to the first one >> - Use = instead of . to mark tagging modifiers. "." is already

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-15 Thread Felix Fietkau
Hi, I would like to propose an alternative configuration format that is structurally close to your proposal, but more generic in that it is not tied to DSA directly but configures bridge vlans instead. Here's the converted form of your example: config device switch0 option name switch0

Re: [PATCH] wireless-regdb: add country selection

2020-07-14 Thread Felix Fietkau
On 2020-07-14 13:57, Florian Eckert wrote: > >> What's the use case for this? > As much as I remember there was the problem in 2017 that you can't > change the country code or have to restrict it. > https://ec.europa.eu/growth/sectors/electrical-engineering/red-directive_de > Of course this

Re: [PATCH] wireless-regdb: add country selection

2020-07-13 Thread Felix Fietkau
On 2020-07-13 11:09, Florian Eckert wrote: > Until now it has not been possible to remove countries from the regdb. > The packages has been extended, so that it is now possible to add or > omit individual countries in the regdb during package compile time. > If this option is not activated, then

Re: [OpenWrt-Devel] [PATCH] build: improve ccache support

2020-06-01 Thread Felix Fietkau
On 2020-06-01 19:11, Michael Jones wrote: > > > On Mon, Jun 1, 2020 at 10:33 AM Roman Yeryomin > wrote: > > Set CCACHE_DIR to $(TOPDIR)/.ccache and CCACHE_BASEDIR to $(TOPDIR). > This allows to do clean and dirclean. Cache hit rate for test build > after

[OpenWrt-Devel] [PATCH libubox 2/3] blobmsg: simplify and fix name length checks in blobmsg_check_name

2020-05-25 Thread Felix Fietkau
blobmsg_hdr_valid_namelen was omitted when name==false The blob_len vs blobmsg_namelen changes were not taking into account potential padding between name and data Signed-off-by: Felix Fietkau --- blobmsg.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git

[OpenWrt-Devel] [PATCH libubox 3/3] blobmsg: fix missing length checks

2020-05-25 Thread Felix Fietkau
this by checking the raw blob length against the buffer length in blobmsg_hdr_from_blob Signed-off-by: Felix Fietkau --- blobmsg.c | 66 +-- 1 file changed, 20 insertions(+), 46 deletions(-) diff --git a/blobmsg.c b/blobmsg.c index 308bef7bc6b0

[OpenWrt-Devel] [PATCH libubox 1/3] blobmsg: fix length in blobmsg_check_array

2020-05-25 Thread Felix Fietkau
blobmsg_check_array_len expects the length of the full attribute buffer, not just the data length. Due to other missing length checks (fixed in the next commit), this did not show up as a test failure Signed-off-by: Felix Fietkau --- blobmsg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [OpenWrt-Devel] [PATCH RFC libubox] blobmsg: another attrs iteration fix for blobmsg_check_array_len()

2020-05-25 Thread Felix Fietkau
On 2020-05-25 10:31, Rafał Miłecki wrote: > From: Rafał Miłecki > > After more reviews is seems that blobmsg_for_each_attr() should not be > used when dealing with untrusted data as it reads length from blob data > itself. It means it can't be used in the blobmsg_check_array_len(). > > Switch

Re: [OpenWrt-Devel] [PATCH] build: always use -minterlink-mips16 if USE_MIPS16

2020-05-25 Thread Felix Fietkau
On 2020-05-25 02:19, Eneas U de Queiroz wrote: > Individual packages may turn off MIPS16 ISA individually with > PKG_USE_MIPS16. However, they may link to a library compiled with > MIPS16. In such cases, the -minterlink-mips16 is needed to ensure there > are no direct jumps to code compiled with

Re: [OpenWrt-Devel] [PATCH 0/3] mac80211: Update to version 5.7-rc2

2020-04-22 Thread Felix Fietkau
On 2020-04-21 23:22, Hauke Mehrtens wrote: > This updates mac80211 in OpenWrt to version 5.7-rc2. > This update contains ath11k and many other ieee80211ax updates. > ath11k only works on the ipq807x devices. > > I tried to start a discussion how we want to go forward with the > wireless

Re: [OpenWrt-Devel] [PATCH 1/1] netifd: add pre-up/down post-up/down callback handling

2020-03-20 Thread Felix Fietkau
On 2020-03-20 15:21, Florian Eckert wrote: > network >>> With this change we can decide if this is a user interaction with >>> CLI/LuCI, >>> because with the new callback mechanism I can set/delete a uci config >>> flag so >>> that the connection should really disconnected. And so does not >>>

Re: [OpenWrt-Devel] [PATCH 1/1] netifd: add pre-up/down post-up/down callback handling

2020-03-20 Thread Felix Fietkau
On 2020-03-19 13:03, Florian Eckert wrote: > In some situations it is useful to execute callback scripts when > manually triggering an ifdown/ifup event via the CLI/LuCI. > > In my case I have a monitoring for a cellular connection. > If this fails the command `ubus call network.interface up` is

Re: [OpenWrt-Devel] [PATCH] ppp: activate PIE ASLR by default

2020-02-22 Thread Felix Fietkau
On 2020-02-22 10:22, Stijn Tintel wrote: > On 22/02/2020 11:10, Felix Fietkau wrote: >> On 2020-02-22 09:54, Stijn Tintel wrote: >>> On 20/02/2020 11:56, Petr Štetiar wrote: >>>> This activates PIE ASLR support by default when the regular option is >>>> s

Re: [OpenWrt-Devel] [PATCH] ppp: activate PIE ASLR by default

2020-02-22 Thread Felix Fietkau
On 2020-02-22 09:54, Stijn Tintel wrote: > On 20/02/2020 11:56, Petr Štetiar wrote: >> This activates PIE ASLR support by default when the regular option is >> selected. >> > Unfortunately this seems to break build on x86/64: > > x86_64-openwrt-linux-musl-gcc -O2 -pipe -fno-caller-saves -fno-plt

Re: [OpenWrt-Devel] Wireless monitor interface causes device to run out of memory

2020-02-11 Thread Felix Fietkau
On 2020-02-11 17:03, Rafał Miłecki wrote: > On Wed, 5 Feb 2020 at 11:14, Rafał Miłecki wrote: >> I noticed that my bcm53xx devices run out of memory after running >> wireless monitor interface for about 2 days. >> >> This problem occurs since 0694d08c84fd ("bcm53xx: switch to kernel >> 4.9")

Re: [OpenWrt-Devel] [RFC/RFT PATCH] ath9k: implement kthread entropy collection for AR5008 and AR9002 PHYs.

2020-02-10 Thread Felix Fietkau
On 2020-02-10 10:44, Rui Salvaterra wrote: > On Fri, 31 Jan 2020 at 08:12, Felix Fietkau wrote: >> >> For at least AR5008 and AR9002, but probably also for AR9003 I would >> like to keep the behavior of collecting entropy only once at driver >> initialization. >

Re: [OpenWrt-Devel] [PATCH] ramips: ethernet: turn off flow control

2020-01-31 Thread Felix Fietkau
On 2020-01-29 17:22, Petr Štetiar wrote: > Rosen Penev [2020-01-25 15:04:03]: > > Hi Bjørn and Rosen, > >> On Thu, Jan 23, 2020 at 12:25 AM Bjørn Mork wrote: >> > > >> > > - if ((rt_sysc_r32(SYSC_REG_CHIP_REV_ID) & 0x) == 0x0101) { >> > > - /* (GE1, Force 1000M/FD, FC ON,

Re: [OpenWrt-Devel] [RFC/RFT PATCH] ath9k: implement kthread entropy collection for AR5008 and AR9002 PHYs.

2020-01-31 Thread Felix Fietkau
On 2020-01-30 21:03, Rui Salvaterra wrote: > The mainline ath9k driver is able to provide a hardware random number > generator by collecting radio noise from the PHY ADC (using a kthread > to fill up the entropy pool as needed). Nevertheless, this feature has > only been implemented for the more

Re: [OpenWrt-Devel] [PATCH 3/7] base-files/functions.sh: use command -v instead of $(which)

2020-01-17 Thread Felix Fietkau
On 2020-01-17 05:43, Rosen Penev wrote: > $(which) must be executed. command -v is a shell builtin. > > https://github.com/koalaman/shellcheck/wiki/SC2230 > > Signed-off-by: Rosen Penev > --- > package/base-files/files/lib/functions.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [OpenWrt-Devel] [PATCH v2] build: separate signing logic

2019-11-12 Thread Felix Fietkau
On 2019-11-12 10:31, Paul Spooren wrote: > This separates the options for signature creation and verification > > * SIGNED_PACKAGES create Packages.sig > * SIGNED_IMAGES add ucert signature to created images > * CHECK_SIGNATURE add verification capabilities to images > * INSTALL_LOCAL_KEY add

Re: [OpenWrt-Devel] [PATCH-19.07] build: fix module strip invalid

2019-10-31 Thread Felix Fietkau
On 2019-10-31 10:43, 大雄 wrote: > Hi, >      >     But sometimes,  .ko not in menuconfig option. >     It's in the kernel_menuconfig option. >     So is no through ipk processing. In that case the solution is to add a package for it. - Felix ___

  1   2   3   4   5   6   7   8   9   10   >