Re: [VOTE] New member proposal: Robimarko (Robert Marko)

2024-02-08 Thread Hans Dedecker
On Tue, Jan 30, 2024 at 7:16 PM Christian Marangi (Ansuel) wrote: > > Robert is active in OpenWrt since 2017 and with some recent stats, he > has more than 310 commits merged in OpenWrt. > He also have uncounted Reviewed-by tag on various PR and merged commits > and generally helps in everything

Re: [PATCH netifd v2] interface-ip: fix ipv6 routing loop

2023-03-29 Thread Hans Dedecker
Hi, On Wed, Mar 29, 2023 at 4:44 PM Maxim Mikityanskiy wrote: > > Hello Hans! > > On Sun, 03 Jan 2021 12:14:18 -0800, Hans Dedecker wrote: > > In case of prefix delegation an upstream ISP will route the complete > > delegated prefix (e.g 2001:DB8:BEEF::/56) to an

Re: [odhcpd PATCH v2 2/2] router: skip RA and wait for LINK-LOCAL to be assigned

2023-03-22 Thread Hans Dedecker
event and set LINK-LOCAL if the addrs added by the event > is a LINK-LOCAL reflecting that the interface finally ended the DAD > process and have a correct address. > > Signed-off-by: Christian Marangi Acked-by: Hans Dedecker > --- > src/config.c | 9 + > src/netli

Re: [odhcpd PATCH 2/2] router: skip RA and wait for LINK-LOCAL to be assigned

2023-03-18 Thread Hans Dedecker
On Fri, Mar 17, 2023 at 1:54 AM Christian Marangi wrote: > > This fix a specific and corner case when the following error and similar > is printed in the log: > > Failed to send to ff02::1%br-lan (Address not available) > > The cause for this was tracked down to the lack of the interface of a >

Re: [odhcpd PATCH 1/2] config: skip interface setup if interface not IFF_RUNNING

2023-03-18 Thread Hans Dedecker
cted. > > To fix this setup services only when interface is in IFF_RUNNING state. > When an interface change state, odhcpd is reloaded and the services are > correctly setup again. > > Signed-off-by: Christian Marangi Acked-by: Hans Dedecker > --- > src/config.c | 2 +- >

Re: [PATCH odhcpd v2 2/2] router: always check ra_default

2023-02-17 Thread Hans Dedecker
On Thu, Feb 16, 2023 at 9:30 PM wrote: > > We currently only check ra_default when an interface has valid > addresses. This results in ra_default being ignored in case we have an > interface with only link-local addresses. This effectively breaks the > use of value 2 for the ra_default parameter.

Re: [PATCH odhcpd v2 1/2] router: improve RA logging

2023-02-17 Thread Hans Dedecker
re is a default route, but no valid prefix, a debug > message explains this, but if there is no default route, we silently > override ra_lifetime. > > Add a debug message for the latter case, and explicitly mention > overriding ra_lifetime in both cases. > > Signed-off-by: S

Re: [PATCH odhcpd 2/2] router: always check ra_lifetime

2023-02-16 Thread Hans Dedecker
fault parameter. > > Fix this by always checking ra_lifetime, regardless of the interface > having public addresses or not. > > Fixes: #11930 > Fixes: 83e14f455817 ("router: advertise removed addresses as invalid in 3 > consecutive RAs") > Signed-off-by: Stijn Tinte

Re: [PATCH odhcpd 1/2] router: improve RA logging

2023-02-16 Thread Hans Dedecker
re is a default route, but no valid prefix, a debug > message explains this, but if there is no default route, we silently > override ra_lifetime. > > Add a debug message for the latter case, and explicitly mention > overriding ra_lifetime in both cases. > > Signed-off-by: St

Re: [PATCH v3] netifd: add devtype to ubus call

2022-01-10 Thread Hans Dedecker
On Mon, Jan 10, 2022 at 4:55 PM Florian Eckert wrote: > > Hello Hans, > > thanks for you review. > > >> +--- a/system.h > >> b/system.h > >> +@@ -23,6 +23,42 @@ > >> + #include "iprule.h" > >> + #include "utils.h" > >> + > >> ++static const unsigned short netdev_type_number[] = { > >> ++

Re: [PATCH v3] netifd: add devtype to ubus call

2021-12-25 Thread Hans Dedecker
Hi Florian, Can you create the patch against the netifd repo ? Further comments inline Hans On Thu, Dec 9, 2021 at 4:18 PM Florian Eckert wrote: > > Every network device has a type. There is no standard interface here. > The type can be determined either from the file >

Re: [PATCH 2/2] interface-ip: copy more info for target host route

2021-11-28 Thread Hans Dedecker
On Tue, Nov 23, 2021 at 3:06 AM wrote: > > From: Luiz Angelo Daros de Luca > > interface_ip_add_target_route was adding a host route without > copying other confs like type, source, online). The result was that this: > > unreachable 192.168.0.9 metric 123 > > was being converted to: > >

Re: OpenWrt 21.02 status

2021-07-19 Thread Hans Dedecker
Hi Hauke, On Mon, Jul 19, 2021 at 8:05 PM Hauke Mehrtens wrote: > > Hi Hans, > > On 7/17/21 5:45 PM, Hauke Mehrtens wrote: > > Hi, > > > > In general the 21.02-rc3 looks good, but we still have some problems. > > > > Currently we still have these problem: > > > > > - DHCPv6 broken if lease

Re: [PATCH netifd] config: support bridge designed UCI section

2021-05-12 Thread Hans Dedecker
; > While introducing this new bridge section a new option was added for > storing bridge port names: "ports". It's clearer than previously used > "ifname". A simple validation code is present to make sure "ports" is > used and contain

Re: [PATCH] odhcpd: add option to use absolute timestamps

2021-02-06 Thread Hans Dedecker
On Sat, Jan 30, 2021 at 5:33 PM Nick Hainke wrote: > > Until now it is not possible to give absolute timestamps in odhcpd. > This means that on every new RA or request, the timestamp is renewed. > Further, the valid and preferred lifetimes are not synced between all > devices. > > There are

[PATCH netifd v2] interface-ip: fix ipv6 routing loop

2021-01-03 Thread Hans Dedecker
-by: Hans Dedecker --- v2: Keep unreachable route in the routing table dropping traffic from the lan not matching any routing rules with an ICMPv6 unreachable interface-ip.c | 77 ++ iprule.h | 10 --- 2 files changed, 71 insertions(+), 16

Re: [PATCH] odhcpd: add option for setting preferred lifetime

2021-01-02 Thread Hans Dedecker
On Fri, Jan 1, 2021 at 9:15 PM wrote: > > From: Nick Hainke > > "valid_lft" and "preferred_lft" are different. If the "preferred_lft" > is expired the prefix should be avoided in source prefix selection. > However, the interface is allowed to still receive downstream traffic. > >

[PATCH] [netifd] interface-ip: fix ipv6 routing loop

2021-01-01 Thread Hans Dedecker
iif eth0 failed_policy 420015: from all iif eth4 failed_policy 420015: from all iif eth4 failed_policy 420019: from all iif br-lan failed_policy Signed-off-by: Hans Dedecker --- interface-ip.c | 70 -- iprule.h | 10

Re: [PATCH] glibc: add arc700 patch

2020-12-26 Thread Hans Dedecker
Hi, On Fri, Dec 25, 2020 at 1:37 AM Rosen Penev wrote: > > glibc does not officially support ARC700 so this adds the missing > pieces. I looked at uClibc-ng and a patch by Synopsis for glibc. > > ran make toolchain/glibc/refresh to clean up fuzz. > > Signed-off-by: Rosen Penev > --- >

Re: [PATCH] netifd: add segment routing support

2020-12-13 Thread Hans Dedecker
On Sat, Dec 12, 2020 at 9:51 PM wrote: > > From: Nick Hainke > > seg6_enabled - Bool > Accept or drop SR-enabled IPv6 packets on this interface. > > More Information: > https://www.kernel.org/doc/html/latest/networking/seg6-sysctl.html > > Now you can set as interface option > option

Re: [PATCH] netifd: add segment routing support

2020-12-12 Thread Hans Dedecker
Hi, On Wed, Dec 2, 2020 at 3:33 PM wrote: > > From: Nick Hainke > > seg6_enabled - Bool > Accept or drop SR-enabled IPv6 packets on this interface. > > More Information: > https://www.kernel.org/doc/html/latest/networking/seg6-sysctl.html > > Now you can set as interface option > option

Re: odhcp6c RENEW timeout issue leads to OOM/OOPS [Was: Re: QEMU x86/64 ubus issues ... ]

2020-12-04 Thread Hans Dedecker
On Fri, Dec 4, 2020 at 11:45 AM Petr Štetiar wrote: > > Hans Dedecker [2020-12-03 21:18:11]: > > Hi, > > > Looking into the new pcap capture I must admit I've never seen such a DHCPv6 > > server with such weird behavior. > > it's OpenWrt so odhcpd. Could you run

Re: odhcp6c RENEW timeout issue leads to OOM/OOPS [Was: Re: QEMU x86/64 ubus issues ... ]

2020-12-03 Thread Hans Dedecker
On Wed, Dec 2, 2020 at 9:25 PM Petr Štetiar wrote: > > Hans Dedecker [2020-12-01 21:12:30]: > > Hi, > > > Can you check if commit > > https://git.openwrt.org/?p=project/odhcp6c.git;a=commit;h=a7b2221f687264c020b7a18a4e690d79f312a667 > > fixes the issue in

Re: odhcp6c RENEW timeout issue leads to OOM/OOPS [Was: Re: QEMU x86/64 ubus issues ... ]

2020-12-01 Thread Hans Dedecker
Hi Petr, On Sat, Nov 28, 2020 at 8:48 PM Hans Dedecker wrote: > > Hi, > > On Sat, Nov 28, 2020 at 5:04 PM Petr Štetiar wrote: > > > > Hans Dedecker [2020-11-26 21:19:30]: > > > > Hi, > > > > > Is it possible to have a pcap trace of the DHC

Re: odhcp6c RENEW timeout issue leads to OOM/OOPS [Was: Re: QEMU x86/64 ubus issues ... ]

2020-11-28 Thread Hans Dedecker
Hi, On Sat, Nov 28, 2020 at 5:04 PM Petr Štetiar wrote: > > Hans Dedecker [2020-11-26 21:19:30]: > > Hi, > > > Is it possible to have a pcap trace of the DHCPv6 messages on the wan ? > > I hope to find some time next weekend to investigate the issue further >

Re: odhcp6c RENEW timeout issue leads to OOM/OOPS [Was: Re: QEMU x86/64 ubus issues ... ]

2020-11-26 Thread Hans Dedecker
Hi Petr On Thu, Nov 26, 2020 at 9:58 AM Petr Štetiar wrote: > > Hi Hans, > > I've tried to ping you on IRC few days ago as I've found some strange issue > with odhcp6c which leads to OOM/OOPS[1] (log with just the important parts). > It simply happens every time after about 10 hours for me when

Re: [PATCH netifd] interface-ip: Normalise prefix address using netmask before using it

2020-11-25 Thread Hans Dedecker
Hi, On Wed, Nov 25, 2020 at 6:36 PM Daniel Gröber wrote: > > When a proto registers a prefix with an address which has bits outside the > netmask set this confuses the prefix-assignment code further down the line. > > For example if we have an interface with > > option ip6prefix

Re: [PATCH] netifd: add possibility to switch off route config

2020-11-23 Thread Hans Dedecker
On Mon, Nov 23, 2020 at 12:08 PM Florian Eckert wrote: > > This change adds the new configuration option `disabled` for the route > section, which can be used to temporarily disable the section so that > the route is not set. The advantage is that I do not have to delete the > whole configuration

Re: [PATCH 1/2] kernel: Remove support for MAP-E FMRs RFC 7597

2020-11-22 Thread Hans Dedecker
Hi Hauke, On Sun, Nov 22, 2020 at 12:33 AM Hauke Mehrtens wrote: > > I am not aware that any user space code uses this feature in OpenWrt and > maintaining this patch costs some effort especially when we add a new > kernel major version. The map package supports the creation of map-e interfaces

[PATCH] ethtool: update to version 5.9

2020-11-15 Thread Hans Dedecker
The ipkg sizes changes as follows for mips 24kc : 5.8 : ethtool_5.8-1_mips_24kc.ipk 34930 5.9 : ethtool_5.9-1_mips_24kc.ipk 35241 Signed-off-by: Hans Dedecker --- package/network/utils/ethtool/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] dropbear: update to 2.81

2020-11-14 Thread Hans Dedecker
Update dropbear to latest stable 2.81; for the changes see https://matt.ucc.asn.au/dropbear/CHANGES Refresh patches Signed-off-by: Hans Dedecker --- package/network/services/dropbear/Makefile | 6 +++--- .../network/services/dropbear/patches/110-change_user.patch | 2

[PATCH] iproute2: update to 5.9

2020-11-12 Thread Hans Dedecker
Update iproute2 to latest stable 5.9; for the changes see https://lwn.net/Articles/834755/ Refresh patches Signed-off-by: Hans Dedecker --- package/network/utils/iproute2/Makefile | 4 ++-- .../utils/iproute2/patches/115-add-config-xtlibdir.patch| 2 +- .../utils

Re: [PATCH] dnsmasq: 'ipset' config sections

2020-11-12 Thread Hans Dedecker
0 at 1:50 AM Hans Dedecker wrote: > > > > Hi, > > > > On Mon, Nov 9, 2020 at 11:55 AM Aleksandr Mezin > > wrote: > > > > > > Is something wrong with this patch? Should I CC someone to get the > > > patch reviewed? I'm unable to figure

Re: [PATCH] dnsmasq: 'ipset' config sections

2020-11-11 Thread Hans Dedecker
Hi, On Mon, Nov 9, 2020 at 11:55 AM Aleksandr Mezin wrote: > > Is something wrong with this patch? Should I CC someone to get the > patch reviewed? I'm unable to figure out who is the maintainer of > dnsmasq package Nothing wrong the patch as it looks fine; it just takes some time before

[PATCH] [RFT] glibc: update to latest stable version 2.32

2020-10-25 Thread Hans Dedecker
Update to latest stable version 2.32 refresh patches : 050-Revert-Disallow-use-of-DES-encryption-functions-in-n.patch 00-fix_cross_rpcgen.patch Signed-off-by: Hans Dedecker --- toolchain/glibc/common.mk | 6 +- ...use-of-DES-encryption-functions-in-n.patch

Re: [PATCH netifd 4/4] interface: proto_ip: order by address index first

2020-10-21 Thread Hans Dedecker
output consistent with linux network interfaces' primary/secondary > address settings. More importantly, the ubus output and dnsmasq config > generation will be more predictable. > > Signed-off-by: Yousong Zhou Acked-by: Hans Dedecker > --- > interface-ip.c | 11 +-- &g

Re: [PATCH netifd 3/4] device_addr: record address index as in the blob

2020-10-21 Thread Hans Dedecker
On Wed, Oct 21, 2020 at 5:08 AM Yousong Zhou wrote: > > Signed-off-by: Yousong Zhou Acked-by: Hans Dedecker > --- > interface-ip.h | 1 + > proto.c| 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/interface-ip.h b/interface-ip.h > in

Re: [PATCH netifd 2/4] proto: rework parse_addr to return struct device_addr

2020-10-21 Thread Hans Dedecker
On Wed, Oct 21, 2020 at 5:08 AM Yousong Zhou wrote: > > This is a preparation for the next commit to record address index for > the returned device_addr struct > > Signed-off-by: Yousong Zhou Acked-by: Hans Dedecker > --- > proto.c | 26 +++---

Re: [PATCH][netifd] system-linux: initialize ifreq struct before using it

2020-10-08 Thread Hans Dedecker
Hi Alin, On Thu, Oct 8, 2020 at 1:31 PM Alin Nastac wrote: Could you add which issue this fixes ? Thx Hans > > Signed-off-by: Alin Nastac > --- > system-linux.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/system-linux.c b/system-linux.c > index 6778b1d..9188899 100644 > ---

Re: [PATCH] wireguard-tools: bump to 1.0.20200827

2020-09-09 Thread Hans Dedecker
Hi, On Tue, Sep 8, 2020 at 6:30 PM Jason A. Donenfeld wrote: > > * ipc: split into separate files per-platform > > This is in preparation for FreeBSD support, which I had hoped to have this > release, but we're still waiting on some tooling fixes, so hopefully next > wg(8) will support that.

Re: [PATCH] ethtool: Update to version 5.8

2020-08-30 Thread Hans Dedecker
On Sat, Aug 29, 2020 at 10:15 PM Hauke Mehrtens wrote: > > Signed-off-by: Hauke Mehrtens Tested-by: Hans Dedecker > --- > package/network/utils/ethtool/Makefile | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/package/network/utils/ethtool/

Re: [PATCH] dropbear: allow disabling support for scp

2020-08-13 Thread Hans Dedecker
Hi, On Wed, Jul 22, 2020 at 3:34 PM Rui Salvaterra wrote: > > If not needed, disabling scp allows for a nice size reduction. > > Dropbear executable size comparison: > > 153621 bytes (baseline) > 133077 bytes (without scp) > > In other words, we trim a total of 20544 bytes. > > [Note: This patch

Re: [OpenWrt-Devel] [PATCH] odhcpd: remove bogus IPKG_INSTROOT reference

2020-06-10 Thread Hans Dedecker
hire-Bryant Acked-by: Hans Dedecker > --- > package/network/services/odhcpd/Makefile| 2 +- > package/network/services/odhcpd/files/odhcpd-update | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/network/services/odhcpd/Makefile

Re: [OpenWrt-Devel] [PATCH] netifd: Improve handling of device rename

2020-06-06 Thread Hans Dedecker
On Wed, Mar 11, 2020 at 2:13 PM Kristian Evensen wrote: > > After an interface has been renamed on a "fast" device (for example > x86_64), the interface is sometimes not handled correctly by netifd. > Looking in the logs, I see the following messages when renaming fails: > > Wed Mar 11 08:52:44

Re: [OpenWrt-Devel] [PATCH netifd] vlandev: support setting ingress/egress QoS mappings

2020-05-09 Thread Hans Dedecker
Hi, As a general remark it's better to use vlist_simple_tree and vlist_simple_node for the list implementation; for the reasons see below On Sun, May 3, 2020 at 7:43 PM Pau Espin Pedrol wrote: > > From: Pau Espin Pedrol > > It allows setting mappings for instance this way: > """ > config

Re: [OpenWrt-Devel] [PATCH netifd] vlandev: support setting ingress/egress QoS mappings

2020-05-01 Thread Hans Dedecker
Hi, On Tue, Apr 28, 2020 at 9:41 AM Pau Espin Pedrol wrote: > From: Pau Espin Pedrol > > It allows setting mappings for instance this way: > """ > config device > option name 'vlan41' > option type '8021q' > option vid '41' > option ifname 'eth1' > list ingress_qos_mapping '1:2' >

Re: [OpenWrt-Devel] Routes disappearing when ip "ip link set down ethX" and bring it up again

2020-05-01 Thread Hans Dedecker
On Thu, Apr 30, 2020 at 9:32 PM Philip Prindeville < philipp_s...@redfish-solutions.com> wrote: > Hi all, > > I noticed that if eth5 is my “wan” interface and I do: > > # ip link set down dev eth5 > > make some firewall changes, then do: > > # ip link set up dev eth5 > > then my routes don’t get

Re: [OpenWrt-Devel] [PATCH] dnsmasq: always inform about disabled dhcp service

2020-04-28 Thread Hans Dedecker
on particular interface is always provided. > > Signed-off-by: Petr Štetiar > Acked-by: Hans Dedecker > --- > package/network/services/dnsmasq/files/dnsmasq.init | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/package/network/servi

Re: [OpenWrt-Devel] [PATCH] tools/cmake: update to 3.17.0

2020-04-06 Thread Hans Dedecker
Hi, On Mon, Apr 6, 2020 at 12:38 AM Rosen Penev wrote: > Remove libressl patches. They are no longer needed. > Can you add why they're not needed anymore ? Thx Hans > > Replace qt tests patch with one that disables all of them. > > Refresh remaining one. > > Signed-off-by: Rosen Penev > ---

Re: [OpenWrt-Devel] [PATCH] netifd: fix 14_migrate-dhcp-release script

2020-04-04 Thread Hans Dedecker
On Sat, Apr 4, 2020 at 9:04 PM wrote: > >>> prepend 'uci' to 'commit network' > >> Can you explain why the prepend of 'uci' is required ? > >> In other words what is not working as I fail to spot the issue > > > > I think the author is right. "commit" is no command but an argument to > the uci

Re: [OpenWrt-Devel] [PATCH] netifd: fix 14_migrate-dhcp-release script

2020-04-04 Thread Hans Dedecker
Hi On Sat, Apr 4, 2020 at 8:46 PM wrote: > >> prepend 'uci' to 'commit network' > > Can you explain why the prepend of 'uci' is required ? > > In other words what is not working as I fail to spot the issue > > I think the author is right. "commit" is no command but an argument to the > uci

Re: [OpenWrt-Devel] [PATCH] netifd: fix 14_migrate-dhcp-release script

2020-04-04 Thread Hans Dedecker
Hi, On Fri, Mar 27, 2020 at 1:36 PM Peter Stadler < peter.stad...@student.uibk.ac.at> wrote: > prepend 'uci' to 'commit network' > Can you explain why the prepend of 'uci' is required ? In other words what is not working as I fail to spot the issue Hans > > Signed-off-by: Peter Stadler > ---

Re: [OpenWrt-Devel] [PATCH] umdns: fix 64-bit time format string

2020-03-28 Thread Hans Dedecker
On Fri, Mar 27, 2020 at 12:00 AM Rosen Penev wrote: > > Fixes compilation under musl 1.2.0 > > Signed-off-by: Rosen Penev > --- > service.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/service.c b/service.c > index 97b6f91..2a7c28f 100644 > --- a/service.c > +++

Re: [OpenWrt-Devel] [PATCH] odhcpd: fix compilation with musl 1.2.0

2020-03-28 Thread Hans Dedecker
Hi, On Fri, Mar 27, 2020 at 12:07 AM Rosen Penev wrote: > > SYS_clock_gettime is gone with musl 1.2.0. Switched to the function. > > Also fixed two format strings that fail as time_t is 64-bit with 1.2.0. > > Signed-off-by: Rosen Penev > --- > src/dhcpv6-ia.c | 8 > src/odhcpd.c|

Re: [OpenWrt-Devel] [PATCH] umdns: fix 64-bit time format string

2020-03-26 Thread Hans Dedecker
On Thu, Mar 26, 2020 at 1:53 AM Rosen Penev wrote: > > Fixes compilation under musl 1.2.0 > > Signed-off-by: Rosen Penev > --- > service.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/service.c b/service.c > index 97b6f91..f9d3b48 100644 > --- a/service.c > +++

Re: [OpenWrt-Devel] [PATCHv3] odhcpd: fix compilation with musl 1.2.0

2020-03-26 Thread Hans Dedecker
On Thu, Mar 26, 2020 at 12:13 AM Rosen Penev wrote: > > SYS_clock_gettime is gone with musl 1.2.0. Switched to the function. > > Also fixed two format strings that fail as time_t is 64-bit with 1.2.0. > > Signed-off-by: Rosen Penev > --- > v3: no need for linking to librt > v2: switch to

Re: [OpenWrt-Devel] [PATCH] netifd: fix compilation with musl 1.2.0

2020-03-25 Thread Hans Dedecker
On Wed, Mar 25, 2020 at 9:27 AM Petr Štetiar wrote: > > Rosen Penev [2020-03-24 22:56:19]: > > Hi, > > > --- a/system-linux.c > > +++ b/system-linux.c > > @@ -59,6 +59,10 @@ > > #define IFA_FLAGS (IFA_MULTICAST + 1) > > #endif > > > > +#ifndef __NR_clock_gettime > > +#define __NR_clock_gettime

Re: [OpenWrt-Devel] [PATCH] netifd: use the 64-bit version of clock_gettime

2020-03-22 Thread Hans Dedecker
hi, On Fri, Mar 20, 2020 at 10:59 PM Rosen Penev wrote: > > Fixes compilation with musl 1.2.0 which removes this syscall. > > Signed-off-by: Rosen Penev > --- > system-linux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/system-linux.c b/system-linux.c > index

Re: [OpenWrt-Devel] [PATCH] iproute2: revert add libcap support, enabled in ip-full

2020-03-16 Thread Hans Dedecker
Hi Mathias, On Sun, Mar 15, 2020 at 11:40 PM Mathias Kresin wrote: > > 05/03/2020 23:29, Alin Năstac: > > On Thu, Mar 5, 2020 at 8:34 PM Mathias Kresin wrote: > >> > >> This reverts commit a6da3f9ef746101b84a6f530f5a40de28341b69a. > > > > Not exactly a revert, since it keeps HAVE_CAP logic. > >

Re: [OpenWrt-Devel] [PATCH] iproute2: revert add libcap support, enabled in ip-full

2020-03-05 Thread Hans Dedecker
rnal packages feed. Therefore it is impossible to package > ip-full without having the external packages feed up and running, which > is a regression to the former behaviour. > > Signed-off-by: Mathias Kresin Acked-by: Hans Dedecker > --- > package/network/utils/iproute2/Makefi

Re: [OpenWrt-Devel] [PATCH] iproute2: update to 5.5.0, enable LTO

2020-02-13 Thread Hans Dedecker
On Wed, Feb 12, 2020 at 1:24 PM DENG Qingfang wrote: > > Update iproute2 to 5.5.0 > Enable LTO to save several KB of size > > Signed-off-by: DENG Qingfang Patch applied; thx Hans > --- > package/network/utils/iproute2/Makefile| 8 >

Re: [OpenWrt-Devel] [netifd][PATCH] interface-ip: transfer prefix route ownership to kernel when IPv6 address becomes deprecated

2020-02-04 Thread Hans Dedecker
Hi Alin, On Mon, Feb 3, 2020 at 4:27 PM Alin Nastac wrote: > > From: Alin Nastac > > When netifd manages the prefix route directly, it will remove it > the moment prefix gets deprecated. This will make it impossible > for the target to send ICMPv6 errors back to LAN devices still > using the

Re: [OpenWrt-Devel] [PATCH] ccache: update to 3.7.7

2020-01-16 Thread Hans Dedecker
On Thu, Jan 16, 2020 at 4:36 PM DENG Qingfang wrote: > > Update ccache to 3.7.7 > > Release notes: > https://ccache.dev/releasenotes.html#_ccache_3_7_7 > > Signed-off-by: DENG Qingfang Patch applied, thx Hans > --- > tools/ccache/Makefile | 4 ++-- >

Re: [OpenWrt-Devel] [OpenWrt-Devel, V3, 2/2] kmodloader: added -a arg to modprobe

2019-12-27 Thread Hans Dedecker
On Sat, Dec 21, 2019 at 2:32 AM Gerard Ryan wrote: > > Does anyone have any tips on how to expedite the review of this patch? > Am I missing something or is the patch malformed? Patch looks fine; some style comments inline Hans > > Thanks in advance, > Gerard > > On Tue, Oct 22, 2019 at 7:08 PM

Re: [OpenWrt-Devel] Inquery

2019-12-11 Thread Hans Dedecker
On Wed, Dec 11, 2019 at 3:22 PM Daniel Golle wrote: > > Hi Tomislav, > > On Wed, Dec 11, 2019 at 11:24:21AM +0100, Tom Psyborg wrote: > > suck it > > As a community, we decided to give our self a set of minimal rules[1]. > And even though it is in the last position, rule #12 "Be nice to each >

Re: [OpenWrt-Devel] The meaning of Signed-off-by for netifd [Was: Re: [PATCH netifd] interface: warn if ip6hint is truncated]

2019-12-03 Thread Hans Dedecker
On Tue, Dec 3, 2019 at 3:59 PM Uwe Kleine-König wrote: > > Hello Hans, > > On 12/3/19 8:50 AM, Hans Dedecker wrote: > > On Fri, Nov 29, 2019 at 9:29 PM Uwe Kleine-König > > wrote: > >> > >> On 11/29/19 8:50 PM, Hans Dedecker wrote: > >>

Re: [OpenWrt-Devel] [PATCH netifd] interface: warn if ip6hint is truncated

2019-12-02 Thread Hans Dedecker
Hi, On Fri, Nov 29, 2019 at 9:29 PM Uwe Kleine-König wrote: > > On 11/29/19 8:50 PM, Hans Dedecker wrote: > > On Wed, Nov 20, 2019 at 7:11 PM Uwe Kleine-König > > wrote: > >> > >> When for example a /60 is assigned to a network the last 4 bits of the >

Re: [OpenWrt-Devel] [PATCH netifd] interface: warn if ip6hint is truncated

2019-11-29 Thread Hans Dedecker
On Wed, Nov 20, 2019 at 7:11 PM Uwe Kleine-König wrote: > > When for example a /60 is assigned to a network the last 4 bits of the > ip6hint are unused. Emit a warning if any of these unused bits is set as > it indicates that someone didn't understand how the hint is used. (As I > did earlier

Re: [OpenWrt-Devel] [PATCH] netifd: dhcp proto convert release to norelease

2019-11-19 Thread Hans Dedecker
On Tue, Nov 19, 2019 at 4:12 PM Kevin Darbyshire-Bryant wrote: > > Change dhcp no/release on shutdown to 'norelease' uci option to match > existing proto dhcpv6 usage. > > Signed-off-by: Kevin Darbyshire-Bryant Acked-by: Hans Dedecker > --- > v2 - store the migrate script u

Re: [OpenWrt-Devel] script hook for odhcpd

2019-11-09 Thread Hans Dedecker
On Sat, Nov 9, 2019 at 2:43 AM Alberto Bursi wrote: > > I'm adding hotplug.d support to all DHCP events. > For now only dnsmasq triggers them, with > openwrt/package/network/services/dnsmasq/files/dhcp-script.sh > > DHCP clients like udcpc and udcp6c are easy to add as the client calls > a script

Re: [OpenWrt-Devel] [PATCH] odhcpd: router: Fix out of scope memory access

2019-09-03 Thread Hans Dedecker
On Mon, Sep 2, 2019 at 10:30 PM Hauke Mehrtens wrote: > > A pointer to search_buf is accessed by search_domain outside of the > if branch which defines search_buf. The compiler could already reuse > this memory. > > Coverity: #1445747 > Signed-off-by: Hauke Mehrtens > --- Patch applied; thx

Re: [OpenWrt-Devel] [PATCH] procd: fix shutdown when running in a container

2019-08-07 Thread Hans Dedecker
On Mon, Aug 5, 2019 at 6:09 PM Paul Spooren wrote: > > Applies patch from @mikma [0] to fix Docker shutdown. Added detection to > state.c if running in a containre or not. > > Tested with a x86/64 Docker image. > > Fixes FS#2425 > > CC: Mikael Magnusson > CC: Petr Štetiar > > [0]: >

Re: [OpenWrt-Devel] [PATCH-18.06] omcproxy: fix compilation on little-endian CPUs

2019-08-05 Thread Hans Dedecker
Hi, On Tue, Jul 23, 2019 at 5:02 AM Rosen Penev wrote: > > From: Eneas U de Queiroz > > Don't use cpu_to_be32 outside of a function. > > Signed-off-by: Eneas U de Queiroz This patch has already been applied in the past; see

Re: [OpenWrt-Devel] [PATCH] ppp: Add missing headers

2019-07-18 Thread Hans Dedecker
Hi, On Thu, Jul 18, 2019 at 3:36 AM Rosen Penev wrote: > > Fixes compilation with -Werror=implicit-function-declaration. > > Patch submitted upstream: https://github.com/paulusmack/ppp/pull/124 The upstream patch is not in line with the expected standards as described in

Re: [OpenWrt-Devel] [PATCH] wireguard: bump to 0.0.20190702

2019-07-02 Thread Hans Dedecker
On Tue, Jul 2, 2019 at 2:43 PM Jason A. Donenfeld wrote: > > * curve25519: not all linkers support bmi2 and adx > > This should allow WireGuard to build on older toolchains. > > * global: switch to coarse ktime > > Our prior use of fast ktime before meant that sometimes, depending on how > broken

Re: [OpenWrt-Devel] [PATCH] nghttp2: deduplicate files in staging_dir

2019-06-22 Thread Hans Dedecker
On Fri, Jun 21, 2019 at 3:05 PM Eneas U de Queiroz via openwrt-devel wrote: > > The sender domain has a DMARC Reject/Quarantine policy which disallows > sending mailing list messages using the original "From" header. > > To mitigate this problem, the original message has been wrapped >

Re: [OpenWrt-Devel] [PATCH 2/3] netsupport: improve xfrm module support

2019-06-16 Thread Hans Dedecker
On Sun, Jun 16, 2019 at 1:50 AM Andre Valentin wrote: > > Hi! > Am 15.06.19 um 21:35 schrieb Hans Dedecker: > > Hi, > > > > On Fri, Jun 14, 2019 at 1:10 PM André Valentin > > wrote: > >> > >> -switch to module autoprobe > >>

Re: [OpenWrt-Devel] [PATCH 2/3] netsupport: improve xfrm module support

2019-06-15 Thread Hans Dedecker
Hi, On Fri, Jun 14, 2019 at 1:10 PM André Valentin wrote: > > -switch to module autoprobe > -exclude 4.9 kernel > > Signed-off-by: André Valentin > --- > package/kernel/linux/modules/netsupport.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [OpenWrt-Devel] [PATCH 1/3] netifd: fix xfrm interface deletion and standardize netlink call

2019-06-15 Thread Hans Dedecker
On Fri, Jun 14, 2019 at 1:10 PM André Valentin wrote: > > -xfrm interfaces were deleted before > -use standard parameters for xfrm interface created > > Signed-off-by: André Valentin Patch merged; thx Hans > --- > system-linux.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >

Re: [OpenWrt-Devel] [PATCH 2/3] network/config/xfrm: add host-dependency for xfrm interface parent

2019-06-15 Thread Hans Dedecker
On Fri, Jun 14, 2019 at 1:10 PM André Valentin wrote: > > Add proto_add_host_dependency to add a dependency to the tunlink interface > > Signed-off-by: André Valentin Patch pushed to master; thx Hans > --- > package/network/config/xfrm/files/xfrm.sh | 19 +++ > 1 file changed,

Re: [OpenWrt-Devel] [PATCH v3 2/3] network/config: add xfrm interface support scripts

2019-06-13 Thread Hans Dedecker
On Thu, Jun 13, 2019 at 9:18 AM Andre Valentin wrote: > > Hi! > > On 13.06.19 08:44, Hans Dedecker wrote: > > Hi, > > > > On Wed, Jun 12, 2019 at 8:28 PM Andre Valentin > > wrote: > >> > >> Hi Hans!! > >> Am 11.06.19 um 22:16 sc

Re: [OpenWrt-Devel] [PATCH v3 2/3] network/config: add xfrm interface support scripts

2019-06-13 Thread Hans Dedecker
Hi, On Wed, Jun 12, 2019 at 8:28 PM Andre Valentin wrote: > > Hi Hans!! > Am 11.06.19 um 22:16 schrieb Hans Dedecker: > > Hi, > > > > On Mon, Jun 10, 2019 at 8:10 PM Andre Valentin > > wrote: > >> > >> Hi Hans, > >> > >>

Re: [OpenWrt-Devel] [PATCH v3 2/3] network/config: add xfrm interface support scripts

2019-06-11 Thread Hans Dedecker
and so on > > What do you think? The description is a bit cryptic to me; could you explain what works and what does not work and why ? Hans > > Kind regards, > > André > > > Am 09.06.19 um 21:27 schrieb Hans Dedecker: > > On Sat, Jun 8, 2019 at 1:48 PM André Vale

Re: [OpenWrt-Devel] [PATCH v3 2/3] network/config: add xfrm interface support scripts

2019-06-09 Thread Hans Dedecker
On Sat, Jun 8, 2019 at 1:48 PM André Valentin wrote: > > This package adds scripts for xfrm interfaces support. > Example configuration via /etc/config/network: > > config interface 'xfrm0' > option proto 'xfrm' > option mtu '1300' > option zone 'VPN' > option

Re: [OpenWrt-Devel] [PATCH v2 1/3] kernel/netsupport: add xfrmi interface support

2019-06-08 Thread Hans Dedecker
On Fri, Jun 7, 2019 at 12:46 AM André Valentin wrote: > > Add support for xfrm interfaces in kernel. XFRM interfaces are used by > the IPsec stack for tunneling. > XFRM interfaces are available since linux 4.19. > > --- > package/kernel/linux/modules/netsupport.mk | 14 ++ > 1 file

Re: [OpenWrt-Devel] [PATCH 2/3] netifd: add xfrm interface support scripts

2019-06-06 Thread Hans Dedecker
Hi, Comments inline Hans On Thu, Jun 6, 2019 at 3:52 PM André Valentin wrote: > > This package adds scripts for xfrm interfaces support. > Example configuration via /etc/config/network: > > config interface 'xfrm0' > option proto 'xfrm' > option mtu '1300' > option zone

Re: [OpenWrt-Devel] [PATCH] wireguard: bump to 0.0.20190531

2019-05-31 Thread Hans Dedecker
On Fri, May 31, 2019 at 6:50 PM Jason A. Donenfeld wrote: > > * tools: add wincompat layer to wg(8) > > Consistent with a lot of the Windows work we've been doing this last cycle, > wg(8) now supports the WireGuard for Windows app by talking through a named > pipe. You can compile this as

[OpenWrt-Devel] [PATCH 2/2] ppp: add config options to tune discovery timeout and attempts

2019-05-29 Thread Hans Dedecker
Signed-off-by: Hans Dedecker --- package/network/services/ppp/Makefile | 2 +- package/network/services/ppp/files/ppp.sh | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/package/network/services/ppp/Makefile b/package/network/services/ppp/Makefile index 3b36444289

[OpenWrt-Devel] [PATCH 1/2] ppp: update to version 2.4.7.git-2019-05-25

2019-05-29 Thread Hans Dedecker
8e77984 rp-pppoe plugin: Add options to tune discovery timeout and number of attempts Signed-off-by: Hans Dedecker --- package/network/services/ppp/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/network/services/ppp/Makefile b/package/network

Re: [OpenWrt-Devel] [PATCH v2] uci: fix options list of section after type change

2019-05-23 Thread Hans Dedecker
On Fri, May 17, 2019 at 2:30 PM Sven Eckelmann wrote: > > A section can store its name in the same memory region as the section > (after the actual section object). The object is then reallocated when the > type is later changed via an uci_set. But the original address of the > section is

Re: [OpenWrt-Devel] [PATCH] interface-ip: fix find locally addressable target for p2p

2019-05-17 Thread Hans Dedecker
Hi, On Fri, May 17, 2019 at 7:27 PM Tan Xiaofan wrote: > > Hi > > > Can you share the network config which requires this patch ? > > > > Hans > > config interface 'wan' > option ifname 'eth0' > option proto 'dhcp' > > config interface 'iptun' > option proto 'l2tp' >

Re: [OpenWrt-Devel] [PATCH] interface-ip: fix find locally addressable target for p2p

2019-05-17 Thread Hans Dedecker
On Fri, May 17, 2019 at 7:27 PM Tan Xiaofan wrote: > > Hi > > > Can you share the network config which requires this patch ? > > > > Hans > > config interface 'wan' > option ifname 'eth0' > option proto 'dhcp' > > config interface 'iptun' > option proto 'l2tp' >

Re: [OpenWrt-Devel] [PATCH] interface-ip: fix find locally addressable target for p2p

2019-05-17 Thread Hans Dedecker
Hi, On Thu, May 16, 2019 at 8:00 PM Tan Xiaofan wrote: > > Hi, the email replace TAB with SPACE, so apply failed. > So, I put the patch file in my server > > > http://167.88.124.64/0001-interface-ip-fix-find-locally-addressable-target-for.patch Can you share the network config which

Re: [OpenWrt-Devel] [PATCH] interface-ip: fix find locally addressable target for p2p

2019-05-16 Thread Hans Dedecker
Hi On Thu, May 16, 2019 at 5:09 PM Tan Xiaofan wrote: > > Hi, I add some explanation to the patch > > From 57007eef77f266e40640a2c76aabd56fd37553f7 Mon Sep 17 00:00:00 2001 > From: xiaofan > Date: Thu, 16 May 2019 21:12:47 +0800 > Subject: [PATCH] interface-ip: fix find locally addressable

Re: [OpenWrt-Devel] [PATCH] interface-ip: fix find locally addressable target for p2p

2019-05-16 Thread Hans Dedecker
Hi, On Thu, May 16, 2019 at 4:01 PM Tan Xiaofan wrote: > > From d0e1cb81b45ec825199d499cda9c8daef94e13a5 Mon Sep 17 00:00:00 2001 > From: xiaofan > Date: Thu, 16 May 2019 21:12:47 +0800 > Subject: [PATCH] interface-ip: fix find locally addressable target for p2p The patch fails to explain why

Re: [OpenWrt-Devel] [PATCH v2] procd: detect lxc container and behave accordingly

2019-05-05 Thread Hans Dedecker
On Sat, May 4, 2019 at 10:30 PM Paul Spooren wrote: > > meaning to not mount some specific parts witch cause trouble. > > The patch is based on previous work of @mikma to combine OpenWrt with > lxd[0]. This patch however adds a detection copied from *virt-what* to > check /proc/1/environment for

Re: [OpenWrt-Devel] [PATCH v2 1/2] scripts/qemustart: no network by default and enable with -n

2019-04-25 Thread Hans Dedecker
ar > Signed-off-by: Yousong Zhou Acked-by: Hans Dedecker > --- > v2 <- v1 > > - Rebase on current master branch > - Fix logic invert in check_setup() of v1 > - Reword commit message > > scripts/qemustart | 12 +++- > 1 file changed, 7 insertions(+)

Re: [OpenWrt-Devel] [PATCH 1/2] scripts/qemustart: no-network by default and enable with -n

2019-04-25 Thread Hans Dedecker
Hi Yousong, On Thu, Apr 25, 2019 at 4:29 PM Yousong Zhou wrote: > > Before this change, we have no way to have network on as both bash and > zsh have zero exit status for "[ -n ]" and "[ -z ]" > > By running qemu without network by default we make common usage of and > first encounter with

Re: [OpenWrt-Devel] [PATCH] openssl: fix OPENSSL_config bug affecting wget

2019-04-22 Thread Hans Dedecker
On Mon, Apr 22, 2019 at 6:39 PM Eneas U de Queiroz via openwrt-devel wrote: > > The sender domain has a DMARC Reject/Quarantine policy which disallows > sending mailing list messages using the original "From" header. > > To mitigate this problem, the original message has been wrapped >

Re: [OpenWrt-Devel] odhcpd problem

2019-04-19 Thread Hans Dedecker
Hi, On Fri, Apr 19, 2019 at 7:36 AM e9hack wrote: > > Hi, > > I've trouble with this patch: > > router: improve code readability > No functional changes; just improve code readabilty in send_router_advert() > > I'm using odhcpd a little bit modified. Odhcpd does not provide dhcpv6, but > it

  1   2   3   4   5   >