[PATCH] procd: procd.sh: make no assumptions about init script path

2021-11-23 Thread Jo-Philipp Wich
` which corresponds to `argv[0]` when readlink failed. This fixes reload trigger setup for init script symlinks that point to files with different base names. Signed-off-by: Jo-Philipp Wich --- package/system/procd/files/procd.sh | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff

[RFC PATCH] treewide: drop librt and libpthread packages

2021-11-18 Thread Jo-Philipp Wich
them as extra shared libraries. Signed-off-by: Jo-Philipp Wich --- package/devel/perf/Makefile | 2 +- package/devel/valgrind/Makefile | 2 +- package/libs/libevent2/Makefile | 2 +- package/libs/libnl/Makefile | 1 - package/libs

[PATCH] procd: setup /dev/stdin, /dev/stdout and /dev/stderr symlinks

2021-11-18 Thread Jo-Philipp Wich
Extend the hotplug.json ruleset to setup the common /dev/std{in,out,err} symbolic links which are needed by some applications, e.g. nftables when applying rulesets from stdin. Signed-off-by: Jo-Philipp Wich --- package/system/procd/files/hotplug.json | 12 +++- 1 file changed, 11

Re: Missing 'libubus.so' and change of ABI in 19.07.8

2021-11-13 Thread Jo-Philipp Wich
Hi, > But I really can't see the breaking change, could you please point it out for > me? struct ubus_client changed its layout. > The second question is the change of the library name from 'libubus.so' to > 'libubus.so.20210603'. Was this intended? Yes, it was intentional. Programs should

Re: [PATCH firewall4 1/2] tests: adapt test to new ICMP print logic

2021-10-24 Thread Jo-Philipp Wich
Hi, merged both patches, thank you! ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] nftables: bump to 1.0.0

2021-10-17 Thread Jo-Philipp Wich
Hi, > Signed-off-by: Stijn Tintel Acked-by: Jo-Philipp Wich signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH 2/2] hostapd: force ieee80211w instead of setting a default

2021-10-11 Thread Jo-Philipp Wich
Hi, > right now luci will force 2 nope, it will not. It calculates the dynamic default according to the logic in hostapd.sh and will remove the value from uci if the selected user value matches the dynamic default [1]. So with WPA3 selected and choosing 11w ... ... required -> remove option

Re: [PATCH 2/2] hostapd: force ieee80211w instead of setting a default

2021-10-11 Thread Jo-Philipp Wich
Hi, > Doesn't that downgrade PSK-SAE which the user configured to be with > mandatory MFP to now only have optional MFP? yes. The way I read it, it also prevents using the WPA3 protocol without obligatory MFP (afair some users use that for limited drivers) ~ Jo signature.asc Description:

Re: RFC: toolchain for building eBPF modules within the OpenWrt build system

2021-10-04 Thread Jo-Philipp Wich
Hi Felix, I'd suggest to require a preinstalled host toolchain for the time being. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] base-files: make os-release symbolic link absolute

2021-09-08 Thread Jo-Philipp Wich
Hi, > Did you check that none of the build scripts try to access this file? In > case they do, they'd fail since an absolute path wouldn't exists on the > building host system. apart from that it might break 3rd party workflows for no obvious reason. The existing absolute symlinks mentioned all

Re: [PATCH luci] luci-mod-network: wireless.js: allow changing the 60 GHz radio's frequency

2021-07-09 Thread Jo-Philipp Wich
Hi Alex, thank you for this patch. Based on your submission I pushed a somewhat smaller fix to LuCI master which omits the last two hunks: https://github.com/openwrt/luci/commit/e5626ece12236f6be9dbb6da6eb90fcbb469a1f0 The code related to the `hwmode` option is there for backwards compatibility

Re: [PATCH 19.07 4/4] treewide: mark selected packages nonshared

2021-07-03 Thread Jo-Philipp Wich
Hi, > I've never seen a non integer release, is there a special reason for this? I used to do that in the past when backporting master changes to branches that didn't apply cleanly anymore. In this case the package contents between master and release branches deviated while keeping the same

Re: ip rule processing partly broken (21.02 and Master)

2021-06-14 Thread Jo-Philipp Wich
Hi, the ip rules encoded in /etc/config/network are processed by netifd C code directly, they're not translated into busybox ip calls. The entire busybox ip.c code contains not a single instance of FIB_RULE_INVERT so it simply does not implement inversion. It will also not be able to report

Re: Luci->Network->Interfaces is broken

2021-06-09 Thread Jo-Philipp Wich
Hi, > It works now (no error message), but the bad thing is, it isn't visible in > LuCI, which wireless adapter's are attached to the bridge and it needs some > clicks to see which interfaces (wired ports) are attached to the bridge. > > I don't like this solution in LuCI. Fixed with

Re: [PATCH 19.07] ubus: update to version 2021-06-03

2021-06-03 Thread Jo-Philipp Wich
Hi Petr, does that change the libubus abi? ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] busybox: sysntpd: add trigger to reload server

2021-06-01 Thread Jo-Philipp Wich
Hi, >> start_service() { >> +. /lib/functions/network.sh > > > This doesn't look right. It's usually added at the top of the file, unnested. Which would be the wrong thing to do here. Since the init script is run on the host system during build (to enable it), it must not source files

Re: Interface names when putting 802.1q VLAN on top of bonding configuration

2021-06-01 Thread Jo-Philipp Wich
Hi, > One more question, now I'm trying to put a bridge on top of each of these > vlan* interfaces so that I can map those to a few physical interfaces. I also > need several vlans to map to one of the interfaces (tagged).. not sure how to > do that yet either. Any suggestions with this

Re: [PATCH] base-files: simplify setting device MAC

2021-06-01 Thread Jo-Philipp Wich
Hi, > Ideally you should be able to use jsonfilter too but I don't know how to > deal with "-" in a property name. Use bracket notation. > Following doesn't work for me: > > ubus call network.device status '{ "name": "br-lan" }' | jsonfilter -e > "$.bridge-members" ubus call network.device

Re: Luci->Network->Interfaces is broken

2021-05-31 Thread Jo-Philipp Wich
Hi, > This is the reason. Long time ago, I did select the option 'Remove ipkg/opkg > status data files in final images' to reduce the image size. Since such an > option can be selected, LuCI cannot assume, that the file netifd.control > exists. fixed. ~ Jo signature.asc Description:

Re: Interface names when putting 802.1q VLAN on top of bonding configuration

2021-05-28 Thread Jo-Philipp Wich
Hi, the following should do what you want. config device option type 8021q option ifname bonding-lan option vid 20 option name vlan20 config interface vlan20 option ifname vlan20 option proto static option ipaddr 172.20.34.2 option netmask 255.255.255.128 ~ Jo signature.asc

Merged: rules: fix device and chain usage forDSCP/MARK targets

2021-03-23 Thread Jo-Philipp Wich
Merged into project/firewall3.git, branch master at http://git.openwrt.org/?p=project/firewall3.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Merged: zone: avoid duplicates in devices list

2021-03-23 Thread Jo-Philipp Wich
Merged into project/firewall3.git, branch master at http://git.openwrt.org/?p=project/firewall3.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH 1/2] uhttpd: Reload config after uhttpd-mod-ubus was added

2021-03-20 Thread Jo-Philipp Wich
Hi Hauke, thanks for looking into it! I have a couple of remarks... > [...] > [ "$(uci -q get uhttpd.main.ubus_socket)" = "/var/run/ubus.sock" ] && { > uci set uhttpd.main.ubus_socket='/var/run/ubus/ubus.sock' > uci commit uhttpd > + reload_config That might reload other,

Re: Question about LuCI state (incl DSA) & request for testing

2021-02-12 Thread Jo-Philipp Wich
Hi, > I'd like to ask: what's the current state of LuCI? > One thing that probably requires some extra focus is DSA. Are there > any remaining issues regarding it? some parts of the DSA/device config code are intentionally disabled since netifd didn't handle these things at the time it was

Re: Revisiting ABI_VERSION handling policy

2021-02-09 Thread Jo-Philipp Wich
Hi, > The last stable update didn't change SONAME, but it included changes to > the same data structure that triggered the bug that I ran into. It could > very likely have introduced very similar subtle breakage. this is a clear upstream bug then. Might make sense to look into how other

Re: Revisiting ABI_VERSION handling policy

2021-02-09 Thread Jo-Philipp Wich
Hi, > The goal of reducing unnecessary build churn makes perfect sense to me, > but I think we need to reconsider the trade-off we're making here, and > the failure modes of each option. the motivation wasn't about build-churn at all but to ensure that library packages can be cleanly upgraded

Re: Job board support on openwrt.org?

2021-01-23 Thread Jo-Philipp Wich
Hi, I don't think this is a good idea due to legal obligations, administrative hassle, quality of work issues and so on. NACK from me. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: Dnsmasq 2.83 causes log spam

2021-01-22 Thread Jo-Philipp Wich
Hi Hannu, unfortunately we lack a reliable reproducer so far. A packet capture would be most helpful, another option would be a bisect of the intermediate dnsmasq Git revisions. ~ Jo signature.asc Description: OpenPGP digital signature ___

Re: Add package version dependency for point releases

2021-01-11 Thread Jo-Philipp Wich
Hi, why not simply wrap the workaround in a uname or /proc/version check? ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [PATCH] wireguard-tools: allow generating private_key

2021-01-08 Thread Jo-Philipp Wich
Hi, I'm afraid this approach is not really acceptable. Automatically calling `uci commit` outside of the early-boot / uci-defaults context is not safe. There could be arbitrary user defined, intentionally uncommitted changes stashed when the ifup sequence is running which you would inadvertently

Re: [PATCH 1/3] rules: add commitcount function

2021-01-07 Thread Jo-Philipp Wich
Hi, I think this change will introduce massive overhead during the DUMP phase of the buildroot when scanning package metadata. You should wrap the logic into an `ifneq ($(DUMP),1)` or similar and simply return a static placeholder value if DUMP==1 ~ Jo signature.asc Description: OpenPGP

Re: R: [RPCD PATCH v4 3/4] iwinfo: add ht and vht operation info to wifi scan

2021-01-06 Thread Jo-Philipp Wich
Hi, > I didn't add the check here as we can assume that ht_operation are always > present. > Should I add this anyway? why can we assume it? They way I see it, HT info is only populated if IE type 61 was present, valid and parsed from BSS info, otherwise the structure mightr be present but

Re: [RPCD PATCH v4 4/4] iwinfo: export center channel for info ubus call

2021-01-05 Thread Jo-Philipp Wich
Hi, comment below. > [...] > diff --git a/iwinfo.c b/iwinfo.c > index 45ca784..94fa822 100644 > --- a/iwinfo.c > +++ b/iwinfo.c > @@ -364,6 +364,8 @@ rpc_iwinfo_info(struct ubus_context *ctx, struct > ubus_object *obj, > > rpc_iwinfo_call_int("mode", iw->mode, IWINFO_OPMODE_NAMES); >

Re: [RPCD PATCH v4 3/4] iwinfo: add ht and vht operation info to wifi scan

2021-01-05 Thread Jo-Philipp Wich
Hi, comments below. > [...] > @@ -441,6 +441,20 @@ rpc_iwinfo_scan(struct ubus_context *ctx, struct > ubus_object *obj, > blobmsg_add_u32(, "quality", e->quality); > blobmsg_add_u32(, "quality_max", e->quality_max); > Only add the "ht_operation"

Re: [IWINFO PATCH v4 2/4] iwinfo: export center_chan info for local wifi

2021-01-05 Thread Jo-Philipp Wich
Hi, comments below. > [...] > diff --git a/include/iwinfo.h b/include/iwinfo.h > index 676db91..680f384 100644 > --- a/include/iwinfo.h > +++ b/include/iwinfo.h > @@ -282,6 +282,8 @@ struct iwinfo_ops { > int (*survey)(const char *, char *, int *); > int (*lookup_phy)(const char *,

Re: [IWINFO PATCH v4 1/4] iwinfo: export ht and vht operation in scan results

2021-01-05 Thread Jo-Philipp Wich
Hi, comments inline below. > [...]@@ -2306,6 +2306,16 @@ static void nl80211_get_scanlist_ie(struct nlattr > **bss, > iwinfo_parse_rsn(>crypto, ie + 6, ie[1] - 4, >IWINFO_CIPHER_TKIP, > IWINFO_KMGMT_PSK); >

Re: [PATCH 1/2 iwinfo] iwinfo: add support for GCMP cipher

2021-01-05 Thread Jo-Philipp Wich
Hi, before merging this, please extend the cmake rules in iwinfo.git to add a SOVERSION property to the resulting libiwinfo library, this way we can adopt ABI versio ntracking when we bump it the next time in OpenWrt. ~ Jo signature.asc Description: OpenPGP digital signature

Merged: libnetfilter-conntrack: update to 1.0.8

2020-12-14 Thread Jo-Philipp Wich
Merged into master at http://git.openwrt.org/?p=openwrt/openwrt.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] uhttpd: don't redirect to HTTPS by default

2020-12-14 Thread Jo-Philipp Wich
Hi, > So we can ship px5g-wolfssl by default in the release image, but still > make the HTTPS for LuCI optional. This small change with addition of > `CONFIG_PACKAGE_px5g-wolfssl=y` into the buildbot's seed config for the > next release should provide optional HTTPS in the next release. please

Re: [luci PATCH 05/13] luci-mod-status: use the new ubus dsl metrics

2020-12-11 Thread Jo-Philipp Wich
Hi, > This is significantly faster. great work! I like it :) Minor nitpick below. > [...] > -var callLuciDSLStatus = rpc.declare({ > - object: 'luci-rpc', > - method: 'getDSLStatus', > +var call_dsl_metrics = rpc.declare({ > + object: 'dsl', > + method: 'metrics', >

Merged: firewall3: fix duplicate defaults section detection

2020-12-06 Thread Jo-Philipp Wich
Merged into project/firewall3.git, branch master at http://git.openwrt.org/?p=project/firewall3.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Merged: ipsets: allow blank/commented lines withloadfile

2020-12-06 Thread Jo-Philipp Wich
Merged into project/firewall3.git, branch master at http://git.openwrt.org/?p=project/firewall3.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: Lightweight policy-based routing

2020-12-04 Thread Jo-Philipp Wich
Hi Philip, ip rules are possible in uci, but not sure if all the bits you require are covered: https://openwrt.org/docs/guide-user/network/ucicheatsheet#ip_rules_for_both_rule_and_rule6 `config route` sections allow specifying `option table` as well to stage the routes in the non-main rttable.

Re: [PATCH] ltq-dsl-base: only lock the dsl pipe once for all stats

2020-12-04 Thread Jo-Philipp Wich
Hi, is there any reason not to use the flock style below? It should be more reliable wrt. unlocking if the script is prematurely terminated. -- 8< -- { flock -x 1000 command command command ... } 1000>/var/lock/dsl_pipe -- >8 -- See also the fourth example at

Re: [PATCH] netifd: add segment routing support

2020-12-02 Thread Jo-Philipp Wich
Hi, the chosen option name does not really fit other existing bool options which do not use an enable(d) or disable(d) prefix/suffix. I'd call the new option simply `seg6` or even better `ip6segmentrouting` to fall in line with other IPv6 specific options [1] ~ Jo 1:

Re: [PATCH] openvpn: update to 2.5.0

2020-11-30 Thread Jo-Philipp Wich
Hi, [...] > @@ -137,6 +143,7 @@ allow_recursive_routing > auth_nocache > auth_user_pass_optional > bind > +block-ipv6 I suppose this needs to be `block_ipv6` ? > ccd_exclusive > client > client_to_client > @@ -185,10 +192,13 @@ tls_server > up_delay > up_restart >

Download server downtime

2020-11-24 Thread Jo-Philipp Wich
mirrors [1] which you can use to download OpenWrt binaries in case the main download server is unavailable. Please excuse the inconvenience and troubles caused. Kind regards, Jo-Philipp Wich 1: https://openwrt.org/downloads#mirrors ___ openwrt-devel

Re: [PATCH v4] build: create $(PKG_SYMVERS_DIR) if non-existent

2020-11-19 Thread Jo-Philipp Wich
Hi Sebastian, thanks for following up with a v4. I merged this change in https://git.openwrt.org/2127accd441b1c979c8f3f56f3ad5264542e185a now. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: Upcoming 19.07.4 and 18.07.9 stable releases

2020-11-14 Thread Jo-Philipp Wich
Hi, > Are there any real blockers left? LuCI support for bridge-vlan config is unmerged/unpolished yet. I'd rather not ship 20.x without functioning switch config support in the ui. ~ Jo signature.asc Description: OpenPGP digital signature ___

Re: [PATCH] rpcd: Add support for plugin command input via argv[3] ($3)

2020-11-11 Thread Jo-Philipp Wich
Hi, the request payload can theoretically become very big, something in the few hundred kilobyte to one megabyte ballpark. I am not sure if it is a good idea to pass that via the argv vector. ~ Jo ___ openwrt-devel mailing list

Re: x86/64 SDK segfaults on some hosts [Was: Re: [PATCH 1/2] fakeroot: make fakeroot script relocatable]

2020-11-09 Thread Jo-Philipp Wich
Hi, > it seems like mixing dynamic loader from the host and libraries from SDK > doesn't work reliably in all cases and may result in crash. Yes, that is why we wrap the SDK executables to forcibly invoke them through the bundled loader. Attempting to use SDK executables or librries with the

Re: [PATCH v2] scripts: bundle-libraries.sh: fix broken SDK compiler

2020-11-01 Thread Jo-Philipp Wich
*) > + file "$bin" | grep -sqE "ELF.*(executable|interpreter)" && > return 0 Apart from this apparently inconsistent indentation (tabs vs. spaces?) - LGTM. Assuming the white space is straightened out... Acked-by: Jo-Philipp Wich ___

Re: [PATCH] scripts: bundle-libraries.sh: fix broken SDK compiler

2020-11-01 Thread Jo-Philipp Wich
Hi Petr, instead of meddling with the file permissions (which might cause unwanted side effects for .so's that *are* supposed to be executable) I'd suggest to simply skip *.so files by name. Something along the lines of: case "$BIN" in *.so|*.so.[0-9]*) : ;; *) [ -n "$LDD" ] && [ -x

Merged: zram-swap: default to lzo instead of lzo-rle compression

2020-09-17 Thread Jo-Philipp Wich
Merged into my staging tree at http://git.openwrt.org/?p=openwrt/staging/jow.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH 2/2] rules.mk: simplify FAKEROOT command line

2020-09-10 Thread Jo-Philipp Wich
Hi again, > please disregard, I made a logical mistake and forgot that the OS X check is > about the *.dylib vs. *.so extension, not the library location. actually it seems fine after all since the proper extension is embedded in the fakeroot script according to whats applicable to the host

Re: [PATCH 2/2] rules.mk: simplify FAKEROOT command line

2020-09-10 Thread Jo-Philipp Wich
Hi, please disregard, I made a logical mistake and forgot that the OS X check is about the *.dylib vs. *.so extension, not the library location. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list

[PATCH 1/2] fakeroot: make fakeroot script relocatable

2020-09-10 Thread Jo-Philipp Wich
invoke fakeroot and subsequently allows us to drop OS X specific logic. Signed-off-by: Jo-Philipp Wich --- tools/fakeroot/patches/000-relocatable.patch | 25 1 file changed, 25 insertions(+) create mode 100644 tools/fakeroot/patches/000-relocatable.patch diff --git a/tools

[PATCH 2/2] rules.mk: simplify FAKEROOT command line

2020-09-10 Thread Jo-Philipp Wich
Since fakeroot is patched to discover related ressources relative to the STAGING_DIR_HOST environment variable, there is no need to pass the path to faked or the preload library manually anymore. Signed-off-by: Jo-Philipp Wich --- rules.mk | 7 +-- 1 file changed, 1 insertion(+), 6

Re: [OpenWrt-Devel] [PATCHv3] mdadm: revised mdadm config & init logic

2020-09-10 Thread Jo-Philipp Wich
Hi, comments inline. On 1/23/20 3:56 AM, Rosen Penev wrote: > From: Joseph Tingiris > > This is a significant revision of /etc/init.d/mdadm. It adds new > features, support for new configuration options, safer error > handling, (configurable) verbose output, and contains multiple bug > fixes.

Re: [PATCH] libcxxabi: fix compilation under the SDK

2020-09-10 Thread Jo-Philipp Wich
Hi, > + $(MAKE) -C $(TOPDIR)/$(if > $(CONFIG_IN_SDK),feeds/base/)package/libs/libcxx prepare this looks like an ugly hack, also the feed is not guaranteed to reside in feeds/base/ - the user can theoretically change the name of the base feed. Why does this package need to trigger an

Re: UCI: Making a config read-only?

2020-08-26 Thread Jo-Philipp Wich
Hi, > Is there a way to truly make a configuration read only in UCI, so that > changes are rejected, and not stored in /tmp/.uci/ ? there is no such facility implemented in uci or libuci. ~ Jo signature.asc Description: OpenPGP digital signature

Re: [PATCH] tools: always create $STAGING_DIR/usr/{include,lib}

2020-08-25 Thread Jo-Philipp Wich
Hi, > Pretty much all packages stage into staging_dir/target-*/usr - I don't > think there are any -I/-L flags we can remove. we're patching the gcc specs [1], [2] to implicitly add $STAGING_DIR/usr/lib to the link- and $STAGING_DIR/usr/include to the CPP flags. There is no need to globally pass

Re: [PATCH] tools: always create $STAGING_DIR/usr/{include,lib}

2020-08-25 Thread Jo-Philipp Wich
Hi, > Isn't that breaking some packages which currently use `/usr/lib`? > > packages.git/boost: > https://github.com/openwrt/packages/blob/e2e152da599ceeacf06b4a045b5b391107d194df/libs/boost/Makefile#L485 I don't see how. The code you quoted creates the destination directory directly in the

Re: [PATCH] tools: always create $STAGING_DIR/usr/{include,lib}

2020-08-24 Thread Jo-Philipp Wich
Hi, > rules.mk always passes these as -I/-L to the toolchain. > > Fixes rare errors like: > cc1: error: staging_dir/target-aarch64_cortex-a53_musl/usr/include: No such > file or directory [-Werror=missing-include-dirs] > > Signed-off-by: Andre Heider NAK - I'd prefer if we remove the

Re: Announcement: Removal of 4.14 kernel from master

2020-08-20 Thread Jo-Philipp Wich
Hi, > Why is ar71xx no longer going to be supported? because development shifted towards the upstream-approved and device tree based ath79 target. > This includes Netgear WNDR-3700-v4 which is a very popular and reliable router > in the OpenWRT community. The Netgear WNDR-3700-v4 is supported

Merged: options: fix parsing of boolean attributes

2020-08-20 Thread Jo-Philipp Wich
Merged into project/firewall3.git, branch master at http://git.openwrt.org/?p=project/firewall3.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: jsonfilter and queries with '-' in them

2020-08-13 Thread Jo-Philipp Wich
Hi, > Could you write a little bit about the underlying cause of this just > so I can understand better? it is basically mimicking JavaScript object access syntax where labels after a dot must be valid identifiers. In JS, an expression `obj.foo-bar.baz` would be interpreted as `obj.foo` minus

Re: jsonfilter and queries with '-' in them

2020-08-12 Thread Jo-Philipp Wich
Hi, as already implied by Dirk, you need to use bracket notation for labels that are not valid variable identifiers. So instead of `@.foo-bar` use `@["foo-bar"]`. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing

Merged: tools/firmware-utils: use UTC for image timestamps

2020-08-07 Thread Jo-Philipp Wich
Merged into my staging tree at http://git.openwrt.org/?p=openwrt/staging/jow.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH 3/4] build: image: remove strange useless comment

2020-08-06 Thread Jo-Philipp Wich
Hi Adrian, > compat_version=$(if $(DEVICE_COMPAT_VERSION),$(DEVICE_COMPAT_VERSION),1.0) > json_quote=$(subst ','\'',$(subst ",\",$(1))) > -#")') This commit was most likely added to aid text editors with naive syntax highlighting capabilities that fail to properly detect the end of the string

Re: [PATCH uhttpd] ubus: rename JSON-RPC format related functions

2020-08-06 Thread Jo-Philipp Wich
Hi, > Use "_json_rpc_" in their names so it's clear they are related to the > JSON-RPC format. This cleans up code a bit and will allow adding more > formats in the future. > > Signed-off-by: Rafał Miłecki Acked-by: Jo-Philipp Wich signature.asc Description:

Re: [PATCH V2 uhttpd] ubus: add new RESTful API

2020-08-04 Thread Jo-Philipp Wich
Hi, > Regarding parsing events stream, event names with spaces seem to be OK: > https://html.spec.whatwg.org/multipage/server-sent-events.html#parsing-an-event-stream To me it feels quirky to separate the path and the type of the event by space. Personally I'd only report the type as "event:"

Re: github private respositories

2020-08-01 Thread Jo-Philipp Wich
Hi, > Is there a way to compile github private repositories as package in openwrt? PKG_SOURCE_URL:=https://githubuser:githubp...@github.com/project/repo.git or PKG_SOURCE_URL:=g...@github.com:project/repo.git or PKG_SOURCE_URL:=ssh://g...@github.com/project/repo.git The first one only

Re: [PATCH] kernel: add missing config symbol

2020-07-31 Thread Jo-Philipp Wich
Hi, > Signed-off-by: Stijn Tintel Acked-by: Jo-Philipp Wich signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH 0/3] Support TLS/SSL and WPA3-Personal/SAE by default

2020-07-27 Thread Jo-Philipp Wich
Hi, >> How stable is the ABI of wolfssl? > > I assume, that we're going to find the answer in the upcoming years :-) see https://abi-laboratory.pro/index.php?view=timeline=wolfssl for the historic track record. Compared to OpenSSL here: https://abi-laboratory.pro/index.php?view=timeline=openssl

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-24 Thread Jo-Philipp Wich
Hi Felix, > [...] > > For a simple default config, you could have this: > > # network > config device option type bridge # I assume this is needed as well > option name switch0 > > config bridge-vlan > option vlan 1 > option ports "lan1 lan2 lan3 lan4" > >

Re: [RFC] Writing sysupgrade.tgz directly to overlay for block-device sysupgrade

2020-07-24 Thread Jo-Philipp Wich
Hi David, > Instead of using the overlay filesystem du jour, perhaps it makes more > sense to simply put the tarball itself, raw, on the loop device > immediately after the end of the squashfs? I suppose the limiting factor for the maximum backup size would be the amount of available RAM then?

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-24 Thread Jo-Philipp Wich
Hi Luiz, I mostly agree with your proposal (though I'd call "device_for" simply "bridge" instead but that's details). I don't think everything can be simply switched in one go but I do think your proposal could be broken down into the following measures. The simple things: - Rename "config

Re: [PATCH v2 firewall3] zones: apply tcp mss clamping also on ingress path

2020-07-24 Thread Jo-Philipp Wich
Hi, > Fixes FS#3231 > > Signed-off-by: Yousong Zhou Acked-by: Jo-Philipp Wich signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinf

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Jo-Philipp Wich
Hi again, > What about spelling out the dependency explicitly? Instead of overloading the > meaning of "option network", add an "option bridge" instead which reuses the > existing vlan notation followed by a vlan id spec as defined by the "option > ports" notation for bridge devices, e.g. That

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Jo-Philipp Wich
Hi, > 1. Have VLAN devices on top of vlan-enabled bridges to define hotplug > ops where applicable, so LAN could be a plain VLAN interface switch0.1 > instead of its own bridge. > 2. With these wrapper hotplug ops, a default VLAN would be passed as > well, unless overwritten by other VLAN

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Jo-Philipp Wich
Hi, yeah I forgot to elaborate that in my last mail. The problem of dynamic / not explicitly addressable wifi interface names in the network config remains. The best solution I can think of is fixing the wifi ifnames using "option ifname" in the wifi-iface sections (which causes some very

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Jo-Philipp Wich
Hi, > Related to this, is it possible to add a wireless interface to a > bridge specifying a non-default PVID? I would have expected that something like config bridge-vlan option device mybridge0 option vlan 100 option ports 'wlan0:u*' achieves that effect. The wlan0 interface would be

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-23 Thread Jo-Philipp Wich
Hi, > One thing which is a bit awkward as long as the bridge itself is > configured as an interface, is that as far as I have understood, > creating a tagged interface to the bridge requires first setting up an > interface for the bridge, e.g. with protocol Unmanaged, and then > setting up one or

Re: [PATCH firewall3] zones: apply tcp mss clamping also on ingress path

2020-07-23 Thread Jo-Philipp Wich
Hi Yousong, On 7/23/20 6:05 AM, Yousong Zhou wrote: > Fixes FS#3231 > > Signed-off-by: Yousong Zhou > --- > zones.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/zones.c b/zones.c > index 68b02ab..d5e756c 100644 > --- a/zones.c > +++ b/zones.c > @@ -580,6 +580,14 @@

Re: [PATCH uhttpd] ubus: parse "call" method params only for relevant call

2020-07-23 Thread Jo-Philipp Wich
Hi, > There is no point in parsing "call" specific params for other ("list") > method calls. This is a minor cleanup that doesn't change uhttpd ubus > behaviour. > > Signed-off-by: Rafał Miłecki Acked-by: Jo-Philipp Wich signature.asc Des

Re: [PATCH umdns] service.c: fix build on gcc 10

2020-07-20 Thread Jo-Philipp Wich
Hi, > Signed-off-by: Kevin Darbyshire-Bryant Acked-by: Jo-Philipp Wich ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] iftop: fix compilation with GCC 10

2020-07-18 Thread Jo-Philipp Wich
Hi, > Where? I don't see a merge request on the git link referenced in the Makefile. sent a patch to the author using git send-email. Couldn't figure out how to open a MR on that Gitlab thing after looking for 30 seconds. ~ Jo ___ openwrt-devel

Re: [PATCH] iftop: fix compilation with GCC 10

2020-07-17 Thread Jo-Philipp Wich
Hi, I've sent a fix using extern declarations upstream, lets see what happens. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-15 Thread Jo-Philipp Wich
Hi, > I'm not sure whether using an asterisk is wise here, as it might pose > interesting problems when people use scripts to set/evaluate uci > config (as you have to be extra careful to not have it treated as a > wildcard.) I'd be happy if we could find another symbol here. hm, can you

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-15 Thread Jo-Philipp Wich
Hi, > If we can't come up with a working automatic scheme, maybe we could have > an option to disable the cpu port per vlan? Having a default-enabled "option self" or "option local" was my idea as well. Any idea which name fits better? ~ Jo ___

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-15 Thread Jo-Philipp Wich
Hi, > Changes: > - The device is created as a netifd bridge > - Bridge vlan sections should always refer to the bridge instead of > automatically be applied to the first one > - Use = instead of . to mark tagging modifiers. "." is already used > for vlan interface names and reusing it here

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-14 Thread Jo-Philipp Wich
Hi, > [...] > The same feeling is still with this DSA proposal. The syntax "lan2.t > lan2 lan3 lan5" is unstructured and it does not help too. What is unstructured about it? The fact that it is not a uci list? That can be easily changed. > The use of "switch0" for cpu interface is good and I

Re: [RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-14 Thread Jo-Philipp Wich
Hi, > [...] > Isn't it conceptually more correct in this case for the vlan filtering > to be configured as part of the "interface" in uci? > Ie I configure an interface of type "bridge" which bridges the switch > ports, then the vlan filtering is a configuration property of this > interface (just

[RFC PATCH v2 1/1] dsaconfig: introduce package for UCI configuration of VLAN filter rules

2020-07-07 Thread Jo-Philipp Wich
by default, and to set VLAN port membership, tagging state and PVID as specified by UCI on each port and on the switch bridge device itself, allowing logical interfaces to reference port VLAN groups by using "switch0.N" as ifname, where N denotes the VLAN ID. Signed-off-by: Jo-Philipp Wich

[RFC PATCH v2 0/1] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-07 Thread Jo-Philipp Wich
vlan and dsa_port respectively - Forcibly move DSA ports to the switch bridge if they're part of another bridge yet - Disallow VLAN ID 0 - Properly display unassigned ports as empty in "dsaconfig show" - Handle implicit switch0 in "dsaconfig show" Jo-Philipp

[PATCH 1/1] dsaconfig: introduce package for UCI configuration of VLAN filter rules

2020-07-07 Thread Jo-Philipp Wich
by default, and to set VLAN port membership, tagging state and PVID as specified by UCI on each port and on the switch bridge device itself, allowing logical interfaces to reference port VLAN groups by using "switch0.N" as ifname, where N denotes the VLAN ID. Signed-off-by: Jo-Philip

[RFC PATCH] Introduce UCI support for configuring DSA VLAN filter rules

2020-07-07 Thread Jo-Philipp Wich
ved performance when processing large configurations. Open questions/topics: - Ensure that the chosen configuration approach actually works with DSA_TAG_PROTO_NONE switches - Consider changing the types of the UCI sections from switch/switch_vlan/switch_port to dsa/dsa_vlan/dsa_port - In

Re: [missing subjects]

2020-06-26 Thread Jo-Philipp Wich
Hi, I think this was a misconfiguration in mailman (global "from_is_list" was set to "Wrap message"). Let's see if this reply mail looks better. Regards, Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list

Re: [PATCH RFC procd] service: add "init_action" ubus method for /etc/init.d/ scripts

2020-06-22 Thread Jo-Philipp Wich
Hi, in addition to the inline comments, I'd personally prefer to see such functionality as rpcd plugin, not in procd itself. Not all init scripts are procd enabled and not all procd processes have init scripts, due to that I think that init script enumeration methods should reside elsewhere

  1   2   3   4   5   6   7   8   9   10   >