Re: [PATCH] kernel: xt_FLOWOFFLOAD: fix use of uninitialized dir variable

2024-03-13 Thread Rosen Penev
On Tue, Mar 12, 2024 at 8:51 PM Qingfang Deng wrote: > > From: Qingfang Deng > > The dir variable has been used uninitialized since the port to 5.10, and > somehow this remains undetected by GCC. This patch looks like it's for iptables. Is it needed anymore? > > Fixes: b10d6044599d ("kernel: add

Re: [PATCH] kernel: of: remove "mac-address-ascii" support hack

2023-11-12 Thread Rosen Penev
gt; > Signed-off-by: Shiji Yang Reviewed-by: Rosen Penev > --- > > Git grep ref: > https://git.openwrt.org/?p=openwrt%2Fopenwrt.git=search=HEAD=grep=mac-address-ascii=1 > > Regards, > Shiji Yang > > > ...of_net-add-mac-address-ascii-support.patch | 116

Re: [PATCH ustream-ssl 1/2] ustream-mbedtls: Add compatibility with Mbed TLS 3.0.0

2023-11-12 Thread Rosen Penev
On Sat, Nov 11, 2023 at 1:35 PM Hauke Mehrtens wrote: > > This adds support for compiling the code against Mbed TLS 3.0.0. > It still compiles against Mbed TLS 2.28. > > The following changes were needed: > * DES and 3DES was removed > * mbedtls_pk_context->pk_info is private, use

Re: [PATCH] ath79: use "fixed-layout" for Embedded Wireless devices

2023-11-12 Thread Rosen Penev
: Ansuel Smith > Cc: Catrinel Catrinescu > Cc: Felix Fietkau > Signed-off-by: Rafał Miłecki Reviewed-by: Rosen Penev > --- > .../dts/ar9331_embeddedwireless_dorin.dts | 26 > .../dts/ar9344_embeddedwireless_balin.dts | 30 ++- > 2 files

Re: [PATCH ustream-ssl 2/2] cmake: Fail if undefined symbols are used

2023-11-11 Thread Rosen Penev
On Sat, Nov 11, 2023 at 1:35 PM Hauke Mehrtens wrote: > > Make the linking of the shared library fail when undefined symbols are > used. Linking undefined symbols in a shared library normally works and > the linking of the binary using the shared library fails. We also > compile some example

Re: [PATCH] build: explicitly specify Makefile generator

2023-10-09 Thread Rosen Penev
On Mon, Oct 9, 2023 at 6:05 AM Eicke Herbertz wrote: > > > > > Where does that CMAKE_GENERATOR environment variable come from? Would > > it make sense to undefine it instead? > > > > Regards, > > Jonas > > Well, from the environment of my development machine. > I have it set to Ninja for a long

Re: mips: Make mips64 n32/o32 userland possible or remove support completely

2023-07-20 Thread Rosen Penev
On Wed, Jul 19, 2023 at 1:29 AM Jeffery To wrote: > > Hi, > > I've been looking into platform triplets for Python and figuring out > the possible combinations. This has led me to trying to compile images > of the possible combinations for testing. > > As a result, I've been trying to compile

Re: [PATCH] ath79: increase the rfkill debounce interval for TP-Link Archer C7 v2

2023-07-14 Thread Rosen Penev
On Fri, Jul 14, 2023 at 8:12 AM Shiji Yang wrote: > > From: Shiji Yang > > Due to circuit issue or silicon defect, sometimes the WiFi switch button > of the Archer C7 v2 can be accidentally triggered multiple times in one > second. This will cause WiFi to be unexpectedly shut down and trigger >

Re: OpenWrt Next Generation Ideas

2023-03-31 Thread Rosen Penev
On Fri, Mar 31, 2023 at 6:50 AM Daniel Golle wrote: > > On Fri, Mar 31, 2023 at 03:52:47PM +0300, Arınç ÜNAL wrote: > > On 31.03.2023 14:33, Daniel Golle wrote: > > > Hi! > > > > > > On Fri, Mar 31, 2023 at 12:44:12PM +0300, Arınç ÜNAL wrote: > > > > Hi all, > > > > > > > > These are the ideas

Re: [PATCH] tools: meson: bump to 1.0.0

2023-02-23 Thread Rosen Penev
On Fri, Feb 17, 2023 at 2:13 AM Andre Heider wrote: > > On 17/02/2023 10:18, Koen Vandeputte wrote: > > Drop upstreamed patch. > > > > Tested by compiling the complete gstreamer package which heavily > > depends on this one. > > > > Signed-off-by: Koen Vandeputte > > Not possible unfortunately,

Re: [PATCH ustream-ssl] ustream-mbedtls: Use getrandom() instead of /dev/urandom

2023-01-28 Thread Rosen Penev
s function returns not > as many bytes as expected. > > Signed-off-by: Hauke Mehrtens Acked-by: Rosen Penev > --- > ustream-mbedtls.c | 23 +-- > 1 file changed, 5 insertions(+), 18 deletions(-) > > diff --git a/ustream-mbedtls.c b/ustream-mbedtls.c >

Re: elfutils build failure

2023-01-25 Thread Rosen Penev
On Wed, Jan 25, 2023 at 1:27 PM Peter Naulls wrote: > > > This is elfutils-0.188 in master. No doubt I'm using a bad toolchain combo - I > brought the config over from my 22.03 build: > > CONFIG_GCC_VERSION="11.3.0" > CONFIG_BINUTILS_VERSION_2_38=y > > > > configure:3994:

Re: mt7621 GPIO mapping mystery

2023-01-20 Thread Rosen Penev
CC: Sergio On Fri, Jan 20, 2023 at 11:29 AM Peter Naulls wrote: > > > > I posted previously on GPIOs, which caused some debate; this may or may not > be relevant, but I'd be remiss to not mention it: > > http://lists.openwrt.org/pipermail/openwrt-devel/2022-October/039593.html > > I've been

Re: [PATCH] archs38: mark as source-only

2022-12-29 Thread Rosen Penev
On Thu, Dec 29, 2022 at 10:52 AM Robert Marko wrote: > > archs38 seems to be pretty much unused, usually only treewide changes or > kernel bumps in order to branch off new stable are done to it. > > Considering that target only support some Synopsis HS38 ARC reference > boards and no consumer

Re: [PATCH RFC] ath79: switch TP-Link Archer C59 v1 to read partitions table

2022-11-15 Thread Rosen Penev
On Thu, Nov 10, 2022 at 3:52 AM Rafał Miłecki wrote: > > From: Rafał Miłecki > > So far DTS file for C59 V1 model was assuming flash partitions were > fixed. It just used a little quirk with a custom "firmware" partition > covering both: "os-image" and "file-system" to avoid hardcoding their >

Re: [PATCH] px5g-mbedtls (Was: px5g return value checking)

2022-11-07 Thread Rosen Penev
On Mon, Nov 7, 2022 at 7:19 AM Peter Naulls wrote: > > On 11/3/22 14:49, Peter Naulls wrote: > > > > Another one from our security scan: > > > > File: /usr/sbin/px5g > > Issue: RET NOT ASSIGNED in function 'FUN_000281b0' at address 0x281c0 while > > calling 'mbedtls_rsa_check_pub_priv' > > Issue:

Re: gpio-mt7621 offset fix for 5.10 kernel series

2022-10-18 Thread Rosen Penev
On Tue, Oct 18, 2022 at 3:50 PM Peter Naulls wrote: > > On 10/18/22 17:10, Lukas Zeller wrote: > . > > > > Just not any more - the mt7621 had this too. I currently patch it back into > > 22.03's gpio-mt7621.c for my builds and set base in the DTS, see [3] > > > > I can follow the rationale to get

Re: [PATCH] uqmi: fix compilation with GCC12

2022-09-29 Thread Rosen Penev
On Thu, Sep 29, 2022 at 7:45 AM Hauke Mehrtens wrote: > > On 9/28/22 04:22, Rosen Penev wrote: > > On Sun, Aug 21, 2022 at 7:54 AM Hauke Mehrtens wrote: > >> > >> On 6/11/22 16:47, Bjørn Mork wrote: > >>> e9hack writes: > >>> > >>

Re: [PATCH] uqmi: fix compilation with GCC12

2022-09-27 Thread Rosen Penev
On Sun, Aug 21, 2022 at 7:54 AM Hauke Mehrtens wrote: > > On 6/11/22 16:47, Bjørn Mork wrote: > > e9hack writes: > > > >> The 'dangling pointer' issue can be fix without using malloc(). > >> > >> --- a/dev.c 2022-05-04 02:18:17.0 +0200 > >> +++ b/dev.c 2022-06-11 08:48:21.185567953

[PATCHv2 2/2] ubox: fix GCC fanalyzer warnings

2022-07-18 Thread Rosen Penev
memory leaks and missing NULL checks. Signed-off-by: Rosen Penev --- v2: remove null check for free kmodloader.c | 12 1 file changed, 12 insertions(+) diff --git a/kmodloader.c b/kmodloader.c index 4b2ffa7..b2e7a8b 100644 --- a/kmodloader.c +++ b/kmodloader.c @@ -336,6 +336,11

[PATCHv2 1/2] ubox: fix bad realloc usage

2022-07-18 Thread Rosen Penev
Both cppcheck and gcc's -fanalyzer complain here that realloc is being used improperly. Signed-off-by: Rosen Penev --- kmodloader.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kmodloader.c b/kmodloader.c index 63bae5e..4b2ffa7 100644 --- a/kmodloader.c +++ b

Re: [PATCH 1/2] ubox: fix GCC fanalyzer warnings

2022-07-18 Thread Rosen Penev
On Mon, Jul 18, 2022 at 1:45 AM Jo-Philipp Wich wrote: > > Hi, > > > [...] > > - free(aliases); > > + if (aliases) > > + free(aliases); > > This check is redundant, the free() function is guaranteed to be NULL-safe in > the standard: > >The free() function shall cause the

[PATCH 1/2] ubox: fix GCC fanalyzer warnings

2022-07-17 Thread Rosen Penev
memory leaks and missing NULL checks. Signed-off-by: Rosen Penev --- kmodloader.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/kmodloader.c b/kmodloader.c index 63bae5e..bc5f20c 100644 --- a/kmodloader.c +++ b/kmodloader.c @@ -336,6 +336,11 @@ static int

[PATCH 2/2] ubox: fix bad realloc usage

2022-07-17 Thread Rosen Penev
Both cppcheck and gcc's -fanalyzer complain here that realloc is being used improperly. Signed-off-by: Rosen Penev --- kmodloader.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kmodloader.c b/kmodloader.c index bc5f20c..5f8c9c1 100644 --- a/kmodloader.c +++ b

Re: Question about ancient TARGET_CFLAGS in rules.mk?

2022-07-17 Thread Rosen Penev
On Sun, Jul 17, 2022 at 2:29 AM Christian Marangi wrote: > > On Sat, Jul 16, 2022 at 10:17:28PM -0700, Rosen Penev wrote: > > On Sat, Jul 16, 2022 at 4:52 PM Ansuel Smith wrote: > > > > > > Hi, > > > some background about this. > > > > &g

Re: Question about ancient TARGET_CFLAGS in rules.mk?

2022-07-17 Thread Rosen Penev
On Sun, Jul 17, 2022 at 2:29 AM Christian Marangi wrote: > > On Sat, Jul 16, 2022 at 10:17:28PM -0700, Rosen Penev wrote: > > On Sat, Jul 16, 2022 at 4:52 PM Ansuel Smith wrote: > > > > > > Hi, > > > some background about this. > > > > &g

Re: Question about ancient TARGET_CFLAGS in rules.mk?

2022-07-16 Thread Rosen Penev
On Sat, Jul 16, 2022 at 4:52 PM Ansuel Smith wrote: > > Hi, > some background about this. > > I'm trying to improve our CI system more and more by finally adding > support for real > EXTERNAL_TOOLCHAIN_SUPPORT... I'm running (and abusing) the github CI > to make sure everything works and all

Re: [PATCH] bcm53xx: disable GRO support at kernel level

2022-06-23 Thread Rosen Penev
On Wed, Jun 22, 2022 at 8:49 PM Rafał Miłecki wrote: > > On 21.06.2022 01:13, Rosen Penev wrote: > > On Mon, Jun 20, 2022 at 2:33 AM Rafał Miłecki wrote: > >> > >> On 10.06.2022 15:16, Rafał Miłecki wrote: > >>> This improves NAT masquarade netwo

[PATCH] libubox: add missing NULL check

2022-06-22 Thread Rosen Penev
strlen takes non NULL parameters. Found with GCC's -fanalyzer. Signed-off-by: Rosen Penev --- blobmsg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/blobmsg.c b/blobmsg.c index d87d607..bb6c469 100644 --- a/blobmsg.c +++ b/blobmsg.c @@ -364,6 +364,8 @@ blobmsg_add_string_buffer(struct

Re: [PATCH] bcm53xx: disable GRO support at kernel level

2022-06-20 Thread Rosen Penev
On Mon, Jun 20, 2022 at 2:33 AM Rafał Miłecki wrote: > > On 10.06.2022 15:16, Rafał Miłecki wrote: > > This improves NAT masquarade network performance. > > > > An alternative to kernel change would be runtime setup but that requires > > ethtool and identifying relevant network interface and all

[PATCH] uqmi: fix compilation with GCC12

2022-06-08 Thread Rosen Penev
GCC12 doesn't seem to see that the completed member gets nulled. Use malloc to work around this. Signed-off-by: Rosen Penev --- commands-nas.c | 2 +- dev.c | 9 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/commands-nas.c b/commands-nas.c index 476cd61

Re: [PATCH] nls.mk: clean up INTL flags

2022-06-05 Thread Rosen Penev
case. > > [1] e6f569406ffe1d9e35b9b9ea36f38cdd5837728d > > Signed-off-by: Sebastian Kemper Reviewed-by: Rosen Penev > --- > include/nls.mk | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/include/nls.mk b/include/nls.mk > index 163e480932..665ccb565d 100644 >

Re: [PATCH] packages: pagekitec: fix crashing due to musl time64

2022-06-03 Thread Rosen Penev
On Fri, Jun 3, 2022 at 10:24 AM wrote: > > From: Lukas Zeller > > [Please note: this is my first attempt at submitting a patch, > please apologize/advise if something is not as it should be. I tried to > follow the guideline in the wiki] https://github.com/openwrt/packages <-- PR there > >

Re: [PATCH 2/6] tools/dwarves: add host package

2022-02-28 Thread Rosen Penev
On Mon, Feb 28, 2022 at 8:17 AM Stijn Tintel wrote: > > On 28/02/2022 16:16, Ansuel Smith wrote: > >> On 27/02/2022 17:20, Ansuel Smith wrote: > >>> > > From: Tony Ambardar > > dwarves is a set of tools that use the debugging information inserted in > ELF binaries by

Re: [PATCH] firmware-utils: fix compilation with macOS

2022-02-28 Thread Rosen Penev
On Mon, Feb 28, 2022 at 12:43 AM Paul Spooren wrote: > > > > > On 28. Feb 2022, at 08:34, Rosen Penev wrote: > > > > __bswap_32 is a GNU extension. > > > > Signed-off-by: Rosen Penev > > — > > Seems to fix the compile issue on my Mac. >

Re: [PATCH] firmware-utils: fix Wparentheses parnings

2022-02-27 Thread Rosen Penev
On Sun, Feb 27, 2022 at 11:42 PM Rosen Penev wrote: > > () is normally used for comparison and (()) for assignment and > comparison. Normalize both situations. > > Signed-off-by: Rosen Penev > --- > src/mkcasfw.c | 2 +- > src/mkcsysimg.c | 2 +- > src/mkmylofw

[PATCH] firmware-utils: fix Wparentheses parnings

2022-02-27 Thread Rosen Penev
() is normally used for comparison and (()) for assignment and comparison. Normalize both situations. Signed-off-by: Rosen Penev --- src/mkcasfw.c | 2 +- src/mkcsysimg.c | 2 +- src/mkmylofw.c | 2 +- src/mkzynfw.c | 2 +- src/srec2bin.c | 2 +- 5 files changed, 5 insertions(+), 5

[PATCH] firmware-utils: fix compilation with macOS

2022-02-27 Thread Rosen Penev
__bswap_32 is a GNU extension. Signed-off-by: Rosen Penev --- src/avm-wasp-checksum.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/avm-wasp-checksum.c b/src/avm-wasp-checksum.c index 8c112f3..41a425e 100644 --- a/src/avm-wasp-checksum.c +++ b/src/avm-wasp-checksum.c

Re: OpenWrt 21.02 and 19.07 minor release

2022-02-14 Thread Rosen Penev
On Mon, Feb 14, 2022 at 12:00 PM Hauke Mehrtens wrote: > > On 2/13/22 01:26, Hauke Mehrtens wrote: > > On 2/10/22 16:12, Seo Suchan wrote: > >> looks like those dnsmasq exploits aren't real > >> > >> bugs never looked by human (no commit related by it), but bots > >> confirmed that thoses look

Re: [PATCH v2 3/3] ramips: mt7621-dts: add pinctrl properties for ethernet

2022-02-11 Thread Rosen Penev
On Fri, Feb 11, 2022 at 2:27 PM Arınç ÜNAL wrote: > > On 12/02/2022 00:53, Rosen Penev wrote: > > On Fri, Feb 11, 2022 at 4:46 AM Arınç ÜNAL wrote: > >> > >> Add the missing pinctrl properties on the ethernet node. > >> GMAC1 will start working with t

Re: [PATCH v2 3/3] ramips: mt7621-dts: add pinctrl properties for ethernet

2022-02-11 Thread Rosen Penev
On Fri, Feb 11, 2022 at 4:46 AM Arınç ÜNAL wrote: > > Add the missing pinctrl properties on the ethernet node. > GMAC1 will start working with this change. > > Link: > https://lore.kernel.org/netdev/83a35aa3-6cb8-2bc4-2ff4-64278bbcd...@arinc9.com/ > > Overwrite pinctrl-0 property without

Re: [PATCH 3/3] ramips: mt7621-dts: add pinctrl properties for ethernet

2022-02-08 Thread Rosen Penev
On Tue, Feb 8, 2022 at 1:02 PM Arınç ÜNAL wrote: > > > > On 08/02/2022 18:02, Arınç ÜNAL wrote: > > Hey Chuanhong, > > > > On 08/02/2022 17:20, Chuanhong Guo wrote: > >> Hi! > >> > >> On Tue, Feb 8, 2022 at 3:38 AM Arınç ÜNAL wrote: > >>> diff --git a/target/linux/ramips/dts/mt7621.dtsi > >>>

Re: [PATCH 0/6] backport fixes and improvements for MT7530

2022-02-05 Thread Rosen Penev
On Sat, Feb 5, 2022 at 10:23 AM Hauke Mehrtens wrote: > > On 2/5/22 19:21, Rosen Penev wrote: > > On Sat, Feb 5, 2022 at 10:12 AM Hauke Mehrtens wrote: > >> > >> On 2/3/22 13:06, DENG Qingfang wrote: > >>> Hi, > >>> > >>> This

Re: [PATCH 0/6] backport fixes and improvements for MT7530

2022-02-05 Thread Rosen Penev
On Sat, Feb 5, 2022 at 10:12 AM Hauke Mehrtens wrote: > > On 2/3/22 13:06, DENG Qingfang wrote: > > Hi, > > > > This series backports some patches from upstream to address the current > > MT7530 DSA driver's problems. > > > > Thanks. > > > > DENG Qingfang (6): > >kernel: backport MediaTek

Re: [PATCH 1/5] ath79: mikrotik: change to qca8k DSA driver

2022-01-26 Thread Rosen Penev
On Tue, Jan 25, 2022 at 10:44 PM Oskari Lemmela wrote: > > Current mikrotik ath79 devices do not use switch drivers. > Enable the QCA8K driver and disable the old AR8126 phy. > > Signed-off-by: Oskari Lemmela > --- > target/linux/ath79/mikrotik/config-default | 4 > 1 file changed, 4

Re: [PATCH] toolchain/gcc: set dialects for each version

2022-01-25 Thread Rosen Penev
On Tue, Jan 25, 2022 at 9:06 AM Stijn Tintel wrote: > > GCC has an option "-std=" to set the language standard for C and C++. > Newer GCC versions sometimes switch to newer standards by default. This > has the potential to break the OpenWrt toolchain build whenever a distro > introduces a new GCC

Re: Switch issues and CI to GitHub

2022-01-07 Thread Rosen Penev
On Fri, Jan 7, 2022 at 1:38 AM Paul Spooren wrote: > > Hi all, > > Back at the Hamburg meeting in 2019 and a succeeding vote we decided to > migrate over to a self-hosted GitLab instance. Some years passed and nothing > really happened so I’d like to give this another go. > > None of the

Re: [PATCH] ramips: add support for Zbtlink ZBT-WG1602

2021-11-29 Thread Rosen Penev
On Tue, Nov 16, 2021 at 2:14 AM Sergey Ryazanov wrote: > > Zbtlink ZBT-WG1602 is a Wi-Fi router intendent to use with WWAN > (UMTS/LTE/3G/4G) modems. The router board offsers a couple of miniPCIe > slots with USB and SIM only and another one pure miniPCIe slot as well > as five Gigabit Ethernet

Re: warning about which deprecated

2021-11-07 Thread Rosen Penev
On Sun, Nov 7, 2021 at 10:14 PM Rosen Penev wrote: > > On Sun, Nov 7, 2021 at 12:32 PM Ansuel Smith wrote: > > > > Il giorno dom 7 nov 2021 alle ore 19:18 Bjørn Mork ha > > scritto: > > > > > > Ansuel Smith writes: > > > > > > >

Re: warning about which deprecated

2021-11-07 Thread Rosen Penev
On Sun, Nov 7, 2021 at 12:32 PM Ansuel Smith wrote: > > Il giorno dom 7 nov 2021 alle ore 19:18 Bjørn Mork ha scritto: > > > > Ansuel Smith writes: > > > > > Updating to latest ubuntu devel this now comes up > > > /home/ansuel/openwrt/staging_dir/host/bin/which: this version of > > > `which' is

Re: [PATCH] config: Activate SECCOMP also on MIPS 64

2021-11-01 Thread Rosen Penev
On Mon, Nov 1, 2021 at 10:05 AM Hauke Mehrtens wrote: > > This activates SECCOMP also on mips64 and mips64el. > > This was working fine in a basic test in qemu. > > Signed-off-by: Hauke Mehrtens > --- > > I only did very basic testing, why was this not activated in the beginning? > > >

Re: Marvell EBU 32-bit performance benchmarks (VFPv3-D16 vs NEON builds, Turris Omnia).

2021-10-21 Thread Rosen Penev
On Thu, Oct 21, 2021 at 12:19 PM Kabuli Chana wrote: > > For me the argument was not about whether there should 2, but whether > the change to vfpv3-d16 was the right choice as the 1. openssl is of > course preordained to run NEON SIMD code so no change would be expected, > but a benefit is seen

Re: [PATCH] libubox: remove support for jsoncpp

2021-10-20 Thread Rosen Penev
ping On Thu, Dec 24, 2020 at 5:12 PM Rosen Penev wrote: > > jsoncpp requires a C++ compiler instead of a C one. Fixes the following > build error: > > fatal error: cstddef: No such file or directory > '#include > > Issue was discovered on the buildbots where an SDK cont

Re: Release goals for 22.XX

2021-10-06 Thread Rosen Penev
On Wed, Oct 6, 2021 at 10:46 AM Rui Salvaterra wrote: > > Hi, Rich, > > On Wed, 6 Oct 2021 at 17:54, Rich Brown wrote: > > > > Paul, Rafał, > > > > I think our emails passed in the ether... > > (http://lists.openwrt.org/pipermail/openwrt-devel/2021-October/036637.html) > > > > As I said in that

Re: RFC: toolchain for building eBPF modules within the OpenWrt build system

2021-10-03 Thread Rosen Penev
On Sun, Oct 3, 2021 at 5:47 AM Felix Fietkau wrote: > > > Hi, > > I recently spent some time digging into what's needed for proper eBPF > build support in OpenWrt. Here's what I found so far: > > Most out-of-tree eBPF based projects fork some of the BPF related kernel > headers from various

Re: mediatek: fix NETDEV WATCHDOG: eth0 (mtk_SOC_eth): Transmit queue 0 timed out

2021-10-03 Thread Rosen Penev
On Sun, Oct 3, 2021 at 5:18 AM Adrian Schmutzler wrote: > > Hi, > > > -Original Message- > > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > > On Behalf Of daxiong > > Sent: Sonntag, 3. Oktober 2021 13:35 > > To: openwrt-devel@lists.openwrt.org > > Subject:

[PATCH] tools/firmware-utils: remove all std= settings

2021-10-02 Thread Rosen Penev
-by: Rosen Penev --- tools/firmware-utils/Makefile | 16 tools/firmware-utils/src/mktplinkfw-lib.h | 8 tools/firmware-utils/src/mktplinkfw.c | 1 + 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/tools/firmware-utils/Makefile b/tools/firmware

Re: Release goals for 22.XX

2021-10-01 Thread Rosen Penev
On Fri, Oct 1, 2021 at 3:05 PM Hauke Mehrtens wrote: > > On 9/30/21 10:40 PM, Paul Spooren wrote: > > > > On 9/30/21 10:01, Nick wrote: > >> > >> On 9/30/21 21:43, Daniel Golle wrote: > >>> On Thu, Sep 30, 2021 at 09:18:06PM +0300, Stijn Tintel wrote: > On 30/09/2021 01:19, Nick wrote: >

Re: Release goals for 22.XX

2021-09-30 Thread Rosen Penev
On Thu, Sep 30, 2021 at 1:05 PM Nick wrote: > > > On 9/30/21 21:43, Daniel Golle wrote: > > On Thu, Sep 30, 2021 at 09:18:06PM +0300, Stijn Tintel wrote: > >> On 30/09/2021 01:19, Nick wrote: > >>> On 9/29/21 22:28, Hauke Mehrtens wrote: > >>> > kernel 5.10: > We should get all targets

Re: [PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-26 Thread Rosen Penev
On Sun, Sep 26, 2021 at 11:31 AM Rui Salvaterra wrote: > > Hi, David, > > On Sun, 26 Sept 2021 at 12:37, David Bauer wrote: > > > > Does this mean parts of this patch are already applied upstream? > > Yes, the ag71xx_ring section. > > > Also are there already performance numbers available? > >

[PATCH] linux: backport GPIO LED patch for MT7350

2021-09-22 Thread Rosen Penev
. Renumbered some patches to keep the date of backports. Refreshed all patches. Signed-off-by: Rosen Penev --- ...-mt7530-MT7530-optional-GPIO-support.patch | 181 ++ ...mt7530-Add-support-for-EEE-features.patch} | 6 +- ...he-dst-buffer-to-of_get_mac_address.patch} | 0

[PATCH] tools/libressl: update to 3.4.0

2021-09-22 Thread Rosen Penev
Signed-off-by: Rosen Penev --- tools/libressl/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libressl/Makefile b/tools/libressl/Makefile index 29fae1dfb6..7d5f87d041 100644 --- a/tools/libressl/Makefile +++ b/tools/libressl/Makefile @@ -8,8 +8,8

Re: [PATCH] base-files: fix zoneinfo support

2021-06-23 Thread Rosen Penev
is an openwrt hack that is used when there are no zoneinfo files. After this patch, it gets created only if they are missing. > > Please send a v2 removing the /tmp/TZ file again iff $zonename exists. There's no point in removing that which is not present. > > On 4/9/21 2:22 PM, Rosen Penev wrote: > &g

Re: [PATCH] Revert "dbus: update to 1.13.18"

2021-04-21 Thread Rosen Penev
On Apr 21, 2021, at 10:46, Ansuel Smith wrote: >> >> This reverts commit 0fb5d3ed2cb31a0a6076d36fb7a668cfe5328c92. >> >> root@finn:/# /etc/init.d/dbus start >> dbus[2537]: Failed to start message bus: Failed to open >> "/dbus-1/system.conf": No such file or directory >> > > The avahi

Re: [PATCH] build: prereq: drop support for Python 3.5

2021-04-17 Thread Rosen Penev
On Sat, Apr 17, 2021 at 2:49 PM Sven Roederer wrote: > > Am Samstag, 17. April 2021, 16:45:01 CEST schrieb Sven Roederer: > > On my Ubuntu 16.04 based build-system I also have build-failures for meson > > using Python3.5. > > Correction: it's a 18.04 LTS ... GCC6 is now minimum, breaking CentOS

Re: [PATCH] kernel: Disable CONFIG_COMPAT_32BIT_TIME by default

2021-04-14 Thread Rosen Penev
On Wed, Apr 14, 2021 at 4:47 PM Linus Walleij wrote: > > On Thu, Apr 15, 2021 at 12:49 AM Rosen Penev wrote: > > > time_t is still 32-bit for 32-bit targets. OpenWrt has not migrated to > > musl 1.2.x. > > > > https://github.com/openwrt/openwrt/pull/30

Re: [PATCH] kernel: Disable CONFIG_COMPAT_32BIT_TIME by default

2021-04-14 Thread Rosen Penev
On Wed, Apr 14, 2021 at 6:27 AM Linus Walleij wrote: > > OpenWRT rebuilds the whole userspace from scratch and uses > recent versions of tools and libraries, thus it should not > be necessary in general to support CONFIG_COMPAT_32BIT_TIME, > not even for purely 32bit systems: their updated

Re: [PATCH] RFC: kernel: Remove CFQ activate BFQ

2021-04-14 Thread Rosen Penev
On Wed, Apr 14, 2021 at 4:46 AM Linus Walleij wrote: > > The CFQ IO scheduler is deleted from the Linux kernel > since commit f382fb0bcef4c37dc049e9f6963e3baf204d815c > "block: remove legacy IO schedulers". > > The new multiqueue block layer has an IO scheduler named > BFQ (Budget Fair Queue)

[PATCH] libsemanage: fix pkgconfig paths

2021-04-13 Thread Rosen Penev
The pkgconfig file currently post to host paths. Signed-off-by: Rosen Penev --- package/libs/libsemanage/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/package/libs/libsemanage/Makefile b/package/libs/libsemanage/Makefile index ff1519f14e..2fde14c06c 100644

Re: [PATCH] fortify-headers: fix compilation with GCC 10.3

2021-04-13 Thread Rosen Penev
On Tue, Apr 13, 2021 at 3:53 PM Hauke Mehrtens wrote: > > On 4/13/21 6:03 AM, Rosen Penev wrote: > > For some reason, fortified mempcpy does not work with GCC 10.3. It > > worked with GCC 10.2. > > > > Some output with tvheadend: > > > > error: 'm

[PATCH] fortify-headers: fix compilation with GCC 10.3

2021-04-12 Thread Rosen Penev
object '__orig_mempcpy' is not a function or function pointer 151 | return _orig_mempcpy(__d, __s, __n); Signed-off-by: Rosen Penev --- toolchain/fortify-headers/Makefile | 2 +- toolchain/fortify-headers/patches/010-mempcpy.patch | 11 +++ 2 files changed, 12

Re: [PATCH] toolchain: gcc: Update to version 10.3.0

2021-04-12 Thread Rosen Penev
On Sat, Apr 10, 2021 at 3:17 PM Hauke Mehrtens wrote: > > Signed-off-by: Hauke Mehrtens Breaks fortify-headers interestingly enough. > --- > toolchain/gcc/Config.version| 2 +- > toolchain/gcc/common.mk | 4 ++-- >

Re: [PATCH] base-files: fix zoneinfo support

2021-04-10 Thread Rosen Penev
On Fri, Apr 9, 2021 at 5:22 PM Rosen Penev wrote: > > The system init script currently sets /tmp/localinfo when zoneinfo is > populated. However, zoneinfo has spaces in it whereas the actual files > have _ instead of spaces. This made the if condition never return true. > > Ex

[PATCH] base-files: fix zoneinfo support

2021-04-09 Thread Rosen Penev
are/zoneinfo/America/Los Angeles This file does not exist. America/Los_Angeles does. Signed-off-by: Rosen Penev --- this should be backported to 21.02 and 19.07 as the issue is also present there. This was tested on 19.07. package/base-files/files/etc/init.d/system | 10 +++--- 1 file changed

[PATCH]-19.07 busybox: backport hwclock fixes

2021-04-09 Thread Rosen Penev
Currently on devices with an RTC, sysfixtime uses busybox' hwclock to set the RTC time. Unfortunately, g/settimeofday on musl completely ignore the second parameter which forces users to use the syscall directly. Backport two patches to fix hwclock's support for timezones. Signed-off-by: Rosen

Re: [PATCH] kernel: Activate FORTIFY_SOURCE for MIPS kernel 5.4

2021-04-07 Thread Rosen Penev
(), memcpy() and memmove() even when not explicitly > telling the compiler to use the build in variant. > > Signed-off-by: Hauke Mehrtens Acked-by: Rosen Penev > --- > > I would like to backport this to 21.02 too. Seems good. > > ...-Kconfig-Add-ARCH_HAS_FORTIFY_SOURC

[PATCH] toolchain/gdb: fix compilation with ccache

2021-04-04 Thread Rosen Penev
For some reason, one of the configure checks results in some infinite loop and ends up spawning endless gcc processes, causing OOM. Just pass a configure var to avoid it. Same fix as 6e23813c1ed7494a9da3b5e59cfcafd71097c420 Signed-off-by: Rosen Penev --- toolchain/gdb/Makefile | 1 + 1 file

Re: Data loss issue (and solution) for MTK uSD driver

2021-04-02 Thread Rosen Penev
On Fri, Apr 2, 2021 at 4:22 PM Enrico Mioso wrote: > > Hello all!! > > I experienced an issue that could cause data loss on a uSD card when used in > some ramips MT7621 devices, like the Zbtlink ZBT-WG3526 (32M). > I fixed it by following the nice solution pointed our here: >

Re: Data loss issue (and solution) for MTK uSD driver

2021-04-02 Thread Rosen Penev
On Fri, Apr 2, 2021 at 5:12 PM Rosen Penev wrote: > > On Fri, Apr 2, 2021 at 4:22 PM Enrico Mioso wrote: > > > > Hello all!! > > > > I experienced an issue that could cause data loss on a uSD card when used > > in some ramips MT7621 devices, like the Z

Re: [PATCH] openssl: don't rename a file with quilt

2021-03-26 Thread Rosen Penev
On Fri, Mar 26, 2021 at 2:57 PM Felix Fietkau wrote: > > > On 2021-03-26 22:39, Eneas U de Queiroz wrote: > > On Fri, Mar 26, 2021 at 4:28 PM Rosen Penev wrote: > >> > >> On Fri, Mar 26, 2021 at 5:55 AM Eneas U de Queiroz > >> wrote: > >> &

Re: [RFC PATCH] openssl: make the patches QUILT-friendly

2021-03-26 Thread Rosen Penev
On Fri, Mar 26, 2021 at 11:56 AM Eneas U de Queiroz wrote: > > The patches in this package are all made by git format-patches. If one > were to run 'make package/openssl/{refresh,update}', then things will > not work as expected, because quilt QUILT does not deal well with > patches that rename

Re: [PATCH] openssl: don't rename a file with quilt

2021-03-26 Thread Rosen Penev
patches > at https://github.com/cotequeiroz/openssl, and refreshing backports > with git is much easier than with quilt. See comments below, as your > patchset breaks compilation with QUILT. > > On Fri, Mar 26, 2021 at 6:26 AM Rosen Penev wrote: > > > > quilt cannot handle

[PATCH 2/2] lua5.3: refresh patches

2021-03-26 Thread Rosen Penev
Renamed doc files in Build/Prepare instead of patches as quilt cannot handle renames in patches. Signed-off-by: Rosen Penev --- package/utils/lua5.3/Makefile | 8 +++ .../patches/001-include-version-number.patch | 8 --- .../lua5.3/patches/020-shared_liblua.patch| 60

[PATCH 1/2] lua: refresh patches

2021-03-26 Thread Rosen Penev
Renamed doc files in Build/Prepare instead of patches as quilt cannot handle renames in patches. Signed-off-by: Rosen Penev --- package/utils/lua/Makefile| 8 .../lua/patches/001-include-version-number.patch | 10 +- .../lua/patches/013-lnum

Re: [PATCH] build: remove GCC7 support

2021-03-26 Thread Rosen Penev
s gerbera in the packages feed. That's actually why I don't backport gerbera to 19.07. > > Signed-off-by: Paul Spooren Acked-by: Rosen Penev > --- > toolchain/gcc/Config.in | 4 - > toolchain/gcc/Config.version | 10 - > toolchain/gcc/common.mk

[PATCH] openssl: don't rename a file with quilt

2021-03-26 Thread Rosen Penev
quilt cannot handle file renames and ends up duplicating the file. Instead of doing that, handle the renaming in the Makefile so that the upstream file can change. Signed-off-by: Rosen Penev --- package/libs/openssl/Makefile |7 + ...o-make-the-dev-crypto-engine

[PATCHv2 2/2] kernel: add exfat again

2021-03-16 Thread Rosen Penev
With kernel 5.10, exfat is out of staging and in tree. Added small hack to make it work with kernel 5.4 as well. Added removed config options for 5.4 to generic config. Signed-off-by: Rosen Penev --- v2: Add missing config options package/kernel/linux/modules/fs.mk | 20

[PATCHv2 1/2] package/exfat: remove

2021-03-16 Thread Rosen Penev
Now that kernel 5.10 is in tree, this can be removed. Signed-off-by: Rosen Penev --- package/kernel/exfat/Makefile | 46 --- 1 file changed, 46 deletions(-) delete mode 100644 package/kernel/exfat/Makefile diff --git a/package/kernel/exfat/Makefile b/package

[PATCH] pcre: bring back C++ bindings

2021-03-16 Thread Rosen Penev
It seems some people use them privately. Reported-by: Jan Kardell Signed-off-by: Rosen Penev --- package/libs/pcre/Makefile | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/package/libs/pcre/Makefile b/package/libs/pcre/Makefile index 8644746b4b

Re: [PATCH] pcre: disable C++ bindings

2021-03-15 Thread Rosen Penev
On Sun, Mar 14, 2021 at 2:40 PM Karl Palsson wrote: > > > Rosen Penev wrote: > > On Sun, Mar 14, 2021 at 7:40 AM Jan Kardell > > wrote: > > > > > > Rosen Penev skrev: > > > > Nothing uses them. Allows to simplify the Makefile. > > &

Re: [PATCH] pcre: disable C++ bindings

2021-03-14 Thread Rosen Penev
On Sun, Mar 14, 2021 at 7:40 AM Jan Kardell wrote: > > Rosen Penev skrev: > > Nothing uses them. Allows to simplify the Makefile. > Actually I use it for stuff that is not in openwrt repos. That means I > must keep pcrecpp out-of-tree. Maybe others do too, but have no

[PATCH 1/2] package/exfat: remove

2021-03-12 Thread Rosen Penev
Now that kernel 5.10 is in tree, this can be removed. Signed-off-by: Rosen Penev --- package/kernel/exfat/Makefile | 46 --- 1 file changed, 46 deletions(-) delete mode 100644 package/kernel/exfat/Makefile diff --git a/package/kernel/exfat/Makefile b/package

[PATCH 2/2] kernel: add exfat again

2021-03-12 Thread Rosen Penev
With kernel 5.10, exfat is out of staging and in tree. Added small hack to make it work with kernel 5.4 as well. Signed-off-by: Rosen Penev --- package/kernel/linux/modules/fs.mk | 20 1 file changed, 20 insertions(+) diff --git a/package/kernel/linux/modules/fs.mk b

Re: [PATCH] ramips: add support for TOTOLINK X5000R

2021-03-12 Thread Rosen Penev
On Fri, Mar 12, 2021 at 6:27 PM Chuanhong Guo wrote: > > Hi! > > On Sat, Mar 13, 2021 at 7:27 AM Bas Mevissen wrote: > > > > Hi, > > > > Thanks for creating this patch. Got my X5000R today. Before flashing it > > to OpenWRT, can you please tell me whether you (or anyone else) did > > performance

Re: [PATCH] uclibc++: remove

2021-03-12 Thread Rosen Penev
On Sat, Feb 27, 2021 at 7:41 AM Hauke Mehrtens wrote: > > On 2/27/21 5:17 AM, Rosen Penev wrote: > > No package here depends on it. Furthermore, uClibc++ is a fairly buggy > > C++ library and seems to be relatively inactive upstream. > > > > It also lacks proper sup

Re: [PATCH 0/4] import libcap from packages feed

2021-03-12 Thread Rosen Penev
On Fri, Mar 12, 2021 at 2:10 AM Stijn Tintel wrote: > > On 12/03/2021 10:50, Petr Štetiar wrote: > > Stijn Tintel [2021-03-12 01:25:24]: > > > > Hi, > > > >> Having libcap in OpenWrt base allows us to enable libcap support in > >> other packages in base. > > there is same functionality available

Re: Dsa multi-cpu port problem

2021-03-10 Thread Rosen Penev
On Wed, Mar 10, 2021 at 4:56 PM Ansuel Smith wrote: > > > > > On Wed, Mar 10, 2021 at 4:19 PM Ansuel Smith wrote: > > > > > > I'm working on the conversion of ipq806x to dsa. > > > It's been 2 years and still dsa doesn't support multi-cpu port. > > > Online there are many patches that add

Re: Dsa multi-cpu port problem

2021-03-10 Thread Rosen Penev
On Wed, Mar 10, 2021 at 4:19 PM Ansuel Smith wrote: > > I'm working on the conversion of ipq806x to dsa. > It's been 2 years and still dsa doesn't support multi-cpu port. > Online there are many patches that add support for this but they were > never accepted upstream since there isn't a solution

Re: Build openwrt with clang

2021-03-06 Thread Rosen Penev
On Sat, Mar 6, 2021 at 12:19 AM Michael Fuckner wrote: > > Hi, > > I'm not exactly sure if this is trivial or totally insane- I have the idea to > compile the whole openwrt with clang instead of gcc. I could not get a point > to start at. Can you help me? I don't think LLVM supports all the

[PATCH] binutils: fix compilation with ccache

2021-03-06 Thread Rosen Penev
For some reason, one of the configure checks results in some infinite loop and ends up spawning endless gcc processes, causing OOM. Just pass a configure var to avoid it. Signed-off-by: Rosen Penev --- toolchain/binutils/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/toolchain

  1   2   3   4   5   6   7   8   9   10   >