[OpenWrt-Devel] [PATCH v3] lantiq: make zlib compression on ubifs the default for BTHOMEHUBV2B

2014-06-20 Thread Ben Mulvihill
On Fri, 2014-06-20 at 07:51 +0200, Ben Mulvihill wrote:
 On Thu, 2014-06-19 at 23:09 +0200, Ben Mulvihill wrote:
  Nand flash on the Home Hub 2B is 32M, so it makes sense at
  least for this board to use some sort of compression on
  ubifs. Of course anyone building trunk for themselves can
  choose whatever they want, but with a release coming up,
  I think compression should be the default in pre-built
  images. However, I have a question. Does it make sense
  for compression by default to be enabled/disabled on a
  board by board basis, or should it be the same for all
  lantiq targets, or perhaps all targets full stop?
  
  Thanks,
  
  Ben
  
 
 P.S. Sorry, missed the sign-off from the first one.

P.P.S. I'm not doing very well this time. Trying to do things
in a hurry. v3 is the right one.

Signed-off-by: Ben Mulvihill ben.mulvih...@gmail.com
---

--- a/config/Config-images.in   2014-06-19 22:44:40.962240035 +0200
+++ b/config/Config-images.in   2014-06-19 19:48:15.508299173 +0200
@@ -158,6 +158,7 @@ menu Target Images
 
choice
prompt compression
+   default TARGET_UBIFS_COMPRESSION_ZLIB if 
TARGET_lantiq_xway_BTHOMEHUBV2B
default TARGET_UBIFS_COMPRESSION_NONE
depends on TARGET_ROOTFS_UBIFS
help
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH v3] lantiq: make zlib compression on ubifs the default for BTHOMEHUBV2B

2014-06-20 Thread John Crispin


On 20/06/2014 08:26, Ben Mulvihill wrote:
 On Fri, 2014-06-20 at 07:51 +0200, Ben Mulvihill wrote:
 On Thu, 2014-06-19 at 23:09 +0200, Ben Mulvihill wrote:
 Nand flash on the Home Hub 2B is 32M, so it makes sense at 
 least for this board to use some sort of compression on ubifs.
 Of course anyone building trunk for themselves can choose
 whatever they want, but with a release coming up, I think
 compression should be the default in pre-built images. However,
 I have a question. Does it make sense for compression by
 default to be enabled/disabled on a board by board basis, or
 should it be the same for all lantiq targets, or perhaps all
 targets full stop?
 
 Thanks,
 
 Ben
 
 
 P.S. Sorry, missed the sign-off from the first one.


Hi Ben,

i had a look at this problem aswell and i think we should globally
enable compression by default. i will ping felix about this and see
what he has to say.

John


 
 P.P.S. I'm not doing very well this time. Trying to do things in a
 hurry. v3 is the right one.
 
 Signed-off-by: Ben Mulvihill ben.mulvih...@gmail.com ---
 
 --- a/config/Config-images.in 2014-06-19 22:44:40.962240035 +0200 
 +++ b/config/Config-images.in 2014-06-19 19:48:15.508299173 +0200 
 @@ -158,6 +158,7 @@ menu Target Images
 
 choice prompt compression + default
 TARGET_UBIFS_COMPRESSION_ZLIB if TARGET_lantiq_xway_BTHOMEHUBV2B 
 default TARGET_UBIFS_COMPRESSION_NONE depends on
 TARGET_ROOTFS_UBIFS help 
 ___ openwrt-devel
 mailing list openwrt-devel@lists.openwrt.org 
 https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
 
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel