Re: [OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-05-01 Thread Jo-Philipp Wich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi again. I merged the new firewall + my modifications into trunk now. ~ Jow -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkvcfS0ACgkQdputYINPTPPgmACbBRDf

Re: [OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-04-28 Thread Malte S. Stretz
Moin, On Wednesday 28 April 2010 16:45:58 Jo-Philipp Wich wrote: > > Therefore I believe that the /etc/sysctl.conf file should have > > net.ipv6.conf.all.forwarding=1 set by default. > > A default firewall solution is needed before it can be made the default. > > Even if you or me do not need a

Re: [OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-04-28 Thread Bastian Bittorf
* Jo-Philipp Wich [28.04.2010 16:50]: > > A default firewall solution is needed before it can be made the default. IMHO: apply alina's patches and set net.ipv6.conf.all.forwarding=1 by default - hey, we are in trunk and wan't to play with the devices and learn something. make a 'fat' warning in

Re: [OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-04-28 Thread Benjamin Cama
Hi, Le mercredi 28 avril 2010 à 20:29 +1000, Andrew Byrne a écrit : > Right now it's in the file but commented out (since r12351). Does > anyone know if having it in there by default causes any errors if > kmod-ipv6 isn't installed? Tested here, when doing a sysctl -p with net.ipv6.conf.all.forw

Re: [OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-04-28 Thread Benjamin Cama
Le mardi 27 avril 2010 à 19:32 +0200, Alina Friedrichsen a écrit : > Routers must not react on router advertisements (written in someone RFC) > or you have a security problem. Mmhhh ... you're right, I may not have thought enough in a router perspective. > IPv6 autoconfiguration and DHCPv6 are to

Re: [OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-04-28 Thread Jo-Philipp Wich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi. > Therefore I believe that the /etc/sysctl.conf file should have > net.ipv6.conf.all.forwarding=1 set by default. A default firewall solution is needed before it can be made the default. Even if you or me do not need a firewall it is not accepta

Re: [OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-04-28 Thread Alina Friedrichsen
Hello Andrew! > When IPv6 routing is enabled (net.ipv6.conf.*.forwarding), > autoconfiguration is automatically prevented due to that RFC, > regardless of the net.ipv6.conf.*.autoconf value. This contradicts my observances. Autoconf is enabled even when forwarding is enabled. > OpenWrt should be

Re: [OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-04-28 Thread Andrew Byrne
> Routers must not react on router advertisements (written in someone RFC) > or you have a security problem. When IPv6 routing is enabled (net.ipv6.conf.*.forwarding), autoconfiguration is automatically prevented due to that RFC, regardless of the net.ipv6.conf.*.autoconf value. OpenWrt should be

Re: [OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-04-27 Thread Alina Friedrichsen
Hi! > > Today all interfaces have enabled IPv6 autoconfiguration now. That's the > > real problem. > > I wouldn't call that a "problem", rather a "particular default > behavior", or something along the line. Routers must not react on router advertisements (written in someone RFC) or you have a s

Re: [OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-04-27 Thread Alina Friedrichsen
Hi! > Perhaps this should be disabled if there is an ipv6addr entry in uci, > but enabled if there isn't. Routers should never react on router advertisements. If they do, this is a security problem because, every client in the network can change the routing table of the router. "proto" "static"

Re: [OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-04-27 Thread Benjamin Cama
Hi, I'd like to comment a bit on this patch, too. Le mardi 27 avril 2010 à 17:11 +0200, Alina Friedrichsen a écrit : > > Yet it is impossibe to have dhcp-enabled interfaces *without* ipv6 then, > > thats my point. > > Today all interfaces have enabled IPv6 autoconfiguration now. That's the > rea

Re: [OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-04-27 Thread Jonas Gorski
Hi On 27 April 2010 17:11, Alina Friedrichsen wrote: >> Also why only for "dhcp" and not "static" or any other >> hypothetical protocol? The relation between dhcp and autoconf is arbritary. > > Because IPv6 autoconfiguration is the counterpart to IPv4 DCHP. If you > choose "static" you want confi

Re: [OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-04-27 Thread Alina Friedrichsen
> Yet it is impossibe to have dhcp-enabled interfaces *without* ipv6 then, > thats my point. Today all interfaces have enabled IPv6 autoconfiguration now. That's the real problem. In nearly all cases you have installed IPv6, you want IPv6 autoconfiguration on the same interface, that have IPv4 DCH

Re: [OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-04-27 Thread Jo-Philipp Wich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > It's not unconditionally, it's only enabled, if the interface "proto" is > "dhcp". So it's configured in uci and you not need to touch this file. > It's much more user friendly. Yet it is impossibe to have dhcp-enabled interfaces *without* ipv6 the

Re: [OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-04-27 Thread Alina Friedrichsen
Hi! > Setting autconf to "0" for switch parent interfaces and bridge ports is > okay, You get really strange problems, if it's not so. > but unconditionally setting it to "1" is not so ideal - it > overrules whatever has been set in sysctl.conf (unless conf.all.autoconf > overrides conf.$iface.a

Re: [OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-04-27 Thread Jo-Philipp Wich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi. Setting autconf to "0" for switch parent interfaces and bridge ports is okay, but unconditionally setting it to "1" is not so ideal - it overrules whatever has been set in sysctl.conf (unless conf.all.autoconf overrides conf.$iface.autoconf, but I

[OpenWrt-Devel] [PATCH] Disable IPv6 autoconfiguration

2010-04-27 Thread Alina Friedrichsen
Disable the IPv6 autoconfiguration where it shouldn't enabled. Signed-off-by: Alina Friedrichsen Index: package/swconfig/files/switch.sh === --- package/swconfig/files/switch.sh (Revision 20854) +++ package/swconfig/files/switch.sh