Re: [OpenWrt-Devel] [PATCH] add a option in menuconfig to set a custom folder for the images packages -- fix typo, sorry for this
Hi, Am Mittwoch, 14. August 2013, 22:41:07 schrieb Hartmut Knaack: Now I see. IMHO sending a [PATCH V2] would be the cleaner solution. +1 Oliver Ertl schrieb: Signed-off-by: Oliver Ertl oli...@ertls-netzwerk.de --- rules.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules.mk b/rules.mk index 2d4d5c8..8594ca6 100644 --- a/rules.mk +++ b/rules.mk @@ -80,7 +80,7 @@ ifdef CONFIG_MIPS64_ABI endif DL_DIR:=$(if $(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(TOPDIR)/dl) -DL_DIR:=$(if $(call qstrip,$(CONFIG_BINARY_FOLDER)),$(call qstrip,$(CONFIG_BINARY_FOLDER)),$(TOPDIR)/bin/$(BOARD)) I guess this is still wrong or should both patches be applied in order? Then this should be a series, please resubmit. BTW: could you explain your intension a little bit in the commit message? I wondering what a use case of this patch would be... +BIN_DIR:=$(if $(call qstrip,$(CONFIG_BINARY_FOLDER)),$(call qstrip,$(CONFIG_BINARY_FOLDER)),$(TOPDIR)/bin/$(BOARD)) INCLUDE_DIR:=$(TOPDIR)/include SCRIPT_DIR:=$(TOPDIR)/scripts BUILD_DIR_BASE:=$(TOPDIR)/build_dir ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH] add a option in menuconfig to set a custom folder for the images packages
Signed-off-by: Oliver Ertl oli...@ertls-netzwerk.de --- Config.in | 4 rules.mk | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Config.in b/Config.in index 0ef2f14..0683125 100644 --- a/Config.in +++ b/Config.in @@ -784,6 +784,10 @@ menuconfig DEVEL string Download folder if DEVEL default + config BINARY_FOLDER + string Binary folder if DEVEL + default + config LOCALMIRROR string Local mirror for source packages if DEVEL default diff --git a/rules.mk b/rules.mk index 14171a0..2d4d5c8 100644 --- a/rules.mk +++ b/rules.mk @@ -80,7 +80,7 @@ ifdef CONFIG_MIPS64_ABI endif DL_DIR:=$(if $(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(TOPDIR)/dl) -BIN_DIR:=$(TOPDIR)/bin/$(BOARD) +DL_DIR:=$(if $(call qstrip,$(CONFIG_BINARY_FOLDER)),$(call qstrip,$(CONFIG_BINARY_FOLDER)),$(TOPDIR)/bin/$(BOARD)) INCLUDE_DIR:=$(TOPDIR)/include SCRIPT_DIR:=$(TOPDIR)/scripts BUILD_DIR_BASE:=$(TOPDIR)/build_dir -- 1.8.1.2 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH] add a option in menuconfig to set a custom folder for the images packages -- fix typo, sorry for this
Signed-off-by: Oliver Ertl oli...@ertls-netzwerk.de --- rules.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules.mk b/rules.mk index 2d4d5c8..8594ca6 100644 --- a/rules.mk +++ b/rules.mk @@ -80,7 +80,7 @@ ifdef CONFIG_MIPS64_ABI endif DL_DIR:=$(if $(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(TOPDIR)/dl) -DL_DIR:=$(if $(call qstrip,$(CONFIG_BINARY_FOLDER)),$(call qstrip,$(CONFIG_BINARY_FOLDER)),$(TOPDIR)/bin/$(BOARD)) +BIN_DIR:=$(if $(call qstrip,$(CONFIG_BINARY_FOLDER)),$(call qstrip,$(CONFIG_BINARY_FOLDER)),$(TOPDIR)/bin/$(BOARD)) INCLUDE_DIR:=$(TOPDIR)/include SCRIPT_DIR:=$(TOPDIR)/scripts BUILD_DIR_BASE:=$(TOPDIR)/build_dir -- 1.8.1.2 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] add a option in menuconfig to set a custom folder for the images packages
Hi. Oliver Ertl schrieb: Signed-off-by: Oliver Ertl oli...@ertls-netzwerk.de --- Config.in | 4 rules.mk | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Config.in b/Config.in index 0ef2f14..0683125 100644 --- a/Config.in +++ b/Config.in @@ -784,6 +784,10 @@ menuconfig DEVEL string Download folder if DEVEL default + config BINARY_FOLDER + string Binary folder if DEVEL + default + config LOCALMIRROR string Local mirror for source packages if DEVEL default diff --git a/rules.mk b/rules.mk index 14171a0..2d4d5c8 100644 --- a/rules.mk +++ b/rules.mk @@ -80,7 +80,7 @@ ifdef CONFIG_MIPS64_ABI endif DL_DIR:=$(if $(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(TOPDIR)/dl) -BIN_DIR:=$(TOPDIR)/bin/$(BOARD) +DL_DIR:=$(if $(call qstrip,$(CONFIG_BINARY_FOLDER)),$(call qstrip,$(CONFIG_BINARY_FOLDER)),$(TOPDIR)/bin/$(BOARD)) Shouldn't that be BIN_DIR? INCLUDE_DIR:=$(TOPDIR)/include SCRIPT_DIR:=$(TOPDIR)/scripts BUILD_DIR_BASE:=$(TOPDIR)/build_dir ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] add a option in menuconfig to set a custom folder for the images packages -- fix typo, sorry for this
Now I see. IMHO sending a [PATCH V2] would be the cleaner solution. Oliver Ertl schrieb: Signed-off-by: Oliver Ertl oli...@ertls-netzwerk.de --- rules.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules.mk b/rules.mk index 2d4d5c8..8594ca6 100644 --- a/rules.mk +++ b/rules.mk @@ -80,7 +80,7 @@ ifdef CONFIG_MIPS64_ABI endif DL_DIR:=$(if $(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(TOPDIR)/dl) -DL_DIR:=$(if $(call qstrip,$(CONFIG_BINARY_FOLDER)),$(call qstrip,$(CONFIG_BINARY_FOLDER)),$(TOPDIR)/bin/$(BOARD)) +BIN_DIR:=$(if $(call qstrip,$(CONFIG_BINARY_FOLDER)),$(call qstrip,$(CONFIG_BINARY_FOLDER)),$(TOPDIR)/bin/$(BOARD)) INCLUDE_DIR:=$(TOPDIR)/include SCRIPT_DIR:=$(TOPDIR)/scripts BUILD_DIR_BASE:=$(TOPDIR)/build_dir ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
