Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven gpio-keys

2019-08-10 Thread Dmitry Tunin
> So should it remove the change for ath9k keys and only do the other ones at > the moment? That's a good question. I suggest to leave devices that HAVE some keys attached to ath9k keys using 'gpio-keys-polled'. It makes no sense to use both drivers.

Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven gpio-keys

2019-08-10 Thread mail
> -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Dmitry Tunin > Sent: Samstag, 10. August 2019 18:25 > To: Adrian Schmutzler > Cc: OpenWrt Development List > Subject: Re: [OpenWrt-Devel] [PATCH] ath79: convert

Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven gpio-keys

2019-08-10 Thread Dmitry Tunin
If you will be pushing it some way, remove debounce-interval too. Without it gpio-keys work better. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven gpio-keys

2019-08-10 Thread Dmitry Tunin
> Can I add your Tested-by? I tested only one target, it makes no sense to add this. And I what about ath9k keys. They are a problem. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven gpio-keys

2019-08-10 Thread mail
> -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Dmitry Tunin > Sent: Samstag, 10. August 2019 11:53 > To: Adrian Schmutzler > Cc: OpenWrt Development List > Subject: Re: [OpenWrt-Devel] [PATCH] ath79: convert

Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven gpio-keys

2019-08-10 Thread Dmitry Tunin
I tested gpio-keys on dir825b1 and didn't see a noticable change against gpio-keys-polled. Both miss events and work poorly. So no objections for a switch. пн, 5 авг. 2019 г. в 19:27, Dmitry Tunin : > > > This recent Pull Request used gpio-keys on ar7100: > >

Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven gpio-keys

2019-08-05 Thread Dmitry Tunin
> This recent Pull Request used gpio-keys on ar7100: > https://github.com/openwrt/openwrt/pull/1359 > > However, I cannot extract how well this was tested. I will have a device for testing around the next weekend. I'll report back. ___ openwrt-devel

Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven gpio-keys

2019-08-05 Thread Adrian Schmutzler
> -Original Message- > From: Dmitry Tunin [mailto:hanipouspi...@gmail.com] > Sent: Montag, 5. August 2019 17:55 > To: Adrian Schmutzler > Cc: OpenWrt Development List > Subject: Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt- > driven gpio-keys >

Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven gpio-keys

2019-08-05 Thread Dmitry Tunin
пн, 5 авг. 2019 г. в 16:53, Adrian Schmutzler : > > > -Original Message- > > From: Dmitry Tunin [mailto:hanipouspi...@gmail.com] > > Sent: Freitag, 2. August 2019 18:51 > > To: Adrian Schmutzler > > Cc: OpenWrt Development List > > Subject: Re:

Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven gpio-keys

2019-08-05 Thread Adrian Schmutzler
> -Original Message- > From: Dmitry Tunin [mailto:hanipouspi...@gmail.com] > Sent: Freitag, 2. August 2019 18:51 > To: Adrian Schmutzler > Cc: OpenWrt Development List > Subject: Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt- > driven gpio-keys >

Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven gpio-keys

2019-08-02 Thread Christian Lamparter
On Friday, August 2, 2019 8:03:17 PM CEST Jeff Kletsky wrote: > > On 8/2/19 7:46 AM, Adrian Schmutzler wrote: > > This converts all remaining devices to use interrupt-driven > > gpio-keys compatible instead of gpio-keys-polled. > > The poll-interval is removed. > > > > Not that this proposed

Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven gpio-keys

2019-08-02 Thread Michal Cieslakiewicz
On Fri, 2 Aug 2019 16:46:10 +0200 Adrian Schmutzler wrote: > This converts all remaining devices to use interrupt-driven > gpio-keys compatible instead of gpio-keys-polled. > The poll-interval is removed. > > Signed-off-by: Adrian Schmutzler > --- > [...] > diff --git

Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven gpio-keys

2019-08-02 Thread Jeff Kletsky
On 8/2/19 7:46 AM, Adrian Schmutzler wrote: This converts all remaining devices to use interrupt-driven gpio-keys compatible instead of gpio-keys-polled. The poll-interval is removed. Not that this proposed change makes the situation any different, but many devices have switches that are

Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven gpio-keys

2019-08-02 Thread Dmitry Tunin
пт, 2 авг. 2019 г. в 17:46, Adrian Schmutzler : > > This converts all remaining devices to use interrupt-driven > gpio-keys compatible instead of gpio-keys-polled. > The poll-interval is removed. > When I ported DIR-825-b1 to ath79 last year, "gpio-keys" where very unreliable and I had to switch

Re: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven gpio-keys

2019-08-02 Thread Adrian Schmutzler
t.org > Subject: [OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven > gpio-keys > > This converts all remaining devices to use interrupt-driven > gpio-keys compatible instead of gpio-keys-polled. > The poll-interval is removed. > > Signed-off-by: Adrian Schm

[OpenWrt-Devel] [PATCH] ath79: convert devices to interrupt-driven gpio-keys

2019-08-02 Thread Adrian Schmutzler
This converts all remaining devices to use interrupt-driven gpio-keys compatible instead of gpio-keys-polled. The poll-interval is removed. Signed-off-by: Adrian Schmutzler --- target/linux/ath79/dts/ar1022_iodata_wn-ag300dgr.dts | 3 +--